Re: [U-Boot] Problem w/ SATA/IDE on Kirkwood _88F6281_ board:

2012-04-02 Thread Prafulla Wadaskar
From: David Purdy [mailto:david.c.pu...@gmail.com] Sent: 03 April 2012 10:40 To: Prafulla Wadaskar; u-boot@lists.denx.de; albert.u.b...@aribaud.net Subject: Problem w/ SATA/IDE on Kirkwood _88F6281_ board: On Mon, Apr 2, 2012 at 12:11 AM, Prafulla Wadaskar mailt

Re: [U-Boot] [PATCH v2] spi/kirkwood: add weak functions board_spi_bus_claim/release

2012-04-02 Thread Prafulla Wadaskar
> -Original Message- > From: Valentin Longchamp [mailto:valentin.longch...@keymile.com] > Sent: 02 April 2012 19:07 > To: Prafulla Wadaskar > Cc: u-boot@lists.denx.de; Gerlando Falauto; Holger Brunck > Subject: Re: [PATCH v2] spi/kirkwood: add weak functions > board_spi_bus_claim/release

[U-Boot] [PATCH] cm-t35: fix Ethernet reset timing

2012-04-02 Thread Igor Grinberg
The reset_net_chip() function has wrong timings for the reset pulse. This appeared to work until: 0607e2b (ARMV7: OMAP: Write more than 1 byte at a time in i2c_write) Fix the Ethernet support by introducing right timings. Signed-off-by: Igor Grinberg --- board/cm_t35/cm_t35.c | 11 ++

Re: [U-Boot] [PATCH] cm-t35: add I2C multi-bus support

2012-04-02 Thread Igor Grinberg
Hi Tom, On 04/02/12 17:18, Tom Rini wrote: > On 04/02/2012 05:29 AM, Igor Grinberg wrote: >> From: Nikita Kiryanov >> >> Enable I2C multi-bus support and config I2C muxes for I2C2 and I2C3. >> >> Signed-off-by: Nikita Kiryanov >> Signed-off-by: Igor Grinberg > > Have you confirmed this is suffici

Re: [U-Boot] [PATCH v8] usb: align buffers at cacheline

2012-04-02 Thread puneets
Hi Marek/Tom, As I understood correctly. I would merge my changes in "denx-uboot-arm/master" as "u-boot-tegra/master", where actually I tested my patch, is pulled in "denx-uboot-arm/master". Will that work... Thanks & Regards, Puneet On Monday 02 April 2012 10:02 PM, Marek Vasut wrote: Dear

Re: [U-Boot] [PATCH v2] Correct corrupted NAND Flash access on KARO TX25 modules

2012-04-02 Thread Gachet Daniel
Hi Stefano, No problem, I will do it with the inverse logic, using a CONFIG_NAND_MXC_NFC_TWO_CYCLES, and adapt the tx25.h file. But could you tell me in which README file I should add the description for that switch? I have a look at all README, but no one has any description about NAND flash c

Re: [U-Boot] [PATCH v3 22/23] tegra: fdt: Add EMC data for Tegra2 Seaboard

2012-04-02 Thread Olof Johansson
On Mon, Apr 2, 2012 at 4:19 PM, Simon Glass wrote: > This adds timings for T20 and T25 Seaboards, using the bindings found here: > > http://patchwork.ozlabs.org/patch/132928/ > > We supply both full speed options for normal running, and half speed options > for testing / development. > > Signed-of

[U-Boot] Problem w/ SATA/IDE on Kirkwood _88F6281_ board:

2012-04-02 Thread David Purdy
On Mon, Apr 2, 2012 at 12:11 AM, Prafulla Wadaskar wrote: > > > I remember there was some delay issue on SATA, since processor in this platform is running at lower clock, (may be) this could be one of parameter to be considered. > May be Albert can have some more inside on this. > > Regards.. > Pr

Re: [U-Boot] [PATCH] Prevent malloc with size 0

2012-04-02 Thread Graeme Russ
Hi Jocke On Tue, Apr 3, 2012 at 7:14 AM, Joakim Tjernlund wrote: > Graeme Russ wrote on 2012/04/02 22:59:57: >> >> >> On Apr 3, 2012 6:57 AM, "Joakim Tjernlund" >> wrote: >> > >> > Graeme Russ wrote on 2012/04/02 22:28:46: >> > > From: Graeme Russ >> > > >> > > On 04/02/2012 05:40 PM, Joakim

[U-Boot] [PATCH v3 19/23] tegra: Add EMC settings for Seaboard

2012-04-02 Thread Simon Glass
From: Jimmy Zhang Set Seaboard to optimal memory settings based on the SOC in use (T20 or T25). Signed-off-by: Simon Glass --- Changes in v2: - Move EMC tables to device tree - Removed check for nominal voltage (not needed as it is done just before) Changes in v3: - Add better error reporting

[U-Boot] [PATCH v3 23/23] tegra: Enable LP0 on Seaboard

2012-04-02 Thread Simon Glass
This enables LP0 to support suspend / resume on Seaboard. Signed-off-by: Simon Glass --- include/configs/seaboard.h |8 include/configs/tegra2-common.h | 17 + 2 files changed, 25 insertions(+), 0 deletions(-) diff --git a/include/configs/seaboard.h b/includ

[U-Boot] [PATCH v3 22/23] tegra: fdt: Add EMC data for Tegra2 Seaboard

2012-04-02 Thread Simon Glass
This adds timings for T20 and T25 Seaboards, using the bindings found here: http://patchwork.ozlabs.org/patch/132928/ We supply both full speed options for normal running, and half speed options for testing / development. Signed-off-by: Simon Glass --- board/nvidia/dts/tegra2-seaboard.dts |

[U-Boot] [PATCH v3 16/23] tegra: Setup PMC scratch info from ap20 setup

2012-04-02 Thread Simon Glass
From: Yen Lin Save SDRAM parameters into the warmboot scratch registers Signed-off-by: Simon Glass --- arch/arm/cpu/armv7/tegra2/ap20.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/arch/arm/cpu/armv7/tegra2/ap20.c b/arch/arm/cpu/armv7/tegra2/ap20.c index 150fb

[U-Boot] [PATCH v3 15/23] tegra: Add warmboot implementation

2012-04-02 Thread Simon Glass
From: Yen Lin Add code to set up the warm boot area in the Tegra CPU ready for a resume after suspend. Signed-off-by: Simon Glass Acked-by: Stephen Warren --- Changes in v2: - Move structs shared between A9 and AVP into warmboot.h header file - Remove unused crypto code - Tidy SDRAM range chec

[U-Boot] [PATCH v3 10/23] tegra: Add tegra_get_chip_type() to detect SKU

2012-04-02 Thread Simon Glass
We want to know which type of chip we are running on - the Tegra family has several SKUs. This can be determined by reading a fuse register, so add this function to ap20. Signed-off-by: Simon Glass Acked-by: Stephen Warren --- Changes in v2: - Add check of undocumented values in hidrev register

[U-Boot] [PATCH v3 14/23] tegra: Set up PMU for Nvidia boards

2012-04-02 Thread Simon Glass
Adjust PMU to permit maximum frequency operation. Signed-off-by: Simon Glass --- Changes in v2: - Check error return from pmu_set_nominal() in debug mode board/nvidia/common/board.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/board/nvidia/common/board.c b/board

[U-Boot] [PATCH v3 21/23] tegra: i2c: Add function to find DVC bus

2012-04-02 Thread Simon Glass
Add tegra_i2c_get_dvc_bus_num() to obtain the I2C bus number of DVC bus. This allows us to talk to the PMU. Signed-off-by: Simon Glass --- Changes in v2: - Add patch to find DVC bus number arch/arm/include/asm/arch-tegra2/tegra_i2c.h |7 +++ drivers/i2c/tegra_i2c.c

[U-Boot] [PATCH v3 20/23] fdt: tegra: Add EMC node to device tree

2012-04-02 Thread Simon Glass
Add a definition of the memory controller node according to the bindings here: http://patchwork.ozlabs.org/patch/132928/ Signed-off-by: Simon Glass --- arch/arm/dts/tegra20.dtsi |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/arch/arm/dts/tegra20.dtsi b/arch/arm/

[U-Boot] [PATCH v3 18/23] tegra: Turn off power detect in board init

2012-04-02 Thread Simon Glass
From: Wei Ni Tegra core power rail has leakage voltage around 0.2V while system in suspend mode. The source of the leakage should be coming from PMC power detect logic for IO rails power detection. That can be disabled by writing a '0' to PWR_DET_LATCH followed by writing '0' to PWR_DET (APBDEV_P

[U-Boot] [PATCH v3 13/23] tegra: Add PMU to manage power supplies

2012-04-02 Thread Simon Glass
From: Jimmy Zhang Power supplies must be adjusted in line with clock frequency. This code provides a simple routine to set the voltage to allow operation at maximum frequency. - Split PMU code into separate TPS6586X driver Signed-off-by: Simon Glass --- arch/arm/cpu/armv7/tegra2/Makefile

[U-Boot] [PATCH v3 01/23] fdt: Add function to locate an array in the device tree

2012-04-02 Thread Simon Glass
fdtdec_locate_array() locates an integer array but does not copy it. This saves the caller having to allocated wasted space. Access to array elements should be through the fdt32_to_cpu() macro. Signed-off-by: Simon Glass --- Changes in v2: - Add new fdtdec_locate_array() function include/fdtde

[U-Boot] [PATCH v3 12/23] tegra: Add EMC support for optimal memory timings

2012-04-02 Thread Simon Glass
From: Jimmy Zhang Add support for setting up the memory controller parameters. Boards can set up an appropriate table in the device tree. Signed-off-by: Simon Glass --- Changes in v2: - Add debug() output to EMC - Move EMC tables to device tree Changes in v3: - Support nvidia,use-ram-code bind

[U-Boot] [PATCH v3 17/23] tegra: Set up warmboot code on Nvidia boards

2012-04-02 Thread Simon Glass
Call the function to put warmboot boot in a suitable place for resume. Signed-off-by: Simon Glass --- board/nvidia/common/board.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/board/nvidia/common/board.c b/board/nvidia/common/board.c index 640b9c4..b82e61a 100644

[U-Boot] [PATCH v3 09/23] tegra: Add flow, gp_padctl, fuse, sdram headers

2012-04-02 Thread Simon Glass
From: Yen Lin These headers provide access to additional Tegra features. flow - start/stop CPUs sdram - parameters for SDRAM fuse - access to on-chip fuses / security settings gp_padctl - pad control and general purpose registers Signed-off-by: Simon Glass --- arch/arm/include/asm/arch-tegra

[U-Boot] [PATCH v3 05/23] Add AES crypto library

2012-04-02 Thread Simon Glass
From: Yen Lin Add support for AES using an implementation form Karl Malbrain. This offers small code size (around 5KB on ARM) and supports 128-bit AES only. Signed-off-by: Simon Glass --- Changes in v2: - Tidy whitespace problems - Use const for sbox arrays include/aes.h | 70 +++ lib/M

[U-Boot] [PATCH v3 11/23] tegra: Add header file for APB_MISC register

2012-04-02 Thread Simon Glass
Add a basic header file for this register, to be filled in as needed. Signed-off-by: Simon Glass --- Changes in v3: - Add apb_misc.h header file in new patch arch/arm/include/asm/arch-tegra2/apb_misc.h | 36 +++ 1 files changed, 36 insertions(+), 0 deletions(-) create

[U-Boot] [PATCH v3 07/23] tegra: Add functions to access low-level Osc/PLL details

2012-04-02 Thread Simon Glass
Add clock_ll_read_pll() to read PLL parameters and clock_get_osc_bypass() to find out if the Oscillator is bypassed. These are needed by warmboot. Signed-off-by: Simon Glass --- Changes in v2: - New patch to add low-level clock functions arch/arm/cpu/armv7/tegra2/clock.c | 32 +++

[U-Boot] [PATCH v3 06/23] tegra: Move ap20.h header into arch location

2012-04-02 Thread Simon Glass
We want to include this from board code, so move the header into an easily-accessible location. Signed-off-by: Simon Glass --- arch/arm/cpu/armv7/tegra2/ap20.c |2 +- arch/arm/cpu/armv7/tegra2/board.c |4 ++-- .../tegra2 => include/asm/arch-tegra2}/ap2

[U-Boot] [PATCH v3 04/23] i2c: Add TPS6586X driver

2012-04-02 Thread Simon Glass
This power management chip supports battery charging and a large number of power supplies. This initial driver only provides the ability to adjust the two synchronous buck converters SM0 and SM1 in a stepwise manner. Signed-off-by: Simon Glass --- Changes in v2: - Split PMU code into separate TPS

[U-Boot] [PATCH v3 08/23] tegra: Add crypto library for warmboot code

2012-04-02 Thread Simon Glass
From: Yen Lin Provides an interface to aes.c for the warmboot code. Signed-off-by: Simon Glass --- Changes in v2: - Rely on compiler to optimise out debug_print_vector() - Remove unused crypto code from crypto.c arch/arm/cpu/armv7/tegra2/crypto.c | 230 a

[U-Boot] [PATCH v3 02/23] fdt: Add function to return next compatible subnode

2012-04-02 Thread Simon Glass
We need to iterate through subnodes of a parent, looking only at compatible nodes. Add a utility function to do this for us. Signed-off-by: Simon Glass --- Changes in v3: - Add new fdtdec_next_compatible_subnode() patch include/fdtdec.h | 17 + lib/fdtdec.c | 15

[U-Boot] [PATCH v3 03/23] Add abs() macro to return absolute value

2012-04-02 Thread Simon Glass
This macro is generally useful to make it available in common. Signed-off-by: Simon Glass --- Changes in v3: - Add new patch to put abs() in common.h include/common.h | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/include/common.h b/include/common.h index

[U-Boot] [PATCH v3 0/23] tegra: warmboot (suspend / resume) support

2012-04-02 Thread Simon Glass
This series adds support for warm boot, allowing the device to suspend and resume. U-Boot sets up some 'warm boot' code in a special area such that the SOC can find it on a resume. This code is responsible for setting up memory and clocked and then allowing the OS to continue where it left off. Al

Re: [U-Boot] [PATCH 1/2] ARM: introduce arch_early_init_r()

2012-04-02 Thread Graeme Russ
Hi Tom, On Tue, Apr 3, 2012 at 8:15 AM, Tom Rini wrote: > On Mon, Apr 02, 2012 at 06:19:45PM -0300, Fabio Estevam wrote: > >> Introduce arch_early_init_r() function, which can be useful for doing >> early initialization after relocation has happened. >> >> Signed-off-by: Fabio Estevam > [snip] >

Re: [U-Boot] [PATCH 1/2] ARM: introduce arch_early_init_r()

2012-04-02 Thread Tom Rini
On Mon, Apr 02, 2012 at 06:19:45PM -0300, Fabio Estevam wrote: > Introduce arch_early_init_r() function, which can be useful for doing > early initialization after relocation has happened. > > Signed-off-by: Fabio Estevam [snip] > +#ifdef CONFIG_ARCH_EARLY_INIT_R > + arch_early_init_r(); > +

Re: [U-Boot] [PATCH 1/2] ARM: introduce arch_early_init_r()

2012-04-02 Thread Tom Rini
On Tue, Apr 03, 2012 at 12:08:33AM +0200, Marek Vasut wrote: > Dear Tom Rini, > > > On Tue, Apr 03, 2012 at 12:00:31AM +0200, Marek Vasut wrote: > > > Dear Tom Rini, > > > > > > > On Mon, Apr 02, 2012 at 06:19:45PM -0300, Fabio Estevam wrote: > > > > > Introduce arch_early_init_r() function, whic

Re: [U-Boot] [PATCH 1/2] ARM: introduce arch_early_init_r()

2012-04-02 Thread Marek Vasut
Dear Tom Rini, > On Tue, Apr 03, 2012 at 12:00:31AM +0200, Marek Vasut wrote: > > Dear Tom Rini, > > > > > On Mon, Apr 02, 2012 at 06:19:45PM -0300, Fabio Estevam wrote: > > > > Introduce arch_early_init_r() function, which can be useful for doing > > > > early initialization after relocation has

Re: [U-Boot] [PATCH 1/2] ARM: introduce arch_early_init_r()

2012-04-02 Thread Tom Rini
On Tue, Apr 03, 2012 at 12:00:31AM +0200, Marek Vasut wrote: > Dear Tom Rini, > > > On Mon, Apr 02, 2012 at 06:19:45PM -0300, Fabio Estevam wrote: > > > Introduce arch_early_init_r() function, which can be useful for doing > > > early initialization after relocation has happened. > > > > > > Sign

Re: [U-Boot] [PATCH 1/2] ARM: introduce arch_early_init_r()

2012-04-02 Thread Marek Vasut
Dear Tom Rini, > On Mon, Apr 02, 2012 at 06:19:45PM -0300, Fabio Estevam wrote: > > Introduce arch_early_init_r() function, which can be useful for doing > > early initialization after relocation has happened. > > > > Signed-off-by: Fabio Estevam > > Perhaps I just overlooked earlier conversati

Re: [U-Boot] [PATCH v2] Correct corrupted NAND Flash access on KARO TX25 modules

2012-04-02 Thread stefano babic
Am 02/04/2012 23:08, schrieb Marek Vasut: > Dear Gachet Daniel, > >> This patch v2 correct corrupted data while reading NAND flash modules on >> the KARO TX25 module. >> >> The current version of the mxc_nand driver uses the symmetric mode to >> access the NAND flash, but the devices populated on

Re: [U-Boot] [PATCH v2] Correct corrupted NAND Flash access on KARO TX25 modules

2012-04-02 Thread stefano babic
Am 02/04/2012 22:55, schrieb Gachet Daniel: > This patch v2 correct corrupted data while reading NAND flash modules on the > KARO TX25 module. > Hi Daniel, > The current version of the mxc_nand driver uses the symmetric mode to access > the NAND flash, but the devices populated on the KARO TX2

Re: [U-Boot] [PATCH 1/2] ARM: introduce arch_early_init_r()

2012-04-02 Thread Tom Rini
On Mon, Apr 02, 2012 at 06:19:45PM -0300, Fabio Estevam wrote: > Introduce arch_early_init_r() function, which can be useful for doing > early initialization after relocation has happened. > > Signed-off-by: Fabio Estevam Perhaps I just overlooked earlier conversations, but why not just do this

[U-Boot] [PATCH 2/2] mmc: mxsmmc: Fix operation with DMA

2012-04-02 Thread Fabio Estevam
Initialize the DMA controller so that the following errors are fixed: U-Boot 2012.04-rc1-1-g037cbfd (Apr 02 2012 - 10:57:48) Freescale i.MX28 family at 454 MHz DRAM: 128 MiB MMC: MXS MMC: 0 MMC0: DMA transfer failed MMC0: DMA transfer failed MMC0: DMA transfer failed MMC0: DMA transfer fai

[U-Boot] [PATCH 1/2] ARM: introduce arch_early_init_r()

2012-04-02 Thread Fabio Estevam
Introduce arch_early_init_r() function, which can be useful for doing early initialization after relocation has happened. Signed-off-by: Fabio Estevam --- arch/arm/include/asm/u-boot-arm.h |1 + arch/arm/lib/board.c |4 2 files changed, 5 insertions(+), 0 deletions(-)

Re: [U-Boot] [PATCH] Prevent malloc with size 0

2012-04-02 Thread Joakim Tjernlund
Graeme Russ wrote on 2012/04/02 22:59:57: > > > On Apr 3, 2012 6:57 AM, "Joakim Tjernlund" > wrote: > > > > Graeme Russ wrote on 2012/04/02 22:28:46: > > > From: Graeme Russ > > > > > > On 04/02/2012 05:40 PM, Joakim Tjernlund wrote: > > > > Hi Grame > > > > > > > > Graeme Russ wrote on 2012/

Re: [U-Boot] [PATCH v2] Correct corrupted NAND Flash access on KARO TX25 modules

2012-04-02 Thread Marek Vasut
Dear Gachet Daniel, > This patch v2 correct corrupted data while reading NAND flash modules on > the KARO TX25 module. > > The current version of the mxc_nand driver uses the symmetric mode to > access the NAND flash, but the devices populated on the KARO TX25 only > support an asymmetric mode (i

Re: [U-Boot] [PATCH] Prevent malloc with size 0

2012-04-02 Thread Joakim Tjernlund
vapierfil...@gmail.com wrote on 2012/04/02 21:14:14: > > On Mon, Apr 2, 2012 at 14:40, Joakim Tjernlund wrote: > > Marek Vasut wrote on 2012/04/02 20:00:03: > >> Dear Joakim Tjernlund, > >> > Depends, if writing generic code for lots of OS:es you cannot rely > >> > malloc(0). Writing kernel code y

Re: [U-Boot] [PATCH v2] mmc: mxsmmc: Fix operation with DMA

2012-04-02 Thread Marek Vasut
Dear Fabio Estevam, > On Mon, Apr 2, 2012 at 5:52 PM, Marek Vasut wrote: > > Well ... CCing Albert to express his concerns about this. > > Ok, great. > > Just to let you know that I also tested NAND on my board (will add > mx28evk support for NAND later). Good job, Fabio! :) Best regards, Mar

Re: [U-Boot] [PATCH v3 6/6] env: delete selected vars not present in imported env

2012-04-02 Thread Marek Vasut
Dear Gerlando Falauto, > On 04/02/2012 09:06 PM, Marek Vasut wrote: > > Dear Gerlando Falauto, > > > >> When variables explicitly specified on the command line are not present > >> in the imported env, delete them from the running env. > >> If the variable is also missing from the running env, is

Re: [U-Boot] [PATCH] Prevent malloc with size 0

2012-04-02 Thread Graeme Russ
On Apr 3, 2012 6:57 AM, "Joakim Tjernlund" wrote: > > Graeme Russ wrote on 2012/04/02 22:28:46: > > From: Graeme Russ > > > > On 04/02/2012 05:40 PM, Joakim Tjernlund wrote: > > > Hi Grame > > > > > > Graeme Russ wrote on 2012/04/02 09:17:44: > > >> > > >> Hi Joakim, > > >> On Apr 2, 2012 4:55

Re: [U-Boot] [PATCH] Prevent malloc with size 0

2012-04-02 Thread Joakim Tjernlund
Graeme Russ wrote on 2012/04/02 22:28:46: > From: Graeme Russ > > On 04/02/2012 05:40 PM, Joakim Tjernlund wrote: > > Hi Grame > > > > Graeme Russ wrote on 2012/04/02 09:17:44: > >> > >> Hi Joakim, > >> On Apr 2, 2012 4:55 PM, "Joakim Tjernlund" > >> wrote: > >>> > > Hi Marek, >

Re: [U-Boot] [PATCH v2] Correct corrupted NAND Flash access on KARO TX25 modules

2012-04-02 Thread Gachet Daniel
This patch v2 correct corrupted data while reading NAND flash modules on the KARO TX25 module. The current version of the mxc_nand driver uses the symmetric mode to access the NAND flash, but the devices populated on the KARO TX25 only support an asymmetric mode (i.MX25: bit 8 within NAND_FLAS

Re: [U-Boot] [PATCH v2] mmc: mxsmmc: Fix operation with DMA

2012-04-02 Thread Fabio Estevam
On Mon, Apr 2, 2012 at 5:52 PM, Marek Vasut wrote: > Well ... CCing Albert to express his concerns about this. Ok, great. Just to let you know that I also tested NAND on my board (will add mx28evk support for NAND later). ___ U-Boot mailing list U-Boo

Re: [U-Boot] [PATCH v2] mmc: mxsmmc: Fix operation with DMA

2012-04-02 Thread Marek Vasut
Dear Fabio Estevam, > On Mon, Apr 2, 2012 at 4:54 PM, Marek Vasut wrote: > > Yes another hook function that'd be called early in board_init_r() > > Ok, please see the patch below and let me know if you like it. > > If you do, then I can probably split it in 2 parts: > one that introduces arch_

Re: [U-Boot] [PATCH v3 3/6] env: add check/apply logic to himport_r()

2012-04-02 Thread Marek Vasut
Dear Gerlando Falauto, > On 04/02/2012 09:01 PM, Marek Vasut wrote: > > Dear Marek Vasut, > > > >> Dear Gerlando Falauto, > >> > >>> Change hashtable so that a callback function will decide whether a > >>> variable can be overwritten, and possibly apply the changes. > >>> > >>> So add a new fie

Re: [U-Boot] [PATCH v3 1/6] env: unify logic to check and apply changes

2012-04-02 Thread Marek Vasut
Dear Gerlando Falauto, > On 04/02/2012 08:56 PM, Marek Vasut wrote: > > Dear Gerlando Falauto, > > > >> The logic of checking special parameters (e.g. baudrate, stdin, stdout, > >> for a valid value and/or whether can be overwritten) and applying the > >> new value to the running system is now al

Re: [U-Boot] [PATCH v3 6/6] env: delete selected vars not present in imported env

2012-04-02 Thread Gerlando Falauto
On 04/02/2012 09:06 PM, Marek Vasut wrote: Dear Gerlando Falauto, When variables explicitly specified on the command line are not present in the imported env, delete them from the running env. If the variable is also missing from the running env, issue a warning. Signed-off-by: Gerlando Falaut

Re: [U-Boot] [PATCH] [U-BOOT] Zoom2: Ethernet: Enabling LAN9221 chip and CMD_NET.

2012-04-02 Thread Tom Rini
On Sat, Mar 31, 2012 at 12:45 PM, Marek Vasut wrote: > Dear Aldo Brett Cedillo Martinez, > >> Configures GPMC, adds macros to enable net commands, and adds proper >> initialization to board_eth_init function. > > Tom, are you OK with applying this patch ? To be clear, lets ask Tom Rix, currently

Re: [U-Boot] [PATCH v3 3/6] env: add check/apply logic to himport_r()

2012-04-02 Thread Gerlando Falauto
On 04/02/2012 09:01 PM, Marek Vasut wrote: Dear Marek Vasut, Dear Gerlando Falauto, Change hashtable so that a callback function will decide whether a variable can be overwritten, and possibly apply the changes. So add a new field to struct hsearch_data: o "apply" callback function to chec

Re: [U-Boot] [PATCH v2] mmc: mxsmmc: Fix operation with DMA

2012-04-02 Thread Fabio Estevam
On Mon, Apr 2, 2012 at 4:54 PM, Marek Vasut wrote: > Yes another hook function that'd be called early in board_init_r() Ok, please see the patch below and let me know if you like it. If you do, then I can probably split it in 2 parts: one that introduces arch_early_init_r() and another one tha

Re: [U-Boot] [PATCH v3 2/6] env: make himport_r() selective on variables

2012-04-02 Thread Gerlando Falauto
On 04/02/2012 08:57 PM, Marek Vasut wrote: Dear Gerlando Falauto, Add 2 new arguments to himport_r(): o "nvars", "vars": number and list of variables to take into account (0 means ALL) Looks nice and clean. But man, these patches are tough to review (not because you made bad job, just

Re: [U-Boot] [PATCH v3 1/6] env: unify logic to check and apply changes

2012-04-02 Thread Gerlando Falauto
On 04/02/2012 08:56 PM, Marek Vasut wrote: Dear Gerlando Falauto, The logic of checking special parameters (e.g. baudrate, stdin, stdout, for a valid value and/or whether can be overwritten) and applying the new value to the running system is now all within a single function env_check_apply() w

Re: [U-Boot] [PATCH] Prevent malloc with size 0

2012-04-02 Thread Graeme Russ
On 04/02/2012 05:40 PM, Joakim Tjernlund wrote: > Hi Grame > > Graeme Russ wrote on 2012/04/02 09:17:44: >> >> Hi Joakim, >> On Apr 2, 2012 4:55 PM, "Joakim Tjernlund" >> wrote: >>> Hi Marek, On Mon, Apr 2, 2012 at 1:36 PM, Marek Vasut wrote: > Dear Mike Frysinger,

Re: [U-Boot] [PATCH v2] mmc: mxsmmc: Fix operation with DMA

2012-04-02 Thread Marek Vasut
Dear Fabio Estevam, > On Mon, Apr 2, 2012 at 4:38 PM, Marek Vasut wrote: > >> Won't calling mxs_dma_init() from arch_misc_init() work? > > > > No, because that's called after NAND is inited. And NAND needs DMA for > > it's init > > > > :( > > Correct. > > Should we go with my ugly hack then?

Re: [U-Boot] [PATCH v2] mmc: mxsmmc: Fix operation with DMA

2012-04-02 Thread Fabio Estevam
On Mon, Apr 2, 2012 at 4:38 PM, Marek Vasut wrote: >> Won't calling mxs_dma_init() from arch_misc_init() work? > > No, because that's called after NAND is inited. And NAND needs DMA for it's > init > :( Correct. Should we go with my ugly hack then? Or what do you mean when you proposed arch_e

Re: [U-Boot] [PATCH] usb: increase delay after port reset

2012-04-02 Thread Ilya Yanok
Hi Marek, Stefano, On 02.04.2012 21:29, Marek Vasut wrote: >> In our setup (OMAP3 EHCI host, keyboard, mouse mass storage and BT >> dongle devices connected via several hubs) keyboard fails to initialize >> during the bus scan (stalled endpoint while get_descriptor/64) and after >> that keyboard i

Re: [U-Boot] [PATCH v2] mmc: mxsmmc: Fix operation with DMA

2012-04-02 Thread Marek Vasut
Dear Anatolij Gustschin, > Hi Fabio, > > On Mon, 2 Apr 2012 16:18:18 -0300 > > Fabio Estevam wrote: > > On Mon, Apr 2, 2012 at 4:03 PM, Marek Vasut wrote: > > > Because that's called before relocation ;-) > > > > What about this? > > > > --- a/drivers/dma/apbh_dma.c > > +++ b/drivers/dma/apb

Re: [U-Boot] [PATCH v2] mmc: mxsmmc: Fix operation with DMA

2012-04-02 Thread Anatolij Gustschin
Hi Fabio, On Mon, 2 Apr 2012 16:18:18 -0300 Fabio Estevam wrote: > On Mon, Apr 2, 2012 at 4:03 PM, Marek Vasut wrote: > > > Because that's called before relocation ;-) > > What about this? > > --- a/drivers/dma/apbh_dma.c > +++ b/drivers/dma/apbh_dma.c > @@ -35,6 +35,7 @@ > > static struct

Re: [U-Boot] [PATCH v2] mmc: mxsmmc: Fix operation with DMA

2012-04-02 Thread Marek Vasut
Dear Fabio Estevam, > On Mon, Apr 2, 2012 at 4:03 PM, Marek Vasut wrote: > > Because that's called before relocation ;-) > > What about this? > > --- a/drivers/dma/apbh_dma.c > +++ b/drivers/dma/apbh_dma.c > @@ -35,6 +35,7 @@ > > static struct mxs_dma_chan mxs_dma_channels[MXS_MAX_DMA_CHANNEL

Re: [U-Boot] [PATCH] Prevent malloc with size 0

2012-04-02 Thread Marek Vasut
Dear Joakim Tjernlund, > Marek Vasut wrote on 2012/04/02 20:00:03: > > Dear Joakim Tjernlund, > > > > > Marek Vasut wrote on 2012/04/02 18:39:33: > > > > From: Marek Vasut > > > > > > > > Dear Joakim Tjernlund, > > > > > > > > > Marek Vasut wrote on 2012/04/02 17:23:03: > > > > > > Dear Joa

Re: [U-Boot] [PATCH v2] mmc: mxsmmc: Fix operation with DMA

2012-04-02 Thread Fabio Estevam
On Mon, Apr 2, 2012 at 4:03 PM, Marek Vasut wrote: > Because that's called before relocation ;-) What about this? --- a/drivers/dma/apbh_dma.c +++ b/drivers/dma/apbh_dma.c @@ -35,6 +35,7 @@ static struct mxs_dma_chan mxs_dma_channels[MXS_MAX_DMA_CHANNELS]; +static int first; /* * Test is

Re: [U-Boot] [PATCH 0/6] add zip command support for uboot

2012-04-02 Thread Mike Frysinger
On Tue, Mar 27, 2012 at 04:04, Lei Wen wrote: > On Sun, Mar 25, 2012 at 11:53 PM,   wrote: >> From: Lei Wen >> >> This patch set add zip command support for uboot. >> The first two patches import deflate and trees functions from zlib 1.2.5 >> without any change. While the third patch did the nece

Re: [U-Boot] [PATCH] Prevent malloc with size 0

2012-04-02 Thread Mike Frysinger
On Mon, Apr 2, 2012 at 14:40, Joakim Tjernlund wrote: > Marek Vasut wrote on 2012/04/02 20:00:03: >> Dear Joakim Tjernlund, >> > Depends, if writing generic code for lots of OS:es you cannot rely >> > malloc(0). Writing kernel code you can. >> >> No you cannot. It's in the spec you cannot and you

Re: [U-Boot] [PATCH V2 2/4] ARM: 926ejs: use debug() for misaligned addresses

2012-04-02 Thread Mike Frysinger
On Mon, Apr 2, 2012 at 14:42, Marek Vasut wrote: >> On Mon, Apr 2, 2012 at 12:18, Stefano Babic wrote: >> > Misaligned warnings are useful to debug faulty drivers. >> > A misaligned warning is printed also when the driver >> > is correct - use debug() instead of printf(). >> >> unfortunately, this

Re: [U-Boot] [PATCH v3 6/6] env: delete selected vars not present in imported env

2012-04-02 Thread Marek Vasut
Dear Gerlando Falauto, > When variables explicitly specified on the command line are not present > in the imported env, delete them from the running env. > If the variable is also missing from the running env, issue a warning. > > Signed-off-by: Gerlando Falauto > --- > lib/hashtable.c | 48 +

Re: [U-Boot] [PATCH v3 5/6] env: make "env default" selective, check and apply

2012-04-02 Thread Marek Vasut
Dear Gerlando Falauto, > Change the syntax (user API) for "env default": > -f: override write-once variables > var... : accept individual variable(s) > -a: all (resetting the whole env is NOT the default behavior) > Looks fine. > Enable variable checking and make changes effective by > en

Re: [U-Boot] [PATCH v2] mmc: mxsmmc: Fix operation with DMA

2012-04-02 Thread Marek Vasut
Dear Fabio Estevam, > On Mon, Apr 2, 2012 at 3:39 PM, Marek Vasut wrote: > > This mxs_dma_desc_alloc() is called in a loop in the MXS NAND driver, > > this is even worse ;-) > > > > Possibly some common mx28 init code would be better? > > If I put it in mx28.c like that: > > +++ b/arch/arm/cpu

Re: [U-Boot] [PATCH v3 4/6] env: check and apply changes on delete/destroy

2012-04-02 Thread Marek Vasut
Dear Gerlando Falauto, > Signed-off-by: Gerlando Falauto Looks ok > --- > common/cmd_nvedit.c |2 +- > include/search.h|5 +++-- > lib/hashtable.c | 16 ++-- > 3 files changed, 14 insertions(+), 9 deletions(-) > > diff --git a/common/cmd_nvedit.c b/common/cmd_nve

Re: [U-Boot] [PATCH v3 3/6] env: add check/apply logic to himport_r()

2012-04-02 Thread Marek Vasut
Dear Marek Vasut, > Dear Gerlando Falauto, > > > Change hashtable so that a callback function will decide whether a > > variable can be overwritten, and possibly apply the changes. > > > > So add a new field to struct hsearch_data: > > o "apply" callback function to check whether a variable can

Re: [U-Boot] [PATCH v3 3/6] env: add check/apply logic to himport_r()

2012-04-02 Thread Marek Vasut
Dear Gerlando Falauto, > Change hashtable so that a callback function will decide whether a > variable can be overwritten, and possibly apply the changes. > > So add a new field to struct hsearch_data: > > o "apply" callback function to check whether a variable can be > overwritten, and pos

Re: [U-Boot] [PATCH v3 2/6] env: make himport_r() selective on variables

2012-04-02 Thread Marek Vasut
Dear Gerlando Falauto, > Add 2 new arguments to himport_r(): > > o "nvars", "vars": number and list of variables to take into account >(0 means ALL) > Looks nice and clean. But man, these patches are tough to review (not because you made bad job, just because they're hard code), lot of he

Re: [U-Boot] [PATCH v3 1/6] env: unify logic to check and apply changes

2012-04-02 Thread Marek Vasut
Dear Gerlando Falauto, > The logic of checking special parameters (e.g. baudrate, stdin, stdout, > for a valid value and/or whether can be overwritten) and applying the > new value to the running system is now all within a single function > env_check_apply() which can be called whenever changes ar

Re: [U-Boot] [PATCH v2] mmc: mxsmmc: Fix operation with DMA

2012-04-02 Thread Fabio Estevam
On Mon, Apr 2, 2012 at 3:39 PM, Marek Vasut wrote: > This mxs_dma_desc_alloc() is called in a loop in the MXS NAND driver, this is > even worse ;-) > > Possibly some common mx28 init code would be better? If I put it in mx28.c like that: +++ b/arch/arm/cpu/arm926ejs/mx28/mx28.c @@ -172,6 +172,8

Re: [U-Boot] [PATCH V2 2/4] ARM: 926ejs: use debug() for misaligned addresses

2012-04-02 Thread Marek Vasut
Dear Mike Frysinger, > On Mon, Apr 2, 2012 at 12:18, Stefano Babic wrote: > > Misaligned warnings are useful to debug faulty drivers. > > A misaligned warning is printed also when the driver > > is correct - use debug() instead of printf(). > > unfortunately, this turns the failure into a silent

Re: [U-Boot] [PATCH] Prevent malloc with size 0

2012-04-02 Thread Joakim Tjernlund
Marek Vasut wrote on 2012/04/02 20:00:03: > > Dear Joakim Tjernlund, > > > Marek Vasut wrote on 2012/04/02 18:39:33: > > > From: Marek Vasut > > > > > > Dear Joakim Tjernlund, > > > > > > > Marek Vasut wrote on 2012/04/02 17:23:03: > > > > > Dear Joakim Tjernlund, > > > > > > > > > > > Marek Va

Re: [U-Boot] [PATCH v2] mmc: mxsmmc: Fix operation with DMA

2012-04-02 Thread Marek Vasut
Dear Fabio Estevam, > Initialize the DMA controller so that the following errors are fixed: > > U-Boot 2012.04-rc1-1-g037cbfd (Apr 02 2012 - 10:57:48) > > Freescale i.MX28 family at 454 MHz > DRAM: 128 MiB > MMC: MXS MMC: 0 > MMC0: DMA transfer failed > MMC0: DMA transfer failed > MMC0: D

[U-Boot] [PATCH v3 0/6] env: handle special variables and selective env default

2012-04-02 Thread Gerlando Falauto
This patchset modifies the handling of all the operations on the environment (set/import/default) so to unify handling of special variables. On top of that we implement a selective "env default". A selective "env import" would imply a user API change and should therefore be discussed separately.

[U-Boot] [PATCH v3 5/6] env: make "env default" selective, check and apply

2012-04-02 Thread Gerlando Falauto
Change the syntax (user API) for "env default": -f: override write-once variables var... : accept individual variable(s) -a: all (resetting the whole env is NOT the default behavior) Enable variable checking and make changes effective by enabling do_apply argument to himport_r(). Signed-off

[U-Boot] [PATCH v3 1/6] env: unify logic to check and apply changes

2012-04-02 Thread Gerlando Falauto
The logic of checking special parameters (e.g. baudrate, stdin, stdout, for a valid value and/or whether can be overwritten) and applying the new value to the running system is now all within a single function env_check_apply() which can be called whenever changes are made to the environment, no ma

[U-Boot] [PATCH v3 4/6] env: check and apply changes on delete/destroy

2012-04-02 Thread Gerlando Falauto
Signed-off-by: Gerlando Falauto --- common/cmd_nvedit.c |2 +- include/search.h|5 +++-- lib/hashtable.c | 16 ++-- 3 files changed, 14 insertions(+), 9 deletions(-) diff --git a/common/cmd_nvedit.c b/common/cmd_nvedit.c index fc6165f..091cd46 100644 --- a/common/cm

[U-Boot] [PATCH v3 3/6] env: add check/apply logic to himport_r()

2012-04-02 Thread Gerlando Falauto
Change hashtable so that a callback function will decide whether a variable can be overwritten, and possibly apply the changes. So add a new field to struct hsearch_data: o "apply" callback function to check whether a variable can be overwritten, and possibly immediately apply the changes;

[U-Boot] [PATCH v3 6/6] env: delete selected vars not present in imported env

2012-04-02 Thread Gerlando Falauto
When variables explicitly specified on the command line are not present in the imported env, delete them from the running env. If the variable is also missing from the running env, issue a warning. Signed-off-by: Gerlando Falauto --- lib/hashtable.c | 48 +++

[U-Boot] [PATCH v3 2/6] env: make himport_r() selective on variables

2012-04-02 Thread Gerlando Falauto
Add 2 new arguments to himport_r(): o "nvars", "vars": number and list of variables to take into account (0 means ALL) NOTE: This patch does not change the current behaviour. Signed-off-by: Gerlando Falauto --- common/cmd_nvedit.c |3 ++- common/env_common.c |6 -- include/sear

Re: [U-Boot] [U-BOOT][PATCH] mmc: support the revision check for eMMC4.5

2012-04-02 Thread Jae hoon Chung
Hi, Anybody think about this patch? mmcinfo is produce correctly? if i miss something, let me know, plz. Best Regards, Jaehoon Chung 2012/3/27 Jaehoon Chung : > eMMC card is introduced the eMMC4.5. > But now eMMC card is checked up to eMMC4.0. > This patch is supported until eMMC4.5 > > Signed-

Re: [U-Boot] [PATCH 1/2] Build u-boot.imx by default when board uses it

2012-04-02 Thread Mike Frysinger
On Mon, Apr 2, 2012 at 13:03, Stefano Babic wrote: > On 11/11/2011 14:26, Loďc Minier wrote: >> On Fri, Nov 11, 2011, Daniel Schwierzeck wrote: >>> ALL-$(CONFIG_UBOOT_IMG) += $(obj)u-boot.img >>> ALL-$(CONFIG_UBOOT_IMX) += $(obj)u-boot.imx >>> ALL-$(CONFIG_UBOOT_KWB) += $(obj)u-boot.kwb >>> >>> the

Re: [U-Boot] [U-BOOT][PATCH] mmc: remove the hard setting for tran_speed

2012-04-02 Thread Jae hoon Chung
Hi Andy. How do you about this patch? I want to know your thinking. In my case, clock is set to 50MHz, but mmcinfo is produced the "25MHz". Because tran_speed is 25MHz. But mmc->card_caps is set to MMC_MODE_HS and MMC_MODE_HS_52MHZ. So we should be see the wrong information with mmcinfo. Best Reg

Re: [U-Boot] [PATCH V2 2/4] ARM: 926ejs: use debug() for misaligned addresses

2012-04-02 Thread Mike Frysinger
On Mon, Apr 2, 2012 at 12:18, Stefano Babic wrote: > Misaligned warnings are useful to debug faulty drivers. > A misaligned warning is printed also when the driver > is correct - use debug() instead of printf(). unfortunately, this turns the failure into a silent one. if i read the code correctly

[U-Boot] [PATCH v2] mmc: mxsmmc: Fix operation with DMA

2012-04-02 Thread Fabio Estevam
Initialize the DMA controller so that the following errors are fixed: U-Boot 2012.04-rc1-1-g037cbfd (Apr 02 2012 - 10:57:48) Freescale i.MX28 family at 454 MHz DRAM: 128 MiB MMC: MXS MMC: 0 MMC0: DMA transfer failed MMC0: DMA transfer failed MMC0: DMA transfer failed MMC0: DMA transfer fai

Re: [U-Boot] [PATCH] Correct corrupted NAND Flash access on KARO TX25 modules

2012-04-02 Thread stefano babic
Am 02/04/2012 19:47, schrieb Gachet Daniel: > Hi Stefano, > > Have I to do more for the patch? Are you ok with the proposal? > That is ok. Please use a shorter name: the function you patch is already surrounded by #ifdef MXC_NFC_V1_1, so it is not required to repeat it in the name (we have a lot

Re: [U-Boot] [PATCH] Prevent malloc with size 0

2012-04-02 Thread Marek Vasut
Dear Joakim Tjernlund, > Marek Vasut wrote on 2012/04/02 18:39:33: > > From: Marek Vasut > > > > Dear Joakim Tjernlund, > > > > > Marek Vasut wrote on 2012/04/02 17:23:03: > > > > Dear Joakim Tjernlund, > > > > > > > > > Marek Vasut wrote on 2012/04/02 16:42:30: > > > > > > Dear Joakim Tjer

  1   2   >