Re: [U-Boot] [PATCH 4/4] USB:gadget:designware Fix memory nonalignment issue

2012-03-06 Thread Amit Virdi
Dear Marek, } This addresses EHCI cache problem, that's why you need bounce buffer, right? No. The problem was we were copying data word-by-word to a non-word aligned memory in the USB gadget. So, this is different from the USB host controller issue. I see ... why isn't buffer aligned b

Re: [U-Boot] Please pull u-boot-ti/master

2012-03-06 Thread Albert ARIBAUD
Hi Wolfgang, Le 06/03/2012 21:16, Wolfgang Denk a écrit : Dear Albert ARIBAUD, In message<4f55bcdc.70...@aribaud.net> you wrote: With the documentation / related changes, Wolfgang said on IRC he was OK for now with the additional SPL bits going on. All these commits are feature additions

Re: [U-Boot] [PATCH v8] usb: align buffers at cacheline

2012-03-06 Thread puneets
Hi Mike, On Tuesday 06 March 2012 08:37 AM, Mike Frysinger wrote: * PGP Signed by an unknown key On Monday 05 March 2012 09:46:21 Puneet Saxena wrote: As DMA expects the buffers to be equal and larger then cache lines, This aligns buffers at cacheline. i don't think this statement is true. DM

Re: [U-Boot] cam_enc_4xx build failure

2012-03-06 Thread Heiko Schocher
Hello Marek, added Tom Rini to cc... Marek Vasut wrote: > Dear Heiko Schocher, > > cam_enc_4xx does not build with ELDK4.2 . Can you please come up with a patch? > > Thanks in advance! > > Copyright (C) 2007 Free Software Foundation, Inc. > This is free software; see the source for copying con

Re: [U-Boot] [PATCH 4/4] USB:gadget:designware Fix memory nonalignment issue

2012-03-06 Thread Amit Virdi
Hey Mike, On 3/6/2012 9:39 PM, Mike Frysinger wrote: On Thursday 16 February 2012 07:03:38 Amit Virdi wrote: --- a/drivers/usb/gadget/designware_udc.c +++ b/drivers/usb/gadget/designware_udc.c + /* copy back tmp buffer to bufp if bufp is not word aligned */ + if ((int)bufp& 0x3) {

[U-Boot] [PATCH V3] OMAP5: reset: Use cold reset in case of 5430ES1.0

2012-03-06 Thread R Sricharan
Warm reset is not functional in case of omap5430ES1.0. So use cold reset instead. Signed-off-by: R Sricharan --- [v3] Addressed Tom Rini's comments. arch/arm/cpu/armv7/omap-common/reset.S |3 +++ arch/arm/cpu/armv7/omap5/hwinit.c | 15 +++ 2 files changed, 18 insert

Re: [U-Boot] [PATCH 1/4] doc: Add documentation for mpc85xx debugger support

2012-03-06 Thread Wolfgang Denk
Dear Kushwaha Prabhakar-B32579, In message <071a08f2c6a57e4e94d980eca553f874575...@039-sn1mpn1-005.039d.mgd.msft.net> you wrote: > > Regarding CONFIG_E500_V1_V2, Its description is also part of this > patch or is it not cleared ? First, documentation of CONFIG_ options belongs into the central

Re: [U-Boot] [PATCH 2/2][v2] powerpc/85xx:Add PSC9131 RDB Support

2012-03-06 Thread Prabhakar Kushwaha
Hi Wolfgang, Thanks for reviewing it. Please find my response in-lined. On Tuesday 06 March 2012 08:41 PM, Wolfgang Denk wrote: Dear Prabhakar Kushwaha, In message<1329304781-27758-1-git-send-email-prabha...@freescale.com> you wrote: ... +#define CONFIG_L2_CACHE/* t

Re: [U-Boot] [PATCH v3 6/7] arm: add a common .lds link script

2012-03-06 Thread Simon Glass
Hi Albert, On Tue, Feb 28, 2012 at 1:25 PM, Albert ARIBAUD wrote: > Hi Simon, > > Le 21/02/2012 21:14, Simon Glass a écrit : >> >> Hi Albert, >> >> >> On Tue, Feb 21, 2012 at 11:52 AM, Albert ARIBAUD >>  wrote: >>> >>> Hi Simon, >>> >>> Le 21/02/2012 18:02, Simon Glass a écrit : >>> >>> >> +

Re: [U-Boot] [PATCH v4 05/13] Move memcpy(), memset() into new lib/membasic.c

2012-03-06 Thread Graeme Russ
Hi Mike, On Wed, Mar 7, 2012 at 3:20 AM, Mike Frysinger wrote: > On Tuesday 06 March 2012 01:34:24 Simon Glass wrote: >> On Mon, Mar 5, 2012 at 9:05 PM, Mike Frysinger wrote: >> > On Monday 20 February 2012 20:32:47 Simon Glass wrote: >> >> These basic functions are needed by relocation. To avoid

Re: [U-Boot] [PATCH v4 05/13] Move memcpy(), memset() into new lib/membasic.c

2012-03-06 Thread Simon Glass
Hi Mike, On Tue, Mar 6, 2012 at 8:20 AM, Mike Frysinger wrote: > On Tuesday 06 March 2012 01:34:24 Simon Glass wrote: >> On Mon, Mar 5, 2012 at 9:05 PM, Mike Frysinger wrote: >> > On Monday 20 February 2012 20:32:47 Simon Glass wrote: >> >> These basic functions are needed by relocation. To avoid

Re: [U-Boot] [PATCH v5 5/9] tegra: i2c: Add I2C driver

2012-03-06 Thread Heiko Schocher
Hello Simon, Simon Glass wrote: > From: Yen Lin > > Add basic i2c driver for Tegra2 with 8- and 16-bit address support. > The driver requires CONFIG_OF_CONTROL to obtain its configuration > from the device tree. > > (Simon Glass: s...@chromium.org modified for upstream) > > Signed-off-by: Simo

[U-Boot] [PATCH v5 5/9] tegra: i2c: Add I2C driver

2012-03-06 Thread Simon Glass
From: Yen Lin Add basic i2c driver for Tegra2 with 8- and 16-bit address support. The driver requires CONFIG_OF_CONTROL to obtain its configuration from the device tree. (Simon Glass: s...@chromium.org modified for upstream) Signed-off-by: Simon Glass --- Changes in v2: - Adjust definitions to

[U-Boot] [PATCH v5 4/9] tegra: fdt: i2c: Add extra I2C bindings for U-Boot

2012-03-06 Thread Simon Glass
Add U-Boot's peripheral clock information to the Tegra20 device tree file. Signed-off-by: Simon Glass --- Changes in v2: - Adjust definitions to fit new peripheral clock bindings - Change 'speed' to 'clock-frequency' - Remove u-boot,pinmux binding (sadly) Changes in v3: - Move speed setting from

Re: [U-Boot] [PATCH v4 5/9] tegra: i2c: Add I2C driver

2012-03-06 Thread Simon Glass
Hi Mike, On Thu, Mar 1, 2012 at 12:29 PM, Mike Frysinger wrote: > On Wednesday 29 February 2012 12:31:25 Simon Glass wrote: >> --- /dev/null >> +++ b/arch/arm/include/asm/arch-tegra2/tegra_i2c.h >> >> +/* Convert i2c slave address to be put on bus  */ >> +#define I2C_ADDR_ON_BUS(chip)            

Re: [U-Boot] [PATCH v4 5/9] tegra: i2c: Add I2C driver

2012-03-06 Thread Simon Glass
Hi Stephen, On Wed, Feb 29, 2012 at 12:30 PM, Stephen Warren wrote: > On 02/29/2012 10:31 AM, Simon Glass wrote: >> From: Yen Lin >> >> Add basic i2c driver for Tegra2 with 8- and 16-bit address support. >> The driver requires CONFIG_OF_CONTROL to obtain its configuration >> from the device tree

Re: [U-Boot] [PATCH v4 4/9] tegra: fdt: i2c: Add extra I2C bindings for U-Boot

2012-03-06 Thread Simon Glass
Hi Stephen, On Wed, Feb 29, 2012 at 12:36 PM, Stephen Warren wrote: > On 02/29/2012 01:32 PM, Simon Glass wrote: >> Hi Stephen, >> >> On Wed, Feb 29, 2012 at 12:21 PM, Stephen Warren wrote: >>> On 02/29/2012 10:31 AM, Simon Glass wrote: Add U-Boot's peripheral clock information to the Tegra

Re: [U-Boot] [PATCH 2/4] powerpc/85xx:Fix MSR[DE] bit in MSR to support debugger

2012-03-06 Thread Prabhakar Kushwaha
Hi Wolfgang, On Tuesday 06 March 2012 08:10 PM, Wolfgang Denk wrote: Dear Prabhakar Kushwaha, In message<1329296042-28506-1-git-send-email-prabha...@freescale.com> you wrote: Debugger's ability to debug an application is constrained by the architecture's debug IP / run-control solution that

Re: [U-Boot] [PATCH 2/4] powerpc/85xx:Fix MSR[DE] bit in MSR to support debugger

2012-03-06 Thread Prabhakar Kushwaha
Hi Wolfgang, On Tuesday 06 March 2012 08:10 PM, Wolfgang Denk wrote: Dear Prabhakar Kushwaha, In message<1329296042-28506-1-git-send-email-prabha...@freescale.com> you wrote: Debugger's ability to debug an application is constrained by the architecture's debug IP / run-control solution that

Re: [U-Boot] [PATCH 3/4] powerpc/85xx:Update NOR code base to support debugger

2012-03-06 Thread Prabhakar Kushwaha
Hi Wolfgang, On Tuesday 06 March 2012 08:15 PM, Wolfgang Denk wrote: Dear Prabhakar Kushwaha, In message<1329296055-28541-1-git-send-email-prabha...@freescale.com> you wrote: Update the NOR code base to support NOR-boot debugging. It ovecome e500 and e500v2's second limitation i.e. IVPR + IV

Re: [U-Boot] [PATCH 1/4] doc: Add documentation for mpc85xx debugger support

2012-03-06 Thread Prabhakar Kushwaha
Hi Wolfgang, Thanks for reviewing this patch. Please find my response in-lined On Tuesday 06 March 2012 08:09 PM, Wolfgang Denk wrote: Dear Prabhakar Kushwaha, In message<1329296027-28471-1-git-send-email-prabha...@freescale.com> you wrote: This describes requirement of e500 and e500v2 pro

[U-Boot] [PATCH v2 2/2] Allow newlines within command environment vars

2012-03-06 Thread Simon Glass
Any environment variable can hold commands to be executed by the 'run' command. The environment variables preboot, bootcmd and menucmd have special code for triggering execution in certain circumstances. We adjust these calls to use run_command_list() instead of run_command(). This change permits

Re: [U-Boot] [PATCH 2/2] Allow newlines within command environment vars

2012-03-06 Thread Simon Glass
Hi Wolfgang, On Tue, Mar 6, 2012 at 7:26 AM, Wolfgang Denk wrote: > Dear Simon Glass, > > In message > you > wrote: > ... >> >> > > The environment variables preboot, bootcmd and menucmd can hold a >> >> > > command >> >> > > to execute. This change permits these variables to have newlines so

Re: [U-Boot] [PATCH v7 09/20] tegra: fdt: Add additional USB binding

2012-03-06 Thread Simon Glass
Hi Stephen, On Tue, Feb 28, 2012 at 10:49 AM, Stephen Warren wrote: > Simon Glass wrote at Tuesday, February 28, 2012 11:49 AM: >> On Tue, Feb 28, 2012 at 10:42 AM, Stephen Warren wrote: >> > Simon Glass wrote at Tuesday, February 28, 2012 11:08 AM: >> >> This adds a property to indicate a port

[U-Boot] [PATCH v8 21/21] tegra: fdt: Enable FDT support for Ventana

2012-03-06 Thread Simon Glass
From: Tom Warren This switches Ventana over to use FDT for run-time config instead of CONFIG options. At present Ventana does not have its own device tree file - it just uses the Seaboard one. Signed-off-by: Tom Warren Signed-off-by: Simon Glass Acked-by: Simon Glass --- Changes in v8: - Add

[U-Boot] [PATCH v8 15/21] tegra: fdt: Add function to return peripheral/clock ID

2012-03-06 Thread Simon Glass
A common requirement is to find the clock ID for a peripheral. This is the second cell of the 'clocks' property (the first being the phandle itself). Signed-off-by: Simon Glass --- Changes in v4: - Add fdtdec function to return peripheral ID Changes in v6: - Move peripheral decode function into

[U-Boot] [PATCH v4] net: allow setting env enetaddr from net device setting

2012-03-06 Thread Rob Herring
From: Rob Herring If the net driver has setup a valid ethernet address and an ethernet address is not set in the environment already, then set the environment variables from the net driver setting. This enables pxe booting on boards which don't set ethaddr env variable. Signed-off-by: Rob Herri

Re: [U-Boot] [PATCH v6 11/20] tegra: fdt: Add clock bindings for Tegra2 Seaboard

2012-03-06 Thread Simon Glass
Hi Tom, On Mon, Mar 5, 2012 at 12:46 PM, Tom Rini wrote: > On Tue, Feb 28, 2012 at 10:41:15AM -0800, Stephen Warren wrote: >> Simon Glass wrote at Tuesday, February 28, 2012 11:37 AM: >> > On Tue, Feb 28, 2012 at 10:31 AM, Stephen Warren >> > wrote: >> > > Simon Glass wrote at Tuesday, February

Re: [U-Boot] [PATCH] lib: zlib: update to 1.2.6

2012-03-06 Thread Lei Wen
Hi Mike, On Wed, Mar 7, 2012 at 12:15 AM, Mike Frysinger wrote: > On Tuesday 06 March 2012 03:55:19 Lei Wen wrote: >> In this patch, I update the current zlib from 1.2.5 to 1.2.6. >> >> There is a lot of warnings when using checkpatch script, I don't know >> whether I should fix it or not... >> S

Re: [U-Boot] [PATCH 1/3] spl: add ymodem support

2012-03-06 Thread Mikhail Kshevetskiy
On Tue, 6 Mar 2012 22:28:46 + Laurence Withers wrote: > On Wed, Mar 07, 2012 at 12:54:05AM +0400, Mikhail Kshevetskiy wrote: > > We have an omap l138 based board without jtag and empty spi flash. > > UART is an only way to load something on this board, so we are using > > uart to load spl ima

Re: [U-Boot] [PATCH 1/3] spl: add ymodem support

2012-03-06 Thread Mikhail Kshevetskiy
On Tue, 6 Mar 2012 18:34:05 -0300 Fabio Estevam wrote: > On Tue, Mar 6, 2012 at 5:54 PM, Mikhail Kshevetskiy > wrote: > > We have an omap l138 based board without jtag and empty spi flash. > > UART is an only way to load something on this board, so we are using > > uart to load spl image u-boot

Re: [U-Boot] OneNAND custodian (was: Re: [RESEND 0/4] onenand: OneNAND board dependent probe and fixes for Samsung targets)

2012-03-06 Thread Kyungmin Park
On 3/7/12, Scott Wood wrote: > On 03/06/2012 12:54 AM, Lukasz Majewski wrote: >> This patch sets add board dependent onenand probes. >> >> Several fixes for GONI and Exynos4210 (C210_universal) targets have been >> added. >> >> Tested at: >> Samsung S5PC110 GONI >> Samsung Exynos4210

[U-Boot] [RFC PATCH 5/5] cmd_scsi: use common get_device_and_partition function

2012-03-06 Thread Rob Herring
From: Rob Herring Convert scsiboot to use common device and partition parsing function. Signed-off-by: Rob Herring --- common/cmd_scsi.c | 58 ++-- 1 files changed, 11 insertions(+), 47 deletions(-) diff --git a/common/cmd_scsi.c b/common/cmd_

[U-Boot] [RFC PATCH 2/5] disk/part: introduce get_device_and_partition

2012-03-06 Thread Rob Herring
From: Rob Herring All block device related commands (scsiboot, fatload, ext2ls, etc.) have simliar duplicated device and partition parsing and selection code. This adds a common function to replace various implementations. The new function has some enhancements over current versions. If no devic

[U-Boot] [RFC PATCH 4/5] cmd_fat: use common get_device_and_partition function

2012-03-06 Thread Rob Herring
From: Rob Herring Convert fatload, fatls, and fatinfo to use common device and partition parsing function. With the common function "dev:part" can come from the environment and a '-' can be used in that case. Signed-off-by: Rob Herring --- common/cmd_fat.c | 72 +++---

[U-Boot] [RFC PATCH 3/5] cmd_ext2: use common get_device_and_partition function

2012-03-06 Thread Rob Herring
From: Rob Herring Convert ext2ls and ext2load to use common device and partition parsing function. Signed-off-by: Rob Herring --- common/cmd_ext2.c | 71 - 1 files changed, 16 insertions(+), 55 deletions(-) diff --git a/common/cmd_ext2.c b

[U-Boot] [RFC PATCH 1/5] disk/part: check bootable flag for DOS partitions

2012-03-06 Thread Rob Herring
From: Rob Herring Determine which partitions are bootable/active. In the partition listing, print "Boot" for partitions with the bootable/active flag set. Signed-off-by: Rob Herring --- disk/part_dos.c | 11 +-- include/part.h |1 + 2 files changed, 10 insertions(+), 2 deletions

[U-Boot] [RFC PATCH 0/5] add bootable partition support

2012-03-06 Thread Rob Herring
From: Rob Herring The primary goal of this series is to enable using the 1st bootable partition as the default partition for disk boot related commands. Every command that takes a "[:]" option duplicates the same parsing code, so this series consolidates the parsing code to a single function. Th

Re: [U-Boot] [PATCH v2] main: unify command parsing functions

2012-03-06 Thread Simon Glass
Hi, On Tue, Mar 6, 2012 at 2:29 PM, Michael Walle wrote: > Hi Wolfgang, > > Am Dienstag 06 März 2012, 21:39:16 schrieb Wolfgang Denk: >> In message <1326499314-8121-1-git-send-email-mich...@walle.cc> you wrote: >> > Introduce source_commands() which incorporates run_command2() and parts >> > of s

Re: [U-Boot] [PATCH 1/8 v3] powerpc/srio: Rewrite the struct ccsr_rio

2012-03-06 Thread Andy Fleming
On Tue, Mar 6, 2012 at 3:45 AM, Liu Gang wrote: > Rewrite this struct for the support of two ports and two message > units registers. > > Signed-off-by: Liu Gang > --- > Changes in v2: >  - Change the subject and commit message. >  - Remove the offsets in the comments. >  - Rewrite the struct for

Re: [U-Boot] [PATCH v2] main: unify command parsing functions

2012-03-06 Thread Michael Walle
Hi Wolfgang, Am Dienstag 06 März 2012, 21:39:16 schrieb Wolfgang Denk: > In message <1326499314-8121-1-git-send-email-mich...@walle.cc> you wrote: > > Introduce source_commands() which incorporates run_command2() and parts > > of source(). > > > > All command script are now treated the same, that

Re: [U-Boot] [PATCH 1/3] spl: add ymodem support

2012-03-06 Thread Laurence Withers
On Wed, Mar 07, 2012 at 12:54:05AM +0400, Mikhail Kshevetskiy wrote: > We have an omap l138 based board without jtag and empty spi flash. > UART is an only way to load something on this board, so we are using > uart to load spl image u-boot and then we are using ymodem to load > the rest part of u-

Re: [U-Boot] (no subject)

2012-03-06 Thread Mike Frysinger
On Tuesday 06 March 2012 16:29:12 Wolfgang Denk wrote: > I have nearly 50 sandbox related patches in my queue, many based on > stuff that was posted before close of the merge window, and I have to > admit that I lost track which of these are supposed to be applied, > which were merely for RFC, or w

Re: [U-Boot] [PATCH V2] net: fec_mxc: allow use with cache enabled

2012-03-06 Thread Marek Vasut
Dear Eric Nelson, > On 03/06/2012 12:49 PM, Marek Vasut wrote: > > Dear Eric Nelson, > > > >> On 03/06/2012 10:06 AM, Eric Nelson wrote: > >>> On 03/05/2012 01:06 PM, Marek Vasut wrote: > Dear Eric Nelson, > > >> >> > > > > + if (!fec->rbd_base) { > > + ret = -ENOMEM;

Re: [U-Boot] [PATCH 1/3] spl: add ymodem support

2012-03-06 Thread Fabio Estevam
On Tue, Mar 6, 2012 at 5:54 PM, Mikhail Kshevetskiy wrote: > We have an omap l138 based board without jtag and empty spi flash. > UART is an only way to load something on this board, so we are using > uart to load spl image u-boot and then we are using ymodem to load > the rest part of u-boot. > -

[U-Boot] [PATCH 2/3] ns16550 has a different register layout on SOC_DA8XX

2012-03-06 Thread Mikhail Kshevetskiy
also fix NS16550_init() as we need 16x divider --- drivers/serial/ns16550.c |2 +- include/ns16550.h|9 + 2 files changed, 10 insertions(+), 1 deletions(-) Signed-off-by: Mikhail Kshevetskiy diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c index 0c23955..

[U-Boot] [PATCH 3/3] arm/davinci/da850: add uart0 pinmux

2012-03-06 Thread Mikhail Kshevetskiy
--- arch/arm/cpu/arm926ejs/davinci/da850_pinmux.c |5 + arch/arm/include/asm/arch-davinci/hardware.h|1 + arch/arm/include/asm/arch-davinci/pinmux_defs.h |1 + 3 files changed, 7 insertions(+), 0 deletions(-) Signed-off-by: Mikhail Kshevetskiy diff --git a/arch/arm/cpu/arm

[U-Boot] [PATCH 1/3] spl: add ymodem support

2012-03-06 Thread Mikhail Kshevetskiy
We have an omap l138 based board without jtag and empty spi flash. UART is an only way to load something on this board, so we are using uart to load spl image u-boot and then we are using ymodem to load the rest part of u-boot. --- arch/arm/cpu/arm926ejs/davinci/spl.c | 25 +++ commo

[U-Boot] (no subject)

2012-03-06 Thread Wolfgang Denk
Mike Frysinger From: Wolfgang Denk Fcc: +U-Boot Subject: Re: [U-Boot] [PATCH v4 1/8] sandbox: fdt: Add support for CONFIG_OF_CONTROL MIME-Version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8bit In-reply-to: <1329349878-16664-1-git-send-email-...@chromium.org> Refere

Re: [U-Boot] [PATCH V2] net: fec_mxc: allow use with cache enabled

2012-03-06 Thread Eric Nelson
On 03/06/2012 02:22 PM, Marek Vasut wrote: Dear Eric Nelson, On 03/06/2012 12:45 PM, Marek Vasut wrote: Dear Eric Nelson, On 03/05/2012 01:06 PM, Marek Vasut wrote: Dear Eric Nelson, ensure that transmit and receive buffers are cache-line aligned invalidate cac

Re: [U-Boot] [PATCH V2] net: fec_mxc: allow use with cache enabled

2012-03-06 Thread Marek Vasut
Dear Eric Nelson, > On 03/06/2012 12:45 PM, Marek Vasut wrote: > > Dear Eric Nelson, > > > >> On 03/05/2012 01:06 PM, Marek Vasut wrote: > >>> Dear Eric Nelson, > >>> > ensure that transmit and receive buffers are cache-line aligned > > invalidate cache after each pac

Re: [U-Boot] [PATCH V2] net: fec_mxc: allow use with cache enabled

2012-03-06 Thread Eric Nelson
On 03/06/2012 12:49 PM, Marek Vasut wrote: Dear Eric Nelson, On 03/06/2012 10:06 AM, Eric Nelson wrote: On 03/05/2012 01:06 PM, Marek Vasut wrote: Dear Eric Nelson, >> >> + if (!fec->rbd_base) { + ret = -ENOMEM; + goto err2; + } + memset(fec->rbd_base, 0, size); + } We might want t

Re: [U-Boot] [PATCH V2] net: fec_mxc: allow use with cache enabled

2012-03-06 Thread Eric Nelson
On 03/06/2012 12:45 PM, Marek Vasut wrote: Dear Eric Nelson, On 03/05/2012 01:06 PM, Marek Vasut wrote: Dear Eric Nelson, ensure that transmit and receive buffers are cache-line aligned invalidate cache after each packet received flush cache before transmi

Re: [U-Boot] [PATCH v2 2/3] image: Support FDTs already loaded at their load address

2012-03-06 Thread Wolfgang Denk
Dear Stephen Warren, In message <1320164902-24190-2-git-send-email-swar...@nvidia.com> you wrote: > boot_get_fdt() expects a uImage-wrapped FDT to be loaded to a staging > location, and then memmove()s it to the load address specified in the > header. This change enhances boot_get_fdt() to detect

Re: [U-Boot] [PATCH] cmd_cache: use cache/invalidate functions available in common.h

2012-03-06 Thread Wolfgang Denk
Dear Stefan Kristiansson, In message <1320121272-17613-1-git-send-email-stefan.kristians...@saunalahti.fi> you wrote: > flush_dcache()/flush_icache() aren't defined in common.h, > flush_dcache_all()/invalidate_icache_all() however are. > > Let the icache and dcache commands use those instead. >

Re: [U-Boot] [PATCH] tools: checkstack.pl from Linux added to tools

2012-03-06 Thread Wolfgang Denk
Dear Tom Rini, In message <1328227625-24653-1-git-send-email-tr...@ti.com> you wrote: > Added from Linux - commit 62aa2b537c6f5957afd98e29f96897419ed5ebab > > Signed-off-by: Tom Rini > --- > Makefile|5 ++ > tools/checkstack.pl | 172 > +

Re: [U-Boot] [PATCH v3] add nand spl boot for qi_lb60 board

2012-03-06 Thread Wolfgang Denk
Dear Xiangfu Liu, In message <1326207993-17791-1-git-send-email-xian...@openmobilefree.net> you wrote: > Signed-off-by: Xiangfu Liu > --- > > Changes for v2: > -Add CONFIG_SYS_NAND_4BIT_HW_ECC_OOBFIRST > -Cleanup jz4740_nand.c a little > > Changes for v3: > -Remove CONFIG_NAND_SPL_TEXT_BASE

Re: [U-Boot] [PATCH] Makefile: Remove mmc_spl related enteries

2012-03-06 Thread Wolfgang Denk
Dear Chander Kashyap, In message <1320727394-3427-1-git-send-email-chander.kash...@linaro.org> you wrote: > As mmc_spl now follows spl infrastructure, removed unwanted > enteries in Makefile for mmc_spl related compilation. > > Signed-off-by: Chander Kashyap > --- > Makefile |8 >

Re: [U-Boot] [PATCH v2] main: unify command parsing functions

2012-03-06 Thread Wolfgang Denk
Dear Michael Walle, In message <1326499314-8121-1-git-send-email-mich...@walle.cc> you wrote: > Introduce source_commands() which incorporates run_command2() and parts of > source(). > > All command script are now treated the same, that is newlines are accepted > within a command script and varia

Re: [U-Boot] [PATCH v5 0/9] Unified command execution in one place

2012-03-06 Thread Wolfgang Denk
Dear Simon Glass, In message you wrote: > > OK good. Hoping it sorts out the command success/failure problem you > saw with the last version also. I've pulled it, further testing will show ;-) > Out of interest what tool are you using to display that information? bloat-o-meter from the kerne

Re: [U-Boot] [PATCH v3] net: allow setting env enetaddr from net device setting

2012-03-06 Thread Wolfgang Denk
Dear Rob, In message <4f566d05.5020...@gmail.com> you wrote: > > >> +3. Write value to environment if setup in struct eth_device->enetaddr by > >> driver > >> + initialize() function. Give priority to the value in the environment > >> if a > >> + conflict. > > > > Sorry, but this descriptio

Re: [U-Boot] Pull request: u-boot-x86/master

2012-03-06 Thread Wolfgang Denk
Dear Graeme Russ, In message <4f55e395.1080...@gmail.com> you wrote: > Hi Wolfgang, > > The following changes since commit fca94c3fd5deef33442813475a5af1650f2d2830: > > integrator: remove fragile delay loop from PCI code (2012-03-04 21:15:31 > +0100) > > are available in the git repository a

Re: [U-Boot] Please pull u-boot-ti/master

2012-03-06 Thread Wolfgang Denk
Dear Albert ARIBAUD, In message <4f55bcdc.70...@aribaud.net> you wrote: > > > With the documentation / related changes, Wolfgang said on IRC he was OK > > for now with the additional SPL bits going on. > > All these commits are feature additions posted after the merge window, > aren't they? Yes,

Re: [U-Boot] [PATCH 2/2] PPC: Drop mv6446x_eth_initialize() from net/eth.c

2012-03-06 Thread Wolfgang Denk
Dear Marek Vasut, In message <1330763972-28106-2-git-send-email-ma...@denx.de> you wrote: > This function was defined as an extern in net/eth.c, drop that and use > standard means of calling it. > > Signed-off-by: Marek Vasut > Cc: Stefan Roese > --- > board/Marvell/db64460/db64460.c |6 ++

Re: [U-Boot] [PATCH 1/2] PPC: Drop mv6436x_eth_initialize() from net/eth.c

2012-03-06 Thread Wolfgang Denk
Dear Marek Vasut, In message <1330763972-28106-1-git-send-email-ma...@denx.de> you wrote: > This function was defined as an extern in net/eth.c, drop that and use > standard means of calling it. > > Signed-off-by: Marek Vasut > Cc: Reinhard Arlt > --- > board/Marvell/db64360/db64360.c |6 +

Re: [U-Boot] [PATCH v5 9/9] Convert cmd_usage() calls in common to use a return value

2012-03-06 Thread Wolfgang Denk
Dear Simon Glass, In message <1329285566-30386-10-git-send-email-...@chromium.org> you wrote: > Change all files in common/ to use CMD_RET_USAGE instead of calling > cmd_usage() directly. This saves about 100 byte or so on ARM. > > Signed-off-by: Simon Glass > --- > Changes in v2: > - Fix minor

Re: [U-Boot] [PATCH v5 8/9] Add cmd_process() to process commands in one place

2012-03-06 Thread Wolfgang Denk
Dear Simon Glass, In message <1329285566-30386-9-git-send-email-...@chromium.org> you wrote: > We currently have the same code in hush.c and main.c. This brings the > code into one place. > > As an added feature, if the command function returns CMD_RET_USAGE then > cmd_process() will print a usag

Re: [U-Boot] [PATCH v5 7/9] Remove interleave of non-U-Boot code in hush

2012-03-06 Thread Wolfgang Denk
Dear Simon Glass, In message <1329285566-30386-8-git-send-email-...@chromium.org> you wrote: > There is a nasty interleave of #ifdefs in hush.c where the two code > paths have different indents. Remove this ickiness. > > Signed-off-by: Simon Glass > Acked-by: Mike Frysinger > --- > > common/h

Re: [U-Boot] [PATCH v5 6/9] Create a single cmd_call() function to handle command execution

2012-03-06 Thread Wolfgang Denk
Dear Simon Glass, In message <1329285566-30386-7-git-send-email-...@chromium.org> you wrote: > We should aim for a single point of entry to the commands, whichever > parser is used. > > Signed-off-by: Simon Glass > --- > Changes in v5: > - Move cmd_call() prototype inside existing #ifdef __ASSEM

Re: [U-Boot] [PATCH v5 5/9] Don't include standard parser if hush is used

2012-03-06 Thread Wolfgang Denk
Dear Simon Glass, In message <1329285566-30386-6-git-send-email-...@chromium.org> you wrote: > This saves about 1KB of code space on ARM with CONFIG_SYS_HUSH_PARSER > defined. > > Signed-off-by: Simon Glass > --- > > common/main.c |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-)

Re: [U-Boot] [PATCH v5 4/9] Stop using builtin_run_command()

2012-03-06 Thread Wolfgang Denk
Dear Simon Glass, In message <1329285566-30386-5-git-send-email-...@chromium.org> you wrote: > Boards can select either the 'built-in' parser or the hush parser. We > should not call builtin_run_command() if we are using the hush parser. > We use run_command() instead, since it knows how to call t

Re: [U-Boot] [PATCH v5 3/9] Rename run_command2() to run_command()

2012-03-06 Thread Wolfgang Denk
Dear Simon Glass, In message <1329285566-30386-4-git-send-email-...@chromium.org> you wrote: > This is a more sensible name, so rename it. > > Signed-off-by: Simon Glass > --- > > common/cmd_pxe.c |2 +- > common/main.c| 10 +- > include/common.h |2 +- > 3 files changed,

Re: [U-Boot] [PATCH v5 2/9] Rename run_command() to builtin_run_command()

2012-03-06 Thread Wolfgang Denk
Dear Simon Glass, In message <1329285566-30386-3-git-send-email-...@chromium.org> you wrote: > The current run_command() is only one of the parsing options - the other > is hush. We should not call run_command() when the hush parser is being > used. So we rename this function to better explain its

Re: [U-Boot] [PATCH v5 1/9] Remove CMD_PXE's static on run_command()

2012-03-06 Thread Wolfgang Denk
Dear Simon Glass, In message <1329285566-30386-2-git-send-email-...@chromium.org> you wrote: > It really isn't clear why this is here and there is no comment, so > drop it. > > > Signed-off-by: Simon Glass > --- > > common/main.c|3 --- > include/common.h |2 -- > 2 files changed,

Re: [U-Boot] [PATCH] env: Add the ability to merge the saved env with the default.

2012-03-06 Thread Mike Frysinger
On Tuesday 06 March 2012 12:07:10 you wrote: > On Mon, Mar 5, 2012 at 8:27 PM, Mike Frysinger wrote: > > also, doesn't the existing `env import` > > do this ? > > > > * env import [-d] [-t | -b | -c] addr [size] > > * -d: delete existing environment before importing; > > * otherwise overw

Re: [U-Boot] [PATCH v5 0/9] Unified command execution in one place

2012-03-06 Thread Simon Glass
Hi Wolfgang, On Tue, Mar 6, 2012 at 11:51 AM, Wolfgang Denk wrote: > Dear Simon Glass, > > In message <1329285566-30386-1-git-send-email-...@chromium.org> you wrote: >> >> At present two parsers have similar code to execute commands. Also >> cmd_usage() is called all over the place. This series a

Re: [U-Boot] [PATCH v3] net: allow setting env enetaddr from net device setting

2012-03-06 Thread Rob Herring
On 03/06/2012 01:30 PM, Wolfgang Denk wrote: > Dear Rob Herring, > > In message <1328138854-28612-1-git-send-email-robherri...@gmail.com> you > wrote: >> >> --- a/doc/README.enetaddr >> +++ b/doc/README.enetaddr >> @@ -32,7 +32,9 @@ Correct flow of setting up the MAC address (summarized): >> >>

Re: [U-Boot] [PATCH V2] net: fec_mxc: allow use with cache enabled

2012-03-06 Thread Marek Vasut
Dear Eric Nelson, > On 03/05/2012 01:06 PM, Marek Vasut wrote: > > Dear Eric Nelson, > > > >>ensure that transmit and receive buffers are cache-line aligned > >> > >> invalidate cache after each packet received > >> flush cache before transmitting > >> > >>Origin

Re: [U-Boot] [PATCH V2] net: fec_mxc: allow use with cache enabled

2012-03-06 Thread Marek Vasut
Dear Eric Nelson, > On 03/06/2012 10:06 AM, Eric Nelson wrote: > > On 03/05/2012 01:06 PM, Marek Vasut wrote: > >> Dear Eric Nelson, > >> > >> > >> > >>> + if (!fec->rbd_base) { > >>> + ret = -ENOMEM; > >>> + goto err2; > >>> + } > >>> + memset(fec->rbd_base, 0, size); > >>> + } > >> > >> We

Re: [U-Boot] [PATCH v5 0/9] Unified command execution in one place

2012-03-06 Thread Wolfgang Denk
Dear Simon Glass, In message <1329285566-30386-1-git-send-email-...@chromium.org> you wrote: > > At present two parsers have similar code to execute commands. Also > cmd_usage() is called all over the place. This series adds a single > function which processes commands called cmd_process(). > >

Re: [U-Boot] [PATCH v3] net: allow setting env enetaddr from net device setting

2012-03-06 Thread Wolfgang Denk
Dear Rob Herring, In message <1328138854-28612-1-git-send-email-robherri...@gmail.com> you wrote: > > --- a/doc/README.enetaddr > +++ b/doc/README.enetaddr > @@ -32,7 +32,9 @@ Correct flow of setting up the MAC address (summarized): > > 1. Read from hardware in initialize() function > 2. Read

Re: [U-Boot] [PATCH] env: Add the ability to merge the saved env with the default.

2012-03-06 Thread Wolfgang Denk
Dear Doug Anderson, In message you wrote: > > It's not quite possible to just import the default from the saved for two > reasons: > 1. I don't know of any way to import the default. It's not stored at any > well-known address or with any well-known size. Then save it to a well-known address.

[U-Boot] OneNAND custodian (was: Re: [RESEND 0/4] onenand: OneNAND board dependent probe and fixes for Samsung targets)

2012-03-06 Thread Scott Wood
On 03/06/2012 12:54 AM, Lukasz Majewski wrote: > This patch sets add board dependent onenand probes. > > Several fixes for GONI and Exynos4210 (C210_universal) targets have been > added. > > Tested at: > Samsung S5PC110 GONI > Samsung Exynos4210 (S5PC210 Universal) > > Lukasz Maje

Re: [U-Boot] [PATCH V2] net: fec_mxc: allow use with cache enabled

2012-03-06 Thread Eric Nelson
On 03/06/2012 10:06 AM, Eric Nelson wrote: On 03/05/2012 01:06 PM, Marek Vasut wrote: Dear Eric Nelson, >> >> + if (!fec->rbd_base) { + ret = -ENOMEM; + goto err2; + } + memset(fec->rbd_base, 0, size); + } We might want to flush the descriptors to memory after they have been inited? We

Re: [U-Boot] [PATCH] env: Add the ability to merge the saved env with the default.

2012-03-06 Thread Doug Anderson
Mike, On Mon, Mar 5, 2012 at 8:27 PM, Mike Frysinger wrote: > this is kind of a crappy interface. > Agreed. > also, doesn't the existing `env import` > do this ? > * env import [-d] [-t | -b | -c] addr [size] > * -d: delete existing environment before importing; > * otherwise overwr

Re: [U-Boot] [PATCH V2] net: fec_mxc: allow use with cache enabled

2012-03-06 Thread Eric Nelson
On 03/05/2012 01:06 PM, Marek Vasut wrote: Dear Eric Nelson, ensure that transmit and receive buffers are cache-line aligned invalidate cache after each packet received flush cache before transmitting Original patch by Marek: http://lists.denx.

Re: [U-Boot] [PATCH v4] usb: align buffers at cacheline

2012-03-06 Thread Mike Frysinger
On Tuesday 06 March 2012 03:24:34 Marek Vasut wrote: > > On Friday 02 March 2012 11:45:15 Wolfgang Denk wrote: > > > > > That's what I did in original patch where I am aligning it by > > > > > adding the line > > > > > > > > > > +/* Device Descriptor */ > > > > > +#ifdef ARCH_DMA_MINALIGN

Re: [U-Boot] [PATCH v5 6/9] Create a single cmd_call() function to handle command execution

2012-03-06 Thread Mike Frysinger
On Tuesday 06 March 2012 01:14:10 Simon Glass wrote: > On Mon, Mar 5, 2012 at 8:40 PM, Mike Frysinger wrote: > > On Wednesday 15 February 2012 00:59:23 Simon Glass wrote: > >> --- a/include/command.h > >> +++ b/include/command.h > >> @@ -150,4 +152,5 @@ extern int do_reset(cmd_tbl_t *cmdtp, int fla

Re: [U-Boot] [PATCH v4 05/13] Move memcpy(), memset() into new lib/membasic.c

2012-03-06 Thread Mike Frysinger
On Tuesday 06 March 2012 01:34:24 Simon Glass wrote: > On Mon, Mar 5, 2012 at 9:05 PM, Mike Frysinger wrote: > > On Monday 20 February 2012 20:32:47 Simon Glass wrote: > >> These basic functions are needed by relocation. To avoid bringing in all > >> string.c functions (and the resulting code bloat

Re: [U-Boot] [PATCH v3 11/28] arm: Use sections header to obtain link symbols

2012-03-06 Thread Mike Frysinger
On Tuesday 06 March 2012 01:24:21 Simon Glass wrote: > On Mon, Mar 5, 2012 at 9:03 PM, Mike Frysinger wrote: > > On Thursday 16 February 2012 09:48:58 Simon Glass wrote: > >> --- a/board/cm4008/flash.c > >> +++ b/board/cm4008/flash.c > >> > >> #include > >> +#include > > > > arches should prov

Re: [U-Boot] [PATCH] lib: zlib: update to 1.2.6

2012-03-06 Thread Mike Frysinger
On Tuesday 06 March 2012 03:55:19 Lei Wen wrote: > In this patch, I update the current zlib from 1.2.5 to 1.2.6. > > There is a lot of warnings when using checkpatch script, I don't know > whether I should fix it or not... > Since it is just copy from as it is from upstream zlib 1.2.6, so I didn't

Re: [U-Boot] [PATCH] usb: replace wait_ms() with mdelay()

2012-03-06 Thread Mike Frysinger
On Tuesday 06 March 2012 10:03:19 Tom Rini wrote: > On Mon, Mar 05, 2012 at 09:04:41PM -0500, Mike Frysinger wrote: > > On Monday 05 March 2012 20:46:40 Graeme Russ wrote: > > > On Tue, Mar 6, 2012 at 12:42 PM, Mike Frysinger wrote: > > > > On Monday 05 March 2012 19:15:54 Marek Vasut wrote: > > >

Re: [U-Boot] [PATCH] USB:host: Attribute packed removed from usb structures

2012-03-06 Thread Mike Frysinger
On Tuesday 06 March 2012 07:06:22 Amit Virdi wrote: > On 2/29/2012 3:55 PM, Amit Virdi wrote: > > On 2/28/2012 6:26 AM, Mike Frysinger wrote: > >> On Monday 27 February 2012 15:53:29 Marek Vasut wrote: > On Monday 27 February 2012 08:14:26 Marek Vasut wrote: > >> On 2/25/2012 3:42 PM, Albe

Re: [U-Boot] [PATCH 4/4] USB:gadget:designware Fix memory nonalignment issue

2012-03-06 Thread Mike Frysinger
On Thursday 16 February 2012 07:03:38 Amit Virdi wrote: > --- a/drivers/usb/gadget/designware_udc.c > +++ b/drivers/usb/gadget/designware_udc.c > > + /* copy back tmp buffer to bufp if bufp is not word aligned */ > + if ((int)bufp & 0x3) { > + bytp = (u8 *)&tmp[0]; > +

Re: [U-Boot] [PATCH 4/4] USB:gadget:designware Fix memory nonalignment issue

2012-03-06 Thread Mike Frysinger
On Tuesday 06 March 2012 04:51:57 Marek Vasut wrote: > > On 3/5/2012 11:51 PM, Marek Vasut wrote: > > > Amit Virdi wrote: > > >> While receiving packets from FIFO sometimes the buffer provided was > > >> nonaligned. Fix this by taking a temporary aligned buffer and then > > >> copying the content t

Re: [U-Boot] [PATCH 2/2] Allow newlines within command environment vars

2012-03-06 Thread Wolfgang Denk
Dear Simon Glass, In message you wrote: ... > >> > > The environment variables preboot, bootcmd and menucmd can hold a > >> > > command > >> > > to execute. This change permits these variables to have newlines so > >> > > that > >> > > they work the same as the 'source' command. ... > >> The f

Re: [U-Boot] [PATCH 2/2][v2] powerpc/85xx:Add PSC9131 RDB Support

2012-03-06 Thread Wolfgang Denk
Dear Prabhakar Kushwaha, In message <1329304781-27758-1-git-send-email-prabha...@freescale.com> you wrote: ... > +#define CONFIG_L2_CACHE /* toggle L2 cache */ > +#define CONFIG_BTB /* toggle branch predition */ Toggle? Do you really toggle, or enable? >

Re: [U-Boot] [PATCH] usb: replace wait_ms() with mdelay()

2012-03-06 Thread Tom Rini
On Mon, Mar 05, 2012 at 09:04:41PM -0500, Mike Frysinger wrote: > On Monday 05 March 2012 20:46:40 Graeme Russ wrote: > > On Tue, Mar 6, 2012 at 12:42 PM, Mike Frysinger wrote: > > > On Monday 05 March 2012 19:15:54 Marek Vasut wrote: > > >> Acked-by: Marek Vasut > > >> > > >> Thanks for your pat

Re: [U-Boot] md,mw commands

2012-03-06 Thread albert . u . boot
Hi V.Balaji, Le 2012-03-06 10:41, VISWANADHULA BALAJI a écrit : Hi, Iam using 256MB RAM on arm11 board.I just tried md,mw commands from uboot like the following mw C80 0x 0x500 here C80 is the 200MB of RAM MCS8142>> md C80 0c80:

Re: [U-Boot] [PATCH] powerpc/85xx:Add PSC9131 RDB Support

2012-03-06 Thread Wolfgang Denk
Dear Prabhakar Kushwaha, In message <4f3b8bb7.9020...@freescale.com> you wrote: > > >> +#define CONFIG_UBOOTPATH u-boot.bin /* U-Boot image on TFTP server */ > > CONFIG_ options are kind of special; if you define new ones (which > > should only be done when it really makes sense - this appears no

  1   2   >