Re: [U-Boot] [PATCH v2 1/2] Introduce generic TPM support in u-boot

2011-10-15 Thread Wolfgang Denk
Dear Vadim Bendebury, In message you wrote: > > > Make it an inline function then, this will do the typechecking for you. > > I am not sure what is wrong with a short macro in this case - is this > against the coding style? "Documentation/CodingStyle": Generally, inline functions are

[U-Boot] [PATCH v4 2/2] NS16550: buffer reads

2011-10-15 Thread Simon Glass
From: Scott Wood From: Scott Wood This improves the performance of U-Boot when accepting rapid input, such as pasting a sequence of commands. Without this patch, on P4080DS I see a maximum of around 5 lines can be pasted. With this patch, it handles around 70 lines before lossage, long enough

Re: [U-Boot] [PATCH v2 2/2] Add a cli command to test the TPM device.

2011-10-15 Thread Mike Frysinger
On Saturday 15 October 2011 16:27:02 Vadim Bendebury wrote: > On Sat, Oct 15, 2011 at 1:01 PM, Mike Frysinger wrote: > > On Saturday 15 October 2011 15:44:04 Wolfgang Denk wrote: > >> Vadim Bendebury wrote: > >> > > Two underscores aren't a good practice. > >> > > >> > I did this as a result of a

[U-Boot] [PATCH v4 1/2] NS16550: trivial code clean for checkpatch

2011-10-15 Thread Simon Glass
This removes most checkpatch warnings from the ns16550 driver and its header. Signed-off-by: Simon Glass --- drivers/serial/ns16550.c | 37 - include/ns16550.h| 16 2 files changed, 28 insertions(+), 25 deletions(-) diff --git a/d

Re: [U-Boot] [PATCH v4 6/6] fdt: add decode helper library

2011-10-15 Thread Mike Frysinger
On Saturday 15 October 2011 11:48:25 Simon Glass wrote: > --- /dev/null > +++ b/lib/fdtdec.c > > +static const char *compat_names[COMPAT_COUNT] = { static const char * const compat_names[COMPAT_COUNT] = { -mike signature.asc Description: This is a digitally signed message part. _

Re: [U-Boot] [PATCH v3] NS16550: buffer reads

2011-10-15 Thread Simon Glass
Hi Marek, On Sat, Oct 15, 2011 at 9:18 PM, Marek Vasut wrote: > On Sunday, October 16, 2011 05:56:56 AM Simon Glass wrote: >> Hi Marek, >> >> On Sat, Oct 15, 2011 at 10:55 AM, Marek Vasut wrote: >> > On Saturday, October 15, 2011 06:03:52 PM Simon Glass wrote: >> >> From: Scott Wood >> >> >> >>

Re: [U-Boot] [PATCH v3] NS16550: buffer reads

2011-10-15 Thread Simon Glass
Hi Wolfgang, On Sat, Oct 15, 2011 at 12:08 PM, Wolfgang Denk wrote: > Dear Simon Glass, > > In message <1318694632-21872-1-git-send-email-...@chromium.org> you wrote: >> From: Scott Wood >> >> From: Scott Wood >> >> This improves the performance of U-Boot when accepting rapid input, >> such as

Re: [U-Boot] [PATCH v2] NS16550: buffer reads

2011-10-15 Thread Simon Glass
Hi Wolfgang, On Sat, Oct 15, 2011 at 12:14 PM, Wolfgang Denk wrote: > Dear Simon Glass, > > In message > you > wrote: >> >> Another thought...the problem is that every character we receive we >> echo, so we can of course never get ahead of the workload.  But we can > > Even worse, if your inpu

Re: [U-Boot] [PATCH v2] NS16550: buffer reads

2011-10-15 Thread Simon Glass
Hi Wolfgang, On Sat, Oct 15, 2011 at 12:00 PM, Wolfgang Denk wrote: > Dear Simon Glass, > > In message > you > wrote: >> >> The situation this occurs is when you paste characters into a serial >> terminal connected to U-Boot. This is a pretty common requirement. Yes >> you can manually select

Re: [U-Boot] [PATCH v3] NS16550: buffer reads

2011-10-15 Thread Marek Vasut
On Sunday, October 16, 2011 05:56:56 AM Simon Glass wrote: > Hi Marek, > > On Sat, Oct 15, 2011 at 10:55 AM, Marek Vasut wrote: > > On Saturday, October 15, 2011 06:03:52 PM Simon Glass wrote: > >> From: Scott Wood > >> > >> From: Scott Wood > >> > >> This improves the performance of U-Boot w

Re: [U-Boot] [PATCH v3] NS16550: buffer reads

2011-10-15 Thread Simon Glass
Hi Marek, On Sat, Oct 15, 2011 at 10:55 AM, Marek Vasut wrote: > On Saturday, October 15, 2011 06:03:52 PM Simon Glass wrote: >> From: Scott Wood >> >> From: Scott Wood >> >> This improves the performance of U-Boot when accepting rapid input, >> such as pasting a sequence of commands. > > Hi Si

Re: [U-Boot] [PATCH v2 1/2] Introduce generic TPM support in u-boot

2011-10-15 Thread Vadim Bendebury
On Sat, Oct 15, 2011 at 8:31 PM, Marek Vasut wrote: > On Sunday, October 16, 2011 03:04:33 AM Vadim Bendebury wrote: >> On Sat, Oct 15, 2011 at 2:09 PM, Marek Vasut wrote: >> > On Saturday, October 15, 2011 08:47:39 PM Vadim Bendebury wrote: >> >> Dear Marek Vasut, >> >> >> >> thank you for your

[U-Boot] Porting lpc313x support up to current u-boot

2011-10-15 Thread jonsm...@gmail.com
I'm porting the lpc313x uboot located here, up to current uboot. It is based on U-boot.2009.11.1 http://git.lpclinux.com/?p=uboot-2009.11-lpc313x.git;a=summary What do I do with the cpu directory? http://git.lpclinux.com/?p=uboot-2009.11-lpc313x.git;a=tree;f=cpu/lpc313x;h=5cc2c80b1ef75c729abff5e

Re: [U-Boot] [PATCH] x86: Rename include/asm/ic to include/asm/arch-sc520

2011-10-15 Thread Graeme Russ
Hi Wolfgang, On 16/10/11 14:29, Graeme Russ wrote: > Also include some trivial related cleanups > > Signed-off-by: Graeme Russ > --- > arch/x86/cpu/sc520/sc520.c |2 +- > arch/x86/cpu/sc520/sc520_car.S |2 +- > arch/x86/cpu/sc520/sc520_pci.c

Re: [U-Boot] [PATCH v2 1/2] Introduce generic TPM support in u-boot

2011-10-15 Thread Marek Vasut
On Sunday, October 16, 2011 03:04:33 AM Vadim Bendebury wrote: > On Sat, Oct 15, 2011 at 2:09 PM, Marek Vasut wrote: > > On Saturday, October 15, 2011 08:47:39 PM Vadim Bendebury wrote: > >> Dear Marek Vasut, > >> > >> thank you for your comments, please see below: > >> > >> On Sat, Oct 15, 2011

Re: [U-Boot] [PATCH] x86: turn off cache: set control register properly

2011-10-15 Thread Graeme Russ
On 01/10/11 04:27, Ondrej Kupka wrote: > Bits should be ORed when they are supposed to be added together > > Cc: Graeme Russ > Signed-off-by: Ondrej Kupka > --- > arch/x86/cpu/start16.S |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > Applied to u-boot-x86 Thanks, Graeme

[U-Boot] [PATCH] x86: Rename include/asm/ic to include/asm/arch-sc520

2011-10-15 Thread Graeme Russ
Also include some trivial related cleanups Signed-off-by: Graeme Russ --- arch/x86/cpu/sc520/sc520.c |2 +- arch/x86/cpu/sc520/sc520_car.S |2 +- arch/x86/cpu/sc520/sc520_pci.c |4 ++-- arch/x86/cpu/sc520/sc520_reset.c

Re: [U-Boot] [PATCH v3 1/2] Introduce generic TPM support in u-boot

2011-10-15 Thread Vadim Bendebury
On Sat, Oct 15, 2011 at 6:20 PM, Vadim Bendebury wrote: > > sorry, sent this and the other patchset with a wrong version number, > will resend with the correct number. > or maybe not - looks like the latest patches were sent with the correct version number (v3) but gmail reader seems to be collap

Re: [U-Boot] [PATCH v3 1/2] Introduce generic TPM support in u-boot

2011-10-15 Thread Vadim Bendebury
On Sat, Oct 15, 2011 at 6:13 PM, Vadim Bendebury wrote: > TPM (Trusted Platform Module) is an integrated circuit and > software platform that provides computer manufacturers with the > core components of a subsystem used to assure authenticity, > integrity and confidentiality. > > This driver supp

[U-Boot] [PATCH v3 2/2] Add a cli command to test the TPM device.

2011-10-15 Thread Vadim Bendebury
The command gets an arbitrary number of arguments (up to 30), which are interpreted as byte values and are feed into the TPM device after proper initialization. Then the return value and data of the TPM driver is examined. TPM commands are described in the TCG specification. For instance, the fol

[U-Boot] [PATCH v3 1/2] Introduce generic TPM support in u-boot

2011-10-15 Thread Vadim Bendebury
TPM (Trusted Platform Module) is an integrated circuit and software platform that provides computer manufacturers with the core components of a subsystem used to assure authenticity, integrity and confidentiality. This driver supports version 1.2 of the TCG (Trusted Computing Group) specifications

Re: [U-Boot] [PATCH v2 1/2] Introduce generic TPM support in u-boot

2011-10-15 Thread Vadim Bendebury
On Sat, Oct 15, 2011 at 12:42 PM, Mike Frysinger wrote: > On Friday 14 October 2011 23:38:50 Vadim Bendebury wrote: >> --- /dev/null >> +++ b/drivers/tpm/generic_lpc_tpm.c >> >> +#define TPM_TIMEOUT_ERR                      (~0) >> +#define TPM_DRIVER_ERR               (-1) > > these are the same

Re: [U-Boot] [PATCH v2 1/2] Introduce generic TPM support in u-boot

2011-10-15 Thread Vadim Bendebury
On Sat, Oct 15, 2011 at 12:25 PM, Wolfgang Denk wrote: > Dear Vadim Bendebury, > > In message <20111015033850.74ad541...@eskimo.mtv.corp.google.com> you wrote: >> TPM (Trusted Platform Module) is an integrated circuit and >> software platform that provides computer manufacturers with the >> core c

Re: [U-Boot] [PATCH v2 1/2] Introduce generic TPM support in u-boot

2011-10-15 Thread Vadim Bendebury
On Sat, Oct 15, 2011 at 2:09 PM, Marek Vasut wrote: > On Saturday, October 15, 2011 08:47:39 PM Vadim Bendebury wrote: >> Dear Marek Vasut, >> >> thank you for your comments, please see below: >> >> On Sat, Oct 15, 2011 at 11:08 AM, Marek Vasut wrote: >> > On Saturday, October 15, 2011 05:38:50 A

Re: [U-Boot] [PATCH v2 2/2] Add a cli command to test the TPM device.

2011-10-15 Thread Vadim Bendebury
Dear Wolfgang Denk, On Sat, Oct 15, 2011 at 12:44 PM, Wolfgang Denk wrote: > Dear Vadim Bendebury, > > In message > you > wrote: >> >> >> + * Copyright (c) 2011 The Chromium OS Authors. All rights reserved. >> >> + * Released under the 2-clause BSD license. >> > >> > Are we ok with this ? Also

Re: [U-Boot] [PATCH v2 2/2] Add a cli command to test the TPM device.

2011-10-15 Thread Vadim Bendebury
On Sat, Oct 15, 2011 at 12:08 PM, Mike Frysinger wrote: > On Saturday 15 October 2011 14:02:29 Marek Vasut wrote: >> On Saturday, October 15, 2011 05:39:08 AM Vadim Bendebury wrote: >> > --- /dev/null >> > +++ b/common/cmd_tpm.c >> > @@ -0,0 +1,111 @@ >> > +/* >> > + * Copyright (c) 2011 The Chrom

Re: [U-Boot] [PATCH] mmc: CMD7:MMC_CMD_SELECT_CARD response fix

2011-10-15 Thread Andy Fleming
>> I need to think about this. Was this causing you a problem? What were >> the symptoms? >> > yes... I am working on adding mmc support for Marvell GplugD board (Armada168 > SoC). So during mmc startup, MMC_CMD_SELECT_CARD(CMD7) gets timed out. So > digging more I found out that CMD7 in driver w

Re: [U-Boot] [PATCH] imx: imx31_phycore.h: fix checkpatch warnings

2011-10-15 Thread Fabio Estevam
Hi Anatolij, On Sat, Oct 15, 2011 at 7:00 PM, Anatolij Gustschin wrote: > Cleanup board config file and fix issues reported by > checkpatch.pl script. > > Signed-off-by: Anatolij Gustschin > Cc: Stefano Babic > --- >  include/configs/imx31_phycore.h |  112 > +++

[U-Boot] [PATCH] imx: imx31_phycore.h: fix checkpatch warnings

2011-10-15 Thread Anatolij Gustschin
Cleanup board config file and fix issues reported by checkpatch.pl script. Signed-off-by: Anatolij Gustschin Cc: Stefano Babic --- include/configs/imx31_phycore.h | 112 +++ 1 files changed, 67 insertions(+), 45 deletions(-) diff --git a/include/configs/imx

Re: [U-Boot] [PATCH] STx AMC8548: initial support for Silicon Turnkey Express AMC8548 board

2011-10-15 Thread Wolfgang Denk
Dear Kumar, In message <1302584653-15312-1-git-send-email-oa...@yahoo.com> Alex Dubov wrote: > From: Alex Dubov > > AMC8548 is a RapidIO development board in AMC form factor, featuring MPC8548E > processor, DDR2 SO-DIMM slot, 16MB of hardwired NAND flash memory, real time > clock and additional

Re: [U-Boot] [PATCH v2 1/2] Introduce generic TPM support in u-boot

2011-10-15 Thread Marek Vasut
On Saturday, October 15, 2011 08:47:39 PM Vadim Bendebury wrote: > Dear Marek Vasut, > > thank you for your comments, please see below: > > On Sat, Oct 15, 2011 at 11:08 AM, Marek Vasut wrote: > > On Saturday, October 15, 2011 05:38:50 AM Vadim Bendebury wrote: > >> TPM (Trusted Platform Module)

Re: [U-Boot] [PATCH 2/4] arm, davinci: Correct the MDSTAT.STATE mask

2011-10-15 Thread Sergei Shtylyov
Hello. On 12-10-2011 15:31, Christian Riesch wrote: > MDSTAT.STATE occupies bits 0..5 according to all available documentation, > therefore change the bitmask to 0x3f. > Signed-off-by: Christian Riesch > Cc: Heiko Schocher > Cc: Paulraj Sandeep > Cc: Albert ARIBAUD > Cc: Sergei Shtylyov > --- >

Re: [U-Boot] [PATCH V2] Ethernut 5 board support

2011-10-15 Thread Wolfgang Denk
Dear Albert, do you have any idea what's the status of this patch: 03/14 Harald Kipp[U-Boot] [PATCH V2] Ethernut 5 board support http://article.gmane.org/gmane.comp.boot-loaders.u-boot/95743 Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev

Re: [U-Boot] [PATCH v2 2/2] Add a cli command to test the TPM device.

2011-10-15 Thread Vadim Bendebury
On Sat, Oct 15, 2011 at 1:01 PM, Mike Frysinger wrote: > On Saturday 15 October 2011 15:44:04 Wolfgang Denk wrote: >> Vadim Bendebury wrote: >> > > Two underscores aren't a good practice. >> > >> > I did this as a result of a previous review. Do you have a suggestion >> > how this should be done i

Re: [U-Boot] [PATCH v2 1/2] Introduce generic TPM support in u-boot

2011-10-15 Thread Vadim Bendebury
On Sat, Oct 15, 2011 at 12:42 PM, Mike Frysinger wrote: > On Friday 14 October 2011 23:38:50 Vadim Bendebury wrote: >> --- /dev/null >> +++ b/drivers/tpm/generic_lpc_tpm.c >> >> +#define TPM_TIMEOUT_ERR                      (~0) >> +#define TPM_DRIVER_ERR               (-1) > > these are the same

Re: [U-Boot] [PATCH v2 3/3] mkimage: adding support for Davinci AIS image

2011-10-15 Thread Wolfgang Denk
Dear Stefano Babic, In message <1317889214-10567-1-git-send-email-sba...@denx.de> you wrote: > Some Davinci processors supports the Application > Image Script (AIS) boot process. The patch adds the generation > of the AIS image inside the mkimage tool to make possible > to generate a bootable U-bo

Re: [U-Boot] [PATCH] serial_exit: punt unused prototype

2011-10-15 Thread Wolfgang Denk
Dear Mike Frysinger, In message <1317690674-15608-1-git-send-email-vap...@gentoo.org> you wrote: > No code defines or calls this, so drop the prototype. > > Signed-off-by: Mike Frysinger > --- > include/common.h |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) Applied, thanks. Bes

Re: [U-Boot] [PATCH v2] punt unused clean/distclean targets

2011-10-15 Thread Wolfgang Denk
Dear Mike Frysinger, In message <1318524897-19001-1-git-send-email-vap...@gentoo.org> you wrote: > The top level Makefile does not do any recursion into subdirs when > cleaning, so these clean/distclean targets in random arch/board dirs > never get used. Punt them all. > > MAKEALL didn't report

Re: [U-Boot] [PATCH 3/3] net: emaclite: Fix coding style

2011-10-15 Thread Wolfgang Denk
Dear Michal Simek, In message <1317974226-25252-3-git-send-email-mon...@monstr.eu> you wrote: > Checked by checkpatch.pl script. > No functional changes. > > Signed-off-by: Michal Simek > --- > drivers/net/xilinx_emaclite.c | 57 +++- > 1 files changed, 27

Re: [U-Boot] [PATCH] common: fix missing function pointer relocation in fixup_cmdtable()

2011-10-15 Thread Wolfgang Denk
Dear Daniel Schwierzeck, In message <1318522059-16182-1-git-send-email-daniel.schwierz...@googlemail.com> you wrote: > The command auto-completion does not work on architectures relying > on CONFIG_NEEDS_MANUAL_RELOC like MIPS. Cause is the missing function > pointer fixup for cmd_tbl_t::complete

Re: [U-Boot] [PATCH] mpc5200: digsy_mtc: fix detection of Coral-PA

2011-10-15 Thread Wolfgang Denk
Dear Anatolij Gustschin, In message <1318519157-4945-1-git-send-email-ag...@denx.de> you wrote: > A delay of approximately 250 ms after PCI bus reset in > pci_mpc5xxx_init() is needed to recognize the Coral-PA > controller on the graphic extention board. > > Signed-off-by: Anatolij Gustschin > -

Re: [U-Boot] [PATCH v2 1/1] pci: move pcidelay code to new location just before PCI bus scan

2011-10-15 Thread Wolfgang Denk
Dear Anatolij Gustschin, In message <1318409070-11792-1-git-send-email-ag...@denx.de> you wrote: > PCI cards might need some time after reset to respond. On some > boards (mpc5200 or mpc8260 based) the PCI bus reset is deasserted > at pci_init_board() time, so we currently can not use available >

Re: [U-Boot] [PATCH v4] net: axi_ethernet: Add driver to u-boot

2011-10-15 Thread Wolfgang Denk
Dear Michal Simek, In message <1317969335-21798-1-git-send-email-mon...@monstr.eu> you wrote: > Add axi_ethernet driver for little-endian Microblaze. > > RX/TX BDs and rxframe buffer are shared among all axi_ethernet MACs. > Only one MAC can work in one time. > > Signed-off-by: Michal Simek >

[U-Boot] [PATCH] m68k: fix ambiguous bit testing

2011-10-15 Thread Mike Frysinger
Building for some m68k boards results in the warning: cpu_init.c: In function 'cpu_init_f': cpu_init.c:287: warning: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~' Signed-off-by: Mike Frysinger --- arch/m68k/cpu/mcf52x2/cpu_init.c |2 +- 1 files change

Re: [U-Boot] [PATCH 3/3] net: emaclite: Fix coding style

2011-10-15 Thread Wolfgang Denk
Dear Michal Simek, In message <1317974226-25252-3-git-send-email-mon...@monstr.eu> you wrote: > Checked by checkpatch.pl script. > No functional changes. Note : this should go into the comment section (pwclient picked the original submit anyway). Best regards, Wolfgang Denk -- DENX Software E

Re: [U-Boot] [PATCH 2/3] net: emaclite: Use PKTSIZE directly

2011-10-15 Thread Wolfgang Denk
Dear Michal Simek, In message <1317974226-25252-2-git-send-email-mon...@monstr.eu> you wrote: > Do not setup additional ENET_MAX_MTU macro. > > Signed-off-by: Michal Simek > --- > drivers/net/xilinx_emaclite.c | 10 -- > 1 files changed, 4 insertions(+), 6 deletions(-) Applied, thank

Re: [U-Boot] [PATCH 1/3 v2] net: emaclite: Setup RX/TX ping pong for every instance

2011-10-15 Thread Wolfgang Denk
Dear Michal Simek, In message <1317974226-25252-1-git-send-email-mon...@monstr.eu> you wrote: > Setup RX/TX ping-pong buffer for every emaclite IP separately. > The next patch move initialization directly to board code. > > Signed-off-by: Michal Simek > > --- > v2: Fix coding style violations >

Re: [U-Boot] [PATCH 1/6 v2] ColdFire: Cleanup lds files for multiple defined symbols

2011-10-15 Thread Mike Frysinger
Acked-by: Mike Frysinger -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-fdt

2011-10-15 Thread Wolfgang Denk
Dear Jerry Van Baren, In message <4e99a789.8090...@cideas.com> you wrote: > The following changes since commit d8fffa057c9430fd0c5104ab6ff7db4cdb03db51: > >Merge branch 'master' of git://git.denx.de/u-boot-mips (2011-10-12 > 22:47:15 +0200) > > are available in the git repository at: > >

Re: [U-Boot] [PATCH v2 2/2] Add a cli command to test the TPM device.

2011-10-15 Thread Mike Frysinger
On Saturday 15 October 2011 15:44:04 Wolfgang Denk wrote: > Vadim Bendebury wrote: > > > Two underscores aren't a good practice. > > > > I did this as a result of a previous review. Do you have a suggestion > > how this should be done instead? > > First, and most important, __u_boot_cmd_tpm appea

Re: [U-Boot] [GIT PULL] Pull request u-boot-85xx.git

2011-10-15 Thread Wolfgang Denk
Dear Kumar Gala, In message you wrote: > The following changes since commit d8fffa057c9430fd0c5104ab6ff7db4cdb03db51: > > Merge branch 'master' of git://git.denx.de/u-boot-mips (2011-10-12 22:47:15 > +0200) > > are available in the git repository at: > > git://git.denx.de/u-boot-mpc85xx

[U-Boot] Pull request: u-boot-video/master

2011-10-15 Thread Anatolij Gustschin
Hello Wolfgang, The following changes since commit d8fffa057c9430fd0c5104ab6ff7db4cdb03db51: Merge branch 'master' of git://git.denx.de/u-boot-mips (2011-10-12 22:47:15 +0200) are available in the git repository at: git://git.denx.de/u-boot-video.git master Helmut Raiger (2): mx31:

Re: [U-Boot] [PATCH v2 2/2] Add a cli command to test the TPM device.

2011-10-15 Thread Wolfgang Denk
Dear Vadim Bendebury, In message you wrote: > > >> + * Copyright (c) 2011 The Chromium OS Authors. All rights reserved. > >> + * Released under the 2-clause BSD license. > > > > Are we ok with this ? Also, you say something about GPL in the same comment? > > > > Can someone please tell me what

Re: [U-Boot] [PATCH v2 1/2] Introduce generic TPM support in u-boot

2011-10-15 Thread Mike Frysinger
On Friday 14 October 2011 23:38:50 Vadim Bendebury wrote: > --- /dev/null > +++ b/drivers/tpm/generic_lpc_tpm.c > > +#define TPM_TIMEOUT_ERR (~0) > +#define TPM_DRIVER_ERR (-1) these are the same thing. another reason why you shouldn't mix ~ with normal values.

Re: [U-Boot] [PATCH v2 1/2] Introduce generic TPM support in u-boot

2011-10-15 Thread Wolfgang Denk
Dear Vadim Bendebury, In message <20111015033850.74ad541...@eskimo.mtv.corp.google.com> you wrote: > TPM (Trusted Platform Module) is an integrated circuit and > software platform that provides computer manufacturers with the > core components of a subsystem used to assure authenticity, > integrit

Re: [U-Boot] [PATCH v2] NS16550: buffer reads

2011-10-15 Thread Wolfgang Denk
Dear Simon Glass, In message you wrote: > > Another thought...the problem is that every character we receive we > echo, so we can of course never get ahead of the workload. But we can Even worse, if your input contains any commands that prodce output, mayeb even lots of output (say "md $addr 1

Re: [U-Boot] [PATCH v2 2/2] Add a cli command to test the TPM device.

2011-10-15 Thread Mike Frysinger
On Friday 14 October 2011 23:39:08 Vadim Bendebury wrote: > --- a/common/Makefile > +++ b/common/Makefile > > COBJS-$(CONFIG_CMD_UBIFS) += cmd_ubifs.o > COBJS-$(CONFIG_CMD_UNIVERSE) += cmd_universe.o > COBJS-$(CONFIG_CMD_UNZIP) += cmd_unzip.o > +COBJS-$(CONFIG_CMD_TPM) += cmd_tpm.o keep the lis

Re: [U-Boot] [PATCH v2 2/2] Add a cli command to test the TPM device.

2011-10-15 Thread Mike Frysinger
On Friday 14 October 2011 23:39:08 Vadim Bendebury wrote: > --- /dev/null > +++ b/common/cmd_tpm.c > > + /* > + * Verify that in case it is present, the first argument, it is > + * exactly one character in size. > + */ > + if (argc < 7) { > + puts("command should

Re: [U-Boot] [PATCH v3] NS16550: buffer reads

2011-10-15 Thread Wolfgang Denk
Dear Simon Glass, In message <1318694632-21872-1-git-send-email-...@chromium.org> you wrote: > From: Scott Wood > > From: Scott Wood > > This improves the performance of U-Boot when accepting rapid input, > such as pasting a sequence of commands. > > Without this patch, on P4080DS I see a max

Re: [U-Boot] [PATCH v2 2/2] Add a cli command to test the TPM device.

2011-10-15 Thread Mike Frysinger
On Saturday 15 October 2011 14:02:29 Marek Vasut wrote: > On Saturday, October 15, 2011 05:39:08 AM Vadim Bendebury wrote: > > --- /dev/null > > +++ b/common/cmd_tpm.c > > @@ -0,0 +1,111 @@ > > +/* > > + * Copyright (c) 2011 The Chromium OS Authors. All rights reserved. > > + * Released under the 2

Re: [U-Boot] [PATCH v2] NS16550: buffer reads

2011-10-15 Thread Wolfgang Denk
Dear Simon Glass, In message you wrote: > > > How about using the time-honored flow-control mechanism? If the serial port > > supports hardware CTS and RTS signals, you can use them to sync with the > > sender. If not, you can send XOFF and XON to respectively ask the sender to > > pause and re

Re: [U-Boot] [PATCH v2] NS16550: buffer reads

2011-10-15 Thread Wolfgang Denk
Dear Simon Glass, In message you wrote: > > The situation this occurs is when you paste characters into a serial > terminal connected to U-Boot. This is a pretty common requirement. Yes > you can manually select each line and paste it but that is a pain. But that's exactly how it's supposed to

Re: [U-Boot] [PATCH v2 1/2] Introduce generic TPM support in u-boot

2011-10-15 Thread Vadim Bendebury
Dear Marek Vasut, thank you for your comments, please see below: On Sat, Oct 15, 2011 at 11:08 AM, Marek Vasut wrote: > On Saturday, October 15, 2011 05:38:50 AM Vadim Bendebury wrote: >> TPM (Trusted Platform Module) is an integrated circuit and >> software platform that provides computer manu

Re: [U-Boot] [PATCH v2 2/2] Add a cli command to test the TPM device.

2011-10-15 Thread Vadim Bendebury
Dear Marek Vasut, thank you for your comments, please see below: On Sat, Oct 15, 2011 at 11:02 AM, Marek Vasut wrote: > On Saturday, October 15, 2011 05:39:08 AM Vadim Bendebury wrote: >> The command gets an arbitrary number of arguments (up to 30), which >> are interpreted as byte values and ar

Re: [U-Boot] Checkpatch warnings for "volatile"

2011-10-15 Thread Marek Vasut
On Saturday, October 15, 2011 10:56:54 AM Wolfgang Denk wrote: > Dear Prabhakar Lad, > > In message you wrote: > > > I've explained this a number of times recently - there are actually > > > very, very few occasions where "volatile" actually makes sense. > > > > > > Agreed, but I see a piec

Re: [U-Boot] [PATCH v2 1/2] Introduce generic TPM support in u-boot

2011-10-15 Thread Marek Vasut
On Saturday, October 15, 2011 05:38:50 AM Vadim Bendebury wrote: > TPM (Trusted Platform Module) is an integrated circuit and > software platform that provides computer manufacturers with the > core components of a subsystem used to assure authenticity, > integrity and confidentiality. [...] Quic

Re: [U-Boot] [PATCH v2 2/2] Add a cli command to test the TPM device.

2011-10-15 Thread Marek Vasut
On Saturday, October 15, 2011 05:39:08 AM Vadim Bendebury wrote: > The command gets an arbitrary number of arguments (up to 30), which > are interpreted as byte values and are feed into the TPM device after > proper initialization. Then the return value and data of the TPM > driver is examined. >

Re: [U-Boot] [RFC] general ULPI support

2011-10-15 Thread Marek Vasut
On Saturday, October 15, 2011 03:19:45 PM Jana Rapava wrote: > Hi all, Dear Jana Rapava, please Cc respective custodians if you want to get _ANY_ feedback at all. > my patch, which added USB support for Efika, needed som ULPI functions. I > was suggested to write general ULPI support code rather

Re: [U-Boot] [PATCH v3] NS16550: buffer reads

2011-10-15 Thread Marek Vasut
On Saturday, October 15, 2011 06:03:52 PM Simon Glass wrote: > From: Scott Wood > > From: Scott Wood > > This improves the performance of U-Boot when accepting rapid input, > such as pasting a sequence of commands. Hi Simon, [...] > diff --git a/include/ns16550.h b/include/ns16550.h > index

Re: [U-Boot] [PATCH v2] NS16550: buffer reads

2011-10-15 Thread Simon Glass
On Sat, Oct 15, 2011 at 9:50 AM, Simon Glass wrote: > Hi Albert, > > On Sat, Oct 15, 2011 at 9:21 AM, Albert ARIBAUD > wrote: >> Le 15/10/2011 18:12, Simon Glass a écrit : >>> >>> Hi Wolfgang, >>> >>> On Sat, Oct 15, 2011 at 9:02 AM, Wolfgang Denk  wrote: Dear Simon Glass, In

Re: [U-Boot] [PATCH v4 01/10] Add getenv_ulong() to read an integer from an environment variable

2011-10-15 Thread Mike Frysinger
Acked-by: Mike Frysinger -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] zlib: handle overflow while calculating available stream input size

2011-10-15 Thread Mike Frysinger
On Saturday 15 October 2011 12:32:52 Anatolij Gustschin wrote: > If compressed data is located in sectors at the end of the flash and > it's offset + input stream size > 0x, the uncompressing time > is very long, since processing of the stream is done bytewise (and > not blockwise) due to o

Re: [U-Boot] [PATCH v2] NS16550: buffer reads

2011-10-15 Thread Simon Glass
Hi Albert, On Sat, Oct 15, 2011 at 9:21 AM, Albert ARIBAUD wrote: > Le 15/10/2011 18:12, Simon Glass a écrit : >> >> Hi Wolfgang, >> >> On Sat, Oct 15, 2011 at 9:02 AM, Wolfgang Denk  wrote: >>> >>> Dear Simon Glass, >>> >>> In >>> message >>>  you wrote: > A general question: is the iss

[U-Boot] [PATCH] zlib: handle overflow while calculating available stream input size

2011-10-15 Thread Anatolij Gustschin
If compressed data is located in sectors at the end of the flash and it's offset + input stream size > 0x, the uncompressing time is very long, since processing of the stream is done bytewise (and not blockwise) due to overflow in inflate_fast() while calculation and checking for enough inp

Re: [U-Boot] [PATCH v2] NS16550: buffer reads

2011-10-15 Thread Albert ARIBAUD
Le 15/10/2011 18:12, Simon Glass a écrit : > Hi Wolfgang, > > On Sat, Oct 15, 2011 at 9:02 AM, Wolfgang Denk wrote: >> Dear Simon Glass, >> >> In >> message >> you wrote: >>> A general question: is the issue with input as such, or with echoing this input? >>> >>> The problem is in ech

[U-Boot] [PATCH v3] NS16550: buffer reads

2011-10-15 Thread Simon Glass
From: Scott Wood From: Scott Wood This improves the performance of U-Boot when accepting rapid input, such as pasting a sequence of commands. Without this patch, on P4080DS I see a maximum of around 5 lines can be pasted. With this patch, it handles around 70 lines before lossage, long enough

Re: [U-Boot] [PATCH v2] NS16550: buffer reads

2011-10-15 Thread Simon Glass
Hi Wolfgang, On Sat, Oct 15, 2011 at 9:02 AM, Wolfgang Denk wrote: > Dear Simon Glass, > > In message > you > wrote: >> >> > A general question: is the issue with input as such, or with echoing this >> > input? >> >> The problem is in echoing the input, since this requires the uart to >> wait

[U-Boot] [PATCH v4 6/6] fdt: add decode helper library

2011-10-15 Thread Simon Glass
This library provides useful functions to drivers which want to use the fdt to control their operation. Functions are provided to: - look up and enumerate a device type (for example assigning i2c bus 0, i2c bus 1, etc.) - decode basic types from the fdt, like addresses and integers While thi

[U-Boot] [PATCH v4 1/6] fdt: ARM: Add device tree control of U-Boot (CONFIG_OF_CONTROL)

2011-10-15 Thread Simon Glass
This adds a device tree pointer to the global data. It can be set by board code. A later commit will add support for making a device tree binary blob available to U-Boot for run-time configuration. Signed-off-by: Simon Glass --- Changes in v3: - Rename gd->blob to gd->fdt_blob Changes in v4: - F

[U-Boot] [PATCH v4 3/6] fdt: Add support for a separate device tree (CONFIG_OF_SEPARATE)

2011-10-15 Thread Simon Glass
This adds support for an FDT to be build as a separate binary file called u-boot.dtb. This can be concatenated with the U-Boot binary to provide a device tree located at run-time by U-Boot. The Makefile is modified to provide this file in u-boot-dtb.bin. Signed-off-by: Simon Glass --- Changes in

[U-Boot] [PATCH v4 4/6] fdt: ARM: Implement and verify embedded and separate device tree

2011-10-15 Thread Simon Glass
This locates the device tree either embedded within U-Boot or attached to the end as a separate binary. When CONFIG_OF_CONTROL is defined, U-Boot requires a valid fdt. A check is provided for this early in initialisation. Signed-off-by: Simon Glass --- arch/arm/lib/board.c | 22 ++

[U-Boot] [PATCH v4 2/6] fdt: Add support for embedded device tree (CONFIG_OF_EMBED)

2011-10-15 Thread Simon Glass
This new option allows U-Boot to embed a binary device tree into its image to allow run-time control of peripherals. This device tree is for U-Boot's own use and is not necessarily the same one as is passed to the kernel. The device tree compiler output should be placed in the $(obj) rooted tree.

[U-Boot] [PATCH v4 5/6] fdt: ARM: Add fdtcontroladdr to set device tree address in environment

2011-10-15 Thread Simon Glass
This adds support for a new environment variable called 'fdtcontroladdr'. If defined, the hex address is used as the address of the control fdt for U-Boot. Note: I have not changed CONFIG_PRAM section as I already have an outstanding patch on that. Signed-off-by: Simon Glass --- Changes in v3: -

[U-Boot] [PATCH v4 0/6] Run-time configuration of U-Boot via a flat device tree (fdt)

2011-10-15 Thread Simon Glass
At present in U-Boot configuration is mostly done using CONFIG options in the board file. This patch set makes it possible for a single U-Boot binary to support multiple boards, with the exact configuration of each board controlled by a flat device tree (fdt). This is the approach recently taken by

Re: [U-Boot] [PATCH V2 1/2] mmc: change magic number to macro define

2011-10-15 Thread Wolfgang Denk
Dear Lei Wen, In message you wrote: > > Thanks for your kindly explaination on the c structure usage in UBOOT. > So should I keep the V2 version of this patch, or anything else need > to be modified? >From my point of view this is OK, so: Acked-by: WOlfgang Denk Best regards, Wolfgang Denk

Re: [U-Boot] [PATCH v2] NS16550: buffer reads

2011-10-15 Thread Wolfgang Denk
Dear Simon Glass, In message you wrote: > > > A general question: is the issue with input as such, or with echoing this > > input? > > The problem is in echoing the input, since this requires the uart to > wait once its transmit FIFO is full. While it is waiting (and not > checking the receiv

Re: [U-Boot] [PATCH 1/3] fdt: check for fdt errors in fdt_create_phandle

2011-10-15 Thread Jerry Van Baren
On 09/20/2011 07:24 PM, Timur Tabi wrote: > fdt_create_phandle() was ignoring errors from fdt_set_phandle(). If an > error occurs, print an error message and return 0, which is an invalid > phandle. We also need to change the return type for fdt_create_phandle() > to indicate that it cannot retur

Re: [U-Boot] [PATCH 1/2 v6] fdt: Add a do_fixup_by_path_string() function

2011-10-15 Thread Jerry Van Baren
On 08/30/2011 10:36 PM, Chunhe Lan wrote: > The do_fixup_by_path_string() will set the specified node's property to the > value contained in "status". It would just be an inline wrapper for > do_fixup_by_path() that calls strlen on the argument. > > Signed-off-by: Chunhe Lan Added to u-boot-fdt, s

[U-Boot] Pull request: u-boot-fdt

2011-10-15 Thread Jerry Van Baren
The following changes since commit d8fffa057c9430fd0c5104ab6ff7db4cdb03db51: Merge branch 'master' of git://git.denx.de/u-boot-mips (2011-10-12 22:47:15 +0200) are available in the git repository at: git://git.denx.de/u-boot-fdt.git master Chunhe Lan (1): fdt: Add a do_fixup_by_pa

Re: [U-Boot] [PATCH v3 5/6] fdt: ARM: Add fdtcontroladdr to set device tree address in environment

2011-10-15 Thread Simon Glass
Hi Mike, On Thu, Oct 13, 2011 at 2:08 PM, Simon Glass wrote: > Hi Mike, > > On Thu, Oct 13, 2011 at 1:27 PM, Mike Frysinger wrote: >> On Tuesday 11 October 2011 18:26:10 Simon Glass wrote: >>> --- a/arch/arm/lib/board.c >>> +++ b/arch/arm/lib/board.c >>> >>> +/** >>> + * Decode the value of an e

Re: [U-Boot] [PATCH v3 4/6] fdt: ARM: Implement embedded and separate device tree

2011-10-15 Thread Simon Glass
Hi Stephen, On Thu, Oct 13, 2011 at 2:39 PM, Stephen Warren wrote: > Simon Glass wrote at Tuesday, October 11, 2011 4:26 PM: >> This locates the device tree either embedded within U-Boot or attached to the >> end as a separate binary. >> >> When CONFIG_OF_CONTROL is defined, U-Boot requires a val

Re: [U-Boot] [PATCH v3 3/6] fdt: Add support for a separate device tree (CONFIG_OF_SEPARATE)

2011-10-15 Thread Simon Glass
Hi Stephen, On Thu, Oct 13, 2011 at 2:36 PM, Stephen Warren wrote: > Simon Glass wrote at Tuesday, October 11, 2011 4:26 PM: >> This adds support for an FDT to be build as a separate binary file called >> u-boot.dtb. This can be concatenated with the U-Boot binary to provide a >> device tree loca

Re: [U-Boot] Checkpatch warnings for "volatile"

2011-10-15 Thread Prabhakar Lad
Hi Wolfgang On 10/15/11, Wolfgang Denk wrote: > Dear Prabhakar Lad, > > In message > you > wrote: >> >> > I've explained this a number of times recently - there are actually >> > very, very few occasions where "volatile" actually makes sense. >> > >> > Agreed, but I see a piece of code wher

Re: [U-Boot] [PATCH v3 2/6] fdt: Add support for embedded device tree (CONFIG_OF_EMBED)

2011-10-15 Thread Simon Glass
Hi Grant, On Fri, Oct 14, 2011 at 10:46 PM, Grant Likely wrote: > On Thu, Oct 13, 2011 at 3:50 PM, Stephen Warren wrote: >> Simon Glass wrote at Thursday, October 13, 2011 3:25 PM: >>> Hi Stephen, >>> >>> On Thu, Oct 13, 2011 at 2:21 PM, Stephen Warren wrote: >>> > Simon Glass wrote at Tuesday,

Re: [U-Boot] [PATCH v2] NS16550: buffer reads

2011-10-15 Thread Simon Glass
Hi Albert, On Sat, Oct 15, 2011 at 3:43 AM, Albert ARIBAUD wrote: > Hi Simon, > > Le 15/10/2011 02:03, Simon Glass a écrit : >> >> From: Scott Wood >> >> From: Scott Wood >> >> This improves the performance of U-Boot when accepting rapid input, >> such as pasting a sequence of commands. >> >> Wit

Re: [U-Boot] [PATCH V2 1/2] mmc: change magic number to macro define

2011-10-15 Thread Lei Wen
Hi Wolfgang, On Sat, Oct 15, 2011 at 4:36 AM, Wolfgang Denk wrote: > Dear Lei Wen, > > In message > you > wrote: >> >> > And both the "index" and "value" arguments are never used in I/O >> > context, i. e. they are actual plain integer parameters.  So just keep >> > it as >> > >> >        err

[U-Boot] [RFC] general ULPI support

2011-10-15 Thread Jana Rapava
Hi all, my patch, which added USB support for Efika, needed som ULPI functions. I was suggested to write general ULPI support code rather than implenent demanded functionality in the driver. However, I've encountered following problems: 1. Where should I put this code? Linux kernel has it in ./driv

Re: [U-Boot] [PATCH 1/2] fdt: Add new fdt_set_node_status & fdt_set_status_by_alias helpers

2011-10-15 Thread Jerry Van Baren
Hi Kumar, Shengzhou, On 10/14/2011 03:10 PM, Kumar Gala wrote: > From: Shengzhou Liu > > Add common function fdt_set_node_status() to assist in various locations > that we set a nodes status. This function utilizes the status values > that are part of the EPAPR spec (on power.org). > > fdt_set_st

Re: [U-Boot] [PATCH V2 5/8] ARM: moved general function to arm/lib

2011-10-15 Thread Stefano Babic
On 10/15/2011 12:15 PM, Albert ARIBAUD wrote: > Hi Stefano, > Hi Albert, > > I agree with Wofgang that sdelay() is redundant wrt udelay() and has > weaker semantics. > > I'll add that sr32() is kind of not ARM specific, so I fail to see why > it should move to generic ARM, and besides, it is a

Re: [U-Boot] [PATCH V2 3/3] mx31: Add board support for HALE TT-01

2011-10-15 Thread Stefano Babic
On 10/15/2011 10:52 AM, Wolfgang Denk wrote: > - if we do something like that, we should discuss it > first, and put it in context with the (Not yet complete) discussion > about the new Timer API. Agree, you're right - this should be part of the Timer API > I definitely do not want to see this fu

  1   2   >