On 10/15/2011 12:15 PM, Albert ARIBAUD wrote: > Hi Stefano, > Hi Albert,
> > I agree with Wofgang that sdelay() is redundant wrt udelay() and has > weaker semantics. > > I'll add that sr32() is kind of not ARM specific, so I fail to see why > it should move to generic ARM, and besides, it is a half-baked solution > to the general problem of setting a bitfield in a register Right, it is. > > I conclude like Wolfgang that despite this code having gone through > review unnoticed, it should not be promoted for wider use. Understood. > > If some functionality of these three functions is desirable and cannot > be met with other means, please submit new code for general ARM > inclusion (and maybe consider adapting armv7 to this new code). I understand your points - and I agree with you, thanks for clarification. Stefano -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de ===================================================================== _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
