Re: [U-Boot] [PATCH 6/8] arm, davinci, am1808: add lowlevel functions for booting from NOR

2011-09-26 Thread Christian Riesch
Hello Heiko, Thank you for your reply. I have just noticed that the patches have already been pulled into arm/next so I guess I am quite late with my comments. I'd like to apologize for this; apparently I need another email filter that also filters for messages containing "am1808" and not only "da8

Re: [U-Boot] [PATCH V2] ARM: remove broken "ixpg425" and "ixpg425" boards

2011-09-26 Thread Albert ARIBAUD
Hi all, On 23/09/2011 09:55, Albert ARIBAUD wrote: > Signed-off-by: Albert ARIBAUD > Acked-by: Stefan Roese > --- > History: > > V2: no change in code, only added missing Signed-off-by > (and included Stefan's Ack) Applied to u-boot-arm/master. Amicalement, -- Albert. _

Re: [U-Boot] [PATCH 0/4] Buffer overruns in printf

2011-09-26 Thread Albert ARIBAUD
On 27/09/2011 00:28, Scott Wood wrote: >> - users who actually wisht to limit outpout ca use either > > You say "actually wish to limit output" as if "let it corrupt memory if > it's too large" is the normal thing to want. What I meant was "users who actually want to limit output explicitly by t

[U-Boot] Der Gewinner

2011-09-26 Thread Euromillion-Microsoft System 2011
EUROPEAN-WORLDWIDE:MICROSOFT-PRIMITIVA JACKPOT-LOTTERIE 2011 PROMO SPAN-NR:Nº/009819 WINNER B.P.S GEMEIND SOFTWARES SYSTEM PROMOTION ESPAÑA)APARTADO POSTAL(P.O.BOX 17083-28080 Zaragoza España)Date:22/09/2011 --- Glückwunsch Ihr E-Mail-Adr

[U-Boot] "nand write.yaffs" is not working as expected

2011-09-26 Thread Peter Pan
I'm recently using YAFFS2 rootfs on our NAND flash. What I'm experiencing is that the u-boot console "nand write.yaffs" is not working. With this image file, I can successfully write it to nand flash if I boot into Linux. In Linux console, I run "nandwrite -a -o /dev/mtd4 yaffs2.img". And then, I c

Re: [U-Boot] U-Boot build break for m501sk board from Artila

2011-09-26 Thread Wolfgang Denk
Dear Jamie, In message you wrote: > > > Not anymore. Because no one fixed this board in the last two years, the > > board was removed from U-Boot mainline. It is not supported. ... > That's too bad. I've been developing for the board for the past 3 years and > only recently have been given the

Re: [U-Boot] U-Boot build break for m501sk board from Artila

2011-09-26 Thread Jamie
Stefano Babic denx.de> writes: > > On 09/21/2011 08:00 AM, Sandeep Kumar wrote: > > Hi, > > > > Hi, > > > Did anybody face the issue which I am facing in building U-Boot for > > m501sk board from Artila. > > Not anymore. Because no one fixed this board in the last two years, the > board was

Re: [U-Boot] [PATCH RFC] Add general nand functions

2011-09-26 Thread Scott Wood
On 09/26/2011 03:27 AM, Simon Schwarz wrote: > On 09/23/2011 07:22 PM, Scott Wood wrote: >> On 09/23/2011 11:36 AM, Simon Schwarz wrote: >>> Added a nand_base.h header that defines all prototypes of nand_base.c >>> functions. >> >> Just add the new prototypes to include/linux/mtd/nand.h (which gets

[U-Boot] [PATCH v3 21/21] sandbox: Makefile changes to build sandbox architecture

2011-09-26 Thread Simon Glass
At this point U-Boot will build and run on x86 under Linux. The idea is to define a new architecture called 'sandbox', alongside ARM and x86. This runs natively on Linux to suit the host machine. All hardware access is either omitted or emulated. The purpose of this system is to test the bulk of

[U-Boot] [PATCH v3 16/21] sandbox: Add serial uart

2011-09-26 Thread Simon Glass
This uart simply writes to stdout and reads from stdin. We might imagine instead buffering the data so that a test interface can check output and inject input. Signed-off-by: Simon Glass --- drivers/serial/Makefile |1 + drivers/serial/sandbox.c | 67 ++

[U-Boot] [PATCH v3 15/21] sandbox: Add main program

2011-09-26 Thread Simon Glass
Add a main program so that we can run U-Boot. Signed-off-by: Simon Glass --- board/sandbox/common/Makefile |2 +- board/sandbox/common/main.c | 33 + 2 files changed, 34 insertions(+), 1 deletions(-) create mode 100644 board/sandbox/common/main.c diff --

[U-Boot] [PATCH v3 06/21] sandbox: Add architecture lib files

2011-09-26 Thread Simon Glass
These files are taken from the ARM board implementation and then reduced to remove unneeded cruft. Ideally we would work towards unifying arch/xxx/lib files, particularly board.c. Signed-off-by: Simon Glass --- Changes in v2: - Fix commit message typo, sadly - Remove ARM cruft from Makefile - Re

[U-Boot] [PATCH v3 05/21] sandbox: Add cpu files

2011-09-26 Thread Simon Glass
This is an initial implementation with all functions defined but not working. The lds file is very simple since we can mostly rely on the linker defaults. Signed-off-by: Simon Glass --- Changes in v2: - Remove setting of LDSCRIPT (top level Makefile does this anyway) - Add comment to do_reset()

[U-Boot] [PATCH v3 17/21] sandbox: Add basic config file

2011-09-26 Thread Simon Glass
This basic provides required features along with a basic command set. Signed-off-by: Simon Glass --- Changes in v2: - Remove CONFIG_SYS_SDRAM_BASE which is always 0 for sandbox boards - Fix #define - Remove CONFIG_LMB include/configs/sandbox.h | 77

[U-Boot] [PATCH v3 13/21] sandbox: Add OS dependent layer

2011-09-26 Thread Simon Glass
We want to keep all OS-dependent code in once place, with a simple interface to U-Boot. For now, this is that place. Signed-off-by: Simon Glass --- Changes in v2: - Move os layer into arch/sandbox - Remove clean and dist-clean targets from Makefile - Try and fail to remove the global -I/usr/inclu

[U-Boot] [PATCH v3 19/21] Use uintptr_t for 32/64-bit compatibility

2011-09-26 Thread Simon Glass
This fixes a few problems when building on 64-bit machines. Signed-off-by: Simon Glass --- common/cmd_mem.c |2 +- common/fdt_support.c |8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/common/cmd_mem.c b/common/cmd_mem.c index e84cc4e..28476d7 100644 --- a/

[U-Boot] [PATCH v3 07/21] sandbox: Add sandbox board

2011-09-26 Thread Simon Glass
This adds basic files for the sandbox board. The lds file is very simple since we can rely mostly on the linker defaults. Signed-off-by: Simon Glass --- Changes in v2: - Remove clean and dist-clean targets from Makefile - Move lds script out of the board directory board/sandbox/sandbox/Makefile

[U-Boot] [PATCH v3 04/21] sandbox: Add compiler defines to support a 64-bit x86_64 platform

2011-09-26 Thread Simon Glass
This sets __WORDSIZE to 8 correctly on 64-bit machines. Signed-off-by: Simon Glass --- Changes in v2: - Update commit message to remove 'temporary' - Allow __WORDSIZE to be defined in Makefile / elsewhere include/compiler.h | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-)

[U-Boot] [PATCH v3 14/21] sandbox: Add board_init()

2011-09-26 Thread Simon Glass
Create a basic empty board_init() to get us running. Signed-off-by: Simon Glass --- board/sandbox/common/Makefile | 41 + board/sandbox/common/board.c | 25 + 2 files changed, 66 insertions(+), 0 deletions(-) create mode 10064

[U-Boot] [PATCH v3 08/21] sandbox: Add board info for architecture

2011-09-26 Thread Simon Glass
This is required for the bdinfo command to work. This also cleans up the #ifdef mess for ethernet and lnum a little. Signed-off-by: Simon Glass --- common/cmd_bdinfo.c | 34 ++ 1 files changed, 30 insertions(+), 4 deletions(-) diff --git a/common/cmd_bdinfo.c

[U-Boot] [PATCH v3 03/21] sandbox: Add architecture image support

2011-09-26 Thread Simon Glass
We won't actually load an image with this architecture, but we still need to define it. Signed-off-by: Simon Glass --- Changes in v3: - Add architecture image support for sandbox include/image.h |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/include/image.h b/i

[U-Boot] [PATCH v3 11/21] sandbox: Disable standalone/API support

2011-09-26 Thread Simon Glass
This is not useful on the sandbox architecture since we can simply link all our code with U-Boot. Also, loading native code doesn't make a lot of sense. Signed-off-by: Simon Glass --- Makefile |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile in

[U-Boot] [PATCH v3 09/21] sandbox: Add bootm support

2011-09-26 Thread Simon Glass
This adds sandbox architecture support to bootm, although it is probably not useful to load sandbox code into the address space and execute it. This change at least make the file build correctly on 64-bit machines. Signed-off-by: Simon Glass --- Changes in v2: - Fix cast of int to pointer instea

[U-Boot] [PATCH v3 12/21] sandbox: Force command sections to be 4-byte aligned

2011-09-26 Thread Simon Glass
By default sections are 16-byte aligned on some architectures, but the command name structure (struct cmd_tbl_s) does not have padding to 16 bytes. This change reduces the alignment to 4-bytes so that the command table can be accessed correctly on any architecture. (Note: this needs doing properly

[U-Boot] [PATCH v3 10/21] sandbox: Disable built-in malloc

2011-09-26 Thread Simon Glass
We prefer to U-Boot's malloc but for now it is easier to use the C library's version. Signed-off-by: Simon Glass --- common/Makefile |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/common/Makefile b/common/Makefile index 2edbd71..8d17a54 100644 --- a/common/Makefile +++

[U-Boot] [PATCH v3 01/21] sandbox: Add architecture header files

2011-09-26 Thread Simon Glass
This adds required header files for the sandbox architecture, and a basic description of what sandbox is (README.sandbox). Signed-off-by: Simon Glass --- Changes in v2: - Removed unneeded clock.h - Moved gpio.h to asm-generic, removed GPIO_COUNT - Removed kernel cruft from posix_types.h - Removed

[U-Boot] [PATCH v3 20/21] Adjust dependency rules to permit per-file flags

2011-09-26 Thread Simon Glass
The dependency rules are currently done in a shell 'for' loop. This does not permit Makefile variables to adjust preprocessor flags as is done with normal compile flags, using the CFLAGS_path/file.o syntax. This change moves the dependency generation into the Makefile itself, and permits a CPPFLAG

[U-Boot] [PATCH v3 18/21] Remove unused variable warnings in cmd_mem, cmd_nvedit

2011-09-26 Thread Simon Glass
There are a few variables set but not used - this marks these as unused for the compiler. Merek's GCC4.6 patch series fixes these so this patch does not need to be applied if you have these: - GCC4.6: Squash warning in cmd_mem.c - GCC4.6: Squash warning in cmd_nvedit.c Signed-off-by: Simon Glass

[U-Boot] [PATCH v3 02/21] Fix use of int as pointer in image.c

2011-09-26 Thread Simon Glass
It is better to use %p in this case. Signed-off-by: Simon Glass Acked-by: Mike Frysinger --- Changes in v2: - Split this change out from 'Add architecture image support' common/image.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/common/image.c b/common/image.c i

[U-Boot] [PATCH v3 0/21] New 'sandbox' test architecture for U-Boot

2011-09-26 Thread Simon Glass
This patch set points towards a possible way to improve the test infrastructure in U-Boot. The goal is to have a test suite that can run in a minute or two on a Linux PC and test all non-platform code. This RFC aims to be just enough boot to U-Boot to a command prompt. You can type help; anything

Re: [U-Boot] [RFC PATCH v2 0/20] New 'sandbox' test architecture for U-Boot

2011-09-26 Thread Simon Glass
Hi Mike, On Sun, Sep 25, 2011 at 9:59 PM, Mike Frysinger wrote: > On Friday, September 23, 2011 12:22:02 Simon Glass wrote: >> This patch set points towards a possible way to improve the test >> infrastructure in U-Boot. The goal is to have a test suite that can run in >> a minute or two on a Lin

Re: [U-Boot] [RFC PATCH v2 13/20] sandbox: Add OS dependent layer

2011-09-26 Thread Simon Glass
On Mon, Sep 26, 2011 at 3:03 PM, Simon Glass wrote: > Hi Mike, > > On Mon, Sep 26, 2011 at 2:19 PM, Mike Frysinger wrote: >> On Monday, September 26, 2011 17:04:49 Simon Glass wrote: >>> On Sun, Sep 25, 2011 at 10:16 PM, Mike Frysinger wrote: >>> > On Friday, September 23, 2011 12:22:15 Simon Gla

Re: [U-Boot] [PATCH] powerpc/85xx: corenet_ds: increase console buffer size to 1024

2011-09-26 Thread Kim Phillips
On Mon, 26 Sep 2011 16:11:14 -0500 Scott Wood wrote: > On 09/26/2011 01:09 PM, Wolfgang Denk wrote: > > In message <20110926112756.bb93d41b.kim.phill...@freescale.com> you wrote: > >> We need to enable reverting an env var to its original default > >> definition. > > > > Do we? We have not had t

Re: [U-Boot] [PATCH V4] console: Implement pre-console buffer

2011-09-26 Thread Vadim Bendebury
On Wed, Aug 31, 2011 at 5:58 AM, Graeme Russ wrote: > Allow redirection of console output prior to console initialisation to a > temporary buffer. > > To enable this functionality, the board configuration file must define: >  - CONFIG_PRE_CONSOLE_BUFFER - Enable pre-console buffer >  - CONFIG_PRE_

Re: [U-Boot] [PATCH] powerpc/85xx: corenet_ds: increase console buffer size to 1024

2011-09-26 Thread Brian Grayson
On Mon, Sep 26, 2011 at 04:11:14PM -0500, Scott Wood wrote: > > What is the resource constraint here that prevents accepting longer > console commands? This is a change to the config for a board that comes > with multiple gigabytes of RAM. This is not code that runs prior to > relocation. Exa

Re: [U-Boot] [PATCH 0/4] Buffer overruns in printf

2011-09-26 Thread Scott Wood
On 09/26/2011 06:20 AM, Albert ARIBAUD wrote: > Hi Simon, > > Le 25/09/2011 16:50, Simon Glass a écrit : > >>> Basically, printf family functions which do not have the 'n' are *know* by >>> all -- experienced enough :) -- programmers to be *unsafe* (but to require >>> less from the caller) print

Re: [U-Boot] Including stdlib.h / ldiv_t

2011-09-26 Thread Mike Frysinger
On Monday, September 26, 2011 16:23:01 Simon Glass wrote: > At the moment including stdlib and including common.h are mutually > exclusive. This probably makes some sense (why would anyone include > stdlib.h in U-Boot except with hostcc?), but in that case we should > try to replace any need for st

Re: [U-Boot] [RFC PATCH v2 13/20] sandbox: Add OS dependent layer

2011-09-26 Thread Simon Glass
Hi Mike, On Mon, Sep 26, 2011 at 2:19 PM, Mike Frysinger wrote: > On Monday, September 26, 2011 17:04:49 Simon Glass wrote: >> On Sun, Sep 25, 2011 at 10:16 PM, Mike Frysinger wrote: >> > On Friday, September 23, 2011 12:22:15 Simon Glass wrote: >> >> --- a/arch/sandbox/cpu/sandbox/Makefile >> >>

Re: [U-Boot] [RFC PATCH v2 13/20] sandbox: Add OS dependent layer

2011-09-26 Thread Mike Frysinger
On Monday, September 26, 2011 17:04:49 Simon Glass wrote: > On Sun, Sep 25, 2011 at 10:16 PM, Mike Frysinger wrote: > > On Friday, September 23, 2011 12:22:15 Simon Glass wrote: > >> --- a/arch/sandbox/cpu/sandbox/Makefile > >> +++ b/arch/sandbox/cpu/sandbox/Makefile > >> > >> +# I want to do this

Re: [U-Boot] [PATCH] powerpc/85xx: corenet_ds: increase console buffer size to 1024

2011-09-26 Thread Scott Wood
On 09/26/2011 01:09 PM, Wolfgang Denk wrote: > In message <20110926112756.bb93d41b.kim.phill...@freescale.com> you wrote: >> We need to enable reverting an env var to its original default >> definition. > > Do we? We have not had that feature for over a decade and nobody ever > really suffered fro

Re: [U-Boot] [RFC PATCH v2 13/20] sandbox: Add OS dependent layer

2011-09-26 Thread Simon Glass
Hi Mike, On Sun, Sep 25, 2011 at 10:16 PM, Mike Frysinger wrote: > On Friday, September 23, 2011 12:22:15 Simon Glass wrote: >>  arch/sandbox/cpu/sandbox/Makefile |    7 - >>  arch/sandbox/cpu/sandbox/os.c     |   49 > > you don't need to follow the "SoC" convention.  arch/sandbox/cpu/*.c sho

Re: [U-Boot] [PATCH v4 4/4] Add USB support for Efika

2011-09-26 Thread Marek Vasut
On Monday, September 26, 2011 10:28:17 PM Jana Rapava wrote: > > > + while (--timeout) { > > > + tmp = readl(&ehci->ulpi_viewpoint); > > > + if (!(tmp & ulpi_bit)) > > > + break; > > > + WATCHDOG_RESET(); > > > + } > > > + if (!tim

Re: [U-Boot] [PATCH v4 4/4] Add USB support for Efika

2011-09-26 Thread Marek Vasut
On Monday, September 26, 2011 10:28:17 PM Jana Rapava wrote: > > > + while (--timeout) { > > > + tmp = readl(&ehci->ulpi_viewpoint); > > > + if (!(tmp & ulpi_bit)) > > > + break; > > > + WATCHDOG_RESET(); > > > + } > > > + if (!tim

Re: [U-Boot] [PATCH v4 4/4] Add USB support for Efika

2011-09-26 Thread Jana Rapava
> > + while (--timeout) { > > + tmp = readl(&ehci->ulpi_viewpoint); > > + if (!(tmp & ulpi_bit)) > > + break; > > + WATCHDOG_RESET(); > > + } > > + if (!timeout) { > > + printf("ULPI %s timed out\n", operation); > > +

Re: [U-Boot] [RFC PATCH v2 03/20] sandbox: Add architecture image support

2011-09-26 Thread Simon Glass
Hi Mike, On Mon, Sep 26, 2011 at 1:19 PM, Mike Frysinger wrote: > On Monday, September 26, 2011 15:39:28 Simon Glass wrote: >> On Sun, Sep 25, 2011 at 10:01 PM, Mike Frysinger wrote: >> > On Friday, September 23, 2011 12:22:05 Simon Glass wrote: >> >>  #elif defined(__sparc__) >> >>       if (!im

[U-Boot] Including stdlib.h / ldiv_t

2011-09-26 Thread Simon Glass
Hi, Before I forget, in my travels recently I found this little bit of code in disk/part_mac.c: /* stdlib.h causes some compatibility problems; should fixe these! -- wd */ #ifndef __ldiv_t_defined typedef struct { long int quot; /* Quotient */ long int rem;

Re: [U-Boot] [RFC PATCH v2 03/20] sandbox: Add architecture image support

2011-09-26 Thread Mike Frysinger
On Monday, September 26, 2011 15:39:28 Simon Glass wrote: > On Sun, Sep 25, 2011 at 10:01 PM, Mike Frysinger wrote: > > On Friday, September 23, 2011 12:22:05 Simon Glass wrote: > >> #elif defined(__sparc__) > >> if (!image_check_arch (hdr, IH_ARCH_SPARC)) > >> +#elif defined(CONFIG_SANDBOX_

[U-Boot] [PATCH v2] image: push default arch values to arch headers

2011-09-26 Thread Mike Frysinger
This pushes the ugly duplicated arch ifdef lists we maintain in various image related files out to the arch headers themselves. Signed-off-by: Mike Frysinger --- v2 - add a friendly #error when the define is missing arch/arm/include/asm/u-boot.h|3 ++ arch/avr32/include/asm/

Re: [U-Boot] [PATCH 7/7] GCC4.6: Squash warning in cmd_mem.c

2011-09-26 Thread Mike Frysinger
On Monday, September 26, 2011 14:29:24 Marek Vasut wrote: > On Monday, September 26, 2011 08:03:45 PM Wolfgang Denk wrote: > > Marek Vasut wrote: > > > > i think gcc-3.x has been broken for a while but no one has noticed > > > > > > I guess we should go the kernel way -- make it 4.2 and be done wi

Re: [U-Boot] [RFC PATCH v2 03/20] sandbox: Add architecture image support

2011-09-26 Thread Simon Glass
Hi Mike, On Sun, Sep 25, 2011 at 10:01 PM, Mike Frysinger wrote: > On Friday, September 23, 2011 12:22:05 Simon Glass wrote: >>  #elif defined(__sparc__) >>       if (!image_check_arch (hdr, IH_ARCH_SPARC)) >> +#elif defined(CONFIG_SANDBOX_ARCH) >> +     if (0) >>  #else >>  # error Unknown CPU t

Re: [U-Boot] [RFC PATCH 06/20] sandbox: Allow board_init_f() and board_init_r() to return

2011-09-26 Thread Anton Staaf
On Mon, Sep 26, 2011 at 12:22 PM, Simon Glass wrote: > Hi Anton, > > On Mon, Sep 26, 2011 at 10:49 AM, Anton Staaf wrote: >> On Mon, Sep 26, 2011 at 9:48 AM, Simon Glass wrote: >>> Hi Mike, >>> >>> On Sun, Sep 25, 2011 at 9:47 PM, Mike Frysinger wrote: On Friday, September 23, 2011 11:55:1

Re: [U-Boot] [PATCH 2/2] phylib: remove a couple of redundant code lines

2011-09-26 Thread Vladimir Zapolskiy
Hello Wolfgang, On 23.09.2011 09:06, Wolfgang Denk wrote: > Dear Andy Fleming, > > In > message > you wrote: >> >> Shoot, I just saw this patch in my tree. It's incorrect. > > Argh... > >> The lines weren't redundant. The logic is (and probably should be >> better commented): >> >> Find the int

Re: [U-Boot] [RFC PATCH 06/20] sandbox: Allow board_init_f() and board_init_r() to return

2011-09-26 Thread Simon Glass
Hi Anton, On Mon, Sep 26, 2011 at 10:49 AM, Anton Staaf wrote: > On Mon, Sep 26, 2011 at 9:48 AM, Simon Glass wrote: >> Hi Mike, >> >> On Sun, Sep 25, 2011 at 9:47 PM, Mike Frysinger wrote: >>> On Friday, September 23, 2011 11:55:11 Simon Glass wrote: On Sat, Sep 17, 2011 at 5:05 PM, Mike

Re: [U-Boot] [PATCH 7/7] GCC4.6: Squash warning in cmd_mem.c

2011-09-26 Thread Marek Vasut
On Monday, September 26, 2011 09:01:16 PM Simon Glass wrote: > Hi Marek, > > On Mon, Sep 26, 2011 at 11:34 AM, Marek Vasut wrote: > > On Monday, September 26, 2011 08:29:22 PM Simon Glass wrote: > >> Hi Merek, > >> > >> On Mon, Sep 26, 2011 at 11:24 AM, Marek Vasut wrote: > >> > On Monday, Sep

Re: [U-Boot] [PATCH 7/7] GCC4.6: Squash warning in cmd_mem.c

2011-09-26 Thread Simon Glass
Hi Marek, On Mon, Sep 26, 2011 at 12:10 PM, Marek Vasut wrote: > On Monday, September 26, 2011 09:01:16 PM Simon Glass wrote: >> Hi Marek, >> >> >> The assignment to i I was referring to is here: >> >>       if (length == 1) { >>               if (size == 4) { >>                       longp = (ui

Re: [U-Boot] [RFC PATCH 04/20] sandbox: Add cpu files

2011-09-26 Thread Simon Glass
Hi Anton, On Mon, Sep 26, 2011 at 10:10 AM, Anton Staaf wrote: > On Mon, Sep 26, 2011 at 9:49 AM, Simon Glass wrote: >> Hi Mike, >> >> On Sun, Sep 25, 2011 at 9:48 PM, Mike Frysinger wrote: >>> On Sunday, September 25, 2011 16:18:32 Simon Glass wrote: On Sun, Sep 25, 2011 at 12:25 PM, Wolf

Re: [U-Boot] Building u-boot for Walnut board (PPC 405GPr)

2011-09-26 Thread Brian S. Park
Thank you for the information. I'm just re-learning my way around u-boot. I appreciate your comments and pointers. Last time I used u-boot, it did not use the current method for configuration and I was able to us // to comment stuff out in the configuration header file. Thank you and you guys

Re: [U-Boot] [PATCH 3/4] Make printf and vprintf safe from buffer overruns

2011-09-26 Thread Simon Glass
Hi Wolfgang, On Mon, Sep 26, 2011 at 11:47 AM, Wolfgang Denk wrote: > Dear Simon Glass, > > In message > you > wrote: >> >> > If you can find one that fits for all boards? =A0Keep in mind that >> > printf() gets used before relocation, when available stack space may >> > be _very_ limited. >>

Re: [U-Boot] [PATCH 7/7] GCC4.6: Squash warning in cmd_mem.c

2011-09-26 Thread Simon Glass
Hi Marek, On Mon, Sep 26, 2011 at 11:34 AM, Marek Vasut wrote: > On Monday, September 26, 2011 08:29:22 PM Simon Glass wrote: >> Hi Merek, >> >> On Mon, Sep 26, 2011 at 11:24 AM, Marek Vasut wrote: >> > On Monday, September 26, 2011 08:05:43 PM Simon Glass wrote: >> >> Hi Marek, >> >> >> >> On S

Re: [U-Boot] [PATCH 7/7] GCC4.6: Squash warning in cmd_mem.c

2011-09-26 Thread Wolfgang Denk
Dear Marek Vasut, In message <201109262029.24934.marek.va...@gmail.com> you wrote: > > Anyway, is there still anyone using 3.x ? If there isn't any such users, we > should simply discard it, add gcc version check and set the lower bound to > some > not-too-buggy version of gcc4. To be honest:

Re: [U-Boot] [PATCH 3/5] NAND: Allow per-buffer allocation

2011-09-26 Thread Marek Vasut
On Monday, September 26, 2011 08:33:56 PM Scott Wood wrote: > On 09/24/2011 07:37 AM, Marek Vasut wrote: > > On Friday, September 23, 2011 07:35:15 PM Scott Wood wrote: > >> On 09/22/2011 03:51 AM, Marek Vasut wrote: > >>> On Thursday, September 22, 2011 09:41:21 AM Stefano Babic wrote: > On 0

[U-Boot] [PATCH] ARM: Convert {in,out}s[bwl] to inline functions

2011-09-26 Thread Marek Vasut
The size of uboot binary grows by a few bytes, but the gain (better type checking) is worth it. Signed-off-by: Marek Vasut Cc: Wolfgang Denk Cc: Nick Thompson Cc: Simon Glass --- arch/arm/include/asm/io.h | 34 -- 1 files changed, 28 insertions(+), 6 deletion

Re: [U-Boot] [PATCH 3/4] Make printf and vprintf safe from buffer overruns

2011-09-26 Thread Wolfgang Denk
Dear Simon Glass, In message you wrote: > > > If you can find one that fits for all boards? =A0Keep in mind that > > printf() gets used before relocation, when available stack space may > > be _very_ limited. > > Yes that is a problem. Perhaps we could changes things so that this > CONFIG real

Re: [U-Boot] [PATCH] image: push default arch values to arch headers

2011-09-26 Thread Wolfgang Denk
Dear Mike Frysinger, In message <201109261415.14398.vap...@gentoo.org> you wrote: > > > Should it not be trivial to add a > > > > #ifndef IH_ARCH_DEFAULT > > # error Unknown CPU type: IH_ARCH_DEFAULT not set > > #endif > > > > or similar to include/image.h ? > > it'd certainly be ea

Re: [U-Boot] Building u-boot for Walnut board (PPC 405GPr)

2011-09-26 Thread Wolfgang Denk
Dear "Brian S. Park", In message <4e80bf3d.8050...@corelis.com> you wrote: > > It seems that the tool that generates u-boot.lds does not like // in the > header file and putting it in the u-boot.lds file. The "tool that generates u-boot.lds" is the standard C preprocessor. Best regards, Wolfga

Re: [U-Boot] Building u-boot for Walnut board (PPC 405GPr)

2011-09-26 Thread Wolfgang Denk
Dear "Brian S. Park", In message <4e80bc71.4000...@corelis.com> you wrote: > > I found my problem. > > My board, though based on walnut board, does not have real time clock. > So, I have to disable RTC support in u-boot. However, as soon as I > comment out > > #define CONFIG_RTC_DS174x1

Re: [U-Boot] [PATCH 0/4] Buffer overruns in printf

2011-09-26 Thread Wolfgang Denk
Dear Simon Glass, In message you wrote: > > For sprintf() I agree - this is well understood and people are aware > of it. For printf() I am not so sure. We are a resource limited boot loader. We got for a small footprint, and accept some resulting restrictions, if they are not really severe.

Re: [U-Boot] [PATCH] GCC4.4: Squash multiple warnings due to strict aliasing

2011-09-26 Thread Marek Vasut
On Monday, September 26, 2011 08:33:58 PM Wolfgang Denk wrote: > Dear Marek Vasut, > > In message <201109261937.01263.marek.va...@gmail.com> you wrote: > > > What exactly are the advantages, and what the disadvantages? > > > > > > code size / memory footprint? > > > > I assume converting those t

Re: [U-Boot] [PATCH 3/5] NAND: Allow per-buffer allocation

2011-09-26 Thread Scott Wood
On 09/24/2011 07:37 AM, Marek Vasut wrote: > On Friday, September 23, 2011 07:35:15 PM Scott Wood wrote: >> On 09/22/2011 03:51 AM, Marek Vasut wrote: >>> On Thursday, September 22, 2011 09:41:21 AM Stefano Babic wrote: On 09/21/2011 10:16 PM, Wolfgang Denk wrote: > Dear Stefano & Marek, >

Re: [U-Boot] [PATCH 7/7] GCC4.6: Squash warning in cmd_mem.c

2011-09-26 Thread Marek Vasut
On Monday, September 26, 2011 08:29:22 PM Simon Glass wrote: > Hi Merek, > > On Mon, Sep 26, 2011 at 11:24 AM, Marek Vasut wrote: > > On Monday, September 26, 2011 08:05:43 PM Simon Glass wrote: > >> Hi Marek, > >> > >> On Sun, Sep 25, 2011 at 5:26 PM, Marek Vasut wrote: > >> > cmd_mem.c: In fu

Re: [U-Boot] [PATCH] GCC4.4: Squash multiple warnings due to strict aliasing

2011-09-26 Thread Wolfgang Denk
Dear Marek Vasut, In message <201109261937.01263.marek.va...@gmail.com> you wrote: > > > What exactly are the advantages, and what the disadvantages? > > > > code size / memory footprint? > > I assume converting those to inline function will yield no memory usage > growth > at all. Please don

Re: [U-Boot] [PATCH 7/7] GCC4.6: Squash warning in cmd_mem.c

2011-09-26 Thread Marek Vasut
On Monday, September 26, 2011 08:03:45 PM Wolfgang Denk wrote: > Dear Marek Vasut, > > In message <201109261931.24045.marek.va...@gmail.com> you wrote: > > > i think gcc-3.x has been broken for a while but no one has noticed > > > > I guess we should go the kernel way -- make it 4.2 and be done w

Re: [U-Boot] [PATCH 7/7] GCC4.6: Squash warning in cmd_mem.c

2011-09-26 Thread Simon Glass
Hi Merek, On Mon, Sep 26, 2011 at 11:24 AM, Marek Vasut wrote: > On Monday, September 26, 2011 08:05:43 PM Simon Glass wrote: >> Hi Marek, >> >> On Sun, Sep 25, 2011 at 5:26 PM, Marek Vasut wrote: >> > cmd_mem.c: In function ‘do_mem_loop’: >> > cmd_mem.c:474:25: warning: variable ‘junk’ set but

Re: [U-Boot] [PATCH 3/4] Make printf and vprintf safe from buffer overruns

2011-09-26 Thread Simon Glass
HI Wolfgang, On Sun, Sep 25, 2011 at 1:14 PM, Wolfgang Denk wrote: > Dear Simon Glass, > > In message > you > wrote: >> >> Yes, indeed. Could we go as far as removing CONFIG_SYS_PBSIZE, and >> just use a standard value? > > If you can find one that fits for all boards?  Keep in mind that > pri

Re: [U-Boot] [PATCH 7/7] GCC4.6: Squash warning in cmd_mem.c

2011-09-26 Thread Marek Vasut
On Monday, September 26, 2011 08:05:43 PM Simon Glass wrote: > Hi Marek, > > On Sun, Sep 25, 2011 at 5:26 PM, Marek Vasut wrote: > > cmd_mem.c: In function ‘do_mem_loop’: > > cmd_mem.c:474:25: warning: variable ‘junk’ set but not used > > [-Wunused-but-set-variable] > > > > The assigned variable

Re: [U-Boot] [PATCH v2] mkconfig: start deprecating Makefile config targets

2011-09-26 Thread Wolfgang Denk
Dear Mike Frysinger, In message <201109191036.38248.vap...@gentoo.org> you wrote: > > > Please update doc/feature-removal-schedule.txt as well. > > i didnt have a schedule in mind ... just start scaring people :) > > any target you have in mind ? Next release? Second next release? Best regards

Re: [U-Boot] [RFC PATCH 17/20] sandbox: Add basic config file

2011-09-26 Thread Simon Glass
Hi Mike, On Sun, Sep 25, 2011 at 9:52 PM, Mike Frysinger wrote: > On Friday, September 23, 2011 12:00:15 Simon Glass wrote: >> On Sat, Sep 17, 2011 at 5:22 PM, Mike Frysinger wrote: >> > On Saturday, September 17, 2011 12:48:56 Simon Glass wrote: >> >> +#define CONFIG_DRAM_SIZE     (128 << 20) >>

Re: [U-Boot] [RFC PATCH 04/20] sandbox: Add cpu files

2011-09-26 Thread Mike Frysinger
On Monday, September 26, 2011 14:12:21 Wolfgang Denk wrote: > Mike Frysinger wrote: > > i would expect "reset" in the sandbox to "exit(1)". how else would you > > exit ? > > "reset" should then use "exit(EXIT_SUCCESS)" as thisis a normal > termination of the program, not an error condition. sure

Re: [U-Boot] [PATCH 4/7] GCC4.6: Squash warning in cmd_nvedit.c

2011-09-26 Thread Simon Glass
On Sun, Sep 25, 2011 at 5:26 PM, Marek Vasut wrote: > cmd_nvedit.c: In function ‘do_env_edit’: > cmd_nvedit.c:463:6: warning: variable ‘len’ set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Marek Vasut I need this also! Acked-by: Simon Glass > --- >  common/cmd_nvedit.c |    

Re: [U-Boot] [PATCH] image: push default arch values to arch headers

2011-09-26 Thread Mike Frysinger
On Monday, September 26, 2011 13:58:59 Wolfgang Denk wrote: > Mike Frysinger wrote: > > > ...here you change a compile time error check into a runtim error. > > > > no, it'll still be a build time error as IH_ARCH_DEFAULT will be > > undefined > > > > it just might not be as clean an error ... gc

Re: [U-Boot] [RFC PATCH 04/20] sandbox: Add cpu files

2011-09-26 Thread Wolfgang Denk
Dear Mike Frysinger, In message <201109260048.41976.vap...@gentoo.org> you wrote: > > i would expect "reset" in the sandbox to "exit(1)". how else would you exit ? "reset" should then use "exit(EXIT_SUCCESS)" as thisis a normal termination of the program, not an error condition. Best regards,

Re: [U-Boot] [PATCH] powerpc/85xx: corenet_ds: increase console buffer size to 1024

2011-09-26 Thread Wolfgang Denk
Dear Kim Phillips, In message <20110926112756.bb93d41b.kim.phill...@freescale.com> you wrote: > > > Instead of extending buffer sizes just to be able to enter some > > incomrephensible long variable setting you should try and figure > > this variable (which I have been comprehending for years

Re: [U-Boot] [RFC PATCH 18/20] sandbox: Remove unused variable warnings

2011-09-26 Thread Simon Glass
Hi Mike, On Sun, Sep 25, 2011 at 9:49 PM, Mike Frysinger wrote: > On Friday, September 23, 2011 12:01:46 Simon Glass wrote: >> On Sat, Sep 17, 2011 at 5:25 PM, Mike Frysinger wrote: >> > On Saturday, September 17, 2011 12:48:57 Simon Glass wrote: >> >> There are a few variables set but not used -

Re: [U-Boot] Building u-boot for Walnut board (PPC 405GPr)

2011-09-26 Thread Brian S. Park
Sorry to keep relying to my self. It seems that the tool that generates u-boot.lds does not like // in the header file and putting it in the u-boot.lds file. I started using /* */ instead and it compiles OK now. Thanks. Brian On 9/26/2011 10:54 AM, Brian S. Park wrote: I found my problem.

Re: [U-Boot] [PATCH 7/7] GCC4.6: Squash warning in cmd_mem.c

2011-09-26 Thread Simon Glass
Hi Marek, On Sun, Sep 25, 2011 at 5:26 PM, Marek Vasut wrote: > cmd_mem.c: In function ‘do_mem_loop’: > cmd_mem.c:474:25: warning: variable ‘junk’ set but not used > [-Wunused-but-set-variable] > > The assigned variable can be removed because the pointers are volatile so > accesses to their addre

Re: [U-Boot] [PATCH 7/7] GCC4.6: Squash warning in cmd_mem.c

2011-09-26 Thread Wolfgang Denk
Dear Marek Vasut, In message <201109261931.24045.marek.va...@gmail.com> you wrote: > > > i think gcc-3.x has been broken for a while but no one has noticed > > I guess we should go the kernel way -- make it 4.2 and be done with it. You are off by one major version. The kernel README says:

Re: [U-Boot] [PATCH] image: push default arch values to arch headers

2011-09-26 Thread Wolfgang Denk
Dear Mike Frysinger, In message <201109261209.46800.vap...@gentoo.org> you wrote: > > > ...here you change a compile time error check into a runtim error. > > no, it'll still be a build time error as IH_ARCH_DEFAULT will be undefined > > it just might not be as clean an error ... gcc will compla

Re: [U-Boot] Faster boot time

2011-09-26 Thread Wolfgang Denk
Dear Dat Tran, In message you wrote: > > Also running the latest X-Loader 1.50 and U-Boot 2011.09-rc1, it takes about > 2 seconds from power on to starting the Linux Kernel. My Kernel takes 1 > second to load and my file system takes another 1.5 seconds for a total of > 4.5 seconds from power on

Re: [U-Boot] Building u-boot for Walnut board (PPC 405GPr)

2011-09-26 Thread Brian S. Park
I found my problem. My board, though based on walnut board, does not have real time clock. So, I have to disable RTC support in u-boot. However, as soon as I comment out #define CONFIG_RTC_DS174x1/* use DS1743 RTC in Walnut*/ in walnut.h, line 68, I get build error. [root@new-li

Re: [U-Boot] [PATCH 0/4] Buffer overruns in printf

2011-09-26 Thread Simon Glass
Hi Albert, On Mon, Sep 26, 2011 at 4:20 AM, Albert ARIBAUD wrote: > Hi Simon, > > Le 25/09/2011 16:50, Simon Glass a écrit : > >>> Basically, printf family functions which do not have the 'n' are *know* >>> by >>> all -- experienced enough :) -- programmers to be *unsafe* (but to >>> require >>>

Re: [U-Boot] [RFC PATCH 06/20] sandbox: Allow board_init_f() and board_init_r() to return

2011-09-26 Thread Anton Staaf
On Mon, Sep 26, 2011 at 9:48 AM, Simon Glass wrote: > Hi Mike, > > On Sun, Sep 25, 2011 at 9:47 PM, Mike Frysinger wrote: >> On Friday, September 23, 2011 11:55:11 Simon Glass wrote: >>> On Sat, Sep 17, 2011 at 5:05 PM, Mike Frysinger wrote: >>> > On Saturday, September 17, 2011 12:48:45 Simon Gl

Re: [U-Boot] [PATCH] GCC4.4: Squash multiple warnings due to strict aliasing

2011-09-26 Thread Marek Vasut
On Monday, September 26, 2011 01:30:41 PM Wolfgang Denk wrote: > Dear Marek Vasut, > > In message <201109261132.43616.marek.va...@gmail.com> you wrote: > > > Would it be better to change the __arch_putb macro into an extern > > > inline function instead which would catch these and future cases? >

[U-Boot] [PATCH 1/7 V3] GCC4.6: Convert various empty macros to inline functions

2011-09-26 Thread Marek Vasut
Fix the following gcc4.6 problems: cmd_date.c: In function ‘do_date’: cmd_date.c:50:6: warning: variable ‘old_bus’ set but not used [-Wunused-but-set-variable] asix.c: In function ‘asix_init’: asix.c:317:6: warning: variable ‘rx_ctl’ set but not used [-Wunused-but-set-variable] usb.c: In function

Re: [U-Boot] [PATCH 7/7] GCC4.6: Squash warning in cmd_mem.c

2011-09-26 Thread Marek Vasut
On Monday, September 26, 2011 06:10:37 PM Mike Frysinger wrote: > On Monday, September 26, 2011 05:03:46 Marek Vasut wrote: > > On Monday, September 26, 2011 09:25:36 AM Wolfgang Denk wrote: > > > Mike Frysinger wrote: > > > > > The assigned variable can be removed because the pointers are > > > >

Re: [U-Boot] [PATCH 0/4] Buffer overruns in printf

2011-09-26 Thread Simon Glass
Hi Wolfgang, On Sun, Sep 25, 2011 at 1:04 PM, Wolfgang Denk wrote: > Dear Simon Glass, > > In message <1316799532-20761-1-git-send-email-...@chromium.org> you wrote: >> The printf family of functions in U-Boot cannot deal with a situation where >> the caller provides a buffer which turns out to b

Re: [U-Boot] [RFC PATCH 04/20] sandbox: Add cpu files

2011-09-26 Thread Anton Staaf
On Mon, Sep 26, 2011 at 9:49 AM, Simon Glass wrote: > Hi Mike, > > On Sun, Sep 25, 2011 at 9:48 PM, Mike Frysinger wrote: >> On Sunday, September 25, 2011 16:18:32 Simon Glass wrote: >>> On Sun, Sep 25, 2011 at 12:25 PM, Wolfgang Denk wrote: >>> > Simon Glass wrote: >>> >> > do_reset() is not sup

Re: [U-Boot] [PATCH v2 0/6] tegra2: Add more clock/pinmux functionality

2011-09-26 Thread Simon Glass
Hi Albert, On Wed, Sep 21, 2011 at 3:40 PM, Simon Glass wrote: > This adds to the basic clock functionality already available. The concept > of a peripheral ID is introduced, and all peripheral clock access is done > using this ID. > > Functions are provided to start, query and adjust peripheral

Re: [U-Boot] [RFC PATCH v2 02/20] Fix use of int as pointer in image.c

2011-09-26 Thread Simon Glass
Hi, On Sun, Sep 25, 2011 at 10:00 PM, Mike Frysinger wrote: > Acked-by: Mike Frysinger > -mike > Thanks - quick question: I want to move this from RFC to normal patch in the next version - should I start at version 3 or version 1 for the header? Regards, Simon _

Re: [U-Boot] [RFC PATCH 04/20] sandbox: Add cpu files

2011-09-26 Thread Simon Glass
Hi Mike, On Sun, Sep 25, 2011 at 9:48 PM, Mike Frysinger wrote: > On Sunday, September 25, 2011 16:18:32 Simon Glass wrote: >> On Sun, Sep 25, 2011 at 12:25 PM, Wolfgang Denk wrote: >> > Simon Glass wrote: >> >> > do_reset() is not supposed to return >> >> >> >> I have adjusted the function meani

Re: [U-Boot] [RFC PATCH 06/20] sandbox: Allow board_init_f() and board_init_r() to return

2011-09-26 Thread Simon Glass
Hi Mike, On Sun, Sep 25, 2011 at 9:47 PM, Mike Frysinger wrote: > On Friday, September 23, 2011 11:55:11 Simon Glass wrote: >> On Sat, Sep 17, 2011 at 5:05 PM, Mike Frysinger wrote: >> > On Saturday, September 17, 2011 12:48:45 Simon Glass wrote: >> >> Since the sandbox architecture doesn't do re

  1   2   >