Re: [Twisted-Python] twisted.python.dist as a public API

On 7 August 2016 at 00:50, Glyph Lefkowitz wrote: [snip] > You always have to follow the compatibility process - if it's not a > security bug, we would have to change the process first :-). But if you > want to follow the exception path rather than the deprecation path (this > message doesn't

[Twisted-Python] INCOMPATIBLE CHANGE: twisted.python.dist renamed to twisted.python._setup

Hi, I would like to remove twisted.python.dist as a public API without following the 1 year deprecation processes. The module has a comment which informs people not to use it outside of Twisted, but I think it should be private module instead. The ticket is here https://twistedmatrix.com/trac/ti

Re: [Twisted-Python] twisted.python.dist as a public API

> On Aug 7, 2016, at 4:03 AM, Adi Roiban wrote: > > > > On 7 August 2016 at 00:50, Glyph Lefkowitz > wrote: > > [snip] > > You always have to follow the compatibility process - if it's not a security > bug, we would have to change the process first :-). Bu

Re: [Twisted-Python] INCOMPATIBLE CHANGE: twisted.python.dist renamed to twisted.python._setup

> On Aug 7, 2016, at 4:19 AM, Adi Roiban wrote: > > Hi, > > I would like to remove twisted.python.dist as a public API without following > the 1 year deprecation processes. > > The module has a comment which informs people not to use it outside of > Twisted, but I think it should be private

Re: [Twisted-Python] INCOMPATIBLE CHANGE: twisted.python.dist renamed to twisted.python._setup

On Sun, Aug 7, 2016 at 4:15 PM, Glyph Lefkowitz wrote: > > On Aug 7, 2016, at 4:19 AM, Adi Roiban wrote: > > Hi, > > I would like to remove twisted.python.dist as a public API without > following the 1 year deprecation processes. > > The module has a comment which informs people not to use it ou

Re: [Twisted-Python] INCOMPATIBLE CHANGE: twisted.python.dist renamed to twisted.python._setup

> On 8 Aug 2016, at 08:15, Craig Rodrigues wrote: > > > > On Sun, Aug 7, 2016 at 4:15 PM, Glyph Lefkowitz > wrote: > >> On Aug 7, 2016, at 4:19 AM, Adi Roiban > > wrote: >> >> Hi, >> >> I would like to remove twisted.python.dist as a p

Re: [Twisted-Python] INCOMPATIBLE CHANGE: twisted.python.dist renamed to twisted.python._setup

On Sun, Aug 7, 2016 at 5:25 PM, Amber "Hawkie" Brown < hawk...@atleastfornow.net> wrote: > > On 8 Aug 2016, at 08:15, Craig Rodrigues wrote: > > > > On Sun, Aug 7, 2016 at 4:15 PM, Glyph Lefkowitz > wrote: > >> >> On Aug 7, 2016, at 4:19 AM, Adi Roiban wrote: >> >> Hi, >> >> I would like to rem

Re: [Twisted-Python] INCOMPATIBLE CHANGE: twisted.python.dist renamed to twisted.python._setup

t.p.dist dates from 2005, and as far as I can tell, predates Twisted's code review system. It's an early mistake, but we can fix many mistakes in parallel. - Amber On 8 Aug 2016 08:36, "Craig Rodrigues" wrote: > > > On Sun, Aug 7, 2016 at 5:25 PM, Amber "Hawkie" Brown < > hawk...@atleastfornow.

Re: [Twisted-Python] INCOMPATIBLE CHANGE: twisted.python.dist renamed to twisted.python._setup

+1 from me On Mon, 8 Aug 2016 at 02:35 Craig Rodrigues wrote: > > I understand the motivation, but the time to have done this was when > dist.py > was originally reviewed. > > There are real problems in the Twisted code, and in the Twisted > infrastructure. > Focusing on something like this inst

Re: [Twisted-Python] INCOMPATIBLE CHANGE: twisted.python.dist renamed to twisted.python._setup

+1 from me as well. Depending directly on how twisted installs itself seems problematic. In my opinion, the more we discourage this practice the better. On Sun, Aug 7, 2016 at 8:00 PM Tristan Seligmann wrote: > +1 from me > > On Mon, 8 Aug 2016 at 02:35 Craig Rodrigues > wrote: > >> >> I unders

Re: [Twisted-Python] INCOMPATIBLE CHANGE: twisted.python.dist renamed to twisted.python._setup

> On Aug 7, 2016, at 5:35 PM, Craig Rodrigues wrote: > > I understand the motivation, but the time to have done this was when dist.py > was originally reviewed. It certainly would have been better :-). > There are real problems in the Twisted code, and in the Twisted > infrastructure. This i

Re: [Twisted-Python] INCOMPATIBLE CHANGE: twisted.python.dist renamed to twisted.python._setup

On Sun, Aug 7, 2016 at 11:01 PM, Glyph Lefkowitz wrote: > > This is also addressing a real problem. One of the *major* issues with > Twisted is *documentation noise*. Developers trying to use Twisted to > build things frequently complain about this: they look for an API to do > XYZ, and they se