Re: [trojita] Merge threading & sorting options

2013-09-13 Thread Pali Rohár
On Thursday 12 September 2013 16:08:08 Jan Kundrát wrote: > On Thursday, 12 September 2013 15:57:37 CEST, Pali Rohár wrote: > > -allIds.append(node.internalId); > > +allIds.append(offset+1); > > You're mixing ThreadNodeInfo::internalId which is an opaque > internal identifi

Re: [trojita] Merge threading & sorting options

2013-09-12 Thread Jan Kundrát
On Thursday, 12 September 2013 15:57:37 CEST, Pali Rohár wrote: -allIds.append(node.internalId); +allIds.append(offset+1); You're mixing ThreadNodeInfo::internalId which is an opaque internal identifier with some consecutive counter -- that won't work. @@ -498,6 +498

Re: [trojita] Merge threading & sorting options

2013-09-12 Thread Pali Rohár
On Tuesday 10 September 2013 10:41:41 Jan Kundrát wrote: > On Tuesday, 10 September 2013 10:20:24 CEST, Pali Rohár wrote: > > Yes, for this I prepared setting "gui/msgList.sortOrder". > > But IMAP function > > ThreadingMsgListModel::setUserWantsThreading(bool) is buggy > > when when is called, it c

Re: [trojita] Merge threading & sorting options

2013-09-10 Thread Jan Kundrát
On Tuesday, 10 September 2013 11:04:38 CEST, David Lang wrote: doesn't this depend on how much server-side support you have for sorting? Theoretically, yes -- CONTEXT=SORT makes this an extremely cheap operation. The problem is that *no IMAP server* that I know about supports ESORT. In pract

Re: [trojita] Merge threading & sorting options

2013-09-10 Thread David Lang
On Tue, 10 Sep 2013, Pali Roh?r wrote: On Tuesday 10 September 2013 10:01:52 Jan Kundr?t wrote: On Tuesday, 10 September 2013 08:59:54 CEST, Pali Roh?r wrote: Furthermore, the patch should respect the gui/msgList.showThreading option, not discard it. I'd like to store also sorting option, no

Re: [trojita] Merge threading & sorting options

2013-09-10 Thread Jan Kundrát
On Tuesday, 10 September 2013 10:20:24 CEST, Pali Rohár wrote: Sorry, but I want to have always sorted messages by date (unless threading is enabled) and I really do not want to click "sort by date" every time I start Trojita. I understand your preference, but the problem with this operation i

Re: [trojita] Merge threading & sorting options

2013-09-10 Thread Pali Rohár
On Tuesday 10 September 2013 10:01:52 Jan Kundrát wrote: > On Tuesday, 10 September 2013 08:59:54 CEST, Pali Rohár wrote: > >> Furthermore, the patch should respect the > >> gui/msgList.showThreading option, not discard it. > > > > I'd like to store also sorting option, not only true/false > > for

Re: [trojita] Merge threading & sorting options

2013-09-10 Thread Jan Kundrát
On Tuesday, 10 September 2013 08:59:54 CEST, Pali Rohár wrote: Furthermore, the patch should respect the gui/msgList.showThreading option, not discard it. I'd like to store also sorting option, not only true/false for threading. For this I created new setting "gui/msgList.sortBy" but not imp

Re: [trojita] Merge threading & sorting options

2013-09-10 Thread Pali Rohár
On Thursday 05 September 2013 14:37:19 Jan Kundrát wrote: > On Thursday, 29 August 2013 20:56:58 CEST, Pali Rohár wrote: > > in my pali-gsoc branch I moved threading option into sorting > > submenu as Jan described at review request 110903. Look and > > what do you think about it. > > Well, the pa

Re: [trojita] Merge threading & sorting options

2013-09-05 Thread Jan Kundrát
On Thursday, 29 August 2013 20:56:58 CEST, Pali Rohár wrote: in my pali-gsoc branch I moved threading option into sorting submenu as Jan described at review request 110903. Look and what do you think about it. Well, the patch removes a couple of comments saying that "threading and searching d

[trojita] Merge threading & sorting options

2013-08-29 Thread Pali Rohár
Hello, in my pali-gsoc branch I moved threading option into sorting submenu as Jan described at review request 110903. Look and what do you think about it. And I found bug in ThreadingMsgListModel::setUserWantsThreading() function. When it is called with false, then message sorting is switche