On Thursday 05 September 2013 14:37:19 Jan Kundrát wrote: > On Thursday, 29 August 2013 20:56:58 CEST, Pali Rohár wrote: > > in my pali-gsoc branch I moved threading option into sorting > > submenu as Jan described at review request 110903. Look and > > what do you think about it. > > Well, the patch removes a couple of comments saying that > "threading and searching doesn't play well together", but > does not actually address this problem. Right now, the > underlying model has a bug meaning that whenever threading is > enabled, search results *will be wrong*. The GUI code shall > therefore switch back to an unthreaded mode (preferably the > "no sorting, just by UIDs" one). Just try searching in > threaded mode, you'll see plenty of examples of what I mean. >
Fixed, Gui code now disable and reenable threading when searching. > Furthermore, the patch should respect the > gui/msgList.showThreading option, not discard it. > I'd like to store also sorting option, not only true/false for threading. For this I created new setting "gui/msgList.sortBy" but not implemented yet. > I also do not like the change from "&No sorting" to "&No > Sorting And Threading". > Reverted. -- Pali Rohár pali.ro...@gmail.com
signature.asc
Description: This is a digitally signed message part.
