Re: mod_webapp file changes for socket pools

2002-04-15 Thread simonkeary
Hi, Attached should be the updated socket pool changes to mod_webapp. I think I've incorporated the recommended changes. If you have any further comments just let me know Simon mod_webapp_update.zip Description: Zip compressed data -- To unsubscribe, e-mail:

Re: [Fwd: mod_webapp file changes for socket pools]

2002-04-12 Thread jean-frederic clere
[EMAIL PROTECTED] wrote: > Hi, > > I've done most of the changes suggested but am a little confused on a few points: > > warp_socket_pool current has the following features: > > 1) It implements a socket pool. > 2) The implementation is thread-safe (I think!) > 3) The implementation uses atomic

Re: [Fwd: mod_webapp file changes for socket pools]

2002-04-12 Thread simonkeary
Hi, I've done most of the changes suggested but am a little confused on a few points: warp_socket_pool current has the following features: 1) It implements a socket pool. 2) The implementation is thread-safe (I think!) 3) The implementation uses atomics. In a mt environment all features except

Re: mod_webapp file changes for socket pools

2002-04-11 Thread Pier Fumagalli
"[EMAIL PROTECTED]" <[EMAIL PROTECTED]> wrote: > Pier wrote: >> The only thing I don't like (much) is the name of the prototype functions: >> - warp_socket_pool_create >> - warp_socket_pool_acquire_socket >> - warp_socket_pool_return_socket >> >> And a lack of warp_socket_pool_destroy... >> >>

Re: mod_webapp file changes for socket pools

2002-04-11 Thread simonkeary
Pier wrote: > The only thing I don't like (much) is the name of the prototype functions: > - warp_socket_pool_create > - warp_socket_pool_acquire_socket > - warp_socket_pool_return_socket > > And a lack of warp_socket_pool_destroy... > > I would have called them > > - warp_sockpool_create > - w

Re: mod_webapp file changes for socket pools

2002-04-11 Thread Pier Fumagalli
"[EMAIL PROTECTED]" <[EMAIL PROTECTED]> wrote: > Hi, > > Attached should be the changes I made to implement socket pools within > mod_webapp. Looks _good_... > I've added a new file, pr_warp_socketpool.c, as suggested. Noticed :) > In the zip file are the complete, changed, versions of the f

mod_webapp file changes for socket pools

2002-04-11 Thread simonkeary
Hi, Attached should be the changes I made to implement socket pools within mod_webapp. I've added a new file, pr_warp_socketpool.c, as suggested. In the zip file are the complete, changed, versions of the files along with the output of diff -u. For each file I've saved the diff in filename.di