"[EMAIL PROTECTED]" <[EMAIL PROTECTED]> wrote:
> Hi,
>
> Attached should be the changes I made to implement socket pools within
> mod_webapp.
Looks _good_...
> I've added a new file, pr_warp_socketpool.c, as suggested.
Noticed :)
> In the zip file are the complete, changed, versions of the files along with
> the output of diff -u. For each file I've saved the diff in filename.diff.
Beautiful..
> If there are any changes suggested to I'll be happy to incorporate them and
> resend the changes..
The only thing I don't like (much) is the name of the prototype functions:
- warp_socket_pool_create
- warp_socket_pool_acquire_socket
- warp_socket_pool_return_socket
And a lack of warp_socket_pool_destroy...
I would have called them
- warp_sockpool_create
- warp_sockpool_acquire
- warp_sockpool_release
- warp_sockpool_destroy
FWIW, I'd like to review the whole thing APRizing it better (function names
and structures are still kinda crummy throughout the entire mod_webapp), but
I'm +1 on this addition...
One thing I'm thinking is wether we can #ifdef parts of it in case we don't
_need_ a socket pool, like in cases when we use 1.3 on UNIX, or 2.0 in
prefork, but I like it, I like it, I like it...
Pier
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
