"[EMAIL PROTECTED]" <[EMAIL PROTECTED]> wrote:
> Pier wrote:
>> The only thing I don't like (much) is the name of the prototype functions:
>> - warp_socket_pool_create
>> - warp_socket_pool_acquire_socket
>> - warp_socket_pool_return_socket
>>
>> And a lack of warp_socket_pool_destroy...
>>
>> I would have called them
>>
>> - warp_sockpool_create
>> - warp_sockpool_acquire
>> - warp_sockpool_release
>> - warp_sockpool_destroy
>>
>
> I'll change the function names and add a destroy function. For the destroy
> function I'm assuming you want:
>
> apr_status_t warp_sockpool_destroy(warp_socket_pool * pool)
> {
> return apr_thread_mutex_destroy(pool->pool_mutex);
> }
>
> Is this right? Am I missing something?
Yes, and as well closing all the sockets opened and remaining open in the
pool...
If you do a patch, can you simply post the output of
"cvs ..... diff -u3 /where/you/checked/out/webapp"
Things look easier to understand... :)
Pier (who has been reading way too many patches lately!)
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
