[PATCH] Re: JDK 1.4 Logging

2002-07-23 Thread Bob Herrmann
On Mon, 2002-07-22 at 14:18, [EMAIL PROTECTED] wrote: > > I think there is a simpler solution for this class of problems, and > that would also work with log4j and doesn't require _any_ API change. > ( only changes to the adapter implementations ) > > Any 'wrapper' will use: > factory=LogFact

Re: JDK 1.4 Logging

2002-07-22 Thread costinm
On 22 Jul 2002, Bob Herrmann wrote: > That is an interesting idea, although in my particular case, I walk > the stack a variable amount. Namely if the stack has method "log()" or > method "internalLog()" I keep unrolling the stack - this may not be > a great idea - but it gives good stack traces

Re: JDK 1.4 Logging

2002-07-22 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: > On 22 Jul 2002, Bob Herrmann wrote: > > >>This could be fixed by adding these methods to Log of commons-logger >> >> void trace(Object msg, Throwable thr, String className, String method); >> void debug(Object msg, Throwable thr, String className, String method); >> vo

Re: JDK 1.4 Logging

2002-07-22 Thread Bob Herrmann
On Mon, 2002-07-22 at 14:18, [EMAIL PROTECTED] wrote: >... > I think there is a simpler solution for this class of problems, and > that would also work with log4j and doesn't require _any_ API change. > ( only changes to the adapter implementations ) > > Any 'wrapper' will use: > factory=LogFa

Re: JDK 1.4 Logging

2002-07-22 Thread costinm
On 22 Jul 2002, Bob Herrmann wrote: > This could be fixed by adding these methods to Log of commons-logger > > void trace(Object msg, Throwable thr, String className, String method); > void debug(Object msg, Throwable thr, String className, String method); > void info(Object msg, Throwable th

Re: JDK 1.4 Logging

2002-07-22 Thread Bob Herrmann
On Mon, 2002-07-22 at 13:00, [EMAIL PROTECTED] wrote: > I'm close to -1 on this patch. > > I think the right long-term solution is to use commons-logging in > all tomcat and jasper, and stop defining our interfaces. > > I am +1 on fixing commons-logger, this will probably be > usefull for other

Re: JDK 1.4 Logging

2002-07-22 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: > I'm close to -1 on this patch. > > I think the right long-term solution is to use commons-logging in > all tomcat and jasper, and stop defining our interfaces. > > I am +1 on fixing commons-logger, this will probably be > usefull for other packages that switch to commo

Re: JDK 1.4 Logging

2002-07-22 Thread Bob Herrmann
On Mon, 2002-07-22 at 12:37, Remy Maucherat wrote: > > Assuming people actually like the JDK 1.4 logger and think it's useful, > I like that solution better (there are flags, use them). The JDK Logger is pretty cool. Although the default output is pretty plain. I use it with my own formatter. M

Re: JDK 1.4 Logging

2002-07-22 Thread costinm
I'm close to -1 on this patch. I think the right long-term solution is to use commons-logging in all tomcat and jasper, and stop defining our interfaces. I am +1 on fixing commons-logger, this will probably be usefull for other packages that switch to commons-logger. Costin On 22 Jul 2002, B

Re: JDK 1.4 Logging

2002-07-22 Thread Patrick Luby
Bob, That would work. I forgot that Remy now puts out a JDK 1.4 build of Tomcat and using the build flags would allow it to be picked up by users of the JDK 1.4 builds. Patrick Bob Herrmann wrote: > Humm... How about this instead (not that I am lazy)? > > $ cvs diff -u catalina/build.xml >

Re: JDK 1.4 Logging

2002-07-22 Thread Remy Maucherat
Bob Herrmann wrote: > Humm... How about this instead (not that I am lazy)? > > $ cvs diff -u catalina/build.xml > Index: catalina/build.xml > === > RCS file: /home/cvspublic/jakarta-tomcat-4.0/catalina/build.xml,v > retrieving revis

Re: JDK 1.4 Logging

2002-07-22 Thread Bob Herrmann
Humm... How about this instead (not that I am lazy)? $ cvs diff -u catalina/build.xml Index: catalina/build.xml === RCS file: /home/cvspublic/jakarta-tomcat-4.0/catalina/build.xml,v retrieving revision 1.124 diff -u -r1.124 build.x

Re: JDK 1.4 Logging

2002-07-22 Thread Patrick Luby
Bob, This is a useful piece of code. However, your patch can't go into Tomcat as it will only compile with JDK 1.4. The standard builds of Tomcat that are downloadable from the jakarta.apache.org are built using JDK 1.3 and should be run without crashing Tomcat on JDK 1.2. So, if you would li

RE: JDK 1.4 Logging

2002-07-22 Thread Bob Herrmann
On Mon, 2002-07-22 at 12:12, David Oxley wrote: > Why does Tomcat not use Log4j for its logging? Some parts of Tomcat do use Log4j, other parts do not. I think this is because different people have just chosen whatever they felt was handy. Tomcat doesn't yet have a unified logging strategy. I

RE: JDK 1.4 Logging

2002-07-22 Thread David Oxley
Why does Tomcat not use Log4j for its logging? Dave. > -Original Message- > From: Bob Herrmann [mailto:[EMAIL PROTECTED]] > Sent: 22 July 2002 15:51 > To: Tomcat Developers List > Subject: JDK 1.4 Logging > > > Hi. I am trying to get Tomcat to log to JDK1.4's logging. > > I tried imp