I'm close to -1 on this patch. I think the right long-term solution is to use commons-logging in all tomcat and jasper, and stop defining our interfaces.
I am +1 on fixing commons-logger, this will probably be usefull for other packages that switch to commons-logger. Costin On 22 Jul 2002, Bob Herrmann wrote: > > Hi. I am trying to get Tomcat to log to JDK1.4's logging. > > I tried implementing a "o.a.c.logging.Logger" subclass that forwarded > calls to commons-logging Log. This was unsatisfying because the > commons-logger unrolls the stack and logs the "class.method" of my > logger, not my logger's caller. > > I was tempted to change the commons-logger to allow for specifying > a class and method on all its methods, but that would be a large > change the commons-logger (involving changes and decisions about > how this new information should be pushed down and handled with > the other loggers it supports.) There is also some issues mapping > tomcat verbosity levels, to common-logger log levels and then to JDK > Logger levels. > > So I punted and implemented the code below. It is a > "o.a.c.logging.Logger" which writes directly to JDK 1.4 Logging. > It allowed me to unroll the stack in a way that fits well with > tomcat (ignoring stack frames calling with method log() or method > internalLog() which are uninteresting.) And allowed me to map > verbosity to JDK Levels. > > Cheers, > -bob > > > -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
