On Mon, 2002-07-22 at 13:00, [EMAIL PROTECTED] wrote:
> I'm close to -1 on this patch.
>
> I think the right long-term solution is to use commons-logging in
> all tomcat and jasper, and stop defining our interfaces.
>
> I am +1 on fixing commons-logger, this will probably be
> usefull for other packages that switch to commons-logger.
I agree. I originally implemented a commons-logger logger, but
the result wasn't very satisfying. Mostly when the commons-logger
uses JDK1.4 it always shows my logger's class and method name.
This could be fixed by adding these methods to Log of commons-logger
void trace(Object msg, Throwable thr, String className, String method);
void debug(Object msg, Throwable thr, String className, String method);
void info(Object msg, Throwable thr, String className, String method);
void warn(Object msg, Throwable thr, String className, String method);
void error(Object msg, Throwable thr, String className, String method);
void fatal(Object msg, Throwable thr, String className, String method);
Although, the bigger problem is all the Loggers have unique features
and trying to squeeze them through the commons-logger API is going to
result in impedance mismatch. Not sure what to do about this.
I can take stab at this little change (although it means touching
just about every class in commons-logging.) Is it worth it? Votes?
Cheers,
-bob
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
