[logging] [PATCH] JDK 1.4 Logging

2002-07-23 Thread Bob Herrmann
On Tue, 2002-07-23 at 15:03, Bob Herrmann wrote: > On Mon, 2002-07-22 at 14:18, [EMAIL PROTECTED] wrote: > > > > I think there is a simpler solution for this class of problems, and > > that would also work with log4j and doesn't require _any_ API change. > > ( only changes to the adapter implem

[PATCH] Re: JDK 1.4 Logging

2002-07-23 Thread Bob Herrmann
On Mon, 2002-07-22 at 14:18, [EMAIL PROTECTED] wrote: > > I think there is a simpler solution for this class of problems, and > that would also work with log4j and doesn't require _any_ API change. > ( only changes to the adapter implementations ) > > Any 'wrapper' will use: > factory=LogFact

Re: JDK 1.4 Logging

2002-07-22 Thread costinm
On 22 Jul 2002, Bob Herrmann wrote: > That is an interesting idea, although in my particular case, I walk > the stack a variable amount. Namely if the stack has method "log()" or > method "internalLog()" I keep unrolling the stack - this may not be > a great idea - but it gives good stack traces

Re: JDK 1.4 Logging

2002-07-22 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: > On 22 Jul 2002, Bob Herrmann wrote: > > >>This could be fixed by adding these methods to Log of commons-logger >> >> void trace(Object msg, Throwable thr, String className, String method); >> void debug(Object msg, Throwable thr, String className, String method); >> vo

Re: JDK 1.4 Logging

2002-07-22 Thread Bob Herrmann
On Mon, 2002-07-22 at 14:18, [EMAIL PROTECTED] wrote: >... > I think there is a simpler solution for this class of problems, and > that would also work with log4j and doesn't require _any_ API change. > ( only changes to the adapter implementations ) > > Any 'wrapper' will use: > factory=LogFa

Re: JDK 1.4 Logging

2002-07-22 Thread costinm
On 22 Jul 2002, Bob Herrmann wrote: > This could be fixed by adding these methods to Log of commons-logger > > void trace(Object msg, Throwable thr, String className, String method); > void debug(Object msg, Throwable thr, String className, String method); > void info(Object msg, Throwable th

Re: JDK 1.4 Logging

2002-07-22 Thread Bob Herrmann
On Mon, 2002-07-22 at 13:00, [EMAIL PROTECTED] wrote: > I'm close to -1 on this patch. > > I think the right long-term solution is to use commons-logging in > all tomcat and jasper, and stop defining our interfaces. > > I am +1 on fixing commons-logger, this will probably be > usefull for other

Re: JDK 1.4 Logging

2002-07-22 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: > I'm close to -1 on this patch. > > I think the right long-term solution is to use commons-logging in > all tomcat and jasper, and stop defining our interfaces. > > I am +1 on fixing commons-logger, this will probably be > usefull for other packages that switch to commo

Re: JDK 1.4 Logging

2002-07-22 Thread Bob Herrmann
On Mon, 2002-07-22 at 12:37, Remy Maucherat wrote: > > Assuming people actually like the JDK 1.4 logger and think it's useful, > I like that solution better (there are flags, use them). The JDK Logger is pretty cool. Although the default output is pretty plain. I use it with my own formatter. M

Re: JDK 1.4 Logging

2002-07-22 Thread costinm
s about > how this new information should be pushed down and handled with > the other loggers it supports.) There is also some issues mapping > tomcat verbosity levels, to common-logger log levels and then to JDK > Logger levels. > > So I punted and implemented the code below. It i

Re: JDK 1.4 Logging

2002-07-22 Thread Patrick Luby
he commons-logger to allow for specifying >>>a class and method on all its methods, but that would be a large >>>change the commons-logger (involving changes and decisions about >>>how this new information should be pushed down and handled with >>>the other loggers it

Re: JDK 1.4 Logging

2002-07-22 Thread Remy Maucherat
Bob Herrmann wrote: > Humm... How about this instead (not that I am lazy)? > > $ cvs diff -u catalina/build.xml > Index: catalina/build.xml > === > RCS file: /home/cvspublic/jakarta-tomcat-4.0/catalina/build.xml,v > retrieving revis

Re: JDK 1.4 Logging

2002-07-22 Thread Bob Herrmann
that would be a large > > change the commons-logger (involving changes and decisions about > > how this new information should be pushed down and handled with > > the other loggers it supports.) There is also some issues mapping > > tomcat verbosity levels, to common-logger l

Re: JDK 1.4 Logging

2002-07-22 Thread Patrick Luby
> how this new information should be pushed down and handled with > the other loggers it supports.) There is also some issues mapping > tomcat verbosity levels, to common-logger log levels and then to JDK > Logger levels. > > So I punted and implemented the code below. It is a &g

RE: JDK 1.4 Logging

2002-07-22 Thread Bob Herrmann
s, -bob > > Dave. > > > -Original Message- > > From: Bob Herrmann [mailto:[EMAIL PROTECTED]] > > Sent: 22 July 2002 15:51 > > To: Tomcat Developers List > > Subject: JDK 1.4 Logging > > > > > > Hi. I am trying to get Tomcat to log to JDK1.4

RE: JDK 1.4 Logging

2002-07-22 Thread David Oxley
Why does Tomcat not use Log4j for its logging? Dave. > -Original Message- > From: Bob Herrmann [mailto:[EMAIL PROTECTED]] > Sent: 22 July 2002 15:51 > To: Tomcat Developers List > Subject: JDK 1.4 Logging > > > Hi. I am trying to get Tomcat to log to JDK1.4

JDK 1.4 Logging

2002-07-22 Thread Bob Herrmann
r loggers it supports.) There is also some issues mapping tomcat verbosity levels, to common-logger log levels and then to JDK Logger levels. So I punted and implemented the code below. It is a "o.a.c.logging.Logger" which writes directly to JDK 1.4 Logging. It allowed me to unroll the s