svn commit: r242257 - head/sys/netinet

2012-10-28 Thread Andre Oppermann
Author: andre Date: Sun Oct 28 18:45:04 2012 New Revision: 242257 URL: http://svn.freebsd.org/changeset/base/242257 Log: Remove bogus 'else' in #ifdef that prevented the rttvar from being reset tcp_timer_rexmt() on retransmit for IPv6 sessions. MFC after:2 weeks Modified: head/sys/

svn commit: r242260 - head/sys/netinet

2012-10-28 Thread Andre Oppermann
Author: andre Date: Sun Oct 28 18:56:57 2012 New Revision: 242260 URL: http://svn.freebsd.org/changeset/base/242260 Log: When retransmitting SYN in TCPS_SYN_SENT state use TCPTV_RTOBASE, the default retransmit timeout, as base to calculate the backoff time until next try instead of the TCP_R

svn commit: r242261 - head/sys/netinet

2012-10-28 Thread Andre Oppermann
Author: andre Date: Sun Oct 28 19:02:07 2012 New Revision: 242261 URL: http://svn.freebsd.org/changeset/base/242261 Log: For retransmits of SYN|ACK from the syncache use the slightly more aggressive special tcp_syn_backoff[] retransmit schedule instead of the normal tcp_backoff[] schedule fo

svn commit: r242262 - head/sys/netinet

2012-10-28 Thread Andre Oppermann
Author: andre Date: Sun Oct 28 19:16:22 2012 New Revision: 242262 URL: http://svn.freebsd.org/changeset/base/242262 Log: Simplify and enhance the window change/update acceptance logic, especially in the presence of bi-directional data transfers. snd_wl1 tracks the right edge, including da

svn commit: r242263 - head/sys/netinet

2012-10-28 Thread Andre Oppermann
Author: andre Date: Sun Oct 28 19:20:23 2012 New Revision: 242263 URL: http://svn.freebsd.org/changeset/base/242263 Log: Add SACK_PERMIT to the list of TCP options that are switched off after retransmitting a SYN three times. MFC after:2 weeks Modified: head/sys/netinet/tcp_timer.c

svn commit: r242264 - head/sys/netinet

2012-10-28 Thread Andre Oppermann
Author: andre Date: Sun Oct 28 19:22:18 2012 New Revision: 242264 URL: http://svn.freebsd.org/changeset/base/242264 Log: Update comment to reflect the change made in r242263. MFC after:2 weeks Modified: head/sys/netinet/tcp_timer.c Modified: head/sys/netinet/tcp_timer.c

svn commit: r242266 - head/sys/netinet

2012-10-28 Thread Andre Oppermann
Author: andre Date: Sun Oct 28 19:47:46 2012 New Revision: 242266 URL: http://svn.freebsd.org/changeset/base/242266 Log: Increase the initial CWND to 10 segments as defined in IETF TCPM draft-ietf-tcpm-initcwnd-05. It explains why the increased initial window improves the overall performance

svn commit: r242267 - head/sys/netinet

2012-10-28 Thread Andre Oppermann
Author: andre Date: Sun Oct 28 19:58:20 2012 New Revision: 242267 URL: http://svn.freebsd.org/changeset/base/242267 Log: If the user has closed the socket then drop a persisting connection after a much reduced timeout. Typically web servers close their sockets quickly under the assumption

Re: svn commit: r242254 - head/sys/netinet

2012-10-28 Thread Andre Oppermann
On 28.10.2012 21:07, Gleb Smirnoff wrote: On Sun, Oct 28, 2012 at 06:07:34PM +, Andre Oppermann wrote: A> @@ -296,8 +297,8 @@ syncache_destroy(void) A> mtx_destroy(&sch->sch_mtx); A> } A> A> - KASSERT(V_tcp_syncache.cache_count == 0, ("%s: cache_count %

Re: svn commit: r242161 - in head/sys: net netinet netpfil/pf

2012-10-28 Thread Andre Oppermann
On 28.10.2012 00:01, Gleb Smirnoff wrote: On Sat, Oct 27, 2012 at 12:58:52PM +0200, Andre Oppermann wrote: A> On 26.10.2012 23:06, Gleb Smirnoff wrote: A> > Author: glebius A> > Date: Fri Oct 26 21:06:33 2012 A> > New Revision: 242161 A> > URL: http://svn.freebsd.org/c

Re: svn commit: r242266 - head/sys/netinet

2012-10-28 Thread Andre Oppermann
On 28.10.2012 22:03, Rui Paulo wrote: On 28 Oct 2012, at 12:47, Andre Oppermann wrote: Author: andre Date: Sun Oct 28 19:47:46 2012 New Revision: 242266 URL: http://svn.freebsd.org/changeset/base/242266 Log: Increase the initial CWND to 10 segments as defined in IETF TCPM draft-ietf-tcpm

Re: svn commit: r242263 - head/sys/netinet

2012-10-28 Thread Andre Oppermann
On 28.10.2012 22:26, Rui Paulo wrote: On 28 Oct 2012, at 12:20, Andre Oppermann wrote: Author: andre Date: Sun Oct 28 19:20:23 2012 New Revision: 242263 URL: http://svn.freebsd.org/changeset/base/242263 Log: Add SACK_PERMIT to the list of TCP options that are switched off after

Re: svn commit: r242261 - head/sys/netinet

2012-10-28 Thread Andre Oppermann
On 28.10.2012 22:34, Rui Paulo wrote: On 28 Oct 2012, at 12:02, Andre Oppermann wrote: Author: andre Date: Sun Oct 28 19:02:07 2012 New Revision: 242261 URL: http://svn.freebsd.org/changeset/base/242261 Log: For retransmits of SYN|ACK from the syncache use the slightly more aggressive

Re: svn commit: r242261 - head/sys/netinet

2012-10-28 Thread Andre Oppermann
On 28.10.2012 23:01, Rui Paulo wrote: On Oct 28, 2012, at 14:56, Andre Oppermann wrote: On 28.10.2012 22:34, Rui Paulo wrote: On 28 Oct 2012, at 12:02, Andre Oppermann wrote: Author: andre Date: Sun Oct 28 19:02:07 2012 New Revision: 242261 URL: http://svn.freebsd.org/changeset/base

Re: svn commit: r242266 - head/sys/netinet

2012-10-28 Thread Andre Oppermann
On 28.10.2012 22:44, Rui Paulo wrote: On 28 Oct 2012, at 14:33, Andre Oppermann wrote: IW10 has been heavily discussed on IETF TCPM. A lot of research on the impact has been done and the overall result has been a significant improvement with very little downside. Linux has adopted it for

Re: svn commit: r242161 - in head/sys: net netinet netpfil/pf

2012-10-29 Thread Andre Oppermann
On 29.10.2012 22:40, YongHyeon PYUN wrote: On Mon, Oct 29, 2012 at 09:21:00AM +0400, Gleb Smirnoff wrote: On Mon, Oct 29, 2012 at 01:41:04PM -0700, YongHyeon PYUN wrote: Y> On Sun, Oct 28, 2012 at 02:01:37AM +0400, Gleb Smirnoff wrote: Y> > On Sat, Oct 27, 2012 at 12:58:52PM +02

svn commit: r242306 - head/sys/kern

2012-10-29 Thread Andre Oppermann
Author: andre Date: Mon Oct 29 12:14:57 2012 New Revision: 242306 URL: http://svn.freebsd.org/changeset/base/242306 Log: Add logging for socket attach failures in sonewconn() during accept(2). Include the pointer to the PCB so it can be attributed to a particular application by corresponding

svn commit: r242308 - head/sys/netinet

2012-10-29 Thread Andre Oppermann
Author: andre Date: Mon Oct 29 12:17:02 2012 New Revision: 242308 URL: http://svn.freebsd.org/changeset/base/242308 Log: Define the delayed ACK timeout value directly as hz/10 instead of obfuscating it by going through PR_FASTHZ. No functional change. MFC after:2 weeks Modified: h

svn commit: r242309 - head/sys/kern

2012-10-29 Thread Andre Oppermann
Author: andre Date: Mon Oct 29 12:31:12 2012 New Revision: 242309 URL: http://svn.freebsd.org/changeset/base/242309 Log: In soreceive_stream() don't drop an already dequeued mbuf chain by overwriting the return mbuf pointer with newly received data after a loop. Instead append the new mbuf

svn commit: r242311 - head/sys/netinet

2012-10-29 Thread Andre Oppermann
Author: andre Date: Mon Oct 29 13:16:33 2012 New Revision: 242311 URL: http://svn.freebsd.org/changeset/base/242311 Log: Forced commit to provide the correct commit message to r242251: Defer sending an independent window update if a delayed ACK is pending saving a packet. The window

Re: svn commit: r242251 - head/sys/netinet

2012-10-29 Thread Andre Oppermann
On 28.10.2012 18:30, Andre Oppermann wrote: Author: andre Date: Sun Oct 28 17:30:28 2012 New Revision: 242251 URL: http://svn.freebsd.org/changeset/base/242251 Log: When SYN or SYN/ACK had to be retransmitted RFC5681 requires us to reduce the initial CWND to one segment. This reduction

Re: svn commit: r242161 - in head/sys: net netinet netpfil/pf

2012-10-31 Thread Andre Oppermann
On 30.10.2012 03:25, YongHyeon PYUN wrote: On Mon, Oct 29, 2012 at 09:20:59AM +0100, Andre Oppermann wrote: On 29.10.2012 22:40, YongHyeon PYUN wrote: On Mon, Oct 29, 2012 at 09:21:00AM +0400, Gleb Smirnoff wrote: On Mon, Oct 29, 2012 at 01:41:04PM -0700, YongHyeon PYUN wrote: Y> On Sun,

Re: svn commit: r242402 - in head/sys: kern vm

2012-10-31 Thread Andre Oppermann
On 31.10.2012 20:40, Ian Lepore wrote: On Thu, 2012-11-01 at 06:30 +1100, Peter Jeremy wrote: On 2012-Oct-31 18:57:37 +, Attilio Rao wrote: On 10/31/12, Adrian Chadd wrote: Right, but you didn't make it configurable for us embedded peeps who still care about memory usage. How is this p

Re: svn commit: r242402 - in head/sys: kern vm

2012-10-31 Thread Andre Oppermann
On 31.10.2012 19:10, Attilio Rao wrote: On Wed, Oct 31, 2012 at 6:07 PM, Attilio Rao wrote: Author: attilio Date: Wed Oct 31 18:07:18 2012 New Revision: 242402 URL: http://svn.freebsd.org/changeset/base/242402 Log: Rework the known mutexes to benefit about staying on their own cache line

Re: svn commit: r242402 - in head/sys: kern vm

2012-11-01 Thread Andre Oppermann
On 01.11.2012 12:53, Attilio Rao wrote: On 10/31/12, Andre Oppermann wrote: On 31.10.2012 19:10, Attilio Rao wrote: On Wed, Oct 31, 2012 at 6:07 PM, Attilio Rao wrote: Author: attilio Date: Wed Oct 31 18:07:18 2012 New Revision: 242402 URL: http://svn.freebsd.org/changeset/base/242402 Log

Re: svn commit: r242421 - head/sys/dev/ixgbe

2012-11-01 Thread Andre Oppermann
On 01.11.2012 00:50, Jack F Vogel wrote: Author: jfv Date: Wed Oct 31 23:50:36 2012 New Revision: 242421 URL: http://svn.freebsd.org/changeset/base/242421 Log: A few important fixes: - Testing TSO6 has led me to discover that HW RSC is a problematic feature, it is ONLY designed to

svn commit: r242601 - head/sys/netinet

2012-11-05 Thread Andre Oppermann
Author: andre Date: Mon Nov 5 09:13:06 2012 New Revision: 242601 URL: http://svnweb.freebsd.org/changeset/base/242601 Log: Back out r242262. The simplified window change/update logic wasn't complete and ready for production use. PR: kern/173309 Modified: head/sys/netinet/tcp_input.

Re: svn commit: r242029 - head/sys/kern

2012-11-08 Thread Andre Oppermann
On 08.11.2012 08:46, Peter Wemm wrote: On Wed, Nov 7, 2012 at 10:24 PM, Alfred Perlstein wrote: [[ + peter ]] Folks, I spent quite a bit of time trying to figure out how to resolve maxusers scaling in a happy way for all. I think I came up with a solution. This solution should work for i386,

Re: svn commit: r242847 - in head/sys: i386/include kern

2012-11-10 Thread Andre Oppermann
On 10.11.2012 19:04, Peter Wemm wrote: On Sat, Nov 10, 2012 at 9:48 AM, Eitan Adler wrote: On 10 November 2012 12:45, Peter Wemm wrote: On Sat, Nov 10, 2012 at 9:33 AM, Eitan Adler wrote: On 10 November 2012 12:04, Alfred Perlstein wrote: Sure, if you'd like you can help me craft that com

Re: svn commit: r242847 - in head/sys: i386/include kern

2012-11-10 Thread Andre Oppermann
On 10.11.2012 23:24, Alfred Perlstein wrote: On 11/10/12 11:18 AM, Andre Oppermann wrote: On 10.11.2012 19:04, Peter Wemm wrote: This is complicated but we need a simple user visible view of it. It really needs to be something like "nmbclusters defaults to 6% of physical ram, with ma

Re: svn commit: r242941 - in head/sys: sys vm

2012-11-12 Thread Andre Oppermann
On 13.11.2012 03:50, Alan Cox wrote: Author: alc Date: Tue Nov 13 02:50:39 2012 New Revision: 242941 URL: http://svnweb.freebsd.org/changeset/base/242941 Log: Replace the single, global page queues lock with per-queue locks on the active and inactive paging queues. Hear hear! Now if onl

Re: svn commit: r240494 - in head: contrib/pf/man contrib/pf/pfctl include sbin/pfctl sbin/pfctl/missing share/man/man4 share/man/man5 sys/conf sys/contrib/pf sys/modules/dummynet sys/modules/ipfw sys

2012-11-13 Thread Andre Oppermann
On 13.11.2012 10:17, Gleb Smirnoff wrote: On Mon, Nov 12, 2012 at 06:11:40PM -0800, David O'Brien wrote: D> On Fri, Sep 14, 2012 at 11:51:51AM +, Gleb Smirnoff wrote: D> > Log: D> > o Create directory sys/netpfil, where all packet filters should D> > reside, and move there ipfw(4) and p

svn commit: r242998 - head/share/man/man9

2012-11-13 Thread Andre Oppermann
Author: andre Date: Tue Nov 13 20:52:17 2012 New Revision: 242998 URL: http://svnweb.freebsd.org/changeset/base/242998 Log: Remove description of deprecated IP fragment checksum support. Since SMPng it wasn't really supported anymore and if it worked then only by chance. Only very few drive

Re: svn commit: r243019 - head/sbin/route

2012-11-14 Thread Andre Oppermann
On 14.11.2012 09:05, Gleb Smirnoff wrote: Author: glebius Date: Wed Nov 14 08:05:21 2012 New Revision: 243019 URL: http://svnweb.freebsd.org/changeset/base/243019 Log: Remove remnants of classful addressing. These magic transformations of supplied arguments is not what a modern sysadmin ex

svn commit: r243147 - head/usr.bin/fetch

2012-11-16 Thread Andre Oppermann
Author: andre Date: Fri Nov 16 12:05:10 2012 New Revision: 243147 URL: http://svnweb.freebsd.org/changeset/base/243147 Log: Change fetch(1) to: o Report the instantaneous bandwidth instead of an average since the beginning of the download. o At the finish of the download report the

Re: svn commit: r242847 - in head/sys: i386/include kern

2012-11-18 Thread Andre Oppermann
On 18.11.2012 15:05, Andrey Zonov wrote: On 11/11/12 3:04 AM, Andre Oppermann wrote: On 10.11.2012 23:24, Alfred Perlstein wrote: On 11/10/12 11:18 AM, Andre Oppermann wrote: On 10.11.2012 19:04, Peter Wemm wrote: This is complicated but we need a simple user visible view of it. It really

svn commit: r243621 - head/sys/netinet

2012-11-27 Thread Andre Oppermann
Author: andre Date: Tue Nov 27 19:07:28 2012 New Revision: 243621 URL: http://svnweb.freebsd.org/changeset/base/243621 Log: Add DELACK to list of timers. MFC after:1 week Modified: head/sys/netinet/tcp_timer.h Modified: head/sys/netinet/tcp_timer.h ==

svn commit: r243624 - in head/sys: dev/bce dev/bxe net netinet sys

2012-11-27 Thread Andre Oppermann
Author: andre Date: Tue Nov 27 19:31:49 2012 New Revision: 243624 URL: http://svnweb.freebsd.org/changeset/base/243624 Log: Remove unused and unnecessary CSUM_IP_FRAGS checksumming capability. Checksumming the IP header of fragments is no different from doing normal IP headers. Discusse

svn commit: r243627 - head/sys/kern

2012-11-27 Thread Andre Oppermann
Author: andre Date: Tue Nov 27 20:04:52 2012 New Revision: 243627 URL: http://svnweb.freebsd.org/changeset/base/243627 Log: Fix a race on listen socket teardown where while draining the accept queues a new socket/connection may be added to the queue due to a race on the ACCEPT_LOCK. The

svn commit: r243628 - head/sys/sys

2012-11-27 Thread Andre Oppermann
Author: andre Date: Tue Nov 27 20:16:01 2012 New Revision: 243628 URL: http://svnweb.freebsd.org/changeset/base/243628 Log: Update comment to prefer M_NOWAIT over M_DONTWAIT and M_WAITOK over M_WAIT. MFC after:1 week Modified: head/sys/sys/mbuf.h Modified: head/sys/sys/mbuf.h

svn commit: r243631 - in head/sys: kern sys

2012-11-27 Thread Andre Oppermann
Author: andre Date: Tue Nov 27 21:19:58 2012 New Revision: 243631 URL: http://svnweb.freebsd.org/changeset/base/243631 Log: Base the mbuf related limits on the available physical memory or kernel memory, whichever is lower. The overall mbuf related memory limit must be set so that mbufs (an

Re: svn commit: r243594 - head/sys/netinet

2012-11-27 Thread Andre Oppermann
On 27.11.2012 04:04, Alfred Perlstein wrote: Author: alfred Date: Tue Nov 27 03:04:24 2012 New Revision: 243594 URL: http://svnweb.freebsd.org/changeset/base/243594 Log: Auto size the tcbhashsize structure based on max sockets. While here, also make the code that enforces power-of-two mor

svn commit: r243638 - head/sys/kern

2012-11-27 Thread Andre Oppermann
Author: andre Date: Tue Nov 27 22:35:48 2012 New Revision: 243638 URL: http://svnweb.freebsd.org/changeset/base/243638 Log: Fix r243627 by testing against the head socket instead of the socket just created. MFC after:1 week X-MFC-with: r243627 Modified: head/sys/kern/uipc_socke

Re: svn commit: r243627 - head/sys/kern

2012-11-27 Thread Andre Oppermann
12:04 PM, Andre Oppermann wrote: Author: andre Date: Tue Nov 27 20:04:52 2012 New Revision: 243627 URL: http://svnweb.freebsd.org/changeset/base/243627 Log: Fix a race on listen socket teardown where while draining the accept queues a new socket/connection may be added to the queue due

Re: svn commit: r243627 - head/sys/kern

2012-11-27 Thread Andre Oppermann
On 27.11.2012 23:48, Robert Watson wrote: On Tue, 27 Nov 2012, Andre Oppermann wrote: On 27.11.2012 23:35, Peter Wemm wrote: Andre.. this breaks incoming connections. TCP is immediately reset and never even gets to the listener process. You need to back out of fix this urgently please

svn commit: r243639 - head/sys/kern

2012-11-27 Thread Andre Oppermann
Author: andre Date: Tue Nov 27 23:16:56 2012 New Revision: 243639 URL: http://svnweb.freebsd.org/changeset/base/243639 Log: Complete r243631 by applying the remainder of kern_mbuf.c that got lost while merging into the commit tree. MFC after:1 month X-MFC-with: r243631 Modified:

Re: svn commit: r243639 - head/sys/kern

2012-11-27 Thread Andre Oppermann
On 28.11.2012 00:16, Andre Oppermann wrote: Author: andre Date: Tue Nov 27 23:16:56 2012 New Revision: 243639 URL: http://svnweb.freebsd.org/changeset/base/243639 Log: Complete r243631 by applying the remainder of kern_mbuf.c that got lost while merging into the commit tree. Please note

Re: svn commit: r243627 - head/sys/kern

2012-11-27 Thread Andre Oppermann
On 28.11.2012 00:05, Robert N. M. Watson wrote: On 27 Nov 2012, at 22:54, Andre Oppermann wrote: Andre.. this breaks incoming connections. TCP is immediately reset and never even gets to the listener process. You need to back out of fix this urgently please. I just found out and fixed it

Re: svn commit: r243627 - head/sys/kern

2012-11-28 Thread Andre Oppermann
On 28.11.2012 00:59, Robert N. M. Watson wrote: On 27 Nov 2012, at 23:29, Andre Oppermann wrote: Andre.. this breaks incoming connections. TCP is immediately reset and never even gets to the listener process. You need to back out of fix this urgently please. I just found out and fixed it

Re: svn commit: r243631 - in head/sys: kern sys

2012-11-28 Thread Andre Oppermann
On 28.11.2012 18:37, Alan Cox wrote: I'm pretty sure that the "realmem" calculation is going to overflow on i386/PAE, where the number of bytes of physical memory is greater than the type long can represent. Right. long == int on i386/PAE, not LP64. Is uint64_t the correct type to use to catc

Re: svn commit: r243631 - in head/sys: kern sys

2012-11-28 Thread Andre Oppermann
On 28.11.2012 22:45, Bruce Evans wrote: On Wed, 28 Nov 2012, Alan Cox wrote: I'm pretty sure that the "realmem" calculation is going to overflow on i386/PAE, where the number of bytes of physical memory is greater than the type long can represent. It overflows on i386 even without PAE, where

Re: svn commit: r243631 - in head/sys: kern sys

2012-11-28 Thread Andre Oppermann
On 29.11.2012 00:14, Bruce Evans wrote: On Wed, 28 Nov 2012, Andre Oppermann wrote: On 28.11.2012 18:37, Alan Cox wrote: I'm pretty sure that the "realmem" calculation is going to overflow on i386/PAE, where the number of bytes of physical memory is greater than the type lon

Re: svn commit: r243627 - head/sys/kern

2012-11-28 Thread Andre Oppermann
On 29.11.2012 01:35, Vijay Singh wrote: a sign of poor prior testing and too much trust into the submitter of the patch it wasn't an earth shattering event. Doesn't distract from Andre, I am really quite disappointed to read this from you. The patch I sent you was fine, and has been well teste

svn commit: r243668 - in head/sys: kern sys

2012-11-28 Thread Andre Oppermann
Author: andre Date: Thu Nov 29 07:30:42 2012 New Revision: 243668 URL: http://svnweb.freebsd.org/changeset/base/243668 Log: Using a long is the wrong type to represent the realmem and maxmbufmem variable as they may overflow on i386/PAE and i386 with > 2GB RAM. Use 64bit quad_t instead.

Re: svn commit: r243714 - in head/sys/dev: ixgbe netmap

2012-12-01 Thread Andre Oppermann
On 01.12.2012 10:48, Jack Vogel wrote: On Sat, Dec 1, 2012 at 12:40 AM, Andre Oppermann mailto:an...@freebsd.org>> wrote: On 30.11.2012 23:19, Jack F Vogel wrote: Author: jfv Date: Fri Nov 30 22:19:18 2012 New Revision: 243714 URL

Re: svn commit: r243631 - in head/sys: kern sys

2012-12-07 Thread Andre Oppermann
On 07.12.2012 10:36, Oleksandr Tymoshenko wrote: On 2012-11-27, at 1:19 PM, Andre Oppermann wrote: Author: andre Date: Tue Nov 27 21:19:58 2012 New Revision: 243631 URL: http://svnweb.freebsd.org/changeset/base/243631 Log: Base the mbuf related limits on the available physical memory or

Re: svn commit: r243594 - head/sys/netinet

2012-12-07 Thread Andre Oppermann
On 28.11.2012 04:04, Alfred Perlstein wrote: On 11/27/12 2:12 PM, Andre Oppermann wrote: On 27.11.2012 04:04, Alfred Perlstein wrote: Author: alfred Date: Tue Nov 27 03:04:24 2012 New Revision: 243594 URL: http://svnweb.freebsd.org/changeset/base/243594 Log: Auto size the tcbhashsize

Re: svn commit: r243594 - head/sys/netinet

2012-12-07 Thread Andre Oppermann
fast path. User friendliness would be to either not have to worry about this at all or to update the related and relevant man pages like tuning(7). Users are unlikely to even find the right place to look for in the source code. -- Andre Sent from my iPhone On Dec 7, 2012, at 7:06 AM, Andre

Re: svn commit: r243631 - in head/sys: kern sys

2012-12-07 Thread Andre Oppermann
On 07.12.2012 22:05, Oleksandr Tymoshenko wrote: On 12/7/2012 1:53 AM, Andre Oppermann wrote: On 07.12.2012 10:36, Oleksandr Tymoshenko wrote: On 2012-11-27, at 1:19 PM, Andre Oppermann wrote: Author: andre Date: Tue Nov 27 21:19:58 2012 New Revision: 243631 URL: http://svnweb.freebsd.org

Re: svn commit: r243631 - in head/sys: kern sys

2012-12-08 Thread Andre Oppermann
On 07.12.2012 23:17, Oleksandr Tymoshenko wrote: On 12/7/2012 1:44 PM, Andre Oppermann wrote: On 07.12.2012 22:05, Oleksandr Tymoshenko wrote: On 12/7/2012 1:53 AM, Andre Oppermann wrote: On 07.12.2012 10:36, Oleksandr Tymoshenko wrote: On 2012-11-27, at 1:19 PM, Andre Oppermann wrote

svn commit: r244039 - head/share/man/man7

2012-12-08 Thread Andre Oppermann
Author: andre Date: Sat Dec 8 21:03:14 2012 New Revision: 244039 URL: http://svnweb.freebsd.org/changeset/base/244039 Log: Remove outdated reference to tcp inflight limiting. It was removed a long time ago. MFC after:1 week Modified: head/share/man/man7/tuning.7 Modified: head/s

Re: svn commit: r244039 - head/share/man/man7

2012-12-08 Thread Andre Oppermann
On 08.12.2012 22:26, Eitan Adler wrote: On 8 December 2012 16:03, Andre Oppermann wrote: Author: andre Date: Sat Dec 8 21:03:14 2012 New Revision: 244039 URL: http://svnweb.freebsd.org/changeset/base/244039 Log: Remove outdated reference to tcp inflight limiting. It was removed a long

Re: svn commit: r243668 - in head/sys: kern sys

2012-12-09 Thread Andre Oppermann
On 09.12.2012 21:35, Alan Cox wrote: Andre, I believe that this change did not actually correct the overflow problem. See below for an explanation. On 11/29/2012 01:30, Andre Oppermann wrote: Author: andre Date: Thu Nov 29 07:30:42 2012 New Revision: 243668 URL: http://svnweb.freebsd.org

svn commit: r244058 - head/usr.bin/fetch

2012-12-09 Thread Andre Oppermann
Author: andre Date: Sun Dec 9 22:54:03 2012 New Revision: 244058 URL: http://svnweb.freebsd.org/changeset/base/244058 Log: Fix bandwidth reporting when doing a restarted download with "-r". The offset is already accounted for in xs->lastrcvd and doesn't have to be subtracted again. Rep

Re: svn commit: r243147 - head/usr.bin/fetch

2012-12-09 Thread Andre Oppermann
On 09.12.2012 20:01, Mateusz Guzik wrote: On Sun, Dec 09, 2012 at 07:42:02PM +0100, Florian Smeets wrote: On 09.12.12 19:27, Mateusz Guzik wrote: On Sun, Dec 09, 2012 at 07:06:22PM +0100, Florian Smeets wrote: On 16.11.12 13:05, Andre Oppermann wrote: Author: andre Date: Fri Nov 16 12:05:10

svn commit: r244080 - head/sys/kern

2012-12-10 Thread Andre Oppermann
Author: andre Date: Mon Dec 10 12:19:03 2012 New Revision: 244080 URL: http://svnweb.freebsd.org/changeset/base/244080 Log: Prevent long type overflow of realmem calculation on ILP32 by forcing calculation to be in quad_t space. Fix style issue with second parameter to qmin(). Reported

Re: svn commit: r243631 - in head/sys: kern sys

2012-12-18 Thread Andre Oppermann
On 18.12.2012 06:40, Oleksandr Tymoshenko wrote: On 2012-12-08, at 1:21 PM, Alan Cox wrote: On 12/08/2012 14:32, Andre Oppermann wrote: .. skipped .. The trouble seems to come from NSFBUFS which is (512 + maxusers * 16) resulting in a kernel map of (512 + 400 * 16) * PAGE_SIZE = 27MB

Re: svn commit: r244112 - head/sys/kern

2012-12-18 Thread Andre Oppermann
On 17.12.2012 23:12, Andriy Gapon wrote: on 18/12/2012 00:02 Adrian Chadd said the following: Why are they there, if we just ship production releases with INVARIANTS disabled? Because there is an axis orthogonal to asserting correctness - performance. Indeed. There are, or will be, a couple

Re: svn commit: r244387 - head/sys/netinet

2012-12-18 Thread Andre Oppermann
On 18.12.2012 09:24, Gleb Smirnoff wrote: Andrey, On Tue, Dec 18, 2012 at 08:14:16AM +, Gleb Smirnoff wrote: T> Author: glebius T> Date: Tue Dec 18 08:14:16 2012 T> New Revision: 244387 T> URL: http://svnweb.freebsd.org/changeset/base/244387 T> T> Log: T> Fix !INET6 build after r244365.

Re: svn commit: r243631 - in head/sys: kern sys

2013-01-07 Thread Andre Oppermann
, Andre Oppermann wrote: .. skipped .. The trouble seems to come from NSFBUFS which is (512 + maxusers * 16) resulting in a kernel map of (512 + 400 * 16) * PAGE_SIZE = 27MB. This seem to be pushing it with the smaller ARM kmap layout. Does it boot and run when you set the tunable

Re: svn commit: r243631 - in head/sys: kern sys

2013-01-14 Thread Andre Oppermann
On 13.01.2013 11:10, Alan Cox wrote: On 01/07/2013 12:47, Oleksandr Tymoshenko wrote: On 12/27/2012 6:46 PM, Oleksandr Tymoshenko wrote: On 12/18/2012 1:59 AM, Alan Cox wrote: On 12/17/2012 23:40, Oleksandr Tymoshenko wrote: On 2012-12-08, at 1:21 PM, Alan Cox wrote: That makes sense. Howe

Re: svn commit: r243631 - in head/sys: kern sys

2013-01-14 Thread Andre Oppermann
On 13.01.2013 19:06, Alfred Perlstein wrote: On 1/12/13 10:32 PM, Adrian Chadd wrote: On 12 January 2013 11:45, Alfred Perlstein wrote: I'm not sure if regressing to the waterfall method of development is a good idea at this point. I see a light at the end of the tunnel and we to continue to

Re: svn commit: r243631 - in head/sys: kern sys

2013-01-14 Thread Andre Oppermann
On 14.01.2013 16:51, Alexander Motin wrote: On 14.01.2013 17:09, Andre Oppermann wrote: On 13.01.2013 19:06, Alfred Perlstein wrote: On 1/12/13 10:32 PM, Adrian Chadd wrote: On 12 January 2013 11:45, Alfred Perlstein wrote: I'm not sure if regressing to the waterfall method of develo

svn commit: r245575 - in head/sys: kern sys

2013-01-17 Thread Andre Oppermann
Author: andre Date: Thu Jan 17 21:28:31 2013 New Revision: 245575 URL: http://svnweb.freebsd.org/changeset/base/245575 Log: Move the mbuf memory limit calculations from init_param2() to tunable_mbinit() where it is next to where it is used later. Change the sysinit level of tunable_mbinit

Re: svn commit: r243631 - in head/sys: kern sys

2013-01-18 Thread Andre Oppermann
On 14.01.2013 16:00, Andre Oppermann wrote: On 13.01.2013 11:10, Alan Cox wrote: 3. The function vm_ksubmap_init() has a dependency on the global variable maxpipekva. vm_ksubmap_init() is executed under SI_SUB_CPU, which comes after SI_SUB_KMEM. Am I missing anything? I'm attaching a

svn commit: r246204 - head/sys/arm/include

2013-02-01 Thread Andre Oppermann
Author: andre Date: Fri Feb 1 10:26:31 2013 New Revision: 246204 URL: http://svnweb.freebsd.org/changeset/base/246204 Log: Add VM_KMEM_SIZE_SCALE parameter set to 2 (50%) for all ARM platforms. VM_KMEM_SIZE_SCALE specifies which fraction of the available physical memory, after deduction

svn commit: r246207 - head/sys/i386/include

2013-02-01 Thread Andre Oppermann
Author: andre Date: Fri Feb 1 14:16:37 2013 New Revision: 246207 URL: http://svnweb.freebsd.org/changeset/base/246207 Log: Remove unused VM_MAX_AUTOTUNE_NMBCLUSTERS define. Modified: head/sys/i386/include/vmparam.h Modified: head/sys/i386/include/vmparam.h ==

svn commit: r246208 - head/sys/netinet

2013-02-01 Thread Andre Oppermann
Author: andre Date: Fri Feb 1 14:21:09 2013 New Revision: 246208 URL: http://svnweb.freebsd.org/changeset/base/246208 Log: uma_zone_set_max() directly returns the rounded effective zone limit. Use the return value directly instead of doing a second uma_zone_set_max() step. MFC after:

Re: svn commit: r246204 - head/sys/arm/include

2013-02-01 Thread Andre Oppermann
On 01.02.2013 18:52, Alan Cox wrote: On 02/01/2013 04:26, Andre Oppermann wrote: Author: andre Date: Fri Feb 1 10:26:31 2013 New Revision: 246204 URL: http://svnweb.freebsd.org/changeset/base/246204 Log: Add VM_KMEM_SIZE_SCALE parameter set to 2 (50%) for all ARM platforms

Re: svn commit: r246204 - head/sys/arm/include

2013-02-01 Thread Andre Oppermann
On 01.02.2013 21:23, Adrian Chadd wrote: .. before you make that assumption, please re-visit some the .. lower-end integrated ethernet MACs in embedded chips. I don't know whether the Atheros stuff does (I think it does, but I don't know under what conditions it's possible.) Maybe have it by de

Re: svn commit: r246204 - head/sys/arm/include

2013-02-01 Thread Andre Oppermann
On 01.02.2013 22:16, Juli Mallett wrote: On Fri, Feb 1, 2013 at 1:01 PM, Andre Oppermann wrote: On 01.02.2013 21:23, Adrian Chadd wrote: .. before you make that assumption, please re-visit some the .. lower-end integrated ethernet MACs in embedded chips. I don't know whether the At

Re: svn commit: r233273 - head/sys/conf

2012-03-21 Thread Andre Oppermann
On 21.03.2012 09:50, Marius Strobl wrote: Author: marius Date: Wed Mar 21 08:50:47 2012 New Revision: 233273 URL: http://svn.freebsd.org/changeset/base/233273 Log: Exclude devices which are mutually exclusive with ATA_CAM. For better or worse, the former are still built as modules as part

Re: svn commit: r253081 - in head: sys/net sys/netinet sys/netinet6 sys/netipsec tools/tools/crypto usr.bin/netstat

2013-07-09 Thread Andre Oppermann
On 09.07.2013 11:32, Andrey V. Elsukov wrote: Author: ae Date: Tue Jul 9 09:32:06 2013 New Revision: 253081 URL: http://svnweb.freebsd.org/changeset/base/253081 Log: Prepare network statistics structures for migration to PCPU counters. Use uint64_t as type for all fields of structures.

svn commit: r253150 - head/sys/netinet

2013-07-10 Thread Andre Oppermann
Author: andre Date: Wed Jul 10 12:06:01 2013 New Revision: 253150 URL: http://svnweb.freebsd.org/changeset/base/253150 Log: Extend debug logging of TCP timestamp related specification violations. Update related comments and style. Modified: head/sys/netinet/tcp_input.c head/sys/netin

svn commit: r253204 - head/sys/kern

2013-07-11 Thread Andre Oppermann
Author: andre Date: Thu Jul 11 12:46:35 2013 New Revision: 253204 URL: http://svnweb.freebsd.org/changeset/base/253204 Log: Fix style issues, a typo in "kern.ipc.nmbufs" and correctly plave and expose the value of the tunable maxmbufmem as "kern.ipc.maxmbufmem" through sysctl. Reported

svn commit: r253207 - head/sys/kern

2013-07-11 Thread Andre Oppermann
Author: andre Date: Thu Jul 11 12:53:13 2013 New Revision: 253207 URL: http://svnweb.freebsd.org/changeset/base/253207 Log: Make use of the fact that uma_zone_set_max(9) already returns the rounded limit making a call to uma_zone_get_max(9) unnecessary. MFC after:1 day Modified: he

svn commit: r253208 - head/sys/crypto/siphash

2013-07-11 Thread Andre Oppermann
= --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/sys/crypto/siphash/siphash.c Thu Jul 11 14:18:38 2013 (r253208) @@ -0,0 +1,241 @@ +/*- + * Copyright (c) 2013 Andre Oppermann + * All rights reserved. + * + * Red

svn commit: r253210 - in head/sys: conf netinet

2013-07-11 Thread Andre Oppermann
* Copyright (c) 2006 Andre Oppermann, Internet Business Solutions AG + * Copyright (c) 2006,2013 Andre Oppermann, Internet Business Solutions AG * All rights reserved. * * This software was developed for the FreeBSD Project by Jonathan Lemon * and McAfee Research, the Security Research Div

Re: svn commit: r253208 - head/sys/crypto/siphash

2013-07-11 Thread Andre Oppermann
On 11.07.2013 16:18, Andre Oppermann wrote: Author: andre Date: Thu Jul 11 14:18:38 2013 New Revision: 253208 URL: http://svnweb.freebsd.org/changeset/base/253208 Log: SipHash is a cryptographically strong pseudo-random function (a.k.a. keyed hash function) optimized for speed on short

svn commit: r253214 - head/sys/crypto/siphash

2013-07-11 Thread Andre Oppermann
Author: andre Date: Thu Jul 11 16:27:11 2013 New Revision: 253214 URL: http://svnweb.freebsd.org/changeset/base/253214 Log: Fix const propagation issues to make GCC happy. Submitted by: Michael Butler Modified: head/sys/crypto/siphash/siphash.c Modified: head/sys/crypto/siphash/siphash

svn commit: r253254 - head/sys/netinet

2013-07-12 Thread Andre Oppermann
Author: andre Date: Fri Jul 12 07:43:56 2013 New Revision: 253254 URL: http://svnweb.freebsd.org/changeset/base/253254 Log: Unbreak VIMAGE by correctly naming the vnet pointer in struct tcp_syncache. Reported by: trociny, rodrigc Modified: head/sys/netinet/tcp_syncache.h Modified: head

Re: svn commit: r253254 - head/sys/netinet

2013-07-12 Thread Andre Oppermann
On 12.07.2013 09:43, Andre Oppermann wrote: Author: andre Date: Fri Jul 12 07:43:56 2013 New Revision: 253254 URL: http://svnweb.freebsd.org/changeset/base/253254 Log: Unbreak VIMAGE by correctly naming the vnet pointer in struct tcp_syncache. Reported by: trociny, rodrigc Sorry for

Re: svn commit: r253210 - in head/sys: conf netinet

2013-07-15 Thread Andre Oppermann
On 15.07.2013 20:38, Mikolaj Golub wrote: On Mon, Jul 15, 2013 at 11:36:16AM +0200, Ulrich Spörlein wrote: Hey Andre, I don't see why this commit triggers it, but Coverity Scan found a new resource leak in this file. syncache_expand() will leak *s when line 1071 is reached. The "failed:" case b

svn commit: r253395 - head/sys/netinet

2013-07-16 Thread Andre Oppermann
Author: andre Date: Tue Jul 16 16:37:08 2013 New Revision: 253395 URL: http://svnweb.freebsd.org/changeset/base/253395 Log: Free the non-fatal "timestamp missing" debug string manually as it is not covered by the catch-all free for the error cases. Found by: Coverity Modified: head

svn commit: r254516 - in head/sys/dev: bce bxe mge ti

2013-08-19 Thread Andre Oppermann
Author: andre Date: Mon Aug 19 10:20:20 2013 New Revision: 254516 URL: http://svnweb.freebsd.org/changeset/base/254516 Log: Remove unused and incomplete support for delayed fragment checksums from bce(4), bxe(4), mge(4) and ti(4) drivers. Modified: head/sys/dev/bce/if_bce.c head/sys/dev/b

svn commit: r254517 - head/sys/netinet

2013-08-19 Thread Andre Oppermann
Author: andre Date: Mon Aug 19 10:30:15 2013 New Revision: 254517 URL: http://svnweb.freebsd.org/changeset/base/254517 Log: Remove unused M_FRAG, M_FIRSTFRAG and M_LASTFRAG tagging from ip_fragment(). There wasn't any real driver (and hardware) support for it. Modern hardware does full frag

svn commit: r254518 - head/sys/netinet

2013-08-19 Thread Andre Oppermann
Author: andre Date: Mon Aug 19 10:34:10 2013 New Revision: 254518 URL: http://svnweb.freebsd.org/changeset/base/254518 Log: Move ip_reassemble()'s use of the global M_FRAG mbuf flag to a protocol layer specific flag instead. The flag is only relevant while the packet stays in the IP reassem

svn commit: r254519 - in head/sys: netinet netinet6 sys

2013-08-19 Thread Andre Oppermann
Author: andre Date: Mon Aug 19 11:08:36 2013 New Revision: 254519 URL: http://svnweb.freebsd.org/changeset/base/254519 Log: Move the global M_SKIP_FIREWALL mbuf flags to a protocol layer specific flag instead. The flag is only used within the IP and IPv6 layer 3 protocols. Because some

svn commit: r254520 - in head/sys: kern sys

2013-08-19 Thread Andre Oppermann
Author: andre Date: Mon Aug 19 11:16:53 2013 New Revision: 254520 URL: http://svnweb.freebsd.org/changeset/base/254520 Log: Remove the unused M_NOFREE mbuf flag. It didn't have any in-tree users for a very long time, if ever. Should such a functionality ever be needed again the appropria

Re: svn commit: r254520 - in head/sys: kern sys

2013-08-19 Thread Andre Oppermann
On 19.08.2013 13:23, Davide Italiano wrote: On Mon, Aug 19, 2013 at 1:16 PM, Andre Oppermann wrote: Modified: head/sys/sys/mbuf.h == --- head/sys/sys/mbuf.h Mon Aug 19 11:08:36 2013(r254519) +++ head/sys/sys

<    1   2   3   >