Author: andre
Date: Tue Jul 16 16:37:08 2013
New Revision: 253395
URL: http://svnweb.freebsd.org/changeset/base/253395

Log:
  Free the non-fatal "timestamp missing" debug string manually as it is
  not covered by the catch-all free for the error cases.
  
  Found by:     Coverity

Modified:
  head/sys/netinet/tcp_syncache.c

Modified: head/sys/netinet/tcp_syncache.c
==============================================================================
--- head/sys/netinet/tcp_syncache.c     Tue Jul 16 15:51:32 2013        
(r253394)
+++ head/sys/netinet/tcp_syncache.c     Tue Jul 16 16:37:08 2013        
(r253395)
@@ -1041,9 +1041,12 @@ syncache_expand(struct in_conninfo *inc,
         * reports of non-compliants stacks.
         */
        if ((sc->sc_flags & SCF_TIMESTAMP) && !(to->to_flags & TOF_TS)) {
-               if ((s = tcp_log_addrs(inc, th, NULL, NULL)))
+               if ((s = tcp_log_addrs(inc, th, NULL, NULL))) {
                        log(LOG_DEBUG, "%s; %s: Timestamp missing, "
                            "no action\n", s, __func__);
+                       free(s, M_TCPLOG);
+                       s = NULL;
+               }
        }
 
        /*
_______________________________________________
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Reply via email to