Re: svn commit: r350005 - head/sys/kern

2019-07-31 Thread Bryan Drewery
On 7/31/19 12:42 PM, Konstantin Belousov wrote: > On Wed, Jul 31, 2019 at 10:08:39AM -0700, Bryan Drewery wrote: >> On 7/30/19 10:14 PM, Konstantin Belousov wrote: >>> No, you should create a situation where the python process ends the endless >>> loop, as reported. Then, it should become killable

Re: svn commit: r350005 - head/sys/kern

2019-07-31 Thread Konstantin Belousov
On Wed, Jul 31, 2019 at 10:08:39AM -0700, Bryan Drewery wrote: > On 7/30/19 10:14 PM, Konstantin Belousov wrote: > > No, you should create a situation where the python process ends the endless > > loop, as reported. Then, it should become killable by 9 with the first > > chunk only applied. > > >

Re: svn commit: r350005 - head/sys/kern

2019-07-31 Thread Bryan Drewery
On 7/30/19 10:14 PM, Konstantin Belousov wrote: > On Tue, Jul 30, 2019 at 08:40:28PM -0700, Bryan Drewery wrote: >> This 2nd change alone (&& count1 == 0) was sufficient to fix the endless >> loop problem. > Good, thank you. > >> >> I am not sure how to test the umtxq_check_susp() change. Do I jus

Re: svn commit: r350005 - head/sys/kern

2019-07-30 Thread Konstantin Belousov
On Tue, Jul 30, 2019 at 08:40:28PM -0700, Bryan Drewery wrote: > This 2nd change alone (&& count1 == 0) was sufficient to fix the endless > loop problem. Good, thank you. > > I am not sure how to test the umtxq_check_susp() change. Do I just need > to ptrace the process? No, you should create a

Re: svn commit: r350005 - head/sys/kern

2019-07-30 Thread Bryan Drewery
On 7/30/19 4:27 PM, Konstantin Belousov wrote: > On Wed, Jul 31, 2019 at 02:13:02AM +0300, Konstantin Belousov wrote: >> On Tue, Jul 30, 2019 at 03:04:57PM -0700, Bryan Drewery wrote: >>> On 7/15/2019 12:18 PM, Konstantin Belousov wrote: Author: kib Date: Mon Jul 15 19:18:25 2019 New

Re: svn commit: r350005 - head/sys/kern

2019-07-30 Thread Bryan Drewery
On 7/30/2019 4:27 PM, Konstantin Belousov wrote: > On Wed, Jul 31, 2019 at 02:13:02AM +0300, Konstantin Belousov wrote: >> On Tue, Jul 30, 2019 at 03:04:57PM -0700, Bryan Drewery wrote: >>> On 7/15/2019 12:18 PM, Konstantin Belousov wrote: Author: kib Date: Mon Jul 15 19:18:25 2019 N

Re: svn commit: r350005 - head/sys/kern

2019-07-30 Thread Konstantin Belousov
On Wed, Jul 31, 2019 at 02:13:02AM +0300, Konstantin Belousov wrote: > On Tue, Jul 30, 2019 at 03:04:57PM -0700, Bryan Drewery wrote: > > On 7/15/2019 12:18 PM, Konstantin Belousov wrote: > > > Author: kib > > > Date: Mon Jul 15 19:18:25 2019 > > > New Revision: 350005 > > > URL: https://svnweb.fre

Re: svn commit: r350005 - head/sys/kern

2019-07-30 Thread Konstantin Belousov
On Tue, Jul 30, 2019 at 03:04:57PM -0700, Bryan Drewery wrote: > On 7/15/2019 12:18 PM, Konstantin Belousov wrote: > > Author: kib > > Date: Mon Jul 15 19:18:25 2019 > > New Revision: 350005 > > URL: https://svnweb.freebsd.org/changeset/base/350005 > > > > Log: > > In do_sem2_wait(), balance umt

Re: svn commit: r350005 - head/sys/kern

2019-07-30 Thread Bryan Drewery
On 7/15/2019 12:18 PM, Konstantin Belousov wrote: > Author: kib > Date: Mon Jul 15 19:18:25 2019 > New Revision: 350005 > URL: https://svnweb.freebsd.org/changeset/base/350005 > > Log: > In do_sem2_wait(), balance umtx_key_get() with umtx_key_release() on retry. > Is this also needed in do_s

svn commit: r350005 - head/sys/kern

2019-07-15 Thread Konstantin Belousov
Author: kib Date: Mon Jul 15 19:18:25 2019 New Revision: 350005 URL: https://svnweb.freebsd.org/changeset/base/350005 Log: In do_sem2_wait(), balance umtx_key_get() with umtx_key_release() on retry. Reported by: ler Bisected and reviewed by: markj Sponsored by: The FreeBSD Foundati