On 2016-09-11 10:49, Baptiste Daroussin wrote:
> On Thu, Aug 25, 2016 at 07:40:25PM +, Kristof Provost wrote:
>> Author: kp
>> Date: Thu Aug 25 19:40:25 2016
>> New Revision: 304815
>> URL: https://svnweb.freebsd.org/changeset/base/304815
>>
>> Log:
>> Add libifc, a library implementing core
On Thu, Aug 25, 2016 at 07:40:25PM +, Kristof Provost wrote:
> Author: kp
> Date: Thu Aug 25 19:40:25 2016
> New Revision: 304815
> URL: https://svnweb.freebsd.org/changeset/base/304815
>
> Log:
> Add libifc, a library implementing core functionality that exists in
> ifconfig(8) today.
>
On Thu, Aug 25, 2016 at 10:30 PM Alexey Dokuchaev wrote:
> On Thu, Aug 25, 2016 at 10:20:29PM +0200, Kristof Provost wrote:
> > On 25 Aug 2016, at 22:14, John Baldwin wrote:
> > > I hate even writing this mail, and it looks like the topic wasn't
> > > really discussed in the review, but I think l
On Thu, Aug 25, 2016 at 1:20 PM, Kristof Provost wrote:
> On 25 Aug 2016, at 22:14, John Baldwin wrote:
>> I hate even writing this mail, and it looks like the topic wasn't really
>> discussed in the review, but I think libifconfig is probably the "better"
>> name if the goal is to move most of if
On Thu, Aug 25, 2016 at 10:20:29PM +0200, Kristof Provost wrote:
> On 25 Aug 2016, at 22:14, John Baldwin wrote:
> > I hate even writing this mail, and it looks like the topic wasn't
> > really discussed in the review, but I think libifconfig is probably
> > the "better" name if the goal is to move
On 08/25/2016 15:20, Kristof Provost wrote:
> On 25 Aug 2016, at 22:14, John Baldwin wrote:
>> On Thursday, August 25, 2016 07:40:25 PM Kristof Provost wrote:
>>> Author: kp
>>> Date: Thu Aug 25 19:40:25 2016
>>> New Revision: 304815
>>> URL: https://svnweb.freebsd.org/changeset/base/304815
>>>
>>>
Some inline comments :)
Cheers,
Mariusz
[...]
> +libifc_handle_t *
> +libifc_open(void)
> +{
> + struct libifc_handle *h;
> +
> + h = calloc(1, sizeof(struct libifc_handle));
This can fail, and we are using NULL references.
> +
> + for (int i = 0; i <= AF_MAX; i++) {
> +
On 25 Aug 2016, at 22:14, John Baldwin wrote:
On Thursday, August 25, 2016 07:40:25 PM Kristof Provost wrote:
Author: kp
Date: Thu Aug 25 19:40:25 2016
New Revision: 304815
URL: https://svnweb.freebsd.org/changeset/base/304815
Log:
Add libifc, a library implementing core functionality that ex
On Thursday, August 25, 2016 07:40:25 PM Kristof Provost wrote:
> Author: kp
> Date: Thu Aug 25 19:40:25 2016
> New Revision: 304815
> URL: https://svnweb.freebsd.org/changeset/base/304815
>
> Log:
> Add libifc, a library implementing core functionality that exists in
> ifconfig(8) today.
>
Author: kp
Date: Thu Aug 25 19:40:25 2016
New Revision: 304815
URL: https://svnweb.freebsd.org/changeset/base/304815
Log:
Add libifc, a library implementing core functionality that exists in
ifconfig(8) today.
libifc (pronounced lib-ifconfig) aims to be a light abstraction layer between
10 matches
Mail list logo
