On 2016-09-11 10:49, Baptiste Daroussin wrote: > On Thu, Aug 25, 2016 at 07:40:25PM +0000, Kristof Provost wrote: >> Author: kp >> Date: Thu Aug 25 19:40:25 2016 >> New Revision: 304815 >> URL: https://svnweb.freebsd.org/changeset/base/304815 >> >> Log: >> Add libifc, a library implementing core functionality that exists in >> ifconfig(8) today. >> >> libifc (pronounced lib-ifconfig) aims to be a light abstraction layer >> between >> programs and the kernel APIs for managing the network configuration. >> This should hopefully make programs easier to maintain, and reduce code >> duplication. >> >> Work will begin on making ifconfig(8) use this library in the near future. >> >> This code is still evolving. The interface should not be considered stable >> until >> it is announced as such. >> > > Sorry I come to this very late but: > > If it is not stable yet, it would probably be a good idea to make it a > privatelib, so even if we end up shipping a release with the lib before > considered stable we are safe updating it? > > It won't prevent any usage one can imagine in base. > > The private flag can be dropped once it is considered stable > > Best regards, > Bapt >
That is a good idea, and is just a one line change: -- Allan Jude
Index: lib/libifconfig/Makefile =================================================================== --- lib/libifconfig/Makefile (revision 305635) +++ lib/libifconfig/Makefile (working copy) @@ -2,6 +2,7 @@ PACKAGE= lib${LIB} LIB= ifconfig +PRIVATELIB= true # Don't build shared library, for now. NO_PIC=
signature.asc
Description: OpenPGP digital signature