On Thu, Aug 25, 2016 at 10:30 PM Alexey Dokuchaev <da...@freebsd.org> wrote:
> On Thu, Aug 25, 2016 at 10:20:29PM +0200, Kristof Provost wrote: > > On 25 Aug 2016, at 22:14, John Baldwin wrote: > > > I hate even writing this mail, and it looks like the topic wasn't > > > really discussed in the review, but I think libifconfig is probably > > > the "better" name if the goal is to move most of ifconfig into it. > > > ... > > > Hmm, it seems you are 'libifc_*'. Most of our libraries do not > > > include 'lib' in the namespace prefix (see above examples that all > > > use the name of the library without 'lib' as the prefix). If nothing > > > else I'd suggest dropping 'lib' to be consistent with most other > > > libraries in the tree. > > +1. > > > The name was in fact discussed privately, and we figured libifconfig > > was a bit on the long side. > > Oh come one, we already have `libblocksruntime' and `libbluetooth' (and > some others I probably don't remember now). `libifconfig' is just fine. > Potential namespace clashes are a lot nastier than a longer name. > > > I certainly take your point about libifc_. Does anyone else have any > > views regarding the naming (or other subjects)? > > I second John, dropping the `lib' prefix and going with `ifconfig_' looks > like a good idea. > > ./danfe > Considering the points raised on this topic, I agree naming it 'libifconfig' and using 'ifconfig_' prefix is better than what's currently in place. I've submitted a differential revision for it here: https://reviews.freebsd.org/D7742 This should be committed before further fixes, to keep as much history as possible. Regards, Marie Helene _______________________________________________ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
