svn commit: r341356 - in head/usr.sbin: . trim

Author: eugen Date: Sat Dec 1 03:20:10 2018 New Revision: 341356 URL: https://svnweb.freebsd.org/changeset/base/341356 Log: Remove trim(8) by multiple demands. Deleted: head/usr.sbin/trim/ Modified: head/usr.sbin/Makefile Modified: head/usr.sbin/Makefile ==

Re: svn commit: r341352 - head/usr.sbin/trim

01.12.2018 9:34, Conrad Meyer wrote: > Generally when a committer puts a patch on phabricator, they'll commit > it when they're ready. I think this is wrong behaviour of the Phabricator to auto-close a differential just because some singe commit referred to it. It was not meant to be closed for n

Re: svn commit: r341352 - head/usr.sbin/trim

Hi Eugene, Generally when a committer puts a patch on phabricator, they'll commit it when they're ready. In particular this patch hadn't actually been approved by any reviewers yet and review discussion was still active. As far as I can tell, imp@ hadn't indicated he wasn't going to commit his pa

Re: svn: head/usr.bin: . trim

01.12.2018 8:54, Steven Hartland wrote: > What I was referring to is ZFS performs a delete of blocks when it > initializes a volume, so there's usually no need to perform a manual step > there. It may be needed after ZIL or ZFS Cache partition became unneeded.

Re: svn: head/usr.bin: . trim

On 30/11/2018 22:09, Eugene Grosbein wrote: 01.12.2018 4:29, Steven Hartland wrote: On 30/11/2018 21:16, Eugene Grosbein wrote: 30.11.2018 21:23, Warner Losh wrote: So I'm back to my point: we should just put it into dd and move on with our lives. It's really the right place for it. Why ca

svn commit: r341354 - head/tests/sys/kern

Author: vangyzen Date: Fri Nov 30 23:47:57 2018 New Revision: 341354 URL: https://svnweb.freebsd.org/changeset/base/341354 Log: Maybe make gcc happy According to Jenkins, the GCC architectures were unhappy because: sigaltstack.c:82: warning: missing initializer sigaltstack.c:

svn commit: r341353 - in head: sys/arm/arm sys/arm64/arm64 sys/riscv/riscv tests/sys/kern

Author: vangyzen Date: Fri Nov 30 22:44:33 2018 New Revision: 341353 URL: https://svnweb.freebsd.org/changeset/base/341353 Log: Fix reporting of SS_ONSTACK Fix reporting of SS_ONSTACK in nested signal delivery when sigaltstack() is used on some architectures. Add a unit test for this

Re: svn: head/usr.bin: . trim

01.12.2018 4:29, Steven Hartland wrote: > On 30/11/2018 21:16, Eugene Grosbein wrote: >> 30.11.2018 21:23, Warner Losh wrote: >> >>> So I'm back to my point: we should just put it into dd and move on with our >>> lives. It's really the right place for it. >> Why can't we have two implementations?

Re: svn commit: r341338 - head/share/man/man4

On Fri, 30 Nov 2018, Edward Tomasz Napierala wrote: Log: Say in plain text what the 'debug' keymap action usually is. MFC after: 2 weeks Sponsored by: DARPA, AFRL Modified: head/share/man/man4/ddb.4 Modified: head/share/man/man4/ddb.4 =

svn commit: r341352 - head/usr.sbin/trim

Author: eugen Date: Fri Nov 30 21:57:02 2018 New Revision: 341352 URL: https://svnweb.freebsd.org/changeset/base/341352 Log: trim(8): serveral style fixes Submitted by: imp MFC after:1 month Differential Revision:https://reviews.freebsd.org/D18380 Modified:

Re: svn: head/usr.bin: . trim

ZFS already does that no need for a separate tool On 30/11/2018 21:16, Eugene Grosbein wrote: 30.11.2018 21:23, Warner Losh wrote: So I'm back to my point: we should just put it into dd and move on with our lives. It's really the right place for it. Why can't we have two implementations? Div

Re: svn: head/usr.bin: . trim

30.11.2018 21:23, Warner Losh wrote: > So I'm back to my point: we should just put it into dd and move on with our > lives. It's really the right place for it. Why can't we have two implementations? Diversity is good thing. I can imagine erasing a partition with ZFS Cache or ZIL inside and "tri

svn commit: r341351 - in head: lib/libc/amd64/string sys/amd64/amd64

Author: mjg Date: Fri Nov 30 20:58:08 2018 New Revision: 341351 URL: https://svnweb.freebsd.org/changeset/base/341351 Log: amd64: handle small memmove buffers with overlapping stores Handling sizes of > 32 backwards will be updated later. Reviewed by: kib (kernel part) Sponsored by:

Re: svn commit: r341327 - head/sys/dev/sfxge

On 30.11.2018 22:01, Philip Paeps wrote: On 2018-11-30 19:36:27 (+0100), John Baldwin wrote: On 11/30/18 10:15 AM, Andrew Rybchenko wrote: On 30.11.2018 20:30, John Baldwin wrote: On 11/29/18 11:11 PM, Andrew Rybchenko wrote: Author: arybchik Date: Fri Nov 30 07:11:05 2018 New Revision: 34132

Re: svn commit: r341327 - head/sys/dev/sfxge

On 30.11.2018 21:54, Brooks Davis wrote: On Fri, Nov 30, 2018 at 09:15:39PM +0300, Andrew Rybchenko wrote: On 30.11.2018 20:30, John Baldwin wrote: On 11/29/18 11:11 PM, Andrew Rybchenko wrote: Author: arybchik Date: Fri Nov 30 07:11:05 2018 New Revision: 341327 URL: https://svnweb.freebsd.org

Re: svn commit: r341327 - head/sys/dev/sfxge

Hi Conrad, On 30.11.2018 21:35, Conrad Meyer wrote: On Fri, Nov 30, 2018 at 10:16 AM Andrew Rybchenko wrote: Basically I'm ready to follow any sensible policy. Hi Andrew, I think general policy is to not include a "Differential Revision:" line in a commit message unless there was actual revi

svn commit: r341348 - in head/usr.sbin: ctld iscsid

Author: oshogbo Date: Fri Nov 30 19:40:16 2018 New Revision: 341348 URL: https://svnweb.freebsd.org/changeset/base/341348 Log: iscsi: simplify the capsicumization Approved by: trasz Differential Revision:https://reviews.freebsd.org/D17962 Modified: head/usr.sbin/ctld/kernel.c

svn commit: r341347 - head/lib/libcasper/services/cap_fileargs

Author: oshogbo Date: Fri Nov 30 19:27:14 2018 New Revision: 341347 URL: https://svnweb.freebsd.org/changeset/base/341347 Log: libcasper: do not fail if Capsicum is not avilable Casper service can be also used on the kernels without Capsicum support. Reported by: sbruno Tested by:

Re: svn commit: r341327 - head/sys/dev/sfxge

On 11/30/18 11:01 AM, Philip Paeps wrote: > On 2018-11-30 19:36:27 (+0100), John Baldwin wrote: >> On 11/30/18 10:15 AM, Andrew Rybchenko wrote: >>> On 30.11.2018 20:30, John Baldwin wrote: On 11/29/18 11:11 PM, Andrew Rybchenko wrote: > Author: arybchik > Date: Fri Nov 30 07:11:05 201

Re: svn commit: r341327 - head/sys/dev/sfxge

On 2018-11-30 19:36:27 (+0100), John Baldwin wrote: On 11/30/18 10:15 AM, Andrew Rybchenko wrote: On 30.11.2018 20:30, John Baldwin wrote: On 11/29/18 11:11 PM, Andrew Rybchenko wrote: Author: arybchik Date: Fri Nov 30 07:11:05 2018 New Revision: 341327 URL: https://svnweb.freebsd.org/changese

Re: svn commit: r341327 - head/sys/dev/sfxge

On Fri, Nov 30, 2018 at 09:15:39PM +0300, Andrew Rybchenko wrote: > On 30.11.2018 20:30, John Baldwin wrote: > > On 11/29/18 11:11 PM, Andrew Rybchenko wrote: > >> Author: arybchik > >> Date: Fri Nov 30 07:11:05 2018 > >> New Revision: 341327 > >> URL: https://svnweb.freebsd.org/changeset/base/3413

Re: svn commit: r341327 - head/sys/dev/sfxge

On 11/30/18 10:15 AM, Andrew Rybchenko wrote: > On 30.11.2018 20:30, John Baldwin wrote: >> On 11/29/18 11:11 PM, Andrew Rybchenko wrote: >>> Author: arybchik >>> Date: Fri Nov 30 07:11:05 2018 >>> New Revision: 341327 >>> URL: https://svnweb.freebsd.org/changeset/base/341327 >>> >>> Log: >>>sf

Re: svn commit: r341327 - head/sys/dev/sfxge

On Fri, Nov 30, 2018 at 10:16 AM Andrew Rybchenko wrote: > Basically I'm ready to follow any sensible policy. Hi Andrew, I think general policy is to not include a "Differential Revision:" line in a commit message unless there was actual review there. (That's separate from the issue of creating

Re: svn commit: r341327 - head/sys/dev/sfxge

On 30.11.2018 20:30, John Baldwin wrote: On 11/29/18 11:11 PM, Andrew Rybchenko wrote: Author: arybchik Date: Fri Nov 30 07:11:05 2018 New Revision: 341327 URL: https://svnweb.freebsd.org/changeset/base/341327 Log: sfxge(4): rollback last seen VLAN TCI if Tx packet is dropped Early pr

Re: svn: head/usr.bin: . trim

Well, I personally think "erase" better describes the option in question. "delete" is ambiguous, since nothing is really "deleted" here and "trim" refers to a name of a particular command in a particular protocol, which may or may not be around in 10 years from now. However, it looks like the indus

svn commit: r341346 - head/usr.bin/top

Author: markj Date: Fri Nov 30 18:02:59 2018 New Revision: 341346 URL: https://svnweb.freebsd.org/changeset/base/341346 Log: Add missing display messages when toggling modes. PR: 233667 Submitted by: James Wright MFC after:1 week Differential Revision:https://re

Re: svn commit: r341344 - head/share/man/man7

On 11/30/18 9:37 AM, Ian Lepore wrote: > On Fri, 2018-11-30 at 16:01 +, Edward Tomasz Napierala wrote: >> Author: trasz >> Date: Fri Nov 30 16:01:43 2018 >> New Revision: 341344 >> URL: https://svnweb.freebsd.org/changeset/base/341344 >> >> Log: >>   Add an example of quick kernel rebuild. >>  

Re: svn commit: r341344 - head/share/man/man7

On Fri, 2018-11-30 at 16:01 +, Edward Tomasz Napierala wrote: > Author: trasz > Date: Fri Nov 30 16:01:43 2018 > New Revision: 341344 > URL: https://svnweb.freebsd.org/changeset/base/341344 > > Log: >   Add an example of quick kernel rebuild. >    >   MFC after: 2 weeks >   Sponsored by:

Re: svn commit: r341327 - head/sys/dev/sfxge

On 11/29/18 11:11 PM, Andrew Rybchenko wrote: > Author: arybchik > Date: Fri Nov 30 07:11:05 2018 > New Revision: 341327 > URL: https://svnweb.freebsd.org/changeset/base/341327 > > Log: > sfxge(4): rollback last seen VLAN TCI if Tx packet is dropped > > Early processing of a packet on trans

Re: svn commit: r341343 - head/share/man/man7

> On Fri, Nov 30, 2018 at 9:24 AM Bjoern A. Zeeb < > bzeeb-li...@lists.zabbadoz.net> wrote: > > > On 30 Nov 2018, at 15:56, Edward Tomasz Napierala wrote: > > > > > Author: trasz > > > Date: Fri Nov 30 15:56:14 2018 > > > New Revision: 341343 > > > URL: https://svnweb.freebsd.org/changeset/base/34

Re: svn: head/usr.bin: . trim

> On Fri, Nov 30, 2018 at 5:57 AM Alexey Dokuchaev wrote: > > > On Fri, Nov 30, 2018 at 07:27:46PM +0700, Eugene Grosbein wrote: > > > 30.11.2018 18:55, Alexey Dokuchaev wrote: > > > > > > >>> Another point: the manpage says, "It is only relevant for flash based > > > >>> storage devices that use

Re: svn commit: r341343 - head/share/man/man7

On 30 Nov 2018, at 16:38, Justin Hibbits wrote: On Fri, Nov 30, 2018, 08:36 Warner Losh On Fri, Nov 30, 2018 at 9:35 AM Justin Hibbits wrote: On Fri, Nov 30, 2018, 08:24 Bjoern A. Zeeb < bzeeb-li...@lists.zabbadoz.net wrote: On 30 Nov 2018, at 15:56, Edward Tomasz Napierala wrote: Au

Re: svn commit: r341343 - head/share/man/man7

On Fri, Nov 30, 2018, 08:36 Warner Losh > > On Fri, Nov 30, 2018 at 9:35 AM Justin Hibbits > wrote: > >> >> >> On Fri, Nov 30, 2018, 08:24 Bjoern A. Zeeb < >> bzeeb-li...@lists.zabbadoz.net wrote: >> >>> On 30 Nov 2018, at 15:56, Edward Tomasz Napierala wrote: >>> >>> > Author: trasz >>> > Date:

Re: svn commit: r341343 - head/share/man/man7

On Fri, Nov 30, 2018 at 9:35 AM Justin Hibbits wrote: > > > On Fri, Nov 30, 2018, 08:24 Bjoern A. Zeeb wrote: > >> On 30 Nov 2018, at 15:56, Edward Tomasz Napierala wrote: >> >> > Author: trasz >> > Date: Fri Nov 30 15:56:14 2018 >> > New Revision: 341343 >> > URL: https://svnweb.freebsd.org/cha

Re: svn commit: r341343 - head/share/man/man7

On Fri, Nov 30, 2018, 08:24 Bjoern A. Zeeb On 30 Nov 2018, at 15:56, Edward Tomasz Napierala wrote: > > > Author: trasz > > Date: Fri Nov 30 15:56:14 2018 > > New Revision: 341343 > > URL: https://svnweb.freebsd.org/changeset/base/341343 > > > > Log: > > Add an example of rebuilding a single pie

Re: svn commit: r341343 - head/share/man/man7

On Fri, Nov 30, 2018 at 9:24 AM Bjoern A. Zeeb < bzeeb-li...@lists.zabbadoz.net> wrote: > On 30 Nov 2018, at 15:56, Edward Tomasz Napierala wrote: > > > Author: trasz > > Date: Fri Nov 30 15:56:14 2018 > > New Revision: 341343 > > URL: https://svnweb.freebsd.org/changeset/base/341343 > > > > Log:

Re: svn commit: r341343 - head/share/man/man7

On 30 Nov 2018, at 15:56, Edward Tomasz Napierala wrote: Author: trasz Date: Fri Nov 30 15:56:14 2018 New Revision: 341343 URL: https://svnweb.freebsd.org/changeset/base/341343 Log: Add an example of rebuilding a single piece of userspace. Modified: head/share/man/man7/development.7 Modif

svn commit: r341345 - head/share/man/man7

Author: trasz Date: Fri Nov 30 16:02:27 2018 New Revision: 341345 URL: https://svnweb.freebsd.org/changeset/base/341345 Log: Silence down the example builds a bit. MFC after:2 weeks Sponsored by: DARPA, AFRL Modified: head/share/man/man7/development.7 Modified: head/share/man/man7

svn commit: r341344 - head/share/man/man7

Author: trasz Date: Fri Nov 30 16:01:43 2018 New Revision: 341344 URL: https://svnweb.freebsd.org/changeset/base/341344 Log: Add an example of quick kernel rebuild. MFC after:2 weeks Sponsored by: DARPA, AFRL Modified: head/share/man/man7/development.7 Modified: head/share/man/man

svn commit: r341343 - head/share/man/man7

Author: trasz Date: Fri Nov 30 15:56:14 2018 New Revision: 341343 URL: https://svnweb.freebsd.org/changeset/base/341343 Log: Add an example of rebuilding a single piece of userspace. MFC after:2 weeks Sponsored by: DARPA, AFRL Modified: head/share/man/man7/development.7 Modified:

svn commit: r341342 - head/share/man/man4

Author: trasz Date: Fri Nov 30 15:52:03 2018 New Revision: 341342 URL: https://svnweb.freebsd.org/changeset/base/341342 Log: Revert r341337; according to imp@ we still support these. MFC after:2 weeks Sponsored by: DARPA, AFRL Modified: head/share/man/man4/ddb.4 Modified: head/sha

Re: svn: head/usr.bin: . trim

On Fri, Nov 30, 2018 at 4:45 AM Eugene Grosbein wrote: > 30.11.2018 18:34, Alexey Dokuchaev wrote: > > > Another point: the manpage says, "It is only relevant for flash based > > storage devices that use wear-leveling algorithms", which is an argument > > against generic "trim". I would mind les

Re: svn: head/usr.bin: . trim

On Fri, Nov 30, 2018 at 5:57 AM Alexey Dokuchaev wrote: > On Fri, Nov 30, 2018 at 07:27:46PM +0700, Eugene Grosbein wrote: > > 30.11.2018 18:55, Alexey Dokuchaev wrote: > > > > >>> Another point: the manpage says, "It is only relevant for flash based > > >>> storage devices that use wear-leveling

Re: svn: head/usr.bin: . trim

On Fri, Nov 30, 2018 at 07:27:46PM +0700, Eugene Grosbein wrote: > 30.11.2018 18:55, Alexey Dokuchaev wrote: > > >>> Another point: the manpage says, "It is only relevant for flash based > >>> storage devices that use wear-leveling algorithms", which is an argument > >>> against generic "trim". I

Re: svn: head/usr.bin: . trim

30.11.2018 18:55, Alexey Dokuchaev wrote: >>> Another point: the manpage says, "It is only relevant for flash based >>> storage devices that use wear-leveling algorithms", which is an argument >>> against generic "trim". I would mind less of it would be called ftrim(8) >>> or ssd_trim(8) or flash

svn commit: r341341 - head/share/man/man4

Author: trasz Date: Fri Nov 30 12:17:35 2018 New Revision: 341341 URL: https://svnweb.freebsd.org/changeset/base/341341 Log: Use .Va for sysctls, not .Dv. MFC after:2 weeks Sponsored by: DARPA, AFRL Modified: head/share/man/man4/textdump.4 Modified: head/share/man/man4/textdump.4

Re: svn: head/usr.bin: . trim

On Fri, Nov 30, 2018 at 06:44:48PM +0700, Eugene Grosbein wrote: > 30.11.2018 18:34, Alexey Dokuchaev wrote: > > > Another point: the manpage says, "It is only relevant for flash based > > storage devices that use wear-leveling algorithms", which is an argument > > against generic "trim". I would

svn commit: r341340 - head/share/man/man4

Author: trasz Date: Fri Nov 30 11:50:41 2018 New Revision: 341340 URL: https://svnweb.freebsd.org/changeset/base/341340 Log: Use .Va for sysctls, not .Dv. MFC after:2 weeks Sponsored by: DARPA, AFRL Modified: head/share/man/man4/ddb.4 Modified: head/share/man/man4/ddb.4 ==

Re: svn: head/usr.bin: . trim

30.11.2018 18:34, Alexey Dokuchaev wrote: > Another point: the manpage says, "It is only relevant for flash based > storage devices that use wear-leveling algorithms", which is an argument > against generic "trim". I would mind less of it would be called ftrim(8) > or ssd_trim(8) or flash_trim(8)

svn commit: r341339 - head/share/man/man4

Author: trasz Date: Fri Nov 30 11:44:43 2018 New Revision: 341339 URL: https://svnweb.freebsd.org/changeset/base/341339 Log: Remove duplicated word. MFC after:2 weeks Sponsored by: DARPA, AFRL Modified: head/share/man/man4/ddb.4 Modified: head/share/man/man4/ddb.4

svn commit: r341338 - head/share/man/man4

Author: trasz Date: Fri Nov 30 11:44:16 2018 New Revision: 341338 URL: https://svnweb.freebsd.org/changeset/base/341338 Log: Say in plain text what the 'debug' keymap action usually is. MFC after:2 weeks Sponsored by: DARPA, AFRL Modified: head/share/man/man4/ddb.4 Modified: head/

svn commit: r341337 - head/share/man/man4

Author: trasz Date: Fri Nov 30 11:42:19 2018 New Revision: 341337 URL: https://svnweb.freebsd.org/changeset/base/341337 Log: Remove the hint for ISA buses; we don't support them anymore. MFC after:2 weeks Sponsored by: DARPA, AFRL Modified: head/share/man/man4/ddb.4 Modified: head

Re: svn: head/usr.bin: . trim

On Fri, Nov 30, 2018 at 06:12:12PM +0700, Eugene Grosbein wrote: > 30.11.2018 17:57, Alexey Dokuchaev wrote: > > On Fri, Nov 30, 2018 at 09:49:55AM +0100, Baptiste Daroussin wrote: > >> On Fri, Nov 30, 2018 at 08:31:17AM +, Steven Hartland wrote: > >>> Personally I disagree, chances of people f

Re: svn: head/usr.bin: . trim

30.11.2018 17:57, Alexey Dokuchaev wrote: > On Fri, Nov 30, 2018 at 09:49:55AM +0100, Baptiste Daroussin wrote: >> On Fri, Nov 30, 2018 at 08:31:17AM +, Steven Hartland wrote: >>> Personally I disagree, chances of people finding that option in dd >>> is slim, a dedicated trim utility makes muc

Re: svn: head/usr.bin: . trim

On Fri, Nov 30, 2018 at 09:49:55AM +0100, Baptiste Daroussin wrote: > On Fri, Nov 30, 2018 at 08:31:17AM +, Steven Hartland wrote: > > Personally I disagree, chances of people finding that option in dd > > is slim, a dedicated trim utility makes much more sense to me. Sure > > have both that's

svn commit: r341335 - in head/sys/netinet: . cc

Author: tuexen Date: Fri Nov 30 10:50:07 2018 New Revision: 341335 URL: https://svnweb.freebsd.org/changeset/base/341335 Log: Limit option_len for the TCP_CCALGOOPT. Limiting the length to 2048 bytes seems to be acceptable, since the values used right now are using 8 bytes. Reviewed

svn commit: r341334 - head/sys/net

Author: ae Date: Fri Nov 30 10:36:14 2018 New Revision: 341334 URL: https://svnweb.freebsd.org/changeset/base/341334 Log: Adapt the fix in r341008 to correctly work with EBR. IFNET_RLOCK_NOSLEEP() is epoch_enter_preempt() in FreeBSD 12+. Holding it in sysctl_rtsock() doesn't protect us fr

svn commit: r341333 - head/sys/dts/arm64/overlays

Author: manu Date: Fri Nov 30 10:31:30 2018 New Revision: 341333 URL: https://svnweb.freebsd.org/changeset/base/341333 Log: arm64: allwinner: Add 792Mhz frequency to sun50i-a64-opp This is the frequency of the cpu on the Pinebook so add it to make cpufreq find the current setting. Note

Re: svn: head/usr.bin: . trim

On Fri, Nov 30, 2018 at 08:31:17AM +, Steven Hartland wrote: > Personally I disagree, chances of people finding that option in dd is slim, > a dedicated trim utility makes much more sense to me. Sure have both that's > cool but keep the trim would be my vote. I also like the idea of a simple d

svn commit: r341329 - head/stand/efi/libefi

Author: tsoome Date: Fri Nov 30 08:42:14 2018 New Revision: 341329 URL: https://svnweb.freebsd.org/changeset/base/341329 Log: loader.efi: fix EFI getchar() for multiple consoles This fix is ported from illumos (issue #9970), the analysis and initial implementation was done by John Levon.

Re: svn: head/usr.bin: . trim

Personally I disagree, chances of people finding that option in dd is slim, a dedicated trim utility makes much more sense to me. Sure have both that's cool but keep the trim would be my vote. On 30/11/2018 01:17, Cy Schubert wrote: Agreed. --- Sent using a tiny phone keyboard. Apologies for

svn commit: r341328 - in head/stand/i386: libi386 loader

Author: tsoome Date: Fri Nov 30 08:01:11 2018 New Revision: 341328 URL: https://svnweb.freebsd.org/changeset/base/341328 Log: loader: create separate lists for fd, cd and hd, merge bioscd with biosdisk Create unified block IO implementation in BIOS version, like it is done in UEFI side.