Re: svn commit: r195200 - in head/usr.sbin: . wake

2009-07-01 Thread Brian Somers
On Wed, 1 Jul 2009 01:45:53 +0400 Stanislav Sedov wrote: > > + p = (u_char *)&pkt; > > + len = sizeof(pkt); > > + bw = 0; > > + while (len) { > > + if ((bw = write(bpf, &pkt, sizeof(pkt))) == -1) > > + return -1; > > + len -= bw; > > + p += b

svn commit: r195228 - head/sys/amd64/amd64

2009-07-01 Thread Doug Rabson
Author: dfr Date: Wed Jul 1 07:34:28 2009 New Revision: 195228 URL: http://svn.freebsd.org/changeset/base/195228 Log: Don't include rpcv2.h - it has been removed. Submitted by: ed@ Approved by: re Modified: head/sys/amd64/amd64/genassym.c Modified: head/sys/amd64/amd64/genassym.c ===

svn commit: r195229 - head

2009-07-01 Thread Doug Rabson
Author: dfr Date: Wed Jul 1 07:35:57 2009 New Revision: 195229 URL: http://svn.freebsd.org/changeset/base/195229 Log: Add an entry documenting removal of the NFS_LEGACYRPC option. Submitted by: Steve Kargl Approved by: re Modified: head/UPDATING Modified: head/UPDATING ==

svn commit: r195230 - head

2009-07-01 Thread Doug Rabson
Author: dfr Date: Wed Jul 1 07:37:21 2009 New Revision: 195230 URL: http://svn.freebsd.org/changeset/base/195230 Log: Add usr/include/nfs/rpcv2.h Submitted by: pluknet at gmail dot com Approved by: re Modified: head/ObsoleteFiles.inc Modified: head/ObsoleteFiles.inc =

svn commit: r195231 - head/sys/netgraph

2009-07-01 Thread Alexander Motin
Author: mav Date: Wed Jul 1 08:08:56 2009 New Revision: 195231 URL: http://svn.freebsd.org/changeset/base/195231 Log: Fix infinite loop in ng_iface, that happens when packet passes out via two different ng interfaces sequentially due to tunnelling. PR: kern/134557 Submitted b

svn commit: r195232 - in stable/7/sys: . contrib/pf netgraph

2009-07-01 Thread Alexander Motin
Author: mav Date: Wed Jul 1 08:43:05 2009 New Revision: 195232 URL: http://svn.freebsd.org/changeset/base/195232 Log: MFC rev.194699: Mark ng_ether node hooks as HI_STACK. It is usually the last point when netgraph may unroll the call stack, and I have found that in some cases 2K guaranti

Re: svn commit: r195213 - head/usr.sbin/wake

2009-07-01 Thread Stanislav Sedov
On Tue, 30 Jun 2009 22:09:47 + (UTC) Martin Blapp mentioned: > Author: mbr > Date: Tue Jun 30 22:09:47 2009 > New Revision: 195213 > URL: http://svn.freebsd.org/changeset/base/195213 > > Log: > Compiles without higher warn level > > MAN= wake.8 > > -WARNS?= 2 > - I believe you wante

Re: svn commit: r195230 - head

2009-07-01 Thread Ed Schouten
Hi Doug, * Doug Rabson wrote: > Author: dfr > Date: Wed Jul 1 07:37:21 2009 > New Revision: 195230 > URL: http://svn.freebsd.org/changeset/base/195230 > > Log: > Add usr/include/nfs/rpcv2.h > > Submitted by: pluknet at gmail dot com > Approved by: re Not sure, but I think there were m

Re: svn commit: r195230 - head

2009-07-01 Thread Ed Schouten
* Ed Schouten wrote: > Not sure, but I think there were multiple header files that were > removed yesterday. Never mind. They were modified, not removed. Sorry for the noise! -- Ed Schouten WWW: http://80386.nl/ pgpIiHoFUa1Yf.pgp Description: PGP signature

Re: AW: svn commit: r195200 - in head/usr.sbin: . wake

2009-07-01 Thread Robert Watson
On Wed, 1 Jul 2009, Blapp, Martin wrote: I really was not my or Marcs intention to skip any discussions. Rwatson told us that if we like to see it in 8.0, we need to approve it by RE and commit it before the 1. of july, and that's what I've done. Sorry if I've upset anyone. Personally I thi

Re: svn commit: r194681 - head/usr.sbin/wpa/ndis_events

2009-07-01 Thread Maxim Konovalov
On Tue, 30 Jun 2009, 16:38+0200, Dag-Erling Smrgrav wrote: > Maxim Konovalov writes: > > fixed, thanks. > > It still says > > static void > usage() > > I know this is allowed by C99, but it's not allowed by style(9). > >From style(9): static void usage() { /* Insert an empty line if the

Re: svn commit: r194538 - head/sys/sys

2009-07-01 Thread Bruce Evans
On Tue, 30 Jun 2009, [utf-8] Dag-Erling Sm??rgrav wrote: Bruce Evans writes: Freestanding reserves fewer symbols for the implementation. IIRC, freestanding implementations are only required to provide and , and everything else is available to the application. Also , , , and . However, _F

Re: svn commit: r194789 - head/usr.bin/usbhidctl

2009-07-01 Thread Bruce Evans
On Tue, 30 Jun 2009, [utf-8] Dag-Erling Sm??rgrav wrote: Bruce Evans writes: Actually, it is OK to use it in FreeBSD iff the system supports the same program having different names, like reboot/halt/etc. I don't see the point - you would still need different usage messages for each version.

Re: svn commit: r194681 - head/usr.sbin/wpa/ndis_events

2009-07-01 Thread Joerg Sonnenberger
On Wed, Jul 01, 2009 at 03:25:33PM +0400, Maxim Konovalov wrote: > static void > usage() > { > /* Insert an empty line if the function has no local variables. */ > ... > > Apart from the empty line, what's wrong? It is K&R style. It should be static void usage(void) { ... Joerg __

svn commit: r195235 - in head/sys: kern security/audit

2009-07-01 Thread Robert Watson
Author: rwatson Date: Wed Jul 1 12:36:10 2009 New Revision: 195235 URL: http://svn.freebsd.org/changeset/base/195235 Log: udit the 'options' argument to wait4(2). Approved by: re (kib) MFC after:3 days Modified: head/sys/kern/kern_exit.c head/sys/security/audit/audit_bsm.c Mod

svn commit: r195236 - in stable/7/sys: . contrib/pf nfsserver

2009-07-01 Thread Andriy Gapon
Author: avg Date: Wed Jul 1 12:44:23 2009 New Revision: 195236 URL: http://svn.freebsd.org/changeset/base/195236 Log: MFC 185586 (kan): Change nfsserver slightly so that it does not trip over the timestamp validation code on ZFS. This should fix O_CREAT|O_EXCL open on NFS where a server

svn commit: r195237 - head/usr.sbin/wake

2009-07-01 Thread Stanislav Sedov
Author: stas Date: Wed Jul 1 13:07:02 2009 New Revision: 195237 URL: http://svn.freebsd.org/changeset/base/195237 Log: - Fix the bug in write(2) called with incorrect parameters resulting in writes always started from the start of the packet. - Fix usage string (multiple addresses can be

Re: svn commit: r195213 - head/usr.sbin/wake

2009-07-01 Thread Bruce Evans
On Wed, 1 Jul 2009, Stanislav Sedov wrote: On Tue, 30 Jun 2009 22:09:47 + (UTC) Martin Blapp mentioned: Log: Compiles without higher warn level MAN= wake.8 -WARNS?= 2 - I believe you wanted something like WARNS?=6 probably? Now you disabled any warnings-related compiler flags ent

svn commit: r195238 - head/sys/kern

2009-07-01 Thread Robert Watson
Author: rwatson Date: Wed Jul 1 13:22:08 2009 New Revision: 195238 URL: http://svn.freebsd.org/changeset/base/195238 Log: Fix link(2) auditing: use the second audit record path for the new object name. Approved by: re (kib) MFC after:3 days Modified: head/sys/kern/vfs_syscalls.

Re: svn commit: r194681 - head/usr.sbin/wpa/ndis_events

2009-07-01 Thread Bruce Evans
On Wed, 1 Jul 2009, Maxim Konovalov wrote: On Tue, 30 Jun 2009, 16:38+0200, Dag-Erling Smrgrav wrote: Maxim Konovalov writes: fixed, thanks. It still says static void usage() I know this is allowed by C99, but it's not allowed by style(9). From style(9): static void usage() {

Re: svn commit: r194628 - head/lib/ncurses/ncurses

2009-07-01 Thread Dag-Erling Smørgrav
Ulrich Spörlein writes: > Btw, I do like the current behaviour, but if $PAGER can be coerced into > not clearing screen after exit, I think more people could be persuaded. cat >~/.termcap my-xterm:\ ti@:te@:tc=xterm ^D DES -- Dag-Erling Smørgrav - d...@des.no ___

Re: svn commit: r194681 - head/usr.sbin/wpa/ndis_events

2009-07-01 Thread Dag-Erling Smørgrav
Maxim Konovalov writes: > From style(9): > > static void > usage() > ... > > Apart from the empty line, what's wrong? Missing void. I wasn't aware that style(9) was incorrect in that respect. DES -- Dag-Erling Smørgrav - d...@des.no ___ svn-src-all@f

Re: svn commit: r194789 - head/usr.bin/usbhidctl

2009-07-01 Thread Dag-Erling Smørgrav
Bruce Evans writes: > "Dag-Erling Smørgrav" writes: > > BTW, there are numerous style issues in sbin/reboot/reboot.c. > Really? According to knfom, it is 94.772% knf (up from 94.520% in > ~5.2 and 92.896% in Lite2). It is a small program so it is easy to > get right, but anything above 90% is a

Re: svn commit: r194628 - head/lib/ncurses/ncurses

2009-07-01 Thread Dag-Erling Smørgrav
better yet: if [ $TERM = xterm ] ; then export TERMCAP=myterm:ti@:te@:tc=xterm: export TERM=myterm fi DES -- Dag-Erling Smørgrav - d...@des.no ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-al

svn commit: r195242 - in head/sys: kern security/audit

2009-07-01 Thread Robert Watson
Author: rwatson Date: Wed Jul 1 15:37:23 2009 New Revision: 195242 URL: http://svn.freebsd.org/changeset/base/195242 Log: Audit the file descriptor number passed to lseek(2). Approved by: re (kib) MFC after:3 days Modified: head/sys/kern/vfs_syscalls.c head/sys/security/audit/a

Re: svn commit: r195181 - in head/sys: nfsclient nfsserver

2009-07-01 Thread John Baldwin
Steve Kargl wrote: On Tue, Jun 30, 2009 at 05:17:48AM +, bz0...@zabbadoz.net wrote: On Tue, 30 Jun 2009, John Baldwin wrote: Author: jhb Date: Tue Jun 30 03:18:51 2009 New Revision: 195181 URL: http://svn.freebsd.org/changeset/base/195181 Log: Fix build with NFS_LEGACYRPC enabled after th

svn commit: r195243 - head/bin/chmod

2009-07-01 Thread Edward Tomasz Napierala
Author: trasz Date: Wed Jul 1 15:52:19 2009 New Revision: 195243 URL: http://svn.freebsd.org/changeset/base/195243 Log: With NFSv4 ACLs, it is possible that applying a mode to an ACL which is identical to the mode computed from that ACL will modify the ACL. For example, mode computed from t

svn commit: r195244 - head/sys/dev/ixgbe

2009-07-01 Thread Jack F Vogel
Author: jfv Date: Wed Jul 1 16:13:01 2009 New Revision: 195244 URL: http://svn.freebsd.org/changeset/base/195244 Log: Multiqueue RX is not correctly enabled on the new 82599 adapter, the SRRCTL register needs to be setup per queue. Approved by: re Modified: head/sys/dev/ixgbe/ixgbe.c

svn commit: r195245 - head/sys/rpc

2009-07-01 Thread Rick Macklem
Author: rmacklem Date: Wed Jul 1 16:38:18 2009 New Revision: 195245 URL: http://svn.freebsd.org/changeset/base/195245 Log: Make sure that cr_error is set to ESHUTDOWN when closing the connection. This is normally done by a loop in clnt_dg_close(), but requests that aren't in the pending que

svn commit: r195246 - head/sys/rpc/rpcsec_gss

2009-07-01 Thread Rick Macklem
Author: rmacklem Date: Wed Jul 1 16:42:03 2009 New Revision: 195246 URL: http://svn.freebsd.org/changeset/base/195246 Log: When unmounting an NFS mount using sec=krb5[ip], the umount system call could get hung sleeping on "gsssta" if the credentials for a user that had been accessing the mo

svn commit: r195247 - in head/sys: kern security/audit

2009-07-01 Thread Robert Watson
Author: rwatson Date: Wed Jul 1 16:56:56 2009 New Revision: 195247 URL: http://svn.freebsd.org/changeset/base/195247 Log: When auditing unmount(2), capture FSID arguments as regular text strings rather than as paths, which would lead to them being treated as relative pathnames and hence con

svn commit: r195249 - in head/sys: amd64/amd64 amd64/include amd64/isa i386/i386 i386/include i386/isa kern sys

2009-07-01 Thread John Baldwin
Author: jhb Date: Wed Jul 1 17:20:07 2009 New Revision: 195249 URL: http://svn.freebsd.org/changeset/base/195249 Log: Improve the handling of cpuset with interrupts. - For x86, change the interrupt source method to assign an interrupt source to a specific CPU to return an error value inst

svn commit: r195250 - stable/7/sys/dev/cxgb

2009-07-01 Thread Navdeep Parhar
Author: np Date: Wed Jul 1 17:50:59 2009 New Revision: 195250 URL: http://svn.freebsd.org/changeset/base/195250 Log: Fix cxgb's version checks in stable. This makes it select the correct buffer size for freelist1. Approved by: gnn (mentor) Modified: stable/7/sys/dev/cxgb/cxgb_sge.c

svn commit: r195251 - head

2009-07-01 Thread Doug Rabson
Author: dfr Date: Wed Jul 1 18:12:50 2009 New Revision: 195251 URL: http://svn.freebsd.org/changeset/base/195251 Log: Clarify the node about removing NFS_LEGACYRPC Approved by: re Modified: head/UPDATING Modified: head/UPDATING ==

svn commit: r195252 - in head/sys: kern security/audit

2009-07-01 Thread Robert Watson
Author: rwatson Date: Wed Jul 1 18:54:49 2009 New Revision: 195252 URL: http://svn.freebsd.org/changeset/base/195252 Log: Define missing audit argument macro AUDIT_ARG_SOCKET(), and capture the domain, type, and protocol arguments to socket(2) and socketpair(2). Approved by: re (audit

svn commit: r195255 - head/sys/kern

2009-07-01 Thread Robert Watson
Author: rwatson Date: Wed Jul 1 19:55:11 2009 New Revision: 195255 URL: http://svn.freebsd.org/changeset/base/195255 Log: Audit file descriptor numbers for various socket-related system calls. Approved by: re (audit argument blanket) MFC after:3 days Modified: head/sys/kern/uipc_

svn commit: r195256 - in head/sys/arm: at91 mv sa11x0

2009-07-01 Thread Rafal Jaworowski
Author: raj Date: Wed Jul 1 20:07:44 2009 New Revision: 195256 URL: http://svn.freebsd.org/changeset/base/195256 Log: Map DPCPU pages into ARM kernel VA space. DPCPU area was not properly mapped into kernel VA space, which caused page fault on the first DPCPU access. This patch fixes the

svn commit: r195257 - head/sys/geom

2009-07-01 Thread Edward Tomasz Napierala
Author: trasz Date: Wed Jul 1 20:16:29 2009 New Revision: 195257 URL: http://svn.freebsd.org/changeset/base/195257 Log: Fix a panic which (reportedly) can happen when unmounting a filesystem with I/O requests in flight on kernels compiled with "options INVARIANTS". Also, make it obvious it'

svn commit: r195259 - head/sys/kern

2009-07-01 Thread Jeff Roberson
Author: jeff Date: Wed Jul 1 20:43:46 2009 New Revision: 195259 URL: http://svn.freebsd.org/changeset/base/195259 Log: - Use fd_lastfile + 1 as the upper bound on nd. This is more correct than using the size of the descriptor array. - A lock is not needed to fetch fd_lastfile. The re

Re: AW: svn commit: r195200 - in head/usr.sbin: . wake

2009-07-01 Thread Garance A Drosehn
At 7:04 AM +0200 7/1/09, Blapp, Martin wrote: Hi folks, I really was not my or Marcs intention to skip any discussions. Rwatson told us that if we like to see it in 8.0, we need to approve it by RE and commit it before the 1. of july, and that's what I've done. Sorry if I've upset anyone. Perso

svn commit: r195264 - head/usr.sbin/wake

2009-07-01 Thread Stanislav Sedov
Author: stas Date: Wed Jul 1 22:23:26 2009 New Revision: 195264 URL: http://svn.freebsd.org/changeset/base/195264 Log: - Properly order headers, local variables and prototypes. [1] - Remove unneeded headers. - Return non-zero error code in usage(). Approved by: re (kib) Suggested by

svn commit: r195265 - head/sys/ufs/ffs

2009-07-01 Thread Edward Tomasz Napierala
Author: trasz Date: Wed Jul 1 22:30:36 2009 New Revision: 195265 URL: http://svn.freebsd.org/changeset/base/195265 Log: Don't panic on attempt to set ACL on a block device file. This is just a part of kern/125613. PR: kern/125613 Submitted by: Jaakko Heinonen Reviewed by:

svn commit: r195267 - in head/sys: kern security/audit

2009-07-01 Thread Robert Watson
Author: rwatson Date: Wed Jul 1 22:47:45 2009 New Revision: 195267 URL: http://svn.freebsd.org/changeset/base/195267 Log: For access(2) and eaccess(2), audit the requested access mode. Approved by: re (audit argument blanket) MFC after:3 days Modified: head/sys/kern/vfs_syscalls.

svn commit: r195272 - in stable/7/usr.sbin/sysinstall: . help

2009-07-01 Thread Xin LI
Author: delphij Date: Thu Jul 2 00:36:00 2009 New Revision: 195272 URL: http://svn.freebsd.org/changeset/base/195272 Log: MFC r180208 (peter): Set magic fbsd:nokeywords property that allows files to bypass keyword expansion. (file-specific replacement for CVSROOT/exclude) Modified: st

svn commit: r195276 - in stable/6/usr.sbin/sysinstall: . help

2009-07-01 Thread Xin LI
Author: delphij Date: Thu Jul 2 00:44:21 2009 New Revision: 195276 URL: http://svn.freebsd.org/changeset/base/195276 Log: MFC r180208 (peter): Set magic fbsd:nokeywords property that allows files to bypass keyword expansion. (file-specific replacement for CVSROOT/exclude) Modified: st

svn commit: r195277 - in stable/6/usr.sbin/sysinstall: . help

2009-07-01 Thread Xin LI
Author: delphij Date: Thu Jul 2 00:45:28 2009 New Revision: 195277 URL: http://svn.freebsd.org/changeset/base/195277 Log: MFC r195012: Correct a typo (which you can use to in order -> which you can use in order to). PR: bin/136040 Submitted by: "Vikentii L. Karabin" Mo

svn commit: r195273 - in stable/7/usr.sbin/sysinstall: . help

2009-07-01 Thread Xin LI
Author: delphij Date: Thu Jul 2 00:39:25 2009 New Revision: 195273 URL: http://svn.freebsd.org/changeset/base/195273 Log: MFC r195012: Correct a typo (which you can use to in order -> which you can use in order to). PR: bin/136040 Submitted by: "Vikentii L. Karabin" Mo

svn commit: r195274 - head/sys/dev/mpt

2009-07-01 Thread Xin LI
Author: delphij Date: Thu Jul 2 00:41:37 2009 New Revision: 195274 URL: http://svn.freebsd.org/changeset/base/195274 Log: Change explicit maximium numbers to the defined macro MPT_MAX_LUNS. Approved by: re (kensmith) Modified: head/sys/dev/mpt/mpt_cam.c Modified: head/sys/dev/mpt/mpt_

svn commit: r195275 - head/sys/dev/mpt

2009-07-01 Thread Xin LI
Author: delphij Date: Thu Jul 2 00:43:10 2009 New Revision: 195275 URL: http://svn.freebsd.org/changeset/base/195275 Log: Use MPT_MAX_LUNS as maximium number of LUNs, not 7, for SAS and FC cases. This matches Linux driver behavior. Discussed with: scottl Approved by: re (kensmit