Bruce Evans <b...@optusnet.com.au> writes: > "Dag-Erling Smørgrav" <d...@des.no> writes: > > BTW, there are numerous style issues in sbin/reboot/reboot.c. > Really? According to knfom, it is 94.772% knf (up from 94.520% in > ~5.2 and 92.896% in Lite2). It is a small program so it is easy to > get right, but anything above 90% is a nice colour. (94.520% is due > to 7 lines fixed by indent(1) and 5 lines broken by indent(1)).
I guess it depends on your definition of "numerous". The most obvious ones (since I was looking at usage()) were the missing void in the definition of usage() and the missing blank line at the top of the function. Other than that: #include directives are unordered, local variables in main() are declared in the wrong order, geteuid() is used as a predicate, and the required parentheses around the return value in get_pageins() are missing. I would also use fopen(3) and fprintf(3) instead of open(2) and write(2) to write nextboot.conf, and I would check that argc is 0 after the getopt(3) loop. DES -- Dag-Erling Smørgrav - d...@des.no _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
