Re: svn commit: r316477 - head/usr.bin/grep

> On Apr 4, 2017, at 17:54, Kyle Evans wrote: > > On Tue, Apr 4, 2017 at 7:51 PM, Rodney W. Grimes > wrote: > Also it might be worth making NetBSD aware of the bad output, and fix > it there, and the regression test, and everyone well be better off. The color tests are new to FreeBSD/NetBSD.

Re: svn commit: r316477 - head/usr.bin/grep

On Tue, Apr 4, 2017 at 7:51 PM, Rodney W. Grimes < free...@pdx.rh.cn85.dnsmgr.net> wrote: > > Also it might be worth making NetBSD aware of the bad output, and fix > it there, and the regression test, and everyone well be better off. > FWIW- I've been in contact with ngie@ w.r.t regression testing

Re: svn commit: r316477 - head/usr.bin/grep

> On 04.04.2017 15:24, Kyle Evans wrote: > > On Tue, Apr 4, 2017 at 7:07 AM, Andrey Chernov > > wrote: > > > > On 04.04.2017 2:16, Ed Maste wrote: > > > if (color) > > > - fprintf(stdout, "\33[m\33[K"); > >

Re: svn commit: r316477 - head/usr.bin/grep

On 04.04.2017 16:41, Kyle Evans wrote: > Upon further review, newer versions of GNU grep(1) drop the explicit > '00' and add the \33[K dropped in this commit a few lines above the > mentioned one. In that case, we might as well revert those two lines and > consider this an improvement. I guess it d

Re: svn commit: r316477 - head/usr.bin/grep

On Tue, Apr 4, 2017 at 8:53 AM, Ed Maste wrote: > In this case I'd rather we remove the 00 and have the test verify > that. I think it's fine if there are a few tests that fail when run > with GNU grep where it has the undesired, differing behaviour. > Excellent- can you please revert this entir

Re: svn commit: r316477 - head/usr.bin/grep

On 4 April 2017 at 09:09, Kyle Evans wrote: > > This is where it gets kind of finnicky, and I'll step out and let others > weigh in -- the test I refer to was specifically written by me > (https://reviews.freebsd.org/D10112), and it's entirely to make it easier > for me to check and quantify to ot

Re: svn commit: r316477 - head/usr.bin/grep

On Tue, Apr 4, 2017 at 8:19 AM, Andrey Chernov wrote: > On 04.04.2017 16:09, Kyle Evans wrote: > > > > First, apologies, I must rewind: what did you mean initially by "We > > don't need to handle internally [...]" > > -- the second half I understand, but it occurs to me that we should > > alrea

Re: svn commit: r316477 - head/usr.bin/grep

On 04.04.2017 16:05, Bruce Evans wrote: > This might be to work around a bug in a terminal driver. I needed the > 0 (but just one) to reset the attributes in my attribute tests, on at > least 1 of the tested terminals (current sc, current vt, old sc, old > xterm, old cygwin xterm). CSI m seems to

Re: svn commit: r316477 - head/usr.bin/grep

On 04.04.2017 16:09, Kyle Evans wrote: > > First, apologies, I must rewind: what did you mean initially by "We > don't need to handle internally [...]" > -- the second half I understand, but it occurs to me that we should > already be internally handling \33[m = \33[00m as defined by ANSI. Of c

Re: svn commit: r316477 - head/usr.bin/grep

First, apologies, I must rewind: what did you mean initially by "We don't need to handle internally [...]" -- the second half I understand, but it occurs to me that we should already be internally handling \33[m = \33[00m as defined by ANSI. On Tue, Apr 4, 2017 at 7:37 AM, Andrey Chernov wrote:

Re: svn commit: r316477 - head/usr.bin/grep

On Tue, 4 Apr 2017, Andrey Chernov wrote: On 04.04.2017 2:16, Ed Maste wrote: if (color) - fprintf(stdout, "\33[m\33[K"); + fprintf(stdout, "\33[00m\33[K"); Please back that one out. We don't need to handle in

Re: svn commit: r316477 - head/usr.bin/grep

On 04.04.2017 15:24, Kyle Evans wrote: > On Tue, Apr 4, 2017 at 7:07 AM, Andrey Chernov > wrote: > > On 04.04.2017 2:16, Ed Maste wrote: > > if (color) > > - fprintf(stdout, "\33[m\33[K"); > > +

Re: svn commit: r316477 - head/usr.bin/grep

On Tue, Apr 4, 2017 at 7:07 AM, Andrey Chernov wrote: > On 04.04.2017 2:16, Ed Maste wrote: > > if (color) > > - fprintf(stdout, "\33[m\33[K"); > > + fprintf(stdout, "\33[00m\33[K"); > > Please back that one out. We don

Re: svn commit: r316477 - head/usr.bin/grep

On 04.04.2017 2:16, Ed Maste wrote: > if (color) > - fprintf(stdout, "\33[m\33[K"); > + fprintf(stdout, "\33[00m\33[K"); Please back that one out. We don't need to handle internally or print remotely excessive 00. At le

svn commit: r316477 - head/usr.bin/grep

Author: emaste Date: Mon Apr 3 23:16:51 2017 New Revision: 316477 URL: https://svnweb.freebsd.org/changeset/base/316477 Log: bsdgrep: fix matching behaviour - Set REG_NOTBOL if we've already matched beginning of line and we're examining later parts - For each pattern we examine, a