On Tue, Apr 4, 2017 at 7:07 AM, Andrey Chernov <a...@freebsd.org> wrote:

> On 04.04.2017 2:16, Ed Maste wrote:
> >                       if (color)
> > -                             fprintf(stdout, "\33[m\33[K");
> > +                             fprintf(stdout, "\33[00m\33[K");
>
> Please back that one out. We don't need to handle internally or print
> remotely excessive 00.
> At least according to
> https://en.wikipedia.org/wiki/ANSI_escape_code
> "With no parameters, CSI m is treated as CSI 0 m (reset / normal), which
> is typical of most of the ANSI escape sequences."


Hi ache@,

This specific change was made in the name of explicitly matching colored
output of GNU grep for simplification of regression test purposes, rather
than for good form. Is it still unacceptable to do so?

Thanks,

Kyle Evans
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Reply via email to