Re: INCLUDE_CONFIG_FILE in GENERIC

2010-01-18 Thread Dag-Erling Smørgrav
"M. Warner Losh" writes: > [...] I think this > is the model that best fits most user's needs, since they EITHER take > GENERIC and hack on it (in which case we preserve all that), OR they > include GENERIC and opt in/out of things based on that default. The latter is a far better option - I use

Re: INCLUDE_CONFIG_FILE in GENERIC

2010-01-16 Thread Ulrich Spörlein
On Fri, 15.01.2010 at 19:58:57 +1100, Peter Jeremy wrote: > On 2010-Jan-14 20:12:24 +, "Robert N. M. Watson" > wrote: > >- Desktop/server users who want their system to work without any > > special tuning or magic, and likely feel the comments they put in > > configuration files are importa

Re: INCLUDE_CONFIG_FILE in GENERIC

2010-01-15 Thread Garance A Drosehn
At the risk of sounding overly simplistic, how hard is it to just go ahead and include both versions? In my current /boot/kernel/kernel , it looks like there's 2675 bytes of CONFIG_AUTOGENERATED lines. My original config file is 13540 bytes. I don't see that there's all that much pain in inclu

Re: INCLUDE_CONFIG_FILE in GENERIC

2010-01-15 Thread Marcel Moolenaar
On Jan 15, 2010, at 11:48 AM, M. Warner Losh wrote: > : PITA != hard. If we're not willing to put in the effort to fix > : something, I don't think we should call it hard to do. We should > : call it like it is: non-trivial, involved or significant. Heck, > : we can even call it a major undertakin

Re: INCLUDE_CONFIG_FILE in GENERIC

2010-01-15 Thread M. Warner Losh
In message: Marcel Moolenaar writes: : : On Jan 15, 2010, at 10:05 AM, M. Warner Losh wrote: : > : Is this really so hard? : > : > Yes. Didn't you read the message I posted about why this is hard? : : No, I didn't. : : > There would be a ton of lexer and parser work to make this h

Re: INCLUDE_CONFIG_FILE in GENERIC

2010-01-15 Thread Marcel Moolenaar
On Jan 15, 2010, at 10:05 AM, M. Warner Losh wrote: > : Is this really so hard? > > Yes. Didn't you read the message I posted about why this is hard? No, I didn't. > There would be a ton of lexer and parser work to make this happen, as > well as a lot of work to internal data structures to keep

Re: INCLUDE_CONFIG_FILE in GENERIC

2010-01-15 Thread M. Warner Losh
In message: Marcel Moolenaar writes: : : On Jan 15, 2010, at 9:47 AM, Wojciech A. Koszek wrote: : : > On Fri, Jan 15, 2010 at 12:50:55PM +1100, Bruce Evans wrote: : >> On Thu, 14 Jan 2010, M. Warner Losh wrote: : >> : >>> In message: <86625798-f339-4863-8f97-63b5232a6...@freebsd.or

Re: INCLUDE_CONFIG_FILE in GENERIC

2010-01-15 Thread Marcel Moolenaar
On Jan 15, 2010, at 9:47 AM, Wojciech A. Koszek wrote: > On Fri, Jan 15, 2010 at 12:50:55PM +1100, Bruce Evans wrote: >> On Thu, 14 Jan 2010, M. Warner Losh wrote: >> >>> In message: <86625798-f339-4863-8f97-63b5232a6...@freebsd.org> >>> "Robert N. M. Watson" writes: >>> : I agree. I

Re: INCLUDE_CONFIG_FILE in GENERIC

2010-01-15 Thread Wojciech A. Koszek
On Fri, Jan 15, 2010 at 12:50:55PM +1100, Bruce Evans wrote: > On Thu, 14 Jan 2010, M. Warner Losh wrote: > >> In message: <86625798-f339-4863-8f97-63b5232a6...@freebsd.org> >>"Robert N. M. Watson" writes: >> : I agree. I see two kinds of users: >> : [..] Reasoning behind -C was tha

Re: INCLUDE_CONFIG_FILE in GENERIC

2010-01-15 Thread Peter Jeremy
On 2010-Jan-14 20:12:24 +, "Robert N. M. Watson" wrote: >- Desktop/server users who want their system to work without any > special tuning or magic, and likely feel the comments they put in > configuration files are important As far as I'm concerned, the most critical bit of my kernel conf

Re: INCLUDE_CONFIG_FILE in GENERIC

2010-01-14 Thread Bruce Evans
On Thu, 14 Jan 2010, M. Warner Losh wrote: In message: <86625798-f339-4863-8f97-63b5232a6...@freebsd.org> "Robert N. M. Watson" writes: : I agree. I see two kinds of users: : : - Desktop/server users who want their system to work without any : special tuning or magic, and likely feel

Re: INCLUDE_CONFIG_FILE in GENERIC

2010-01-14 Thread M. Warner Losh
In message: <86625798-f339-4863-8f97-63b5232a6...@freebsd.org> "Robert N. M. Watson" writes: : : On 14 Jan 2010, at 20:01, Doug Barton wrote: : : > FWIW, I actually think this makes it worse, not better. The : > INCLUDE_CONFIG_FILE option should include everything needed to recreate

Re: INCLUDE_CONFIG_FILE in GENERIC

2010-01-14 Thread Robert N. M. Watson
On 14 Jan 2010, at 20:01, Doug Barton wrote: > FWIW, I actually think this makes it worse, not better. The > INCLUDE_CONFIG_FILE option should include everything needed to recreate > the kernel. If it doesn't, it's worse than worthless, it leads to a > false sense of security which makes it dange

Re: INCLUDE_CONFIG_FILE in GENERIC

2010-01-14 Thread Doug Barton
On 1/14/2010 9:56 AM, M. Warner Losh wrote: + * If INCLUDE_CONFIG_FILE is defined, then we include the config file + * verbatim (and that's the only config file we include). Otherwise, if + * INCLUDE_CONFIG is defined, we include it. Otherwise, we include nothing + * at all. FWIW, I actually thi

Re: INCLUDE_CONFIG_FILE in GENERIC

2010-01-14 Thread M. Warner Losh
In message: <20100114.102142.328914705071816274@bsdimp.com> "M. Warner Losh" writes: : Personally, I'd rather see us have two different options here, as : suggested by others, so that it is clear and self-contained. I'd vote : for INCLUDE_CONFIG for today's behavior without -C, an

Re: INCLUDE_CONFIG_FILE in GENERIC

2010-01-14 Thread M. Warner Losh
In message: Robert Watson writes: : : > In the interests of bringing this to a close: : > # Store the plain version of the configuration file in the kernel : > # itself. : > # For information on extraction, and storing the comments also, see : > config(8). : : Am I right in thinking

Re: INCLUDE_CONFIG_FILE in GENERIC

2010-01-14 Thread Robert Watson
In the interests of bringing this to a close: # Store the plain version of the configuration file in the kernel itself. # For information on extraction, and storing the comments also, see config(8). Am I right in thinking that even with this change, you still end up with a single giant config

Re: INCLUDE_CONFIG_FILE in GENERIC

2010-01-14 Thread Bruce Evans
On Thu, 14 Jan 2010, Nikolay Denev wrote: I just want to add a user's point of view : To me INCLUDE_CONFIG_FILE sounds like the whole config file will be included, not just the output after preprocessing. It used to mean to actually include the config file. This became a broken meaning when t

Re: INCLUDE_CONFIG_FILE in GENERIC

2010-01-13 Thread Nikolay Denev
On 14 Jan, 2010, at 24:04 , M. Warner Losh wrote: > In message: <201001131633.09669@freebsd.org> >John Baldwin writes: > : On Wednesday 13 January 2010 3:36:26 pm Doug Barton wrote: > : > On 1/13/2010 12:15 PM, John Baldwin wrote: > : > > On Wednesday 13 January 2010 1:48:38 pm Do

Re: INCLUDE_CONFIG_FILE in GENERIC

2010-01-13 Thread M. Warner Losh
In message: <201001131633.09669@freebsd.org> John Baldwin writes: : On Wednesday 13 January 2010 3:36:26 pm Doug Barton wrote: : > On 1/13/2010 12:15 PM, John Baldwin wrote: : > > On Wednesday 13 January 2010 1:48:38 pm Doug Barton wrote: : > >> To address the other responses, Tom,

Re: INCLUDE_CONFIG_FILE in GENERIC

2010-01-13 Thread John Baldwin
On Wednesday 13 January 2010 3:28:31 pm Julian Elischer wrote: > John Baldwin wrote: > > On Wednesday 13 January 2010 1:48:38 pm Doug Barton wrote: > >> To address the other responses, Tom, sorry, your suggested text doesn't > >> address my concern. John, I don't think that users would somehow > >>

Re: INCLUDE_CONFIG_FILE in GENERIC

2010-01-13 Thread Julian Elischer
John Baldwin wrote: On Wednesday 13 January 2010 1:48:38 pm Doug Barton wrote: To address the other responses, Tom, sorry, your suggested text doesn't address my concern. John, I don't think that users would somehow magically know to look in NOTES for more information about an option that is alr

Re: INCLUDE_CONFIG_FILE in GENERIC

2010-01-13 Thread John Baldwin
On Wednesday 13 January 2010 3:36:26 pm Doug Barton wrote: > On 1/13/2010 12:15 PM, John Baldwin wrote: > > On Wednesday 13 January 2010 1:48:38 pm Doug Barton wrote: > >> To address the other responses, Tom, sorry, your suggested text doesn't > >> address my concern. John, I don't think that users

Re: INCLUDE_CONFIG_FILE in GENERIC

2010-01-13 Thread Doug Barton
On 1/13/2010 12:15 PM, John Baldwin wrote: > On Wednesday 13 January 2010 1:48:38 pm Doug Barton wrote: >> To address the other responses, Tom, sorry, your suggested text doesn't >> address my concern. John, I don't think that users would somehow >> magically know to look in NOTES for more informat

Re: INCLUDE_CONFIG_FILE in GENERIC

2010-01-13 Thread John Baldwin
On Wednesday 13 January 2010 1:48:38 pm Doug Barton wrote: > To address the other responses, Tom, sorry, your suggested text doesn't > address my concern. John, I don't think that users would somehow > magically know to look in NOTES for more information about an option > that is already in GENERIC

Re: INCLUDE_CONFIG_FILE in GENERIC

2010-01-13 Thread Doug Barton
n, 10 Jan 2010, Warner Losh wrote: > : > : > : > : > Author: imp > : > : > Date: Sun Jan 10 17:44:22 2010 > : > : > New Revision: 202019 > : > : > URL: http://svn.freebsd.org/changeset/base/202019 > : > : > > : > : > Log: > : > : > Add INCLUDE_CON

Re: INCLUDE_CONFIG_FILE in GENERIC

2010-01-13 Thread M. Warner Losh
Jan 2010, Warner Losh wrote: : > > : : > > : > Author: imp : > > : > Date: Sun Jan 10 17:44:22 2010 : > > : > New Revision: 202019 : > > : > URL: http://svn.freebsd.org/changeset/base/202019 : > > : > : > > : > Log: : > > : > Add

Re: INCLUDE_CONFIG_FILE in GENERIC

2010-01-13 Thread John Baldwin
10 17:44:22 2010 > > : > New Revision: 202019 > > : > URL: http://svn.freebsd.org/changeset/base/202019 > > : > > > : > Log: > > : > Add INCLUDE_CONFIG_FILE in GENERIC on all non-embedded platforms. > > : > > : Thanks for doing this, however

Re: INCLUDE_CONFIG_FILE in GENERIC

2010-01-12 Thread M. Warner Losh
Date: Sun Jan 10 17:44:22 2010 : > : > New Revision: 202019 : > : > URL: http://svn.freebsd.org/changeset/base/202019 : > : > : > : > Log: : > : > Add INCLUDE_CONFIG_FILE in GENERIC on all non-embedded platforms. : > : : > : Thanks for doing this, however the comment about

INCLUDE_CONFIG_FILE in GENERIC

2010-01-12 Thread Doug Barton
hangeset/base/202019 > : > > : > Log: > : > Add INCLUDE_CONFIG_FILE in GENERIC on all non-embedded platforms. > : > : Thanks for doing this, however the comment about how to include the > : whole file (including the comments) were not included. Do I need to do > : t