This issue is stale because it has been open 6 weeks with no activity. Remove
stale label or comment or this will be closed in 2 weeks.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/4019#issuecomment-2557967993
You are receiving this because yo
This issue is stale because it has been open 6 weeks with no activity. Remove
stale label or comment or this will be closed in 2 weeks.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3982#issuecomment-2557967982
You are receiving this because yo
This issue is stale because it has been open 6 weeks with no activity. Remove
stale label or comment or this will be closed in 2 weeks.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3995#issuecomment-2557967988
You are receiving this because yo
Suggestion for `cmake/compiler-specific.cmake` - allow user to override
CFLAGS/LDFLAGS:
```
if(CMAKE_SYSTEM_PROCESSOR STREQUAL "x86_64")
if(CMAKE_C_COMPILER_ID STREQUAL "GNU")
target_compile_definitions(common INTERFACE CC_GCC_LIKE_ASM)
if(NOT DEFINED ENV{CFLAGS})
target_compile
### Description
ping @xkaraman
cmake is overriding distro build flags
Here is typical CFLAGS for EL distros
```
export CFLAGS='-O2 -flto=auto -ffat-lto-objects -fexceptions -g
-grecord-gcc-switches -pipe -Wall -Werror=format-security
-Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS
-specs
> I pushed a commit for it, can you try with git master branch?
I applied d92a990a4040279ed7ee4d71debf2a13fd4d6782 and
9abe414a186e2a6e9041dd03a1a8968f0efa954d to `5.8` and it works now as expected.
Thanks.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamail
I think i agree on `add_library` should stay in each module `CMakelists.txt`
folder, to be clearly visible.
For code formating there are tools to enforce, that's what I meant. Completely
agree in the coherence/uniformity side though and we should do it of course.
```
file(GLOB MODULE_SOURCES "
Module: kamailio
Branch: master
Commit: b5cb581bd8f529dab8f4bcc6173e0cf1ad936550
URL:
https://github.com/kamailio/kamailio/commit/b5cb581bd8f529dab8f4bcc6173e0cf1ad936550
Author: S-P Chan
Committer: S-P Chan
Date: 2024-12-20T20:56:09+08:00
tls: warn if tls_threads_mode=1 and force value to 2
Yes - I will do that (re: warning on tls_threads_mode=1).
On further study I will not implement tls_threads_mode=3 for 6.x; I'll
merely leave it in the docs.
It uses a function that is actually deprecated in libssl3 - so is fragile
with respect to the build of OpenSSL.
Regards
Richard
___
Hi Richard,
thanks, sounds fine then.
We probably should add some logic to detect the tls_thread mode 1 setting for
existing configuration, and then log a WARNING and use the mode 2 or so.
Cheers,
Henning
From: Richard Chan
Sent: Freitag, 20. Dezember 2024 13:14
To: Henning Westerholt
Cc: K
Henning - noted about this; I'm looking at how intrusive the diff is but a
quick assessment shows that it shouldn't touch any modules outside tls.so.
On Fri, 20 Dec 2024 at 16:42, Henning Westerholt wrote:
> Hello Richard,
>
>
>
> as we are in the code freeze for 6.0 already, it would be great
Module: kamailio
Branch: master
Commit: 003a92942aeefd6611f9a2754f71b293ac73caaf
URL:
https://github.com/kamailio/kamailio/commit/003a92942aeefd6611f9a2754f71b293ac73caaf
Author: Xenofon Karamanos
Committer: Xenofon Karamanos
Date: 2024-12-20T11:04:53Z
cmake/utills: Config all files for build
Module: kamailio
Branch: master
Commit: ea96d46a6ab4d60614a1f1cb86bcc1d983811b06
URL:
https://github.com/kamailio/kamailio/commit/ea96d46a6ab4d60614a1f1cb86bcc1d983811b06
Author: Xenofon Karamanos
Committer: Xenofon Karamanos
Date: 2024-12-20T11:04:53Z
cmake/utils: Fix double kamctl lib path
Hi Xenofon,
It works for me now - thanks! You can go ahead with the merge to master.
On Fri, 20 Dec 2024 at 19:35, Xenofon via sr-dev
wrote:
> Hey Richard,
>
> Thanks for testing this out and letting me know! I pushed some fixes
> regarding `kamctl` and `kamdbctl` in
> https://github.com/kamail
@xkaraman: I know that technically the result is the same, but it is also about
coherence/uniformity and future maintenance. At the end nothing can be
enforced, but we have suggestions/recommendations that we provide to developers
(the contribution guidelines, code formatting, ... ).
I won't l
Hey Richard,
Thanks for testing this out and letting me know! I pushed some fixes regarding
`kamctl` and `kamdbctl` in https://github.com/kamailio/kamailio/tree/cmake
branch! I have tested and it seems to work.
If you can confirm it as well before pushing to master, and it works as
expected w
Module: kamailio
Branch: master
Commit: 13c3f133ffd1f158593d2aa4b3b61d88c2009a6a
URL:
https://github.com/kamailio/kamailio/commit/13c3f133ffd1f158593d2aa4b3b61d88c2009a6a
Author: Victor Seva
Committer: Victor Seva
Date: 2024-12-20T11:26:30+01:00
github: remove extra info from nightly jobs [ski
Module: kamailio
Branch: master
Commit: e36b2d60de5c8ea6831e174bb3e690c374a755b3
URL:
https://github.com/kamailio/kamailio/commit/e36b2d60de5c8ea6831e174bb3e690c374a755b3
Author: Victor Seva
Committer: Victor Seva
Date: 2024-12-20T11:23:53+01:00
github: remove extra info from nightly jobs [ski
@miconda @henningw
For the `GLOB`ing it doesn't really matter, `acc_SRC` or `SRC_FILES` is just a
variable name. When I started implementing this I used the `acc_SRC` but then
since I was copy-pasting a lot, I just used a non module-name variable.
We can decide on one, but since we can't enfor
Module: kamailio
Branch: master
Commit: 852d17946e8857056572a03f3b5bff6438bed29c
URL:
https://github.com/kamailio/kamailio/commit/852d17946e8857056572a03f3b5bff6438bed29c
Author: Victor Seva
Committer: Victor Seva
Date: 2024-12-20T10:53:52+01:00
github: add step name on check [skip ci]
---
M
Module: kamailio
Branch: master
Commit: 4133f24fde0ade54a5454baf045f774a73434cef
URL:
https://github.com/kamailio/kamailio/commit/4133f24fde0ade54a5454baf045f774a73434cef
Author: Victor Seva
Committer: Victor Seva
Date: 2024-12-20T10:39:16+01:00
github: fix check step for nightly jobs [skip ci
Module: kamailio
Branch: master
Commit: 2df6fd2b92c95791fa299500680a31814f95291c
URL:
https://github.com/kamailio/kamailio/commit/2df6fd2b92c95791fa299500680a31814f95291c
Author: S-P Chan
Committer: S-P Chan
Date: 2024-12-20T17:01:03+08:00
tls: warn if thread-locals are initialized before this
Module: kamailio
Branch: master
Commit: 5c48fb7ba1b6e7d516d6f5dad50f8c0a91f0a298
URL:
https://github.com/kamailio/kamailio/commit/5c48fb7ba1b6e7d516d6f5dad50f8c0a91f0a298
Author: Kamailio Dev
Committer: Kamailio Dev
Date: 2024-12-20T09:46:07+01:00
modules: readme files regenerated - siprepo ..
Hello Richard,
as we are in the code freeze for 6.0 already, it would be great if you could
quickly outline how intrusive the proposed tls_thread mode 3 would be, e.g.
would it touch all the modules etc..
We might consider maybe then adding it later.
Thank you,
Henning
From: Richard Chan via
Module: kamailio
Branch: master
Commit: ed61054f3b406452397bb22ae4d53b84d949
URL:
https://github.com/kamailio/kamailio/commit/ed61054f3b406452397bb22ae4d53b84d949
Author: Daniel-Constantin Mierla
Committer: Daniel-Constantin Mierla
Date: 2024-12-20T09:41:45+01:00
siprepo: docs - small
Module: kamailio
Branch: master
Commit: 8cc21a5af0846ddd657b20363895e220658816ea
URL:
https://github.com/kamailio/kamailio/commit/8cc21a5af0846ddd657b20363895e220658816ea
Author: S-P Chan
Committer: S-P Chan
Date: 2024-12-20T16:36:12+08:00
tls: fix compiler warning of unused variable
---
Mod
Module: kamailio
Branch: master
Commit: 398e647b0667f5609d30ccb9f4cedbb659dca3ab
URL:
https://github.com/kamailio/kamailio/commit/398e647b0667f5609d30ccb9f4cedbb659dca3ab
Author: S-P Chan
Committer: S-P Chan
Date: 2024-12-20T16:27:07+08:00
tls: revert tls_threads_mode=1
---
Modified: src/mod
Module: kamailio
Branch: master
Commit: ca87db75102504eb29e802a0047cf22730dfc30e
URL:
https://github.com/kamailio/kamailio/commit/ca87db75102504eb29e802a0047cf22730dfc30e
Author: S-P Chan
Committer: S-P Chan
Date: 2024-12-20T16:27:07+08:00
core: revert tls_threads_mode=1
---
Modified: src/co
Module: kamailio
Branch: master
Commit: 92f17d2e7945858cdfe40ab498fb7b046e02955a
URL:
https://github.com/kamailio/kamailio/commit/92f17d2e7945858cdfe40ab498fb7b046e02955a
Author: S-P Chan
Committer: S-P Chan
Date: 2024-12-20T16:27:07+08:00
xcap_client: revert tls_threads_mode=1
---
Modified:
Module: kamailio
Branch: master
Commit: ab6d46e6ab08066021419154045da5c3f2721377
URL:
https://github.com/kamailio/kamailio/commit/ab6d46e6ab08066021419154045da5c3f2721377
Author: S-P Chan
Committer: S-P Chan
Date: 2024-12-20T16:27:07+08:00
outbound: revert tls_threads_mode=1
---
Modified: sr
Module: kamailio
Branch: master
Commit: a8c23061bf2b9ce2240cd52e554b440cb996bc9e
URL:
https://github.com/kamailio/kamailio/commit/a8c23061bf2b9ce2240cd52e554b440cb996bc9e
Author: S-P Chan
Committer: S-P Chan
Date: 2024-12-20T16:27:07+08:00
db_unixodbc: revert tls_threads_mode=1
---
Modified:
Module: kamailio
Branch: master
Commit: de84212c4a43402ea094f1b38aed9ca09b0c89a5
URL:
https://github.com/kamailio/kamailio/commit/de84212c4a43402ea094f1b38aed9ca09b0c89a5
Author: S-P Chan
Committer: S-P Chan
Date: 2024-12-20T16:27:07+08:00
http_client: revert tls_threads_mode=1
---
Modified:
Module: kamailio
Branch: master
Commit: 7f33c48cc788d4caea0b1e06748bae0e6a6e90fb
URL:
https://github.com/kamailio/kamailio/commit/7f33c48cc788d4caea0b1e06748bae0e6a6e90fb
Author: S-P Chan
Committer: S-P Chan
Date: 2024-12-20T16:27:07+08:00
http_async_client: revert tls_threads_mode=1
---
Mod
Module: kamailio
Branch: master
Commit: b7694edb65db852ee5a935fbbfe6f9d8c05fa508
URL:
https://github.com/kamailio/kamailio/commit/b7694edb65db852ee5a935fbbfe6f9d8c05fa508
Author: S-P Chan
Committer: S-P Chan
Date: 2024-12-20T16:27:07+08:00
db_postgres: revert tls_threads_mode=1
---
Modified:
Module: kamailio
Branch: master
Commit: 50042a4a21318f9b89cd1b5d35c04800ef2cbec5
URL:
https://github.com/kamailio/kamailio/commit/50042a4a21318f9b89cd1b5d35c04800ef2cbec5
Author: S-P Chan
Committer: S-P Chan
Date: 2024-12-20T16:27:07+08:00
db_mysql: revert tls_threads_mode=1
---
Modified: sr
The `${module_name}` is available in the CMakeLists.txt from modules, I tested
for acc module with the following CMakeLists.txt content:
```
file(GLOB MODULE_SOURCES "*.c")
add_library(${module_name} SHARED ${MODULE_SOURCES})
```
What do you think, is it good to use it in the CMakeLists.txt for
36 matches
Mail list logo
