On Tue, Apr 19, 2016 at 07:46:14PM +0530, RK RK wrote:
> Thanks for your reply Christophe, I am using oVirt 3.6.3 in my production
> environment with 250 Virtual Desktops accessed from within the office
> premises.
>
> Our users will have thin client devices running trimmed down version of
> CentO
On Tue, Apr 19, 2016 at 5:16 PM, RK RK wrote:
> Thanks for your reply Christophe, I am using oVirt 3.6.3 in my production
> environment with 250 Virtual Desktops accessed from within the office
> premises.
>
> Our users will have thin client devices running trimmed down version of
> CentOS 7 with
I have attached the deprecation message screenshot for your reference.
On Tue, Apr 19, 2016 at 7:46 PM, RK RK wrote:
> Thanks for your reply Christophe, I am using oVirt 3.6.3 in my production
> environment with 250 Virtual Desktops accessed from within the office
> premises.
>
> Our users will
Thanks for your reply Christophe, I am using oVirt 3.6.3 in my production
environment with 250 Virtual Desktops accessed from within the office
premises.
Our users will have thin client devices running trimmed down version of
CentOS 7 with spice-xpi installed via yum.
Please let me know if you ne
On Tue, Apr 19, 2016 at 11:36:21AM +0530, RK RK wrote:
> Hi Team,
>
> I have seen in https://bugs.freedesktop.org/enter_bug.cgi?product=Spice
> that xpi-activex (Browser plugins (to be deprecated)).
I cannot find the "to be deprecated" that you mention by looking
at this page, or at the bug list
> Something like that diff squashed into this patch?
Yep, looks okay.
This is an interesting hack by firefox btw, looks hard to catch.
> --- a/SpiceXPI/src/plugin/controller.cpp
> +++ b/SpiceXPI/src/plugin/controller.cpp
> @@ -174,6 +174,7 @@ gpointer SpiceController::ClientThread(gpointer data)
On Thu, Jun 04, 2015 at 11:14:03AM +0200, Victor Toso wrote:
> Hey,
>
> On Wed, Jun 03, 2015 at 03:36:09PM +0200, Christophe Fergeau wrote:
> > Ping ?
>
> I would only add a FIXME in the comment to easily find it and check
> if it is already fixed;
Something like that diff squashed into this pat
On Thu, Jun 04, 2015 at 11:14:03AM +0200, Victor Toso wrote:
> Hey,
>
> On Wed, Jun 03, 2015 at 03:36:09PM +0200, Christophe Fergeau wrote:
> > Ping ?
>
> I would only add a FIXME in the comment to easily find it and check
> if it is already fixed;
Sure, I'll add this.
Christophe
>
> -toso
>
Hey,
On Wed, Jun 03, 2015 at 03:36:09PM +0200, Christophe Fergeau wrote:
> Ping ?
I would only add a FIXME in the comment to easily find it and check
if it is already fixed;
-toso
>
> On Thu, May 28, 2015 at 01:37:24PM +0200, Christophe Fergeau wrote:
> > When it's built with gtk3, firefox plug
Ping ?
Christophe
On Thu, May 28, 2015 at 01:37:24PM +0200, Christophe Fergeau wrote:
> When it's built with gtk3, firefox plugin-container will use some
> LD_PRELOAD hack in order to be able to load the gtk2 flash plugin.
> However, this LD_PRELOAD'ed .so will cause gtk3 remote-viewer to crash
>
On 12/08/2014 09:55 PM, Alex wrote:
Hi, I have a RHEV 3.3 environment but I run 3.17.4-1-ARCH on my work
station and would like to access the RHEV spice server on the VM's, I
have also tried with openSuSE but I never get the expected "Spice
window frame" that I would get if I used a RHEL syst
Hey,
On Mon, Dec 08, 2014 at 02:31:51PM -0800, Alex wrote:
> Hi, I have a RHEV 3.3 environment but I run 3.17.4-1-ARCH on my work station
> and would like to access the RHEV spice server on the VM's, I have also
> tried with openSuSE but I never get the expected "Spice window frame" that I
> w
> The plugin binary name was changed from libnsISpice to npSpiceConsole,
> but the Makefile.am rule optionnally building SpiceXpi.xpi was not
> changed to take this rename into account.
ACK series.
> ---
> SpiceXPI/Makefile.am | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff
On Mon, Apr 08, 2013 at 01:52:34PM +0200, Marc-André Lureau wrote:
> ack
All pushed now, thanks!
Christophe
pgpRKVLl8OpAl.pgp
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailma
Many thanks.
I have already solved this problem as you suggested.
Regards
> _
>
> Il 8 aprile 2013 alle 14.46 Uri Lublin ha scritto:
> > On 04/03/2013 07:51 PM, Ignazio Cassano wrote:
> > > Hi all, I do not know if
On 04/03/2013 07:51 PM, Ignazio Cassano wrote:
Hi all, I do not know if this is the correct emailing list to ask about my
problem, any case I am very interested to know about spice-xpi .
I created a java script for launching the spice-xpi plugin but I'd like to know
what TrustStore parameter must
ack
On Mon, Apr 8, 2013 at 10:37 AM, Christophe Fergeau wrote:
> Ping?
>
> Christophe
>
> On Wed, Mar 27, 2013 at 02:09:08PM +0100, Christophe Fergeau wrote:
> > This class implements the controller interface for Windows/mingw.
> > ---
> >
> > Changes since v1:
> > - Adjusted copyright notice
>
Ping?
Christophe
On Wed, Mar 27, 2013 at 02:09:08PM +0100, Christophe Fergeau wrote:
> This class implements the controller interface for Windows/mingw.
> ---
>
> Changes since v1:
> - Adjusted copyright notice
> - Initialize random seed with current time
> - Simplify error handling in several p
Hi,
On Mon, Mar 25, 2013 at 08:06:27AM -0400, Marc-André Lureau wrote:
> - Mensaje original -
> > > In general, returning true on success is easier to read.
> >
> > This mimics the return value of connect(2), I'd prefer to keep that
> > (at
> > least in that patch, can be improved as a s
- Mensaje original -
> On Mon, Mar 25, 2013 at 12:18:32PM +0100, Marc-André Lureau wrote:
> > On Mon, Mar 25, 2013 at 11:50 AM, Christophe Fergeau
> > wrote:
> > > I've considered that, but this means I'd have to sanitize the
> > > filename for
> > > \, '..', and probably some other thin
- Mensaje original -
> > In general, returning true on success is easier to read.
>
> This mimics the return value of connect(2), I'd prefer to keep that
> (at
> least in that patch, can be improved as a separate cleanup as this
> needs
> changes in SpiceController and SpiceControllerUn
Hey, thanks for the detailed review!
A few questions below,
On Sun, Mar 24, 2013 at 11:27:45PM +0100, Marc-André Lureau wrote:
> On Sun, Mar 24, 2013 at 12:16 PM, Christophe Fergeau
> wrote:
> > +SpiceControllerWin::~SpiceControllerWin()
> > +{
> > +}
> > +
> > +int SpiceControllerWin::Connect()
On Mon, Mar 25, 2013 at 12:18:32PM +0100, Marc-André Lureau wrote:
> On Mon, Mar 25, 2013 at 11:50 AM, Christophe Fergeau
> wrote:
> > I've considered that, but this means I'd have to sanitize the filename for
> > \, '..', and probably some other things I didn't think of. As this is just
> > a deb
On Mon, Mar 25, 2013 at 11:50 AM, Christophe Fergeau
wrote:
> I've considered that, but this means I'd have to sanitize the filename for
> \, '..', and probably some other things I didn't think of. As this is just
> a debugging help, I've chosen to go with a hardcoded filename which does
> not nee
On Sun, Mar 24, 2013 at 11:27:41PM +0100, Marc-André Lureau wrote:
> > +}
> > +
> > +static void glib_setup_logging(void)
> > +{
> > +#if defined(XP_WIN)
> > +FILE *log_file;
> > +gchar *log_filename;
> > +
> > +if (!g_getenv("SPICE_XPI_LOG_TO_FILE"))
> > +return;
>
> Imho, it
ack
On Sun, Mar 24, 2013 at 12:16 PM, Christophe Fergeau
wrote:
> Based on a patch from Nerijus Baliunas
> ---
> SpiceXPI/src/plugin/Makefile.am | 23 ---
> SpiceXPI/src/plugin/resource.rc | 34 ++
> configure.ac| 19 ++
ack
On Sun, Mar 24, 2013 at 12:16 PM, Christophe Fergeau
wrote:
> Windows Firefox expects the plugin filename to start with 'np'
> otherwise it won't pick it up as a plugin.
> ---
> SpiceXPI/src/plugin/Makefile.am | 16
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff
ack
On Sun, Mar 24, 2013 at 12:16 PM, Christophe Fergeau
wrote:
> NPAPI plugins only need to have 3 symbols exported, make that
> explicit. This is also required when building Windows plugins
> as these symbols *must* be explicitly exported.
> ---
> SpiceXPI/src/plugin/Makefile.am | 9
On Sun, Mar 24, 2013 at 12:16 PM, Christophe Fergeau
wrote:
> This class implements the controller interface for Windows/mingw.
> ---
> SpiceXPI/src/plugin/Makefile.am| 2 +
> SpiceXPI/src/plugin/controller-win.cpp | 266
> +
> SpiceXPI/src/plugin/contro
On Sun, Mar 24, 2013 at 12:16 PM, Christophe Fergeau
wrote:
> As it's not very convenient to get logging output from the plugin
> while firefox is running, this commit adds a dumb glib logging
> implementation that writes the logging information to a file.
> As this is not efficient at all, it's d
On Wed, Mar 13, 2013 at 01:52:59PM +0100, Marc-André Lureau wrote:
> Except the g_message vs g_critical, ack the series.
Thanks, pushed with that change! Only a few more patches to go, which I'll
send once I write proper commit logs and do a bit of cleanup :)
Christophe
pgpJFf9ArtmQF.pgp
Descr
Except the g_message vs g_critical, ack the series.
--
Marc-André Lureau
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
On Wed, Mar 13, 2013 at 11:15 AM, Christophe Fergeau
wrote:
> +tmp_file = g_file_new_tmp("trustore.pem-XX", &iostream, NULL);
> +if (tmp_file == NULL) {
> +g_message("Couldn't create truststore");
> +return false;
> }
> -else
> -{
> -g_critical("cou
On Tue, Mar 12, 2013 at 01:16:20PM +0100, Marc-André Lureau wrote:
> On Tue, Mar 12, 2013 at 12:23 PM, Christophe Fergeau
> wrote:
> > +/* FIXME: we are not in the main thread!! */
> > +fake_this->m_plugin->OnSpiceClientExit(status);
>
> That scares me, but it looks like you didn't introd
On Tue, Mar 12, 2013 at 01:00:42PM +0100, Marc-André Lureau wrote:
> On Tue, Mar 12, 2013 at 12:22 PM, Christophe Fergeau
> wrote:
> > Copyright 2009-2011, Red Hat Inc.
> > + * Copyright 2013, Red Hat Inc.
>
> I would just update the range, instead of adding extra line (one for
> each year?).
On Tue, Mar 12, 2013 at 2:55 PM, Christophe Fergeau wrote:
> Yup, the Windows version of this function will be using dynamic allocation
> as we need to get the client name from the registry, split it, ...
You could make use of g_strdupv() instead perhaps?
--
Marc-André Lureau
__
On Tue, Mar 12, 2013 at 01:37:06PM +0100, Marc-André Lureau wrote:
> after this patch:
>
> "LoadPlugin: failed to initialize"..., 212LoadPlugin: failed to
> initialize shared library
> /home/elmarco/.mozilla/plugins/libnsISpicec.so
> [/home/elmarco/.mozilla/plugins/libnsISpicec.so: undefined symbo
On Tue, Mar 12, 2013 at 01:32:13PM +0100, Marc-André Lureau wrote:
> On Tue, Mar 12, 2013 at 12:23 PM, Christophe Fergeau
> wrote:
> > void SpiceController::GetClientPaths(GStrv *client_argv, GStrv
> > *fallback_argv)
> > +{
> > +if (client_argv != NULL) {
> > +*client_argv = g_new0(c
On Tue, Mar 12, 2013 at 12:32:55PM +0100, Marc-André Lureau wrote:
> ack (please push for the next series to be reviewed)
Sorry, I just saw that email, I've now pushed the series with the added
configure log you asked for, but this comes after sending the next series.
Christophe
pgpqEzTRZz_Cz.p
after this patch:
"LoadPlugin: failed to initialize"..., 212LoadPlugin: failed to
initialize shared library
/home/elmarco/.mozilla/plugins/libnsISpicec.so
[/home/elmarco/.mozilla/plugins/libnsISpicec.so: undefined symbol:
_ZN19SpiceControllerUnix14GetClientPathsEPPPcS2_
On Tue, Mar 12, 2013 at 1
On Tue, Mar 12, 2013 at 12:23 PM, Christophe Fergeau
wrote:
> void SpiceController::GetClientPaths(GStrv *client_argv, GStrv *fallback_argv)
> +{
> +if (client_argv != NULL) {
> +*client_argv = g_new0(char *, 2);
> +(*client_argv)[0] = g_strdup("/usr/libexec/spice-xpi-client");
You could also fix this deprecation
warning: 'GThread* g_thread_create(GThreadFunc, gpointer, gboolean,
GError**)' is deprecated (declared at
/usr/include/glib-2.0/glib/deprecated/gthread.h:100): Use
'g_thread_new' instead [-Wdeprecated-declarations]
--
Marc-André Lureau
__
On Tue, Mar 12, 2013 at 12:23 PM, Christophe Fergeau
wrote:
> +/* FIXME: we are not in the main thread!! */
> +fake_this->m_plugin->OnSpiceClientExit(status);
That scares me, but it looks like you didn't introduce that, so it's
okay I guess.
Apparently, it was done in "Drop sigchld handl
On Tue, Mar 12, 2013 at 12:22 PM, Christophe Fergeau
wrote:
> Copyright 2009-2011, Red Hat Inc.
> + * Copyright 2013, Red Hat Inc.
I would just update the range, instead of adding extra line (one for
each year?).
--
Marc-André Lureau
___
Spice-de
On Tue, Mar 12, 2013 at 12:22 PM, Christophe Fergeau
wrote:
> This has the big advantage of being portable, in addition to removing
> some code. Big disadvantage is that this adds a dependency on gio.
> ---
> SpiceXPI/src/plugin/plugin.cpp | 67
> +-
> Spi
ack (please push for the next series to be reviewed)
On Mon, Mar 11, 2013 at 12:52 PM, Christophe Fergeau
wrote:
> On Mon, Mar 11, 2013 at 12:24:03PM +0100, Marc-André Lureau wrote:
>> How do you apply this? if fails on both current master, and after the
>> previous 10 patches.
>
> As indicated i
On Mon, Mar 11, 2013 at 01:56:04PM +0100, Marc-André Lureau wrote:
> On Mon, Mar 11, 2013 at 10:16 AM, Christophe Fergeau
> wrote:
>
> > +AC_ARG_ENABLE([xpi],
> > + [AS_HELP_STRING([--enable-xpi],
> > + [Enable compilation of an xpi package])],
> > + [], [enable_xpi=no])
> > +i
On Mon, Mar 11, 2013 at 10:16 AM, Christophe Fergeau
wrote:
> +AC_ARG_ENABLE([xpi],
> + [AS_HELP_STRING([--enable-xpi],
> + [Enable compilation of an xpi package])],
> + [], [enable_xpi=no])
> +if test x"$enable_xpi" != xno; then
> PKG_CHECK_MODULES(XUL, libxul-embedding >= 10
- Mensaje original -
> On Mon, Mar 11, 2013 at 01:24:34PM +0100, Marc-André Lureau wrote:
> > On Mon, Mar 11, 2013 at 10:16 AM, Christophe Fergeau
> > wrote:
> > > AC_ARG_ENABLE 3rd argument is what to do when the argument is
> > > specified and the 4th arg is what to do when the argumen
On Mon, Mar 11, 2013 at 01:24:34PM +0100, Marc-André Lureau wrote:
> On Mon, Mar 11, 2013 at 10:16 AM, Christophe Fergeau
> wrote:
> > AC_ARG_ENABLE 3rd argument is what to do when the argument is
> > specified and the 4th arg is what to do when the argument is
> > not specified. Using [enable_gen
On Mon, Mar 11, 2013 at 10:16 AM, Christophe Fergeau
wrote:
> AC_ARG_ENABLE 3rd argument is what to do when the argument is
> specified and the 4th arg is what to do when the argument is
> not specified. Using [enable_generator=true] as the 3rd argument
> is wrong as this would enable the generato
On Mon, Mar 11, 2013 at 12:24:03PM +0100, Marc-André Lureau wrote:
> How do you apply this? if fails on both current master, and after the
> previous 10 patches.
As indicated in the cover letter:
"thiss series also replaces patches 8/9 and 9/9 of the previous series as
the configure.ac changes fro
How do you apply this? if fails on both current master, and after the
previous 10 patches.
--
Marc-André Lureau
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
ack series
On Thu, Mar 7, 2013 at 4:39 PM, Christophe Fergeau wrote:
> Hey,
>
> In the last few weeks, I've accumulated quite a lot of patches
> to build spice-xpi on Windows. Time has come to start merging that upstream,
> to avoid sending a 20 patch series to review, I'll split that work into a
Erfane Arwani píše v Po 03. 12. 2012 v 15:01 +0100:
> Hi,
>
> I'm pretty new to Spice.
> Could you please tell me what's spice-xpi made for?
It's a launcher that allows the standalone client binary to be launched from
web browser. OTOH html5 client is self-contained client.
David
> What does
Windows support would be nice, so one could use oVirt web admin on Windows
without IE.
Y.
- Original Message -
> Hello folks,
>
> I would like to ask you all: Do you have any feature/improvement in
> mind, that can be added to spice-xpi plugin? Maybe, it is the time,
> when
> the plugin
Uri Lublin píše v Ne 08. 04. 2012 v 17:11 +0300:
> On 04/03/2012 07:12 PM, David Jaša wrote:
> > Hi Christophe,
> >
> > Christophe Fergeau píše v Út 03. 04. 2012 v 16:38 +0200:
> >> The secure channel names need to be fixed for compatibility with
> >> older spice versions. However, it's better to d
On Sun, Apr 08, 2012 at 03:01:20PM +0300, Uri Lublin wrote:
> On 04/04/2012 05:29 PM, Christophe Fergeau wrote:
> >Next question -- which is not really a problem for now since the various
> >properties are only sent once after the client has started -- is how do we
> >unset a previously set filter
On 04/03/2012 07:12 PM, David Jaša wrote:
Hi Christophe,
Christophe Fergeau píše v Út 03. 04. 2012 v 16:38 +0200:
The secure channel names need to be fixed for compatibility with
older spice versions. However, it's better to do it directly when
m_secure_channels is set rather than waiting until
On 04/04/2012 05:29 PM, Christophe Fergeau wrote:
Hey Uri,
On Wed, Apr 04, 2012 at 12:33:17PM +0300, Uri Lublin wrote:
The default is an empty string.
How does the client behave with such a filter string? Refuse redir
for all devices ?
That's a good question, thanks for pointing this out.
The
Hey Uri,
On Wed, Apr 04, 2012 at 12:33:17PM +0300, Uri Lublin wrote:
> The default is an empty string.
> How does the client behave with such a filter string? Refuse redir
> for all devices ?
That's a good question, thanks for pointing this out.
The good news is that the filter is sent using Sen
On Wed, Apr 04, 2012 at 04:02:38PM +0200, Peter Hatina wrote:
> Hi,
>
> On 04/03/2012 04:38 PM, Christophe Fergeau wrote:
> > All callers were using std::string::c_str(), better to move this
> > call to SendStr instead of doing it everywhere.
> > ---
> > SpiceXPI/src/plugin/plugin.cpp | 28
Hi,
On 04/04/2012 11:33 AM, Uri Lublin wrote:
On 04/04/2012 11:03 AM, Christophe Fergeau wrote:
The Firefox plugin exposes the UsbAutoShare property and the SetUsbFilter
method that were not wired until now. This commit propagates their value to
the nsPluginInstance object and send them through
Hi,
On 04/03/2012 04:38 PM, Christophe Fergeau wrote:
> All callers were using std::string::c_str(), better to move this
> call to SendStr instead of doing it everywhere.
> ---
> SpiceXPI/src/plugin/plugin.cpp | 28 ++--
> SpiceXPI/src/plugin/plugin.h |2 +-
> 2 fi
On 04/04/2012 11:03 AM, Christophe Fergeau wrote:
The Firefox plugin exposes the UsbAutoShare property and the SetUsbFilter
method that were not wired until now. This commit propagates their value to
the nsPluginInstance object and send them through the controller socket.
---
SpiceXPI/src/plugi
On Tue, Apr 03, 2012 at 11:21:07PM +0200, Marc-André Lureau wrote:
> On Tue, Apr 3, 2012 at 6:12 PM, David Jaša wrote:
> > The s- idio^W^W^W^Wlegacy goes much further, see the ovirt-engine
> > sources what you can expect:
> > http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=blob;f=backend/manag
On Tue, Apr 3, 2012 at 6:12 PM, David Jaša wrote:
> The s- idio^W^W^W^Wlegacy goes much further, see the ovirt-engine
> sources what you can expect:
> http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=blob;f=backend/manager/tools/engine-config/src/main/resources/engine-config.properties#l109
Hm
This patch may not be needed (see discussion of patch 1).
On 04/03/2012 03:07 PM, Christophe Fergeau wrote:
---
data/test.html |5 +
1 file changed, 5 insertions(+)
diff --git a/data/test.html b/data/test.html
index ff7743b..3384a56 100644
--- a/data/test.html
+++ b/data/test.html
@@
All 4 patches look good, ACK series
On 04/03/2012 04:38 PM, Christophe Fergeau wrote:
The secure channel names need to be fixed for compatibility with
older spice versions. However, it's better to do it directly when
m_secure_channels is set rather than waiting until its first use
---
SpiceXPI
Hey,
On Tue, Apr 03, 2012 at 07:44:51PM +0200, Hans de Goede wrote:
> Eh, my idea wrt sending usbredir enable / disable to the spice-client was to
> base
> it on the usb_listen_port setting, if usb_listen_port is set we are using old
> usb,
> so disable the new usb (thus send disabled to the cli
ACK
On 04/03/2012 03:07 PM, Christophe Fergeau wrote:
spice-xpi doesn't currently support changing properties after the
initial connection, so set the USB filter during initial connection
so that USB filters can be tested.
---
data/test.html |1 +
1 file changed, 1 insertion(+)
diff --gi
ACK.
On 04/03/2012 03:07 PM, Christophe Fergeau wrote:
The Firefox plugin exposes the UsbAutoShare property and the SetUsbFilter
method that were not wired until now. This commit propagates their value to
the nsPluginInstance object. Next step will be to transmit them to
the controller.
---
Sp
Hi,
Eh, my idea wrt sending usbredir enable / disable to the spice-client was to
base
it on the usb_listen_port setting, if usb_listen_port is set we are using old
usb,
so disable the new usb (thus send disabled to the client over the controller).
If usb_listen_port is not set then the idea is
Hi Christophe,
Christophe Fergeau píše v Út 03. 04. 2012 v 16:38 +0200:
> The secure channel names need to be fixed for compatibility with
> older spice versions. However, it's better to do it directly when
> m_secure_channels is set rather than waiting until its first use
> ---
> SpiceXPI/src/pl
- Original Message -
> On 03/15/2012 02:48 PM, Marc-André Lureau wrote:
> > why not use only __FUNCTION__?
> >
>
> Because, it does not format the string to meet this pattern for
> classes:
> "class::method". What I get is only the method name, which is not
> enough
> in this case.
Appa
On 03/15/2012 02:48 PM, Marc-André Lureau wrote:
> Peter,
>
> To resume the discussion and be a bit more specific:
>
>> +#if __GNUC__
>> +static inline std::string pretty_func_to_func_name(const std::string&
>> f_name)
>> +{
>> +std::string name(f_name);
>> +std::string::size_type end_po
Peter,
To resume the discussion and be a bit more specific:
> +#if __GNUC__
> +static inline std::string pretty_func_to_func_name(const std::string& f_name)
> +{
> +std::string name(f_name);
> +std::string::size_type end_pos = f_name.find('(');
> +if (end_pos == std::string::npos)
> +
- Original Message -
> From: "Christophe Fergeau"
> To: "Marc-André Lureau"
> Cc: spice-devel@lists.freedesktop.org
> Sent: Tuesday, March 13, 2012 2:02:33 PM
> Subject: Re: [Spice-devel] spice-xpi
>
> On Tue, Mar 13, 2012 at
On 03/13/2012 01:55 PM, Marc-André Lureau wrote:
>
>
> - Mensaje original -
>> Hi,
>>
>> as Marc-Andre has decided to drop log4cpp, I would like to at least
>> revert the part of the message format. The reason is simple, Spice-QA
>> guys are developing a test framework, which uses the log
On Tue, Mar 13, 2012 at 02:10:50PM +0100, Marc-André Lureau wrote:
> I agree. So why removing existing debug? Why making the code more
> complicated (execv, title handling?)
95% of the patch is either wrapping g_* calls in macros or adding logging,
there isn't a lot of "making the code more compli
- Original Message -
From: "Lubos Kocman"
To: "Marc-André Lureau"
Cc: spice-devel@lists.freedesktop.org
Sent: Tuesday, March 13, 2012 2:11:32 PM
Subject: Re: [Spice-devel] spice-xpi
Hello Marc-Andre,
I agree as well that parsing logs is not the best way. I had easy wa
desktop.org
Sent: Tuesday, March 13, 2012 1:55:16 PM
Subject: Re: [Spice-devel] spice-xpi
- Mensaje original -
> Hi,
>
> as Marc-Andre has decided to drop log4cpp, I would like to at least
> revert the part of the message format. The reason is simple, Spice-QA
> guys are dev
On Tue, Mar 13, 2012 at 2:02 PM, Christophe Fergeau wrote:
> I think they are exploring using systemtap too. In the mean time, it
> doesn't really hurt to have more expressive logs messages, and logs in
> places where it might be useful...
I agree. So why removing existing debug? Why making the c
On Tue, Mar 13, 2012 at 08:58:26AM -0400, Marc-André Lureau wrote:
>
>
> - Mensaje original -
> > glog is missing the "modified" method name, which is added by the
> > patch.
> > QA guys rely especially on the method name.
>
> That's the problem: we can't refactor, rename function, add a
On 03/13/2012 01:26 PM, Christophe Fergeau wrote:
> Hey,
>
> On Tue, Mar 13, 2012 at 12:29:01PM +0100, Peter Hatina wrote:
>> Hi,
>>
>> as Marc-Andre has decided to drop log4cpp, I would like to at
>> least revert the part of the message format. The reason is
>> simple, Spice-QA guys are developi
On Tue, Mar 13, 2012 at 08:58:26AM -0400, Marc-André Lureau wrote:
>
>
> - Mensaje original -
> > glog is missing the "modified" method name, which is added by the
> > patch.
> > QA guys rely especially on the method name.
>
> That's the problem: we can't refactor, rename function, add
>
- Mensaje original -
> glog is missing the "modified" method name, which is added by the
> patch.
> QA guys rely especially on the method name.
That's the problem: we can't refactor, rename function, add arguments or change
order of things, or even perhaps add more debugging. This smell
- Mensaje original -
> Hi,
>
> as Marc-Andre has decided to drop log4cpp, I would like to at least
> revert the part of the message format. The reason is simple, Spice-QA
> guys are developing a test framework, which uses the log4cpp format
> we had.
>
> Opinions?
IOW, why not just imp
On 03/13/2012 01:45 PM, Marc-André Lureau wrote:
>
>
> - Mensaje original -
>> Hi,
>>
>> as Marc-Andre has decided to drop log4cpp, I would like to at least
>
> It was publicly acked by several people in the team.
>
>> revert the part of the message format. The reason is simple, Spice-Q
- Mensaje original -
> Hi,
>
> as Marc-Andre has decided to drop log4cpp, I would like to at least
It was publicly acked by several people in the team.
> revert the part of the message format. The reason is simple, Spice-QA
> guys are developing a test framework, which uses the log4cpp
Hey,
On Tue, Mar 13, 2012 at 12:29:01PM +0100, Peter Hatina wrote:
> Hi,
>
> as Marc-Andre has decided to drop log4cpp, I would like to at least
> revert the part of the message format. The reason is simple, Spice-QA
> guys are developing a test framework, which uses the log4cpp format we had.
>
ack both
- Mensaje original -
> It was spelt SendCtrlAltdelete (lower case "d" in delete) throughout
> the code base while spice-x and the rhev/ovirt portals use
> SendCtrlAltDelete. This commit changes all occurences of Altdelete
> to AltDelete. After this change, the "Pass Ctrl+Alt+Del"
On 03/05/2012 05:51 PM, Christophe Fergeau wrote:
> On Linux, the default behaviour of the client is to have
> Ctrl+Alt+Del passthrough enabled, so it's better to default to
> enabling it from the controller as well to avoid getting a different
> behaviour when the client handles controller message
On 03/05/2012 03:33 PM, Christophe Fergeau wrote:
> ::SendVal will not send messages when the value is 0, which is not
> what is expected when sending a boolean value.
> ---
> SpiceXPI/src/plugin/plugin.cpp |6 ++
> SpiceXPI/src/plugin/plugin.h |1 +
> 2 files changed, 7 insertions(+
On Mon, Mar 05, 2012 at 02:33:33PM +0100, Christophe Fergeau wrote:
> ::SendVal will not send messages when the value is 0, which is not
> what is expected when sending a boolean value.
Looks good.
Ack series.
> ---
> SpiceXPI/src/plugin/plugin.cpp |6 ++
> SpiceXPI/src/plugin/plugin.h
- Mensaje original -
> It's using ./spice-protocol instead of ../spice-protocol as the
> relative path to use to build the submodule clone URI.
> ---
> .gitmodules |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/.gitmodules b/.gitmodules
> index 14b3beb..f
- Mensaje original -
> Are there plans that spice-xpi would use spice-gtk instead of spicec?
> Otherwise, it looks like there are features developed only in
> spice-gtk,
> and spicec is going to lag behind.
> (just installed spice-xpi on Fedora, and it only brought spice-client
> RPM with
ACK series
Acked-by: Arnon Gilboa
Uri Lublin wrote:
Mostly debug messages to log variable values coming in (from java-script)
and going out (to spice-client).
Uri Lublin (3):
logging: add logging of variable setting (#753155)
logging: add logging of messages sent to the client (#753155)
- Original Message -
> - Original Message -
> > Password and TrustStore are not logged.
> > ---
> > SpiceXPI/src/plugin/plugin.cpp | 20 +++-
> > 1 files changed, 19 insertions(+), 1 deletions(-)
> >
> > diff --git a/SpiceXPI/src/plugin/plugin.cpp
> > b/SpiceXPI/
- Original Message -
> Password and TrustStore are not logged.
> ---
> SpiceXPI/src/plugin/plugin.cpp | 20 +++-
> 1 files changed, 19 insertions(+), 1 deletions(-)
>
> diff --git a/SpiceXPI/src/plugin/plugin.cpp
> b/SpiceXPI/src/plugin/plugin.cpp
> index 2dada12..0b2ec4
1 - 100 of 102 matches
Mail list logo
