On 04/04/2012 05:29 PM, Christophe Fergeau wrote:
Hey Uri,

On Wed, Apr 04, 2012 at 12:33:17PM +0300, Uri Lublin wrote:
The default is an empty string.
How does the client behave with such a filter string?  Refuse redir
for all devices ?
That's a good question, thanks for pointing this out.
The good news is that the filter is sent using SendStr which ignores empty
strings:

PluginInstance::SendStr(uint32_t id, std::string str)
{
     if (str.empty())
         return;

so we'll rely on spice-gtk defaults when the string is empty.

Thanks for reminding me.
That aligns nicely with Hans' reply too :-)

Next question -- which is not really a problem for now since the various
properties are only sent once after the client has started -- is how do we
unset a previously set filter using the controller. I don't think there's
any way to do that currently, but it might be interesting to do at some
point..
That's true also for changing the filter (or any other variable) while the client is running. We can add code to Set-variable-functions that sends an appropriate message to the
client, if it is connected.

Uri.
_______________________________________________
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel

Reply via email to