Re: [Spice-devel] [NSIS 3/7] packaging: Re-enable NSIS branding

2015-10-26 Thread Christophe Fergeau
On Mon, Oct 26, 2015 at 10:41:41AM -0400, Lev Veyde wrote: > We already have the conditional in place to have a different > code/values for Spice and oVirt, so we see no reason why we can't use > it in this case as well. Because it's meant to deal with core differences between the spice and ovirt

Re: [Spice-devel] [NSIS 3/7] packaging: Re-enable NSIS branding

2015-10-26 Thread Lev Veyde
Bar David" Cc: "Lev Veyde" , spice-devel@lists.freedesktop.org Sent: Monday, October 26, 2015 12:53:32 PM Subject: Re: [Spice-devel] [NSIS 3/7] packaging: Re-enable NSIS branding On Mon, Oct 26, 2015 at 12:39:44PM +0200, Yedidyah Bar David wrote: > On Mon, Oct 26, 2015 at 10:57 A

Re: [Spice-devel] [NSIS 3/7] packaging: Re-enable NSIS branding

2015-10-26 Thread Christophe Fergeau
On Mon, Oct 26, 2015 at 12:39:44PM +0200, Yedidyah Bar David wrote: > On Mon, Oct 26, 2015 at 10:57 AM, Christophe Fergeau > wrote: > > On Sun, Oct 25, 2015 at 01:01:06PM +0200, Yedidyah Bar David wrote: > >> If you only object to the aesthetics, and not the principle, can you please > >> state wh

Re: [Spice-devel] [NSIS 3/7] packaging: Re-enable NSIS branding

2015-10-26 Thread Yedidyah Bar David
On Mon, Oct 26, 2015 at 10:57 AM, Christophe Fergeau wrote: > On Sun, Oct 25, 2015 at 01:01:06PM +0200, Yedidyah Bar David wrote: >> If you only object to the aesthetics, and not the principle, can you please >> state what should be done to make it nice enough for you? Searching for >> 'branding'

Re: [Spice-devel] [NSIS 3/7] packaging: Re-enable NSIS branding

2015-10-26 Thread Christophe Fergeau
On Sun, Oct 25, 2015 at 01:01:06PM +0200, Yedidyah Bar David wrote: > If you only object to the aesthetics, and not the principle, can you please > state what should be done to make it nice enough for you? Searching for > 'branding' in [1] does find a few tunables. They seem to be for if you want

Re: [Spice-devel] [NSIS 3/7] packaging: Re-enable NSIS branding

2015-10-25 Thread Yedidyah Bar David
- Original Message - > From: "Christophe Fergeau" > To: "Lev Veyde" > Cc: spice-devel@lists.freedesktop.org > Sent: Friday, October 23, 2015 12:10:12 PM > Subject: Re: [Spice-devel] [NSIS 3/7] packaging: Re-enable NSIS branding > > On Thu, Oct 22,

Re: [Spice-devel] [NSIS 3/7] packaging: Re-enable NSIS branding

2015-10-25 Thread Lev Veyde
the need of the open source community is more important than some aesthetics considerations. Thanks in advance, Lev Veyde. - Original Message - From: "Christophe Fergeau" To: "Lev Veyde" Cc: spice-devel@lists.freedesktop.org Sent: Friday, October 23, 2015 12:10:12 P

Re: [Spice-devel] [NSIS 3/7] packaging: Re-enable NSIS branding

2015-10-23 Thread Christophe Fergeau
On Thu, Oct 22, 2015 at 08:26:29AM -0400, Lev Veyde wrote: > Hi, > > Almost all installers provide this kind of info, and the idea is to show it > so everyone, including ones who don't really know how and where to search > will get a pointer. > So I think it's a good idea to tell everyone who ru

Re: [Spice-devel] [NSIS 3/7] packaging: Re-enable NSIS branding

2015-10-22 Thread Lev Veyde
rsday, October 22, 2015 2:40:24 PM Subject: Re: [Spice-devel] [NSIS 3/7] packaging: Re-enable NSIS branding On Thu, Oct 22, 2015 at 06:39:56AM -0400, Lev Veyde wrote: > Hi Christophe, > > Yes, that's the reason. > > I don't see any reason to hide the fact that we use anot

Re: [Spice-devel] [NSIS 3/7] packaging: Re-enable NSIS branding

2015-10-22 Thread Christophe Fergeau
On Thu, Oct 22, 2015 at 06:39:56AM -0400, Lev Veyde wrote: > Hi Christophe, > > Yes, that's the reason. > > I don't see any reason to hide the fact that we use another open > source project (NSIS) to produce the installer, even if it provides > that option. > Unless of course, we absolutely must

Re: [Spice-devel] [NSIS 3/7] packaging: Re-enable NSIS branding

2015-10-22 Thread Lev Veyde
that fact somewhere else. Thanks in advance, Lev Veyde. - Original Message - From: "Yedidyah Bar David" To: "Christophe Fergeau" Cc: spice-devel@lists.freedesktop.org, "Lev Veyde" Sent: Thursday, October 22, 2015 8:28:15 AM Subject: Re: [Spice-devel] [NSIS

Re: [Spice-devel] [NSIS 3/7] packaging: Re-enable NSIS branding

2015-10-22 Thread Christophe Fergeau
On Thu, Oct 22, 2015 at 08:28:15AM +0300, Yedidyah Bar David wrote: > On Wed, Oct 21, 2015 at 7:50 PM, Christophe Fergeau > wrote: > > Sorry if I missed it/forgot the answer > > You didn't :-) > > You already asked and I replied asking Lev. > > > , but why do we need/want this > > change? > >

Re: [Spice-devel] [NSIS 3/7] packaging: Re-enable NSIS branding

2015-10-21 Thread Yedidyah Bar David
On Wed, Oct 21, 2015 at 7:50 PM, Christophe Fergeau wrote: > Sorry if I missed it/forgot the answer You didn't :-) You already asked and I replied asking Lev. > , but why do we need/want this > change? I guess it's mainly to pay tribute to that project. Lev? You already merged it to your own

Re: [Spice-devel] [NSIS 3/7] packaging: Re-enable NSIS branding

2015-10-21 Thread Christophe Fergeau
Sorry if I missed it/forgot the answer, but why do we need/want this change? Christophe On Tue, Oct 20, 2015 at 02:35:24PM +0300, Yedidyah Bar David wrote: > From: Lev Veyde > > Change-Id: I8692e636d42f127f953f578d86c7cbe8f2bcc06a > Signed-off-by: Lev Veyde > --- > win-guest-tools.nsis | 2 +-

[Spice-devel] [NSIS 3/7] packaging: Re-enable NSIS branding

2015-10-20 Thread Yedidyah Bar David
From: Lev Veyde Change-Id: I8692e636d42f127f953f578d86c7cbe8f2bcc06a Signed-off-by: Lev Veyde --- win-guest-tools.nsis | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/win-guest-tools.nsis b/win-guest-tools.nsis index efd7392..a6e14de 100644 --- a/win-guest-tools.nsis +++ b/w