Hi Christophe, We already have the conditional in place to have a different code/values for Spice and oVirt, so we see no reason why we can't use it in this case as well.
Thanks in advance, Lev Veyde. ----- Original Message ----- From: "Christophe Fergeau" <cferg...@redhat.com> To: "Yedidyah Bar David" <d...@redhat.com> Cc: "Lev Veyde" <lve...@redhat.com>, spice-devel@lists.freedesktop.org Sent: Monday, October 26, 2015 12:53:32 PM Subject: Re: [Spice-devel] [NSIS 3/7] packaging: Re-enable NSIS branding On Mon, Oct 26, 2015 at 12:39:44PM +0200, Yedidyah Bar David wrote: > On Mon, Oct 26, 2015 at 10:57 AM, Christophe Fergeau > <cferg...@redhat.com> wrote: > > On Sun, Oct 25, 2015 at 01:01:06PM +0200, Yedidyah Bar David wrote: > >> If you only object to the aesthetics, and not the principle, can you please > >> state what should be done to make it nice enough for you? Searching for > >> 'branding' in [1] does find a few tunables. > > > > They seem to be for if you want to replace the default branding with > > your own. I'd much prefer making it obvious where to get the installer > > source from rather than showing the whole installation time "hey, this > > is an nsis installer". But all this information belongs on webpages > > associated with the installer, not in the installer by itself. > > Seems I'll not convince you :-) > > Now posting a patch to do that conditionally only for oVirt. I'd rather not have conditionals for this kind of things, makes the codebase more complicated for no gain... Christophe _______________________________________________ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel
