Re: [Spice-devel] [ovirt-users] Re: remote-viewer Spice Problem on MacOS

2018-06-22 Thread Yaniv Kaul
+Spice devel mailing list. On Thu, Jun 21, 2018, 11:57 PM John Florian wrote: > > On 2018-06-21 08:20, Michal Skrivanek wrote: > > Any connectivity issue should no really be dependent on what you do in > guest > Agreed > > Still, please bring that up to SPICE team - > https://www.spice-space.org

Re: [Spice-devel] [spice-list] Fwd: [ovirt-users] Fwd: VM hanging at boot - [drm] Initialized qxl

2018-06-20 Thread Yaniv Kaul
ktop.org > list.​ > > > > > > Thank you, > > David Blechter > > 978-392-3182 <(978)%20392-3182> > > > > On Tue, Jun 19, 2018 at 2:26 AM, Yaniv Kaul wrote: > > > > > Anyone monitoring oVirt mailing list for Spice related issues? > > > Y.

[Spice-devel] Failure to compile spice-gtk: spicy.c:1711:10: error: ignoring return value of ‘write’

2012-12-08 Thread Yaniv Kaul
CC spicy-spicy.o spicy.c: In function ‘port_data’: spicy.c:1711:10: error: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Werror=unused-result] cc1: all warnings being treated as errors Latest commit: commit a9b7e4cbb31a3457a90582ebe5cdb177393edbd2 Auth

Re: [Spice-devel] spice-xpi features

2012-09-20 Thread Yaniv Kaul
Windows support would be nice, so one could use oVirt web admin on Windows without IE. Y. - Original Message - > Hello folks, > > I would like to ask you all: Do you have any feature/improvement in > mind, that can be added to spice-xpi plugin? Maybe, it is the time, > when > the plugin

Re: [Spice-devel] Failure to compile [was: [Spice-commits] gtk/channel-display.c]

2012-09-10 Thread Yaniv Kaul
On 09/10/2012 05:57 PM, Alon Levy wrote: On Mon, Sep 10, 2012 at 12:08:30PM +0300, Yaniv Kaul wrote: Confirmed, great and thanks. I'd be happy if we could avoid such situations in the future. I know we (used to?) have a build-bot for Spice. Is it alive and working? It was working a few

Re: [Spice-devel] Failure to compile [was: [Spice-commits] gtk/channel-display.c]

2012-09-10 Thread Yaniv Kaul
On 09/10/2012 11:57 AM, Christophe Fergeau wrote: Hey, On Sat, Sep 08, 2012 at 04:54:53PM -0400, Yaniv Kaul wrote: channel-display.c: In function 'spice_display_channel_reset_capabilities': channel-display.c:685:247: error: 'SPICE_DISPLAY_CAP_A8_SURFACE' undeclared (first

[Spice-devel] Failure to compile [was: [Spice-commits] gtk/channel-display.c]

2012-09-08 Thread Yaniv Kaul
channel-display.c: In function 'spice_display_channel_reset_capabilities': channel-display.c:685:247: error: 'SPICE_DISPLAY_CAP_A8_SURFACE' undeclared (first use in this function) channel-display.c:685:247: note: each undeclared identifier is reported only once for each function it appears in mak

[Spice-devel] Error while updating spice-gtk

2012-08-30 Thread Yaniv Kaul
Updating 836a18d..4b39f32 error: The following untracked working tree files would be overwritten by merge: doc/reference/spice-gtk-overrides.txt Please move or remove them before you can merge. Anything i'm doing wrong? Y. ___ Spice-devel mailing

Re: [Spice-devel] SPICE session hanging randomly

2012-08-22 Thread Yaniv Kaul
Any chance one of the participants (either the server or the client, but most likely the client) is heavily swapping? It's enough for a VM to have parts of its memory swapping to crawl. Alternatively, are you over-committing with CPU? For example, running a 4vCPU VM on a 2pCPU host? What do you

Re: [Spice-devel] change the Monitor refresh rate of VM

2012-08-16 Thread Yaniv Kaul
It's just a number, I don't think we are doing anything with it. miniport/qxl.c: video_mode->Frequency = 100; And we don't do a lot with it later, I think. The real question is what the client refresh rate is, which I don't think we touch. Y. - Original Message - > I just want to

Re: [Spice-devel] Mouse failure happens when mouse hovers on some Apps like Kaspersky Anti-virus tool.

2012-08-15 Thread Yaniv Kaul
On 08/15/2012 01:05 PM, Arnon Gilboa wrote: Yaniv Kaul wrote: - Original Message - Hi Naga, Tested and reproduced it on Win7. I bet you'd see this in any many personal FW / Antivirus, to prevent a malicious software from manipulating it via the mouse (and disable it, for ex

Re: [Spice-devel] Mouse failure happens when mouse hovers on some Apps like Kaspersky Anti-virus tool.

2012-08-15 Thread Yaniv Kaul
- Original Message - > Hi Naga, > > Tested and reproduced it on Win7. I bet you'd see this in any many personal FW / Antivirus, to prevent a malicious software from manipulating it via the mouse (and disable it, for example). I'd try with ZoneAlarm (http://www.zonealarm.com/security/e

Re: [Spice-devel] [PATCH 4/7] spice-ppc: fix glz magic endianess

2012-08-08 Thread Yaniv Kaul
- Original Message - > On Tue, Aug 07, 2012 at 03:43:11PM -0300, Erlon Cruz wrote: > > From: Erlon Cruz > > > > Signed-off-by: Erlon R. Cruz > > Signed-off-by: Fabiano Fidêncio > > > > Signed-off-by: Rafael F. Santos > > > > --- > > server/glz_encoder.c |2 +- > > 1 files changed,

Re: [Spice-devel] [PATCH 2/7] spice-ppc: Fixing endianess for channel startup negotiation

2012-08-08 Thread Yaniv Kaul
- Original Message - > Signed-off-by: Erlon R. Cruz > Signed-off-by: Fabiano Fidêncio > > Signed-off-by: Rafael F. Santos > > --- > server/reds.c | 82 > - > 1 files changed, 69 insertions(+), 13 deletions(-) > > diff --git a/

Re: [Spice-devel] [PATCH 4/7] spice-ppc: fix glz magic endianess

2012-08-08 Thread Yaniv Kaul
On 08/08/2012 12:34 PM, Christophe Fergeau wrote: On Wed, Aug 08, 2012 at 05:24:30AM -0400, Yaniv Kaul wrote: - Original Message - On Tue, Aug 07, 2012 at 03:43:11PM -0300, Erlon Cruz wrote: From: Erlon Cruz Signed-off-by: Erlon R. Cruz Signed-off-by: Fabiano Fidêncio Signed-off

Re: [Spice-devel] Performance of Xspice - some results, and a potential patch

2012-08-08 Thread Yaniv Kaul
- Original Message - > > I don't know what were the network conditions you tested, but it > > would be great if you could repeat your test with lower bandwidth > > (you can use tc), and also, you can try disabling off-screen > > surfaces in the driver. > > I do have a test network construc

Re: [Spice-devel] Performance of Xspice - some results, and a potential patch

2012-08-07 Thread Yaniv Kaul
- Original Message - > I've spent several weeks analyzing the network performance of Xspice > against two test cases. I also crafted a patch which implements an > alternate mode for the xf86-video-qxl driver that dramatically > improves > network performance. > > The two test cases are si

[Spice-devel] Failure to compile spice-gtk : desktop-integration.c:175:30: error: unused variable 'self'

2012-07-08 Thread Yaniv Kaul
Git hash 2157ea0bf87989ccc29814aece3fa7f434f25840: CC spice-widget-enums.lo desktop-integration.c: In function 'spice_desktop_integration_dispose': desktop-integration.c:175:30: error: unused variable 'self' [-Werror=unused-variable] ___ Spice-d

Re: [Spice-devel] xf86-video-qxl performance

2012-06-29 Thread Yaniv Kaul
- Original Message - > I am going to dive into the xf86 driver performance in a serious way > starting next week. This is great news - good luck! > > I'm planning on building instrumentation to let me build sample data > sets. I want to see what sort of X operations result from a typica

[Spice-devel] Student Project around Spice

2012-06-20 Thread Yaniv Kaul
Hi, I'm trying to get students to develop something for Spice as a project for their university. It should take 60-120 hours, though, and while they have basic C/C++ knowledge, I would not assume anything more. Any ideas? For example, do you estimate it's feasible to develop a POC for Opus au

Re: [Spice-devel] Add support for A8 bitmap format

2012-06-17 Thread Yaniv Kaul
On 06/17/2012 12:03 PM, Alon Levy wrote: On Sat, Jun 16, 2012 at 01:57:49AM -0400, Yaniv Kaul wrote: - Original Message - Hello, The following patches add support for a new A8 bitmap format, and for LZ compression of it. This format is heavliy used by the X server Render extension for

Re: [Spice-devel] Add support for A8 bitmap format

2012-06-15 Thread Yaniv Kaul
- Original Message - > Hello, > > The following patches add support for a new A8 bitmap format, and for > LZ compression of it. This format is heavliy used by the X server > Render extension for glyphs and geometry information. > > I have verified that the patches with an experiemental ve

[Spice-devel] Failure to compile: error: 'SpiceUsbDeviceManagerPrivate' has no member named 'auto_conn_filter_rules'

2012-06-13 Thread Yaniv Kaul
F17/x64, git hash faa2599188a91102945e607e765e3caf0ba1071d: make[4]: Entering directory `/home/ykaul/spice-gtk/gtk' CC decode-glz.lo CC usb-device-manager.lo usb-device-manager.c: In function 'spice_usb_device_manager_finalize': usb-device-manager.c:239:14: error: 'SpiceUsbDeviceManag

Re: [Spice-devel] Announcing the first version of spice-html5

2012-06-06 Thread Yaniv Kaul
- Original Message - > >> *blush* Yes, sorry, the keyboard code is truly awful. It's a > >> matter of > >> translating web key codes into scan codes; I didn't find a good > >> way to > >> do it, and just used a brute force hack. If you're at all a > >> programmer, > >> it would be easy to

Re: [Spice-devel] Announcing the first version of spice-html5

2012-06-05 Thread Yaniv Kaul
- Original Message - > I am happy to announce that Alon has committed my initial version of > the > spice html5 client. Wow. Bravo! > > It has many limitations and it requires a modern browser (up to date > Firefox or Chrome). However, it certainly makes an interesting proof > of > conc

Re: [Spice-devel] xf86-video-qxl performance

2012-05-24 Thread Yaniv Kaul
- Original Message - > I need to improve the performance of the xf86-video-qxl driver; aka > xspice; by a fairly substantial margin. What performance characteristic would you like to improve? 1. Performance over WAN (high latency and/or low bandwidth) ? 2. CPU usage (on the server and/or t

Re: [Spice-devel] [spice-common PATCH] rect.h: rename variable "small" to "sml"

2012-05-07 Thread Yaniv Kaul
- Original Message - > Hi, > > Hmm I don't really like the name sml, but I cannot come > up with anything better, so: ACK. small_rect and big_rect? Y. > > Regards, > > Hans > > > On 05/07/2012 09:41 AM, Uri Lublin wrote: > > Apparently when compiling spice-gtk with mingw, small is de

Re: [Spice-devel] Minor fix to the SpiceClip/type field

2012-04-27 Thread Yaniv Kaul
- Original Message - > This patch should make it reflect the on wire size. > > This one cost me an hour and some hair; hopefully it'll save someone > else in the future. I suggest taking a look at the Wireshark Spice dissector, which is more aligned with the wire format than the Spice co

Re: [Spice-devel] [PATCH] Change xorg-macros -> xorg-x11-util-macros in configure error message

2012-04-25 Thread Yaniv Kaul
On 04/24/2012 07:30 PM, Christophe Fergeau wrote: On Tue, Apr 24, 2012 at 02:28:42PM +0300, Alon Levy wrote: On Tue, Apr 24, 2012 at 01:22:41PM +0300, Yaniv Kaul wrote: At least in Fedora 17, the correct RPM name is xorg-x11-util-macros We could use the upstream name too, xorg-util-macros

Re: [Spice-devel] Client Graphics Filtering

2012-04-25 Thread Yaniv Kaul
On 04/25/2012 10:41 AM, Yonit Halperin wrote: > On 04/25/2012 08:32 AM, Noel Van Hook wrote: >> If I recall my windows drivers correctly, I don't think the driver >> even knows what application owns the buffer it is drawing into. >> > IIUC, the implementation involves guest components that track do

Re: [Spice-devel] [PATCH] Change xorg-macros -> xorg-x11-util-macros in configure error message

2012-04-24 Thread Yaniv Kaul
That's for xf86-video-qxl . Y. On 04/24/2012 01:22 PM, Yaniv Kaul wrote: At least in Fedora 17, the correct RPM name is xorg-x11-util-macros diff --git a/configure.ac b/configure.ac index cb874f7..a97f477 100644 --- a/configure.ac +++ b/configure.ac @@ -36,7 +36,7 @@ AC_CONFIG_HE

[Spice-devel] [PATCH] Change xorg-macros -> xorg-x11-util-macros in configure error message

2012-04-24 Thread Yaniv Kaul
At least in Fedora 17, the correct RPM name is xorg-x11-util-macros diff --git a/configure.ac b/configure.ac index cb874f7..a97f477 100644 --- a/configure.ac +++ b/configure.ac @@ -36,7 +36,7 @@ AC_CONFIG_HEADERS([config.h]) # Require xorg-macros: XORG_DEFAULT_OPTIONS m4_ifndef([XORG_MACROS_VE

Re: [Spice-devel] Failing to compile spice-gtk: ../common/client_marshallers.h:27:24: fatal error: marshaller.h: No such file or directory

2012-04-02 Thread Yaniv Kaul
On 04/01/2012 10:41 PM, Marc-André Lureau wrote: Hi - Mensaje original - Indeed - that was the problem - thank you. I don't know how it was not removed during 'git pull'. (and already found a spice-gtk bug - the 'shift+F12' combination seems to work only as 'left-shift+F12', not 'right-

Re: [Spice-devel] Failing to compile spice-gtk: ../common/client_marshallers.h:27:24: fatal error: marshaller.h: No such file or directory

2012-04-01 Thread Yaniv Kaul
On 04/01/2012 07:38 PM, Marc-André Lureau wrote: - Mensaje original - This time, even 'git clean -dfx' didn't save me. And 'make clean' does not seem to work. Tried also ./autogen.sh and ./configure, but no luck: make[4]: Entering directory `/home/ykaul/spice-gtk/gtk' CC bio-gs

[Spice-devel] Failing to compile spice-gtk: ../common/client_marshallers.h:27:24: fatal error: marshaller.h: No such file or directory

2012-04-01 Thread Yaniv Kaul
This time, even 'git clean -dfx' didn't save me. And 'make clean' does not seem to work. Tried also ./autogen.sh and ./configure, but no luck: make[4]: Entering directory `/home/ykaul/spice-gtk/gtk' CC bio-gsocket.lo CC glib-compat.lo CC spice-audio.lo In file included from spi

Re: [Spice-devel] [Users] Really need serious help with spice (its just not working !!) - attached ~/.spicec/spicec.log

2012-03-21 Thread Yaniv Kaul
On 03/21/2012 05:52 PM, David Jaša wrote: Hi, Itamar Heim píše v St 21. 03. 2012 v 17:28 +0200: cc'ing spice-devel On 03/20/2012 07:01 PM, Morgan Cox wrote: Hi. My Setup - 3 servers 1 Frontend (ovirt engine) - Fedora 16- external + local IP 1 Ovirt node (using the node .iso) - externa

Re: [Spice-devel] [PATCH spice-protocol] Add name & uuid messages on main channel

2012-03-20 Thread Yaniv Kaul
Latest Spice dissector in Wireshark trunk[1] has been enhanced to support these two new main channel messages. (It was a bit surprising to find out the UUID is sent as big endian, while most of the protocol is little endian) Y. [1] http://anonsvn.wireshark.org/viewvc/trunk/epan/dissectors/pack

[Spice-devel] spice-gtk core dump

2012-03-20 Thread Yaniv Kaul
Using spice-gtk b9b658f6ea41a2473853149b41fef2cb808ec4f2 spice 914e50814f151a9a5680018e2f264fd900885af9 qemu 33cf629a3754b58a1e2dbbe01d91d97e712b7c06 [ykaul@ykaul spice-gtk]$ gtk/spicy & [1] 29428 [ykaul@ykaul spice-gtk]$ GSpice-Message: main channel: failed to connect GSpice-Message: main channe

Re: [Spice-devel] Failing to compile spice-gtk: generated_marshallers1.c:2:25: fatal error: marshallers.h: No such file or directory

2012-03-19 Thread Yaniv Kaul
which I'm having such issues with each time. I thought 'make clean ; ./autogen.sh' would have solved it. Alas, it didn't. I was not aware of 'git clean' - that worked - thanks! Y. On Mon, Mar 19, 2012 at 9:10 AM, Yaniv Kaul wrote: Yeste

[Spice-devel] Failing to compile spice-gtk: generated_marshallers1.c:2:25: fatal error: marshallers.h: No such file or directory

2012-03-19 Thread Yaniv Kaul
Yesterday's issue was fixed (with commit 837b98d043d10b1d6360d8e1079f88606b37ac84 , I think), but I'm still failing: CC generated_marshallers1.lo generated_marshallers1.c:2:25: fatal error: marshallers.h: No such file or directory compilation terminated. configure: Spice-Gtk 0

[Spice-devel] Failure to compile latest spice-gtk: spice-channel-priv.h:103:33: error: field 'xmit_queue_lock' has incomplete type

2012-03-18 Thread Yaniv Kaul
CC spice-audio.lo In file included from spice-audio.c:44:0: spice-channel-priv.h:103:33: error: field 'xmit_queue_lock' has incomplete type make[2]: *** [spice-audio.lo] Error 1 F16/x64, after ./autogen.sh and 'make clean'. Output of ./configure: Spice-Gtk 0.11.26-e8c9 ==

Re: [Spice-devel] [PATCH 1/2] Add log for invalid/expired tickets

2012-03-04 Thread Yaniv Kaul
On 03/02/2012 05:52 PM, Christophe Fergeau wrote: Currently, when a ticket has already expired, or is invalid, there is no qemu log to tell what went wrong. This commit adds such a log. Fixes rhbz#787669 How 'heavy' is this red_printf? Can this cause DoS (if there's no print limiting to it) ?

Re: [Spice-devel] [PATCH spice-protocol] Add name & uuid messages on main channel

2012-03-04 Thread Yaniv Kaul
On 03/02/2012 03:15 PM, Marc-André Lureau wrote: On Fri, Mar 2, 2012 at 2:10 PM, Christophe Fergeau wrote: Do we really need 2 separate messages for this? You don't necessarily have the 2 value available, you may have none, one or the other, or both. Do you really need two capabilities, thou

Re: [Spice-devel] RFC: remove Adler checksum and zlib header/trailer from zlib compressed images

2012-02-26 Thread Yaniv Kaul
On 02/26/2012 01:46 PM, Yonit Halperin wrote: On 02/23/2012 08:46 PM, Yaniv Kaul wrote: On 02/06/2012 09:43 AM, Yonit Halperin wrote: On 02/06/2012 09:02 AM, Yaniv Kaul wrote: On 01/29/2012 11:29 AM, Alon Levy wrote: On Sun, Jan 29, 2012 at 09:28:34AM +0200, Yaniv Kaul wrote: These small

Re: [Spice-devel] RFC: remove Adler checksum and zlib header/trailer from zlib compressed images

2012-02-23 Thread Yaniv Kaul
On 02/06/2012 09:43 AM, Yonit Halperin wrote: On 02/06/2012 09:02 AM, Yaniv Kaul wrote: On 01/29/2012 11:29 AM, Alon Levy wrote: On Sun, Jan 29, 2012 at 09:28:34AM +0200, Yaniv Kaul wrote: These small changes to server and (gtk) client seem to work, and remove both the zlib header/trailer

Re: [Spice-devel] [PATCH] spice - fix typo: recive -> receive

2012-02-14 Thread Yaniv Kaul
On 02/14/2012 02:48 PM, Alon Levy wrote: On Tue, Jan 31, 2012 at 09:57:19PM +0200, Yaniv Kaul wrote: Fix typo: recive -> receive No functional changes, compile tested only. The patch doesn't apply, looks like some lines are cut in the middle by your email client. Did you use git se

Re: [Spice-devel] [PATCH] Use non-zero data for initial ping

2012-02-14 Thread Yaniv Kaul
On 02/14/2012 10:40 AM, Alon Levy wrote: Other then that looks good, and like you say probably better - although I'm not convinced that by checking several common desktop compression programs you are checking whatever compression scheme vpn's are using. VPNs usually use DEFLATE (which is cl

Re: [Spice-devel] [PATCH] Use non-zero data for initial ping

2012-02-13 Thread Yaniv Kaul
On 02/14/2012 01:54 AM, Dan McGee wrote: On Mon, Feb 13, 2012 at 3:11 PM, Yaniv Kaul wrote: While the best thing would have been to pass the first image already to the client using those 256K (and calculate the bandwidth based on the first data passed to the client and continue to do so, as

Re: [Spice-devel] Untested idea: enlarge the TCP send buffer (server), receive buffer (client)

2012-02-13 Thread Yaniv Kaul
On 02/13/2012 10:47 PM, Yaniv Kaul wrote: For both LAN (high bandwidth, high performance) and WAN (high latency) perhaps it may be worthwhile to increase (via socket options) the TCP receive (on the client) and send (on the server) buffers for the display channel? It will cause: - bigger TCP

Re: [Spice-devel] [PATCH] Use non-zero data for initial ping

2012-02-13 Thread Yaniv Kaul
While the best thing would have been to pass the first image already to the client using those 256K (and calculate the bandwidth based on the first data passed to the client and continue to do so, as the protocol continues), the next best thing would probably be pass *some* image to the client

[Spice-devel] Untested idea: enlarge the TCP send buffer (server), receive buffer (client)

2012-02-13 Thread Yaniv Kaul
For both LAN (high bandwidth, high performance) and WAN (high latency) perhaps it may be worthwhile to increase (via socket options) the TCP receive (on the client) and send (on the server) buffers for the display channel? It will cause: - bigger TCP window (which is good for both cases above)

[Spice-devel] spice-xpi and spicec or spice-gtk as the client

2012-02-07 Thread Yaniv Kaul
Are there plans that spice-xpi would use spice-gtk instead of spicec? Otherwise, it looks like there are features developed only in spice-gtk, and spicec is going to lag behind. (just installed spice-xpi on Fedora, and it only brought spice-client RPM with it). Y. __

Re: [Spice-devel] RFC: remove Adler checksum and zlib header/trailer from zlib compressed images

2012-02-05 Thread Yaniv Kaul
On 01/29/2012 11:29 AM, Alon Levy wrote: On Sun, Jan 29, 2012 at 09:28:34AM +0200, Yaniv Kaul wrote: These small changes to server and (gtk) client seem to work, and remove both the zlib header/trailer from the deflate stream as well as the Adler checksum, which removes several bytes from the

[Spice-devel] [PATCH] spice - fix typo: recive -> receive

2012-01-31 Thread Yaniv Kaul
Fix typo: recive -> receive No functional changes, compile tested only. diff --git a/server/main_channel.h b/server/main_channel.h index c5d407e..1a1ad59 100644 --- a/server/main_channel.h +++ b/server/main_channel.h @@ -38,8 +38,8 @@ struct MainMigrateData { uint32_t read_state; VDIC

Re: [Spice-devel] [Users] oVirt console plans

2012-01-30 Thread Yaniv Kaul
On 01/31/2012 07:38 AM, Brown, Chris (GE Healthcare) wrote: I did some more extensive testing tonight to see how many guests would have issues with a SPICE based console. This testing was specifically during guest OS install time. On how many of them was the Spice guest agent installed? Witho

[Spice-devel] Where is xf86-video-qxl discussed?

2012-01-28 Thread Yaniv Kaul
Would be nice to see commits to it sent to the spice-comm...@lists.freedesktop.org , if that's possible. Is it discussed here (spice-devel) or elsewhere? I've noticed caching was finally added to it, but I'm not sure I understand how it works. Specifically, I don't see how images are actually f

[Spice-devel] RFC: remove Adler checksum and zlib header/trailer from zlib compressed images

2012-01-28 Thread Yaniv Kaul
These small changes to server and (gtk) client seem to work, and remove both the zlib header/trailer from the deflate stream as well as the Adler checksum, which removes several bytes from the stream as well as speedup (unnoticeable) of the compression/decompression due to the removal of the ch

[Spice-devel] Failure to compile spice-gtk

2012-01-24 Thread Yaniv Kaul
As usual, I'm having problems with the strict requirements of spice-gtk (why can't it just disable usbredir if it does not find it in the ./configure phase is beyond me). I suspect too old RPMs, but I'm not sure where I should be taking newer ones (same goes to usbredir, but at least I can disa

Re: [Spice-devel] Delay in Gimp when using qxl driver

2012-01-23 Thread Yaniv Kaul
:59PM +0100, Dominique Rodrigues wrote: Le 22/01/2012 18:28, Alon Levy a écrit : On Sun, Jan 22, 2012 at 05:15:42PM +0200, Alon Levy wrote: On Sun, Jan 22, 2012 at 03:53:40PM +0100, Dominique Rodrigues wrote: Le 22/01/2012 16:00, Alon Levy a écrit : On Fri, Jan 20, 2012 at 02:04:47PM -0500, Yaniv

Re: [Spice-devel] Delay in Gimp when using qxl driver

2012-01-20 Thread Yaniv Kaul
- Original Message - > On Wed, Jan 18, 2012 at 11:59:45AM +0100, Dominique Rodrigues wrote: > > Le 18/01/2012 11:48, Alon Levy a écrit : > > >On Wed, Jan 18, 2012 at 11:39:13AM +0100, Dominique Rodrigues > > >wrote: > > >>Le 18/01/2012 11:32, Alon Levy a écrit : > > >>>On Wed, Jan 18, 2012

Re: [Spice-devel] spice-protocol "mess"

2012-01-16 Thread Yaniv Kaul
On 01/15/2012 10:40 AM, Yaniv Kaul wrote: On 01/15/2012 10:13 AM, Yonit Halperin wrote: BTW, Yaniv, can you update the wireshark dissector to handle the new protocol? Yonit. Already on it, hopefully patch will be ready by the end of the week. https://bugs.wireshark.org/bugzilla

Re: [Spice-devel] spice-protocol "mess"

2012-01-15 Thread Yaniv Kaul
On 01/15/2012 10:13 AM, Yonit Halperin wrote: BTW, Yaniv, can you update the wireshark dissector to handle the new protocol? Yonit. Already on it, hopefully patch will be ready by the end of the week. I'm not sure the capability exchange was done in the spirit of the protocol (I think e

[Spice-devel] Compilation warning over libcspice-client-gtk-3.0

2012-01-08 Thread Yaniv Kaul
When compiling latest git, just noticed I'm getting (marked two issues, in bold): ... CC spice-widget-cairo.lo CCLD libspice-client-glib-2.0.la GISCAN SpiceClientGLib-2.0.gir CCLD libspice-client-gtk-3.0.la *spice-option.c:52: Warning: SpiceClientGLib: spice_get_option_group: ret

Re: [Spice-devel] Failure to compile spice-gtk (git clone git://git.engineering.redhat.com/users/rvaknin/preint_scripts/.git)

2012-01-05 Thread Yaniv Kaul
On 01/05/2012 03:42 PM, Christophe Fergeau wrote: On Thu, Jan 05, 2012 at 03:38:11PM +0200, Yaniv Kaul wrote: On 01/05/2012 03:31 PM, Christophe Fergeau wrote: On Thu, Jan 05, 2012 at 03:26:48PM +0200, Yaniv Kaul wrote: [ykaul@ykaul qemu-kvm]$ rpm -qa|grep usb libusb1-devel-doc-1.0.9-0.3.rc1

Re: [Spice-devel] Failure to compile spice-gtk (git clone git://git.engineering.redhat.com/users/rvaknin/preint_scripts/.git)

2012-01-05 Thread Yaniv Kaul
On 01/05/2012 03:31 PM, Christophe Fergeau wrote: On Thu, Jan 05, 2012 at 03:26:48PM +0200, Yaniv Kaul wrote: [ykaul@ykaul qemu-kvm]$ rpm -qa|grep usb libusb1-devel-doc-1.0.9-0.3.rc1.fc16.noarch usbredir-0.3.1-1.fc16.x86_64 libusb1-devel-1.0.9-0.3.rc1.fc16.x86_64 libgusb-0.1.3-1.fc16.x86_64

Re: [Spice-devel] Failure to compile spice-gtk (git clone git://git.engineering.redhat.com/users/rvaknin/preint_scripts/.git)

2012-01-05 Thread Yaniv Kaul
On 01/05/2012 03:13 PM, Christophe Fergeau wrote: On Thu, Jan 05, 2012 at 02:13:57PM +0200, Yaniv Kaul wrote: Latest git, on F16/x64: CC channel-usbredir.lo channel-usbredir.c: In function 'spice_usbredir_channel_open_device': channel-usbredir.c:193:5: error: implicit decl

Re: [Spice-devel] Failure to compile spice-gtk (git clone git://git.engineering.redhat.com/users/rvaknin/preint_scripts/.git)

2012-01-05 Thread Yaniv Kaul
On 01/05/2012 02:13 PM, Yaniv Kaul wrote: Latest git, on F16/x64: CC channel-usbredir.lo channel-usbredir.c: In function 'spice_usbredir_channel_open_device': channel-usbredir.c:193:5: error: implicit declaration of function 'usbredirhost_open_full' [-Werr

[Spice-devel] Failure to compile spice-gtk (git clone git://git.engineering.redhat.com/users/rvaknin/preint_scripts/.git)

2012-01-05 Thread Yaniv Kaul
Latest git, on F16/x64: CC channel-usbredir.lo channel-usbredir.c: In function 'spice_usbredir_channel_open_device': channel-usbredir.c:193:5: error: implicit declaration of function 'usbredirhost_open_full' [-Werror=implicit-function-declaration] channel-usbredir.c:193:16: error: assignm

Re: [Spice-devel] [spice-xpi PATCH 1/3] logging: add logging of variable setting (#753155)

2012-01-01 Thread Yaniv Kaul
- Original Message - > - Original Message - > > Password and TrustStore are not logged. > > --- > > SpiceXPI/src/plugin/plugin.cpp | 20 +++- > > 1 files changed, 19 insertions(+), 1 deletions(-) > > > > diff --git a/SpiceXPI/src/plugin/plugin.cpp > > b/SpiceXPI/

Re: [Spice-devel] [spice-xpi PATCH 1/3] logging: add logging of variable setting (#753155)

2012-01-01 Thread Yaniv Kaul
- Original Message - > Password and TrustStore are not logged. > --- > SpiceXPI/src/plugin/plugin.cpp | 20 +++- > 1 files changed, 19 insertions(+), 1 deletions(-) > > diff --git a/SpiceXPI/src/plugin/plugin.cpp > b/SpiceXPI/src/plugin/plugin.cpp > index 2dada12..0b2ec4

Re: [Spice-devel] [PATCH spice-protocol 1/2] Add support for a header without sub list.

2011-12-29 Thread Yaniv Kaul
On 12/29/2011 10:30 AM, Alon Levy wrote: On Thu, Dec 29, 2011 at 08:11:27AM +0200, Yonit Halperin wrote: On 12/28/2011 10:04 PM, Yaniv Kaul wrote: On 12/28/2011 07:14 PM, Yonit Halperin wrote: Add SpiceDataHeaderNoSub. Introduce capability SPICE_COMMON_CAP_HEADER_NO_SUB. Introduce

Re: [Spice-devel] [PATCH spice-protocol 1/2] Add support for a header without sub list.

2011-12-28 Thread Yaniv Kaul
On 12/29/2011 08:11 AM, Yonit Halperin wrote: On 12/28/2011 10:04 PM, Yaniv Kaul wrote: On 12/28/2011 07:14 PM, Yonit Halperin wrote: Add SpiceDataHeaderNoSub. Introduce capability SPICE_COMMON_CAP_HEADER_NO_SUB. Introduce SPICE_MSG_LIST: the msg body is SpiceSubMessageList. The advantage of

Re: [Spice-devel] [PATCH spice-protocol 1/2] Add support for a header without sub list.

2011-12-28 Thread Yaniv Kaul
On 12/28/2011 07:14 PM, Yonit Halperin wrote: Add SpiceDataHeaderNoSub. Introduce capability SPICE_COMMON_CAP_HEADER_NO_SUB. Introduce SPICE_MSG_LIST: the msg body is SpiceSubMessageList. The advantage of using a header without sub list is to spare the 4 bytes that were sent for a lot of messag

Re: [Spice-devel] Failure to compile xf86-video-qxl (SPICE_BITMAP_FMT_8BIT_A' undeclared)

2011-12-18 Thread Yaniv Kaul
On 12/18/2011 05:37 PM, Alon Levy wrote: On Sat, Dec 17, 2011 at 08:54:48PM +0200, Yaniv Kaul wrote: make[3]: Entering directory `/home/ykaul/xf86-video-qxl/src' CC qxl_driver.lo CC qxl_image.lo qxl_image.c: In function 'qxl_image_create': qxl_image.

[Spice-devel] Failure to compile xf86-video-qxl (SPICE_BITMAP_FMT_8BIT_A' undeclared)

2011-12-17 Thread Yaniv Kaul
make[3]: Entering directory `/home/ykaul/xf86-video-qxl/src' CC qxl_driver.lo CC qxl_image.lo qxl_image.c: In function 'qxl_image_create': qxl_image.c:215:29: error: 'SPICE_BITMAP_FMT_8BIT_A' undeclared (first use in this function) F16/x64, fully updated. Probably related to: com

Re: [Spice-devel] vala is now needed?

2011-12-10 Thread Yaniv Kaul
On 12/10/2011 05:05 PM, Hans de Goede wrote: Hi, On 12/09/2011 09:56 PM, Yaniv Kaul wrote: 1. Too bad there is no proper check for vala when running ./configure (or ./autogen.sh). 2. I've have vala installed and installed vala-devel, ./configure passes, yet with 'make' I

[Spice-devel] vala is now needed?

2011-12-09 Thread Yaniv Kaul
1. Too bad there is no proper check for vala when running ./configure (or ./autogen.sh). 2. I've have vala installed and installed vala-devel, ./configure passes, yet with 'make' I'm getting: make[4]: Entering directory `/home/ykaul/spice-gtk/gtk/controller' *** Error: missing valac! *** Yo

Re: [Spice-devel] Spice required ports

2011-12-02 Thread Yaniv Kaul
On 12/01/2011 07:39 PM, Alon Levy wrote: On Thu, Dec 01, 2011 at 11:01:39AM -0500, Richard Mann wrote: Just joined. Not sure where to ask this question. It relates to security and opening ports on a firewall through which the Spice clients and server would communicate. I would lik

Re: [Spice-devel] [PATCH vdagent-win 3/3] vdlog: change log times to human readable date & time rhbz#672828

2011-11-16 Thread Yaniv Kaul
On 11/16/2011 02:46 PM, David Jaša wrote: Arnon Gilboa píše v St 16. 11. 2011 v 14:20 +0200: Alon Levy wrote: On Wed, Nov 16, 2011 at 12:16:37PM +0200, Arnon Gilboa wrote: ifndef USE_DATE_TIME, use system time instead of secs from system startup Why do we want to keep the old behavior? Fo

[Spice-devel] spicy gets stuck (with SASL and wrong password)

2011-11-06 Thread Yaniv Kaul
Hi, I'm trying to run the following: qemu (latest git, with spice from latest git): ./x86_64-softmmu/qemu-system-x86_64 -spice port=6901,disable-ticketing,sasl -k en-us -name XP -boot c -soundhw pcspk -m 1024 -cpu core2duo,+x2apic -smp 2 -balloon none -bios /usr/share/seabios/bios.bin -monitor

Re: [Spice-devel] [master PATCH 2/2] server: netstat: send random data not zeros

2011-10-19 Thread Yaniv Kaul
On 10/19/2011 01:42 PM, Frédéric Grelot wrote: That seems like a good idea. Note that if the first image is not compressed, we may have a similar problem with WAN accelerators. Also maybe it is better to always compress it. This random buffer was intended as a quick fix. In the long run, we woul

Re: [Spice-devel] [master PATCH 1/2] server: netstat: modify network bandwidth calculation

2011-10-18 Thread Yaniv Kaul
On 18/10/2011 19:20, Uri Lublin wrote: Currently spice-server network bandwidth estimation is: send an empty ping packet to the client (and ignore it) ("warmup") Useless. 'warmup' of what exactly? The TCP MSS and everything else is already set by the TCP handshake and the RED initial connec

Re: [Spice-devel] [master PATCH 2/2] server: netstat: send random data not zeros

2011-10-18 Thread Yaniv Kaul
On 18/10/2011 19:20, Uri Lublin wrote: WAN accelerators may compress the zeros which results with a wrong bandwidth calculation. Is this really the right approach? Why not calculate the latency based on the time it takes to send the first image? That image is not using the WAN feature anyway,

Re: [Spice-devel] Ubuntu - max video resoltion 1024x768

2011-10-10 Thread Yaniv Kaul
On 10/10/2011 05:03 AM, Naga Mohan Pothula wrote: Hi Alon, Thank you for your prompt response. I can't work on xorg.conf to set resolution for each guest. This is not optimum soltuion for me that hundreds of guests need to be updated. Regardless of Spice, if you have hundreds of guests you ne

Re: [Spice-devel] Question on fill_mask() (server/red_worker.c)

2011-10-04 Thread Yaniv Kaul
On 10/04/2011 01:25 PM, Yonit Halperin wrote: On 10/04/2011 01:20 PM, Alon Levy wrote: On Tue, Oct 04, 2011 at 01:00:47PM +0200, Alon Levy wrote: On Tue, Oct 04, 2011 at 12:40:21PM +0200, Yaniv Kaul wrote: Unless I'm misreading the code (which may very well be), the function looks like

Re: [Spice-devel] Question on fill_mask() (server/red_worker.c)

2011-10-04 Thread Yaniv Kaul
On 10/04/2011 01:00 PM, Alon Levy wrote: On Tue, Oct 04, 2011 at 12:40:21PM +0200, Yaniv Kaul wrote: Unless I'm misreading the code (which may very well be), the function looks like: if (mask_bitmap&& m) { if (this or that) { do X fill_bits(...

[Spice-devel] Question on fill_mask() (server/red_worker.c)

2011-10-04 Thread Yaniv Kaul
Unless I'm misreading the code (which may very well be), the function looks like: if (mask_bitmap && m) { if (this or that) { do X fill_bits(...) } else { fill_bits(...) } } So essentially, if the condition (mask_bitmap && m) is NOT met, we do not fill the b

Re: [Spice-devel] Spice protocol dissector in Wireshark trunk

2011-09-30 Thread Yaniv Kaul
On 30/09/2011 21:02, Christophe Fergeau wrote: On Fri, Sep 30, 2011 at 06:53:45PM +0300, Yaniv Kaul wrote: My Spice protocol dissector has just been accepted into Wireshark and is available in trunk. Great news! Congratulations! Do you have an idea when the next release of wireshark will be

[Spice-devel] Spice protocol dissector in Wireshark trunk

2011-09-30 Thread Yaniv Kaul
My Spice protocol dissector has just been accepted into Wireshark and is available in trunk. Y. ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] About QoS and/or Timing profiling

2011-09-27 Thread Yaniv Kaul
On 09/28/2011 01:05 AM, Antonio Perez-Aranda wrote: HI all, I recently started a project to give service about 400 concurrent desktops but customer ask me for timing profiling tests. I have set TLS (it's a requeriment), and I could have intranet and extranet sniffers. So, Can I measure the del

Re: [Spice-devel] SPICE protocol - UDP or TCP?

2011-09-15 Thread Yaniv Kaul
On 09/15/2011 04:36 AM, Jose Ruelas (josruela) wrote: hello My name is Jose Ruelas, from Cisco (LATAM) we have a customer that is considering to use RHEV for Desktops, and the SPICE protocol came to discussion table one question is still on air, about how SPICE protocol "travels" over the

Re: [Spice-devel] Why is the CA certificate needed on the SPICE server?

2011-09-07 Thread Yaniv Kaul
On 09/07/2011 01:42 PM, Andrea Spadaccini wrote: Hello, I am implementing SPICE support in Ganeti (http://code.google.com/p/ganeti), and while implementing TLS I noticed that the SPICE server needs, apart from his key and certificate, also the certificate of the CA that signed its certificate. I

Re: [Spice-devel] WinQXL: PREfast analysis errors and warnings

2011-09-01 Thread Yaniv Kaul
in a balloon in the tray bar. Y. 2011/9/1 Yaniv Kaul mailto:yk...@redhat.com>> Has anyone looked at the warning and errors PREfast (from MS DDK) produces? - driver.c(111): usage of _snprintf banned API - driver.c(112): usage of _vsnprintf banned API - driver.c(387): &#x

[Spice-devel] WinQXL: PREfast analysis errors and warnings

2011-09-01 Thread Yaniv Kaul
Has anyone looked at the warning and errors PREfast (from MS DDK) produces? - driver.c(111): usage of _snprintf banned API - driver.c(112): usage of _vsnprintf banned API - driver.c(387): 'video_buff' could be '0' and is a copy of the value found in 'selected_mode'. See line 358 for an earlier l

Re: [Spice-devel] problem for vdagent

2011-08-09 Thread Yaniv Kaul
On 08/09/2011 01:30 PM, Arnon Gilboa wrote: I guess you are forking vdagent ;) Do you call CreateProcess() from vdagent? or vdservice? upon receiving specific msg? what's the GetLastError()? if used from vdagent, why not just use MessageBox()? what OS are you using? Please provide all the details

Re: [Spice-devel] Question about Spice and Display Channel

2011-08-03 Thread Yaniv Kaul
On 03/08/2011 21:33, Andrea Celestino wrote: Hi, I want to try to implements a new channel dedicated to streaming video. It's only an experiment, I don't know if this can bring an improvement. I would like to know some guidelines for implementing this channel. In spice every channel is a differen

[Spice-devel] [patch] [typo] NASKE -> MASK (WinQXL)

2011-08-03 Thread Yaniv Kaul
For WinQXL: diff --git a/display/qxldd.h b/display/qxldd.h index 9b613c1..7ee8896 100644 --- a/display/qxldd.h +++ b/display/qxldd.h @@ -89,11 +89,11 @@ typedef struct Ring { #define CURSOR_CACHE_SIZE (1 << 6) #define CURSOR_HASH_SIZE (CURSOR_CACHE_SIZE << 1) -#define CURSOR_HASH_NASKE (CURSOR

Re: [Spice-devel] Spice Windows 7 display driver?

2011-08-02 Thread Yaniv Kaul
0 = Windows 2000 * 2:5.1 = Windows XP * 2:5.2 = Windows Server 2003 * 2:6.0 = Windows Vista and Windows Server 2008 * 2:6.1 = Windows 7 and Windows 2008 R2 x64 HTH, Y. On 08/02/2011 09:41 AM, Yaniv Kaul wrote: On 02/08/2011 16:25, Nathan Lager wrote: I'm not sure what went wrong last

Re: [Spice-devel] Spice Windows 7 display driver?

2011-08-02 Thread Yaniv Kaul
On 02/08/2011 16:25, Nathan Lager wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I'm not sure what went wrong last time, but this time I was able to get the driver signed with a Test Cert. Followed the instructions for enabling test signing, and attempted to install the driver. It presen

Re: [Spice-devel] [PATCH 2/2] server: init all fields on SpiceMsgDisplayStreamCreate

2011-08-02 Thread Yaniv Kaul
On 08/02/2011 01:54 PM, Alon Levy wrote: On Tue, Aug 02, 2011 at 12:31:57PM +0200, Christophe Fergeau wrote: This patch is an RFC red_display_marshall_stream_start initializes a SpiceMsgDisplayStreamCreate structure before marshalling it and sending it on the wire. However, it never fills Spice

  1   2   >