Re: [Spice-devel] [PATCH] change marshalling macros to consider alignment of types

2015-12-25 Thread Anton D . Kachalov
t;>  > %s((%s_t)val)" % (utype, swap, utype)) >>  > + writer.writeln("#elif __GNUC__ > 3") >>  > + struct = "pkg_struct" >> >>  Why is it called 'pkg_struct' ? > > Was a struct before... and few fantasy at the moment :) > >>  I'll let Anton tell us if this helps with his situation or not before >>  looking closer at that patch >> >>  Christophe > > I should have put an "RFC", this patch was intended to be tested by Anton > (it's in reply to Anton's thread). > > Note that this patch does not consider architectures with big endian and > unaligned access problems. > > Frediano > ___ > Spice-devel mailing list > Spice-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/spice-devel -- Anton D. Kachalov ITO, System Architect Tel: 7 (495) 739-70-00 ext.7613 ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] [PATCH] demarshall: Add safe method for unaligned byte access.

2015-12-23 Thread Anton D . Kachalov
es not globally enable aligned read access but only when not aligned (or > better when alignment is not expected). > > I'll post a patch to solve this issue. > > Frediano > -- Anton D. Kachalov ___ Spice-devel mailin

Re: [Spice-devel] [PATCH] demarshall: Add safe method for unaligned byte access.

2015-12-03 Thread Anton D . Kachalov
itecture it's your machine. Could be that using some >>  gcc options would make the compiler generate only aligned access >>  instructions. > > Can you try to add -mno-unaligned-access option to your CFLAGS ? > > Frediano

[Spice-devel] Decoders list?

2015-11-30 Thread Anton D . Kachalov
Hello. Decoders passed as a number of parameters. If we like to have another one decoder, we would add one more parameter. Might it be better to implement just a list of decoders? http://cgit.freedesktop.org/spice/spice-common/tree/common/sw_canvas.c#n1287 http://cgit.freedesktop.org/spice/spic

[Spice-devel] [PATCH] demarshall: Add safe method for unaligned byte access.

2015-11-25 Thread Anton D . Kachalov
Usefull for ARM. Enable with "USE_MEMCPY" define. Should be better to add "--use-memcpy" to configure.ac Signed-off-by: Anton D. Kachalov --- python_modules/demarshal.py | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --

Re: [Spice-devel] aspeed: video frames pass-through

2015-11-18 Thread Anton D . Kachalov
regression on our ARM SoC during video streaming. May be a little CPU usage (~3-5% overhead comparing to unpacked/aligned structures). I may try to modify codegen to use memcpy and publish it among marshaller.c on git. Would you mind to perform a perf te

Re: [Spice-devel] aspeed: video frames pass-through

2015-11-18 Thread Anton D . Kachalov
18.11.2015, 17:29, "Anton D. Kachalov" : > Hi. > > > struct { >   uint16_t foo; >   uint32_t bar; > } > > What alignment would be on "bar" access (ptr address input for read_uint32)? This might work: uint32_t read_uint32(uint8_t *ptr) { return

Re: [Spice-devel] aspeed: video frames pass-through

2015-11-18 Thread Anton D . Kachalov
use memcpy? It is align-safe. > Yup, I'm suggesting 2. above. Maybe it will be best to make these > code-paths ARM specific. I'll try to rewrite with memcpy and check. -- Anton D. Kachalov ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

Re: [Spice-devel] aspeed: video frames pass-through

2015-11-18 Thread Anton D . Kachalov
erall performance. BTW, SPICE_TICKET_PUBKEY_BYTES definiton is unaligned too (1024 / 8 + 34) eq 162 (40 and a half double words). Used in SpiceLinkReply. 16.11.2015, 16:39, "Christophe Fergeau" : > On Thu, Nov 12, 2015 at 08:29:07PM +0300, Anton D. Kachalov wrote: >>  Hello.

Re: [Spice-devel] aspeed: video frames pass-through

2015-11-12 Thread Anton D . Kachalov
Hello. 03.11.2015, 19:17, "Anton D. Kachalov" : > 03.11.2015, 18:43, "Christophe Fergeau" : >>  Hmm, not very familiar with ARM, and not sure this has seen a lot of >>  testing. Maybe getting a backtrace would shed more light? > > I'll try rewritten

Re: [Spice-devel] aspeed: video frames pass-through

2015-11-03 Thread Anton D . Kachalov
03.11.2015, 18:43, "Christophe Fergeau" : > On Tue, Oct 27, 2015 at 08:42:03PM +0300, Anton D. Kachalov wrote: >>  Hello, >> > > If I understand correctly, the encoding/decoding is all done in > hardware? Encoding & compressing is done in hardware while

Re: [Spice-devel] red_dispatcher: client disconnect hangs the server

2015-11-03 Thread Anton D . Kachalov
Hell, Christophe. I've found a missed mutex unlock in my code added to the red_worker/fill_bits. Git version looks stable for me now. 03.11.2015, 18:24, "Christophe Fergeau" : > Hey, > > On Thu, Oct 29, 2015 at 08:54:12PM +0300, Anton D. Kachalov wrote: >>  Hi.

Re: [Spice-devel] Full featured (qxl compatible) spice web client released

2015-10-30 Thread Anton D . Kachalov
munity contributions? > > I note the attribution clause in your license. As it stands now, I > don't think that would cause any trouble (because of the 'however' of 5 > (d) of the agpl). But it would probably be useful to get a clear > expression of your intent - is

[Spice-devel] red_dispatcher: client disconnect hangs the server

2015-10-29 Thread Anton D . Kachalov
b604c1530a in g_main_loop_run () from /lib/x86_64-linux-gnu/libglib-2.0.so.0 #14 0x00401f95 in basic_event_loop_mainloop () at basic_event_loop.c:173 #15 0x00401bfc in main () at test_display_no_ssl.c:86 -- Anton D. Kachalov ___ S

[Spice-devel] aspeed: video frames pass-through

2015-10-27 Thread Anton D . Kachalov
o much. Links to repo:   https://github.com/ya-mouse/spice/tree/gst   https://github.com/ya-mouse/spice-common/tree/gst   https://github.com/ya-mouse/spice-protocol/tree/gst   https://github.com/ya-mouse/spice-gtk Attached file is a dump for testing purpose (just put as /dev/videocap to te

[Spice-devel] aspeed: video frames pass-through

2015-10-27 Thread Anton D . Kachalov
://github.com/ya-mouse/spice-common/tree/gst  https://github.com/ya-mouse/spice-protocol/tree/gst  https://github.com/ya-mouse/spice-gtk Attached file is a dump for testing purpose (just put as /dev/videocap to test server/client). -- Anton D. Kachalov videocap.bin Description: Binary data ___