Re: [Spice-devel] Streaming video performance concepts

2011-06-22 Thread Attila Sukosd
How about WebM? http://www.webmproject.org/ Sounds like it could be useful :) Best Regards, Attila Sukosd - DTU Computing Center - www.cc.dtu.dk att...@cc.dtu.dk, gba...@student.dtu.dk, s070...@student.dtu.dk On Thu, Jun 23, 2011 at 1:58 AM, John A. Su

Re: [Spice-devel] Streaming video performance concepts

2011-06-22 Thread John A. Sullivan III
On Wed, 2011-06-22 at 23:49 +0200, Alon Levy wrote: > On Wed, Jun 22, 2011 at 03:44:40PM -0400, John A. Sullivan III wrote: > > On Wed, 2011-06-22 at 17:01 +0200, Alon Levy wrote: > > > On Wed, Jun 22, 2011 at 09:56:28AM -0400, John A. Sullivan III wrote: > > > > On Wed, 2011-06-22 at 11:27 +0200,

Re: [Spice-devel] Streaming video performance concepts

2011-06-22 Thread Alon Levy
On Wed, Jun 22, 2011 at 03:44:40PM -0400, John A. Sullivan III wrote: > On Wed, 2011-06-22 at 17:01 +0200, Alon Levy wrote: > > On Wed, Jun 22, 2011 at 09:56:28AM -0400, John A. Sullivan III wrote: > > > On Wed, 2011-06-22 at 11:27 +0200, Alon Levy wrote: > > > > > Thank you very much for the expla

Re: [Spice-devel] Streaming video performance concepts

2011-06-22 Thread John A. Sullivan III
On Wed, 2011-06-22 at 17:01 +0200, Alon Levy wrote: > On Wed, Jun 22, 2011 at 09:56:28AM -0400, John A. Sullivan III wrote: > > On Wed, 2011-06-22 at 11:27 +0200, Alon Levy wrote: > > > > Thank you very much for the explanation. It's pretty much what I > > > > expected - that the codec is differen

Re: [Spice-devel] repository reorg

2011-06-22 Thread Alon Levy
On Wed, Jun 22, 2011 at 08:14:57PM +0300, Uri Lublin wrote: > On 06/22/2011 06:00 PM, Alon Levy wrote: > >Hi All, > > > > We currently have the following repositories: > > spice-protocol > > spice > > spice-gtk > > also > spice-vdagent (for both Windows and Linux) > spice-xpi/acti

Re: [Spice-devel] repository reorg

2011-06-22 Thread Uri Lublin
On 06/22/2011 06:00 PM, Alon Levy wrote: Hi All, We currently have the following repositories: spice-protocol spice spice-gtk also spice-vdagent (for both Windows and Linux) spice-xpi/active-x (as mentioned below) spice-protocol contains the following parts: qxl_de

Re: [Spice-devel] repository reorg

2011-06-22 Thread Marc-André Lureau
On Wed, Jun 22, 2011 at 6:11 PM, Christophe Fergeau wrote: > Hi, > > On Wed, Jun 22, 2011 at 05:00:10PM +0200, Alon Levy wrote: >>  Suggested changes: >>   spice - merge spice-protocol into it >>   spice-protocol - kill it >>   common - extract to a separate library, it's own configure, pkg-config

Re: [Spice-devel] repository reorg

2011-06-22 Thread Christophe Fergeau
Hi, On Wed, Jun 22, 2011 at 05:00:10PM +0200, Alon Levy wrote: > Suggested changes: > spice - merge spice-protocol into it > spice-protocol - kill it > common - extract to a separate library, it's own configure, pkg-config, > name it spice-render, >and have spice-gtk and spice (server

[Spice-devel] repository reorg

2011-06-22 Thread Alon Levy
Hi All, We currently have the following repositories: spice-protocol spice spice-gtk spice-protocol contains the following parts: qxl_dev.h - required by qemu and drivers controller.h - required by spice client and xpi/active-x the rest - protocol definitions for server and client

Re: [Spice-devel] [PATCH 1/3] add check for pyparsing

2011-06-22 Thread Christophe Fergeau
On Wed, Jun 22, 2011 at 06:12:42PM +0300, Uri Lublin wrote: > On 06/22/2011 12:09 PM, Christophe Fergeau wrote: > >Check both in configure.ac (after checking if we need to rebuild > >the marshalling files) and in the python script using pyparsing > >(for people modifying .proto files in tarballs) >

Re: [Spice-devel] [PATCH 1/3] add check for pyparsing

2011-06-22 Thread Uri Lublin
On 06/22/2011 12:09 PM, Christophe Fergeau wrote: Check both in configure.ac (after checking if we need to rebuild the marshalling files) and in the python script using pyparsing (for people modifying .proto files in tarballs) I'm ok with this patch (aka ack). Just wanted to note that the cond

Re: [Spice-devel] Streaming video performance concepts

2011-06-22 Thread Alon Levy
On Wed, Jun 22, 2011 at 09:56:28AM -0400, John A. Sullivan III wrote: > On Wed, 2011-06-22 at 11:27 +0200, Alon Levy wrote: > > > Thank you very much for the explanation. It's pretty much what I > > > expected - that the codec is different, trading CPU efficiency for > > > bandwidth inefficiency a

Re: [Spice-devel] [PATCH 0/3] Misc patches

2011-06-22 Thread Christophe Fergeau
On Wed, Jun 22, 2011 at 11:43:03AM +0200, Marc-André Lureau wrote: > ack pushed with s/__visible__/SPICE_GNUC_VISIBLE in the new volume functions you added, and with the #define for SPICE_GNUC_VISIBLE fixed (there was a missing space after SPICE_GNUC_VISIBLE) Christophe pgpQtC3Rtw4DZ.pgp Descri

Re: [Spice-devel] Streaming video performance concepts

2011-06-22 Thread John A. Sullivan III
On Wed, 2011-06-22 at 11:27 +0200, Alon Levy wrote: > > Thank you very much for the explanation. It's pretty much what I > > expected - that the codec is different, trading CPU efficiency for > > bandwidth inefficiency and I certainly understand the reasons why. > > > > Is there any thought or pl

Re: [Spice-devel] [PATCH 0/2] spice-protocol: audio volume update

2011-06-22 Thread Alon Levy
On Wed, Jun 22, 2011 at 12:03:00PM +0200, Marc-André Lureau wrote: > Hi ACK. > > The following patches are necessary to build the spice > server with audio volume support. > > Marc-André Lureau (2): > spice: enums.h regenerated > protocol: add SPICE_{PLAYBACK,RECORD}_CAP_VOLUME caps > > s

Re: [Spice-devel] [PATCH 0/4] sndworker: add volume messages

2011-06-22 Thread Alon Levy
On Wed, Jun 22, 2011 at 11:51:33AM +0200, Marc-André Lureau wrote: > Hi, ACK with the one line move. > > The following patches allow the guest to control > the client stream volume, preceded by 2 small codegen patches. > > Marc-André Lureau (4): > codegen: typedef the protocol enums > pytho

Re: [Spice-devel] [PATCH 3/4] sndworker: add AudioVolume/AudioMute messages

2011-06-22 Thread Marc-André Lureau
On Wed, Jun 22, 2011 at 12:04 PM, Alon Levy wrote: > You remove this line here and put it back in the next patch. > Gah, mixed that with the wrong commit - fixed, my bad. -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop

Re: [Spice-devel] [PATCH 3/4] sndworker: add AudioVolume/AudioMute messages

2011-06-22 Thread Alon Levy
On Wed, Jun 22, 2011 at 11:51:36AM +0200, Marc-André Lureau wrote: > These messages allow the guest to send the audio device volume to the > client. It uses an arbitrary scale of 16bits, which works good enough > for now. > > Save VolumeState in {Playback,Record}State, so that we can send the > cu

[Spice-devel] [PATCH 2/2] protocol: add SPICE_{PLAYBACK, RECORD}_CAP_VOLUME caps

2011-06-22 Thread Marc-André Lureau
From: Marc-André Lureau These changes the protocol the following way: When the client announces it has SPICE_PLAYBACK_CAP_VOLUME, the server can send PlaybackChannel.{volume,mute} messages to notify of volume changes (respectively for RECORD). If the client doesn't implement SPICE_PLAYBACK_CAP_

[Spice-devel] [PATCH 1/2] spice: enums.h regenerated

2011-06-22 Thread Marc-André Lureau
From: Marc-André Lureau --- spice/enums.h | 145 +--- 1 files changed, 75 insertions(+), 70 deletions(-) diff --git a/spice/enums.h b/spice/enums.h index 29f5933..756df56 100644 --- a/spice/enums.h +++ b/spice/enums.h @@ -1,9 +1,10 @@ +/* thi

[Spice-devel] [PATCH 0/2] spice-protocol: audio volume update

2011-06-22 Thread Marc-André Lureau
Hi The following patches are necessary to build the spice server with audio volume support. Marc-André Lureau (2): spice: enums.h regenerated protocol: add SPICE_{PLAYBACK,RECORD}_CAP_VOLUME caps spice/enums.h| 145 -- spice/protocol.

[Spice-devel] [PATCH 4/4] sndworker: check the caps before sending volume messages

2011-06-22 Thread Marc-André Lureau
--- server/snd_worker.c | 57 ++- 1 files changed, 47 insertions(+), 10 deletions(-) diff --git a/server/snd_worker.c b/server/snd_worker.c index e4cefb1..7dbc490 100644 --- a/server/snd_worker.c +++ b/server/snd_worker.c @@ -114,6 +114,8 @@ struc

[Spice-devel] [PATCH 3/4] sndworker: add AudioVolume/AudioMute messages

2011-06-22 Thread Marc-André Lureau
These messages allow the guest to send the audio device volume to the client. It uses an arbitrary scale of 16bits, which works good enough for now. Save VolumeState in {Playback,Record}State, so that we can send the current volume on channel connection. Note about future improvements: - add exac

[Spice-devel] [PATCH 2/4] python: remove c-ism trailing ;

2011-06-22 Thread Marc-André Lureau
--- python_modules/codegen.py |6 +++--- python_modules/demarshal.py| 32 python_modules/ptypes.py |6 +++--- python_modules/spice_parser.py |2 +- spice_codegen.py |4 ++-- 5 files changed, 25 insertions(+), 25 deleti

[Spice-devel] [PATCH 1/4] codegen: typedef the protocol enums

2011-06-22 Thread Marc-André Lureau
Commit 9d5ef9beeca722b2ceff7d15aaa3f07ecfbf in spice-protocol introduced a typedef manually in the generated enums.h header. This patch adds them automatically to all enums during enums.h generation. --- python_modules/ptypes.py | 16 1 files changed, 12 insertions(+), 4 de

[Spice-devel] [PATCH 0/4] sndworker: add volume messages

2011-06-22 Thread Marc-André Lureau
Hi, The following patches allow the guest to control the client stream volume, preceded by 2 small codegen patches. Marc-André Lureau (4): codegen: typedef the protocol enums python: remove c-ism trailing ; sndworker: add AudioVolume/AudioMute messages sndworker: check the caps before sen

Re: [Spice-devel] [PATCH 0/3] Misc patches

2011-06-22 Thread Marc-André Lureau
ack On Wed, Jun 22, 2011 at 11:09 AM, Christophe Fergeau wrote: > Hi, > > Here are 3 patches for spice, I don't feel too strongly about the first one > (pyparsing check), so consider this one as a RFC. The other too should go in > if there are no issues with them. The __visible__ one probably con

Re: [Spice-devel] [RfC PATCH 3/7] spice: lock spice worker calls

2011-06-22 Thread Alon Levy
On Wed, Jun 22, 2011 at 10:46:02AM +0200, Gerd Hoffmann wrote: > ... so we can call them from a thread. maybe better to rename the existing lock to something else in the same time? > > Signed-off-by: Gerd Hoffmann > --- > ui/spice-display.c | 31 +++ > ui/spice-di

Re: [Spice-devel] Streaming video performance concepts

2011-06-22 Thread Alon Levy
On Tue, Jun 21, 2011 at 11:46:59PM -0400, John A. Sullivan III wrote: > On Wed, 2011-06-22 at 01:46 +0200, Alon Levy wrote: > > On Tue, Jun 21, 2011 at 07:33:58PM -0400, John A. Sullivan III wrote: > > > Hello, all. This isn't a critical question so please do not take lots > > > of time to answer

[Spice-devel] [PATCH 3/3] don't #include config.h in generated header files

2011-06-22 Thread Christophe Fergeau
7e30572ab adds a #include to the beginning of generated files. It also does this for generated headers and enums files, which is not wanted, especially if it's an installed file. This commit only adds this include for the non-header non-enum case (hopefully, enums are only generated for use in a .

[Spice-devel] [PATCH 2/3] s/__visible__/SPICE_GNUC_VISIBLE

2011-06-22 Thread Christophe Fergeau
The C specification reserves use of identifiers starting with __ to the compiler so we shouldn't use one such symbol. --- server/red_tunnel_worker.c |4 +- server/reds.c | 86 ++-- server/reds.h |2 +- server/snd_worker.c

[Spice-devel] [PATCH 1/3] add check for pyparsing

2011-06-22 Thread Christophe Fergeau
Check both in configure.ac (after checking if we need to rebuild the marshalling files) and in the python script using pyparsing (for people modifying .proto files in tarballs) --- configure.ac | 10 ++ python_modules/spice_parser.py | 11 --- 2 files changed,

[Spice-devel] [PATCH 0/3] Misc patches

2011-06-22 Thread Christophe Fergeau
Hi, Here are 3 patches for spice, I don't feel too strongly about the first one (pyparsing check), so consider this one as a RFC. The other too should go in if there are no issues with them. The __visible__ one probably conflicts with Marc-André's volume stuff, so I'll wait until this gets in to c

[Spice-devel] [RfC xf86-video-qxl PATCH] Use async I/O commands.

2011-06-22 Thread Gerd Hoffmann
Use the non-blocking versions of the I/O commands when available. --- src/qxl.h |8 +++ src/qxl_driver.c | 61 src/qxl_surface.c |4 +- 3 files changed, 66 insertions(+), 7 deletions(-) diff --git a/src/qxl.h b/src/qxl.h

[Spice-devel] [RfC PATCH 7/7] async qxl I/O

2011-06-22 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/qxl.c | 134 -- hw/qxl.h |3 + 2 files changed, 133 insertions(+), 4 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 03c871a..60caff9 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -28,6 +28,18 @@

[Spice-devel] [RfC spice-protocol PATCH] Add async I/O commands.

2011-06-22 Thread Gerd Hoffmann
Add async versions of the I/O commands which do not block and instead raise the new QXL_INTERRUPT_IO_CMD when done. Signed-off-by: Gerd Hoffmann --- spice/qxl_dev.h |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/spice/qxl_dev.h b/spice/qxl_dev.h index e3e0696..5

[Spice-devel] [RfC PATCH 5/7] move qemu_spice_create_primary_surface call out of qxl_create_guest_primary

2011-06-22 Thread Gerd Hoffmann
--- hw/qxl.c | 44 ++-- 1 files changed, 26 insertions(+), 18 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 538f51e..247c260 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -824,9 +824,9 @@ void *qxl_phys2virt(PCIQXLDevice *qxl, QXLPHYSICAL pqxl, int group

[Spice-devel] [RfC PATCH 6/7] remove qxl_destroy_primary

2011-06-22 Thread Gerd Hoffmann
--- hw/qxl.c | 28 1 files changed, 12 insertions(+), 16 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 247c260..03c871a 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -120,7 +120,6 @@ static QXLMode qxl_modes[] = { static PCIQXLDevice *qxl0; static void qxl_send_

[Spice-devel] [RfC PATCH 1/7] spice: add worker wrapper functions.

2011-06-22 Thread Gerd Hoffmann
Add wrapper functions for all spice worker calls. Signed-off-by: Gerd Hoffmann --- hw/qxl-render.c|4 +- hw/qxl.c | 32 +- ui/spice-display.c | 94 --- ui/spice-display.h | 20 +++ 4 files changed, 12

[Spice-devel] [RfC PATCH 4/7] move qemu_spice_add_memslot call out of qxl_add_memslot

2011-06-22 Thread Gerd Hoffmann
--- hw/qxl.c | 40 1 files changed, 24 insertions(+), 16 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 39a4542..538f51e 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -704,7 +704,8 @@ static void qxl_vga_ioport_write(void *opaque, uint32_t addr, uint32_t

[Spice-devel] [RfC PATCH 2/7] spice: add qemu_spice_display_init_common

2011-06-22 Thread Gerd Hoffmann
Factor out SimpleSpiceDisplay initialization into qemu_spice_display_init_common() and call it from both qxl.c (for vga mode) and spice-display.c Signed-off-by: Gerd Hoffmann --- hw/qxl.c |7 +-- ui/spice-display.c | 17 +++-- ui/spice-display.h |1 + 3 files

[Spice-devel] [RfC PATCH 3/7] spice: lock spice worker calls

2011-06-22 Thread Gerd Hoffmann
... so we can call them from a thread. Signed-off-by: Gerd Hoffmann --- ui/spice-display.c | 31 +++ ui/spice-display.h |1 + 2 files changed, 32 insertions(+), 0 deletions(-) diff --git a/ui/spice-display.c b/ui/spice-display.c index b524b82..bb1e4a7 100644 --

[Spice-devel] [RfC PATCH 0/7] spice: add async i/o commands.

2011-06-22 Thread Gerd Hoffmann
Hi, This patch series introduces non-blocking versions of the qxl io port commands to avoid blocking qemu and the guest vcpu. Needs guest driver updates. Patches for spice-protocol and xf86-video-qxl follow. cheers, Gerd Gerd Hoffmann (7): spice: add worker wrapper functions. spice: ad