Re: CVS commit: src/external/bsd/mdocml/dist

2013-03-22 Thread Christos Zoulas
In article <20130322152757.gu25...@nef.pbox.org>, Alistair Crooks wrote: > >I usually find that a > >#ifndef __arraycount >#define__arraycount(__x) (sizeof(__x) / sizeof(__x[0])) >#endif > >before the function, and then just use __arraycount(r->nr), is a bit >more readable. I will

Re: CVS commit: src/lib

2013-03-22 Thread Emmanuel Dreyfus
On Sat, Mar 23, 2013 at 12:56:01AM +0900, Joerg Sonnenberger wrote: > > I was lucky, it worked reliabily on netbsd-5. It failed reliabily on > > netbsd-6. I call that a regression. The patch makes it working > > reliabily again, even for the unlucky. > > Repeating it doesn't make it any more tru

Re: CVS commit: src/lib

2013-03-22 Thread Joerg Sonnenberger
On Fri, Mar 22, 2013 at 03:30:19PM +, Emmanuel Dreyfus wrote: > On Fri, Mar 22, 2013 at 11:24:35AM -0400, Thor Lancelot Simon wrote: > > And furthermore, there was no regression. One example was provided of > > an application (actually a PAM module) that now threw an error rather > > than happ

Re: CVS commit: src/lib

2013-03-22 Thread Emmanuel Dreyfus
On Fri, Mar 22, 2013 at 11:24:35AM -0400, Thor Lancelot Simon wrote: > And furthermore, there was no regression. One example was provided of > an application (actually a PAM module) that now threw an error rather > than happening to get lucky and silently working rather than failing. I was lucky,

Re: CVS commit: src/external/bsd/mdocml/dist

2013-03-22 Thread Alistair Crooks
On Fri, Mar 22, 2013 at 08:31:25AM -0400, Christos Zoulas wrote: > Module Name: src > Committed By: christos > Date: Fri Mar 22 12:31:25 UTC 2013 > > Modified Files: > src/external/bsd/mdocml/dist: roff.c > > Log Message: > avoid arraycount for toolz > > > To generate a diff of t

Re: CVS commit: src/lib

2013-03-22 Thread Thor Lancelot Simon
On Sat, Mar 23, 2013 at 12:12:49AM +0900, Joerg Sonnenberger wrote: > On Fri, Mar 22, 2013 at 01:08:18PM +, Christos Zoulas wrote: > > In article <20130322030831.ga10...@britannica.bec.de>, > > Joerg Sonnenberger wrote: > > > > > >This is wrong and unnecessary as pointed out on the mailing li

Re: CVS commit: src/lib

2013-03-22 Thread Joerg Sonnenberger
On Fri, Mar 22, 2013 at 01:08:18PM +, Christos Zoulas wrote: > In article <20130322030831.ga10...@britannica.bec.de>, > Joerg Sonnenberger wrote: > > > >This is wrong and unnecessary as pointed out on the mailing lists. Why > >are technical objections silently ignored now? Especially if they

Re: CVS commit: src/lib

2013-03-22 Thread Christos Zoulas
In article <20130322030831.ga10...@britannica.bec.de>, Joerg Sonnenberger wrote: > >This is wrong and unnecessary as pointed out on the mailing lists. Why >are technical objections silently ignored now? Especially if they add >overhead without any gain and make the error case more mysterious. Te

Re: CVS commit: src/lib

2013-03-22 Thread Emmanuel Dreyfus
On Fri, Mar 22, 2013 at 08:42:35AM +, David Laight wrote: > Does it even work? ATF tests show it does. -- Emmanuel Dreyfus m...@netbsd.org

Re: CVS commit: src/lib

2013-03-22 Thread David Laight
On Fri, Mar 22, 2013 at 12:08:31PM +0900, Joerg Sonnenberger wrote: > On Thu, Mar 21, 2013 at 12:49:12PM -0400, Christos Zoulas wrote: > > Module Name:src > > Committed By: christos > > Date: Thu Mar 21 16:49:12 UTC 2013 > > > > Modified Files: > > src/lib/libc/incl