On Wed, 7 Dec 2022 11:16:03 GMT, Albert Mingkun Yang wrote:
> Small change of merging two classes to reduce inheritance chain length.
>
> Test: hotspot_gc
Marked as reviewed by tschatzl (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/11556
On Thu, 22 Dec 2022 02:04:30 GMT, Kim Barrett wrote:
> Please review this change to WhiteBox and some tests involving G1 concurrent
> GCs.
>
> Some tests currently use WhiteBox.g1StartConcMarkCycle() to trigger a
> concurrent GC. Many of them follow it with a loop waiting for a concurrent
> cy
On Tue, 10 Jan 2023 10:51:14 GMT, Albert Mingkun Yang wrote:
> Simple change of using the actual type for a field.
>
> Test: hotspot_gc
Marked as reviewed by tschatzl (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/11925
On Sat, 28 Jan 2023 18:32:31 GMT, Afshin Zafari wrote:
> ### Description
> Hashtable class to be replaced with ResourceHashtable class in all source
> code.
>
> ### Patch
> The only instance was `#include "hashtable.hpp"` in `jvmtiTagMapTable.cpp`
> and removed.
> The corresponding files (`ha
On Fri, 3 Mar 2023 12:30:38 GMT, Albert Mingkun Yang wrote:
>> Simple refactoring of merging two types.
>>
>> Test: tier1-5
>
> Albert Mingkun Yang has updated the pull request incrementally with one
> additional commit since the last revision:
>
> copyright-year
Marked as reviewed by tscha
Hi all,
please review this refactoring that replaces various casts in GC more-or-less
related to get all bits set in an uint/size_t with the available constants from
cstdint.
The ones in ZGC files were skipped on request.
Testing: local compilation, gha
Thanks,
Thomas
-
Commi
On Fri, 10 Mar 2023 14:20:54 GMT, Albert Mingkun Yang wrote:
>> Hi all,
>>
>> please review this refactoring that replaces various casts in GC and
>> more-or-less related to get all bits set in an uint/size_t with the
>> available constants from cstdint.
>> The ones in ZGC files were skipped
On Fri, 10 Mar 2023 12:58:42 GMT, Thomas Schatzl wrote:
> Hi all,
>
> please review this refactoring that replaces various casts in GC and
> more-or-less related to get all bits set in an uint/size_t with the available
> constants from cstdint.
> The ones in ZGC fil
On Tue, 18 Apr 2023 20:16:06 GMT, Ioi Lam wrote:
>> This PR combines the "open" and "closed" regions of the CDS archive heap
>> into a single region. This significantly simplifies the implementation,
>> making it more compatible with non-G1 collectors. There's a net removal of
>> ~1000 lines i
Hi all,
please review this change that removes the pinned tag from `HeapRegion`.
So that "pinned" tag for G1 heap regions indicates that the region should not
move during (young) gc. This applies to now removed archive regions and
humongous objects/regions.
With "real" g1 region pinning to d
On Tue, 25 Apr 2023 15:05:10 GMT, Albert Mingkun Yang wrote:
>> Hi all,
>>
>> please review this change that removes the pinned tag from `HeapRegion`.
>>
>> So that "pinned" tag for G1 heap regions indicates that the region should
>> not move during (young) gc. This applies to now removed ar
On Tue, 25 Apr 2023 15:29:08 GMT, Thomas Schatzl wrote:
>> src/hotspot/share/gc/g1/g1HeapVerifier.cpp line 414:
>>
>>> 412: // There are no other valid region types. Check for one invalid
>>> 413: // one we can identify before crashing: non-mov
>
> The suggestion this change implements is to remove the "pinned" tag as it is,
> and reserve it for future g1 region pinning (that needs to store the pinning
> attribute differently as a refcount anyway).
>
> Testing: tier1-3, gha
>
> Thanks,
> Thomas
Th
> Hi all,
>
> please review this change that removes some remaining CMS related stuff.
>
> Testing: tier1-3, gha
>
> Thanks,
> Thomas
Thomas Schatzl has updated the pull request incrementally with one additional
commit since the last revision:
cplummer review
>
> The suggestion this change implements is to remove the "pinned" tag as it is,
> and reserve it for future g1 region pinning (that needs to store the pinning
> attribute differently as a refcount anyway).
>
> Testing: tier1-3, gha
>
> Than
On Tue, 25 Apr 2023 18:31:19 GMT, Chris Plummer wrote:
>> Thomas Schatzl has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> cplummer review
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/H
On Mon, 24 Apr 2023 09:25:01 GMT, Kim Barrett wrote:
>> Please review this change to the string deduplication thread to make it a
>> kind
>> of JavaThread rather than a ConcurrentGCThread. There are several pieces to
>> this change:
>>
>> (1) New class StringDedupThread (derived from JavaThrea
On Tue, 25 Apr 2023 16:43:27 GMT, Aleksey Shipilev wrote:
>> Thomas Schatzl has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> cplummer review
>
> Looks fine to me.
>
> But the synopsis has a
On Tue, 25 Apr 2023 16:25:40 GMT, Thomas Schatzl wrote:
> Hi all,
>
> please review this change that removes some remaining CMS related stuff.
>
> Testing: tier1-3, gha
>
> Thanks,
> Thomas
This pull request has now been integrated.
Changeset: d94ce656
Author
>
> The suggestion this change implements is to remove the "pinned" tag as it is,
> and reserve it for future g1 region pinning (that needs to store the pinning
> attribute differently as a refcount anyway).
>
> Testing: tier1-3, gha
>
> Thanks,
> Thomas
On Thu, 27 Apr 2023 10:38:17 GMT, Albert Mingkun Yang wrote:
> > I think you are right about using is_humongous() directly here: the reason
> > we skip compacting of humongous regions during the "main" compaction is
> > intentional here
>
> However, I am unable to discern the difference -- why
>
> The suggestion this change implements is to remove the "pinned" tag as it is,
> and reserve it for future g1 region pinning (that needs to store the pinning
> attribute differently as a refcount anyway).
>
> Testing: tier1-3, gha
>
> Thanks,
> Thomas
Th
>
> The suggestion this change implements is to remove the "pinned" tag as it is,
> and reserve it for future g1 region pinning (that needs to store the pinning
> attribute differently as a refcount anyway).
>
> Testing: tier1-3, gha
>
> Thanks,
>
On Tue, 2 May 2023 15:53:17 GMT, Thomas Schatzl wrote:
>> Hi all,
>>
>> please review this change that removes the pinned tag from `HeapRegion`.
>>
>> So that "pinned" tag for G1 heap regions indicates that the region should
>> not move during (
On Wed, 26 Apr 2023 17:28:49 GMT, Chris Plummer wrote:
>> Thomas Schatzl has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> cplummer review
>
> SA changes look good.
Thanks @plummercj @sspitsyn
On Tue, 25 Apr 2023 13:49:05 GMT, Thomas Schatzl wrote:
> Hi all,
>
> please review this change that removes the pinned tag from `HeapRegion`.
>
> So that "pinned" tag for G1 heap regions indicates that the region should not
> move during (young) gc. This ap
On Thu, 4 May 2023 09:33:49 GMT, Stefan Karlsson wrote:
> When running jstat tests like the following:
> test/jdk/sun/tools/jstatd/TestJstatdServer.java
>
> with Generational ZGC we get a failure because the O (old generation
> percentage) is reported as `-` and not a number. The reason why it
On Fri, 30 Jun 2023 08:11:47 GMT, Matthias Baesken wrote:
> Most G1 tests set -XX:+UseG1GC, but a few (e.g.
> gc/g1/TestVerificationInConcurrentCycle.java) miss that.
> This is usually just fine and no problem because G1 is the default anyway.
> However in some cases, where a custom JVM changes
On Fri, 8 Jul 2022 19:39:24 GMT, Daniel D. Daugherty wrote:
> A trivial fix to ProblemList
> serviceability/jvmti/GetLocalVariable/GetLocalWithoutSuspendTest.java
> on windows-x64 in -Xcomp mode.
Marked as reviewed by tschatzl (Reviewer).
-
PR: https://git.openjdk.org/jdk19/pull/1
Hi all,
can I have reviews for this change that moves `HeapRegion::_compaction_top`
into the `G1FullCollector` class; my reasoning is that these values are
transient temporary values only ever useful for the full collection algorithm,
basically results of the application of the algorithm, tha
application of the algorithm, that are
> otherwise unused. This makes `HeapRegion` a bit easier to understand/read.
>
> Testing: tier1-3
>
> Thanks,
> Thomas
Thomas Schatzl has updated the pull request incrementally with one additional
commit since the last revision:
kba
On Mon, 11 Jul 2022 14:58:07 GMT, Axel Boldt-Christmas wrote:
> Currently the `RegisterMap` constructor uses implicit boolean arguments to
> configure its function. Implicit boolean arguments makes code harder to
> understand and reason about at the call site. Using explicit scoped enums
> ins
On Wed, 27 Jul 2022 09:45:25 GMT, Axel Boldt-Christmas wrote:
>> Currently the `RegisterMap` constructor uses implicit boolean arguments to
>> configure its function. Implicit boolean arguments makes code harder to
>> understand and reason about at the call site. Using explicit scoped enums
>>
On Thu, 21 Jul 2022 11:14:01 GMT, Kim Barrett wrote:
>> Thomas Schatzl has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> kbarrett review
>
> Marked as reviewed by kbarrett (Reviewer).
Thanks @kimbarr
On Tue, 19 Jul 2022 15:47:01 GMT, Thomas Schatzl wrote:
> Hi all,
>
> can I have reviews for this change that moves `HeapRegion::_compaction_top`
> into the `G1FullCollector` class; my reasoning is that these values are
> transient temporary values only ever useful for the
On Sat, 22 Oct 2022 01:38:44 GMT, Kim Barrett wrote:
> Please review this change to GrowableArray to support capacity management.
> Two functions are added to GrowableArray, reserve and shrink_to_fit. Also
> renamed the max_length function to capacity.
>
> Used these new functions in StringDedu
The JEP covers the idea very well, so I'm only covering some implementation
details here:
* regions get a "pin count" (reference count). As long as it is non-zero, we
conservatively never reclaim that region even if there is no reference in
there. JNI code might have references to it.
* the JN
On Tue, 24 Oct 2023 09:56:57 GMT, Thomas Schatzl wrote:
> The JEP covers the idea very well, so I'm only covering some implementation
> details here:
>
> * regions get a "pin count" (reference count). As long as it is non-zero, we
> conservatively never reclaim t
On Fri, 27 Oct 2023 20:18:24 GMT, Albert Mingkun Yang wrote:
>> The JEP covers the idea very well, so I'm only covering some implementation
>> details here:
>>
>> * regions get a "pin count" (reference count). As long as it is non-zero, we
>> conservatively never reclaim that region even if th
On Fri, 27 Oct 2023 20:38:19 GMT, Albert Mingkun Yang wrote:
>> The JEP covers the idea very well, so I'm only covering some implementation
>> details here:
>>
>> * regions get a "pin count" (reference count). As long as it is non-zero, we
>> conservatively never reclaim that region even if th
On Fri, 27 Oct 2023 20:53:29 GMT, Albert Mingkun Yang wrote:
>> The JEP covers the idea very well, so I'm only covering some implementation
>> details here:
>>
>> * regions get a "pin count" (reference count). As long as it is non-zero, we
>> conservatively never reclaim that region even if th
marking happens.
>
> I.e. pinned marking candidates are immediately moved to retained
> candidates, and if in total the region has been pinned for
> `G1NumCollectionsKeepUnreclaimable` collections it is dropped from the
> candidates. Its current value is fairly random.
>
> * G1 pauses got a new tag if t
On Sat, 28 Oct 2023 18:32:56 GMT, Albert Mingkun Yang wrote:
>> Thomas Schatzl has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> ayang review1
>
> src/hotspot/share/gc/g1/heapRegion.cpp line 734:
>
&
marking happens.
>
> I.e. pinned marking candidates are immediately moved to retained
> candidates, and if in total the region has been pinned for
> `G1NumCollectionsKeepUnreclaimable` collections it is dropped from the
> candidates. Its current value is fairly random.
>
> * G1 pauses got a new tag if t
On Mon, 30 Oct 2023 13:41:02 GMT, Thomas Schatzl wrote:
>> src/hotspot/share/gc/g1/heapRegion.cpp line 734:
>>
>>> 732: // ranges passed in here corresponding to the space between live
>>> objects, it is
>>> 733: // possible that there
On Mon, 30 Oct 2023 13:46:21 GMT, Albert Mingkun Yang wrote:
>> Apart from having an early return in the `should_compact`-if, one option
>> would be making `has_pinned_objects()` more clever by stating something like:
>>
>>
>> bool has_pinned_objects() const {
>> return pinned_count() >
On Mon, 30 Oct 2023 13:43:33 GMT, Albert Mingkun Yang wrote:
>> Maybe rename `should_retain_evac_failed_region` to
>> `should_keep_retained_region[_in_old]` or something?
>
> Is it possible to drop 1 so that an obj is evac-fail iff it's pinned or OOM?
> (I feel "retain" is on region-level.)
Th
marking happens.
>
> I.e. pinned marking candidates are immediately moved to retained
> candidates, and if in total the region has been pinned for
> `G1NumCollectionsKeepUnreclaimable` collections it is dropped from the
> candidates. Its current value is fairly random.
>
> * G1 pauses got a new tag if t
On Tue, 31 Oct 2023 18:08:00 GMT, Thomas Schatzl wrote:
>> The JEP covers the idea very well, so I'm only covering some implementation
>> details here:
>>
>> * regions get a "pin count" (reference count). As long as it is non-zero, we
>> conservat
marking happens.
>
> I.e. pinned marking candidates are immediately moved to retained
> candidates, and if in total the region has been pinned for
> `G1NumCollectionsKeepUnreclaimable` collections it is dropped from the
> candidates. Its current value is fairly random.
>
> * G1 pauses got a new tag if t
marking happens.
>
> I.e. pinned marking candidates are immediately moved to retained
> candidates, and if in total the region has been pinned for
> `G1NumCollectionsKeepUnreclaimable` collections it is dropped from the
> candidates. Its current value is fairly random.
>
> * G1 pauses got a new tag if t
marking happens.
>
> I.e. pinned marking candidates are immediately moved to retained
> candidates, and if in total the region has been pinned for
> `G1NumCollectionsKeepUnreclaimable` collections it is dropped from the
> candidates. Its current value is fairly random.
>
> * G1 pauses got a new tag if t
On Tue, 31 Oct 2023 18:54:26 GMT, Thomas Schatzl wrote:
> Had a discussion with @albertnetymk and we came to the following agreement
> about naming:
>
>"allocation failure" - allocation failed in the to-space due to memory
>exhaustion
>"pinned" - the regi
marking happens.
>
> I.e. pinned marking candidates are immediately moved to retained
> candidates, and if in total the region has been pinned for
> `G1NumCollectionsKeepUnreclaimable` collections it is dropped from the
> candidates. Its current value is fairly random.
>
> * G1 pauses got a new tag if t
On Mon, 30 Oct 2023 17:12:19 GMT, Thomas Schatzl wrote:
>> I do not think so. I will do some more testing about this.
>
> I (still) do not think it is possible after some more re-testing. There are
> the following situations I can think of:
>
> * string deduplication is a
On Fri, 3 Nov 2023 09:56:43 GMT, Albert Mingkun Yang wrote:
>> Thomas Schatzl has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add documentation about why and how we handle pinned regions in the
>> young/o
marking happens.
>
> I.e. pinned marking candidates are immediately moved to retained
> candidates, and if in total the region has been pinned for
> `G1NumCollectionsKeepUnreclaimable` collections it is dropped from the
> candidates. Its current value is fairly random.
>
> * G1 pauses got a new tag if t
On Thu, 2 Nov 2023 15:51:35 GMT, Thomas Schatzl wrote:
>> The JEP covers the idea very well, so I'm only covering some implementation
>> details here:
>>
>> * regions get a "pin count" (reference count). As long as it is non-zero, we
>> conservat
marking happens.
>
> I.e. pinned marking candidates are immediately moved to retained
> candidates, and if in total the region has been pinned for
> `G1NumCollectionsKeepUnreclaimable` collections it is dropped from the
> candidates. Its current value is fairly random.
>
> * G1 pauses got a new tag if t
On Fri, 3 Nov 2023 12:41:05 GMT, Albert Mingkun Yang wrote:
>> Thomas Schatzl has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> ayang review - renamings + documentation
>
> src/hotspot/share/gc/g1/g1_g
On Fri, 3 Nov 2023 12:44:10 GMT, Albert Mingkun Yang wrote:
>> Thomas Schatzl has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> ayang review - renamings + documentation
>
> src/hotspot/share/gc/g1/g1YoungC
marking happens.
>
> I.e. pinned marking candidates are immediately moved to retained
> candidates, and if in total the region has been pinned for
> `G1NumCollectionsKeepUnreclaimable` collections it is dropped from the
> candidates. Its current value is fairly random.
>
> * G1 pauses got a new tag if t
marking happens.
>
> I.e. pinned marking candidates are immediately moved to retained
> candidates, and if in total the region has been pinned for
> `G1NumCollectionsKeepUnreclaimable` collections it is dropped from the
> candidates. Its current value is fairly random.
>
> * G1 pauses got a new tag if t
marking happens.
>
> I.e. pinned marking candidates are immediately moved to retained
> candidates, and if in total the region has been pinned for
> `G1NumCollectionsKeepUnreclaimable` collections it is dropped from the
> candidates. Its current value is fairly random.
>
> * G1 pauses got a new tag if t
On Mon, 6 Nov 2023 19:46:07 GMT, Roman Kennke wrote:
> I'm curious (and puzzled), though. How would this situation normally have
> been repaired without this explicit header-resetting code? Would the
> failed-promotion slide directly into full-GC which repairs it? OTOH, I don't
> even see code
marking happens.
>
> I.e. pinned marking candidates are immediately moved to retained
> candidates, and if in total the region has been pinned for
> `G1NumCollectionsKeepUnreclaimable` collections it is dropped from the
> candidates. Its current value is fairly random.
>
> * G1 pauses got a new tag if t
marking happens.
>
> I.e. pinned marking candidates are immediately moved to retained
> candidates, and if in total the region has been pinned for
> `G1NumCollectionsKeepUnreclaimable` collections it is dropped from the
> candidates. Its current value is fairly random.
>
> * G1 pauses got a new tag if t
On Tue, 7 Nov 2023 18:12:45 GMT, Roman Kennke wrote:
>> See JBS issue for details.
>>
>> Testing:
>> - [x] gc/logging/TestUnifiedLoggingSwitchStress.java -XX:+UseParallelGC
>> - [x] tier1 -XX:+UseParallelGC
>> - [x] tier2 -XX:+UseParallelGC
>> - [x] hotspot_gc
>
> Roman Kennke has updated th
marking happens.
>
> I.e. pinned marking candidates are immediately moved to retained
> candidates, and if in total the region has been pinned for
> `G1NumCollectionsKeepUnreclaimable` collections it is dropped from the
> candidates. Its current value is fairly random.
>
> * G1 pauses got a new tag if t
On Wed, 8 Nov 2023 14:46:16 GMT, Stefan Johansson wrote:
>> The example looks good to me.
>
> Have the final output looking something like this was agreed on during
> internal discussion:
> GC(6) Pause Young (Normal) (Evacuation Failure: Pinned) 1M->1M(22M) 36.16ms
> GC(6) Pause Young (Normal) (
On Thu, 9 Nov 2023 13:26:06 GMT, Stefan Johansson wrote:
>> Thomas Schatzl has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Modify evacuation failure log message as suggested by sjohanss: Use
>> &qu
marking happens.
>
> I.e. pinned marking candidates are immediately moved to retained
> candidates, and if in total the region has been pinned for
> `G1NumCollectionsKeepUnreclaimable` collections it is dropped from the
> candidates. Its current value is fairly random.
>
> * G1 pauses got a new tag if t
On Wed, 8 Nov 2023 10:51:19 GMT, Albert Mingkun Yang wrote:
> Simple cleanup of removing an unnecessary indirection. The real change is
> only 11 LOC, using the global variables directly for young/old gen.
Marked as reviewed by tschatzl (Reviewer).
-
PR Review: https://git.openjdk
On Fri, 3 Nov 2023 14:14:50 GMT, Albert Mingkun Yang wrote:
>> Thomas Schatzl has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> typos
>
> Marked as reviewed by ayang (Reviewer).
Thanks @albertnetymk @kstef
On Tue, 24 Oct 2023 09:56:57 GMT, Thomas Schatzl wrote:
> The JEP covers the idea very well, so I'm only covering some implementation
> details here:
>
> * regions get a "pin count" (reference count). As long as it is non-zero, we
> conservatively never reclaim t
On Sat, 3 Feb 2024 04:28:24 GMT, Chris Plummer wrote:
>> This PR adds G1 support to PointerFinder/PointerLocation. Previously we only
>> had SerialGC support. Previously for G1 addresses SA would only report that
>> the address is "In unknown section of Java heap" with no other details. Now
>>
On Fri, 9 Feb 2024 05:31:17 GMT, Yifeng Jin wrote:
>> These two files (`GCCause.java` and `gcCause.hpp`) should be in sync by
>> design, see comments in these two files. However, some recent changes (e.g.
>> [JDK-8240239](https://bugs.openjdk.org/browse/JDK-8240239)) to `gcCause.hpp`
>> were n
On Wed, 14 Feb 2024 20:17:21 GMT, Albert Mingkun Yang wrote:
>> Relocate `Generation.java` to mirror the structure in hotspot. Also,
>> specialize the logic to two concrete generations.
>>
>> Test: tier1-3
>
> Albert Mingkun Yang has updated the pull request incrementally with three
> addition
On Sat, 20 Apr 2024 08:44:45 GMT, Lei Zaakjyu wrote:
>> follow up 8267941
>
> Lei Zaakjyu has updated the pull request incrementally with one additional
> commit since the last revision:
>
> also tidy up
Indentation issues. I will run the higher tier SA tests just for verification.
There ar
On Mon, 22 Apr 2024 16:24:06 GMT, Guoxiong Li wrote:
> Hi all,
>
> This patch removes the class `TenuredSpace` and adjusts its usages. After
> removing `TenuredSpace`, the file `space.inline.hpp` is empty, so I remove
> this file and change the included header file to `space.hpp`.
>
> The tes
On Sat, 27 Apr 2024 02:34:21 GMT, Lei Zaakjyu wrote:
>> follow up 8267941
>
> Lei Zaakjyu has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix indentation
mach5 higher tier SA tests are fine.
What are your plans for the remaining SA renames
On Mon, 29 Apr 2024 22:54:18 GMT, Kim Barrett wrote:
> > mach5 higher tier SA tests are fine. What are your plans for the remaining
> > SA renames (would highly recommend to add) and the G1HeapRegion related
> > helper classes?
>
> I suggest the related helper classes be done in further follow
On Fri, 3 May 2024 06:21:54 GMT, Lei Zaakjyu wrote:
>> And here also it seems you agreed with this suggestion but the change was
>> never made.
>
> I think we can make these changes in later PRs in order to avoid making this
> one even larger.
As mentioned earlier, I also think the SA changes
On Thu, 2 May 2024 14:40:35 GMT, Aleksey Shipilev wrote:
> `CollectedHeap::is_gc_active()` is confusing, since its name implies _any_ GC
> phase is running, while it actually only covers the STW GCs. It would be good
> to rename it for clarity. The freed-up name, `is_gc_active` could then be
>
On Sun, 12 May 2024 06:01:27 GMT, Lei Zaakjyu wrote:
>> follow up 8267941
>
> Lei Zaakjyu has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix
I'm good with leaving the `heapRegionIterator()` method name as is, but please
make sure that @p
On Fri, 24 May 2024 13:04:14 GMT, Lei Zaakjyu wrote:
>> follow up 8267941
>
> Lei Zaakjyu has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 10 commits:
>
> - review
> - Merge branch 'master' of https://git.openjdk.org/jdk into JDK-
Hi all,
after [JDK-8330694](https://bugs.openjdk.org/browse/JDK-8330694) which
renamed HeapRegion to G1HeapRegion, there were a few related helper classes in
this CR that were not renamed.
It's purely mechanical renaming without even further renaming of files etc.
This change updates them.
On Tue, 2 Jul 2024 10:21:35 GMT, Albert Mingkun Yang wrote:
>> Hi all,
>>
>> after [JDK-8330694](https://bugs.openjdk.org/browse/JDK-8330694) which
>> renamed HeapRegion to G1HeapRegion, there were a few related helper classes
>> in this CR that were not renamed.
>>
>> It's purely mechanic
On Mon, 1 Jul 2024 09:35:00 GMT, Thomas Schatzl wrote:
> Hi all,
>
> after [JDK-8330694](https://bugs.openjdk.org/browse/JDK-8330694) which
> renamed HeapRegion to G1HeapRegion, there were a few related helper classes
> in this CR that were not renamed.
>
> It's
On Tue, 23 Jul 2024 14:11:20 GMT, Albert Mingkun Yang wrote:
> Simple obsoleting a Parallel GC product flag.
The flag needs to be added to the obsolete flags table too, not only removed.
-
PR Comment: https://git.openjdk.org/jdk/pull/20299#issuecomment-2247230042
On Wed, 24 Jul 2024 09:11:13 GMT, Albert Mingkun Yang wrote:
>> Simple obsoleting a Parallel GC product flag.
>
> Albert Mingkun Yang has updated the pull request incrementally with one
> additional commit since the last revision:
>
> review
Marked as reviewed by tschatzl (Reviewer).
--
On Thu, 25 Jul 2024 07:44:45 GMT, Albert Mingkun Yang wrote:
>> Simple obsoleting a Parallel GC product flag.
>
> Albert Mingkun Yang has updated the pull request incrementally with one
> additional commit since the last revision:
>
> copyright
Marked as reviewed by tschatzl (Reviewer).
---
On Wed, 31 Jul 2024 11:25:50 GMT, Albert Mingkun Yang wrote:
> Trivial removing an unused gc-cause; it was previously used by Parallel only.
Good.
-
Marked as reviewed by tschatzl (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/20403#pullrequestreview-2210168192
On Mon, 9 Sep 2024 10:29:55 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> previ
On Thu, 22 Aug 2024 20:08:43 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Mon, 9 Sep 2024 11:55:52 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> previ
On Mon, 9 Sep 2024 11:55:52 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> previ
On Mon, 9 Sep 2024 15:00:09 GMT, Stefan Karlsson wrote:
> could be any value that is not a valid field offset
I understand that that "random value" needs to satisfy this condition.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/20677#discussion_r1750433800
On Fri, 13 Sep 2024 09:00:32 GMT, Stefan Karlsson wrote:
>> src/hotspot/share/oops/oop.cpp line 230:
>>
>>> 228: // disjunct below to fail if the two comparands are computed across
>>> such
>>> 229: // a concurrent change.
>>> 230: return Universe::heap()->is_stw_gc_active() &&
>>> klass
On Fri, 13 Sep 2024 12:48:53 GMT, Stefan Karlsson wrote:
>> If you've already fixed this for GC then I agree that we could remove this.
>
> This seems like something that should be done as a separate patch that gets
> pushed before this PR.
Will remove in JDK-8340119.
-
PR Review
1 - 100 of 108 matches
Mail list logo
