On Tue, 25 Apr 2023 18:31:19 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> Thomas Schatzl has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> cplummer review
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/HSDB.java line 1109:
>
>> 1107: } else if (region.isPinned()) {
>> 1108: anno = "Pinned ";
>> 1109: bad = false;
>
> Does this mean that the region will now always be one of Free, Young,
> Humongous, or Old?
As the description says, the "pinned" attribute is going away temporarily as it
is not really required/used at this time. So only the base region types you
specified will remain.
The attribute will be re-introduced in a bit during completion of
[JDK-8276094](https://bugs.openjdk.org/browse/JDK-8276094) with a slightly
different meaning.
Btw, the code has been wrong in that the "pinned" attribute is a modifier of
the base types (Free, Young, ...), not a separate category.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13643#discussion_r1177560794
