On Fri, 3 Nov 2023 12:41:05 GMT, Albert Mingkun Yang <ay...@openjdk.org> wrote:
>> Thomas Schatzl has updated the pull request incrementally with one >> additional commit since the last revision: >> >> ayang review - renamings + documentation > > src/hotspot/share/gc/g1/g1_globals.hpp line 327: > >> 325: range(1, 256) >> \ >> 326: >> \ >> 327: product(uint, G1NumCollectionsKeepPinned, 8, DIAGNOSTIC, >> \ > > Any particular reason this is not `EXPERIMENTAL`? Changing this does not in any way enable risky/experimental code not fit for production. This knob is for helping diagnose performance issues. G1 does have its fair share of experimental options, but all/most of these were from the initial import where G1 as a whole had been experimental (unstable) for some time. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16342#discussion_r1381706769
