On Wed, 20 Sep 2023 00:39:44 GMT, David Holmes wrote:
>> Jonathan Joo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix build issues
>
> src/hotspot/share/gc/shared/collectedHeap.cpp line 161:
>
>> 159: }
>> 160:
>> 161: void Collect
On Thu, 5 Oct 2023 03:00:36 GMT, Jonathan Joo wrote:
>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add comment and change if defined to ifdef
Changes re
On Fri, 15 Sep 2023 01:27:04 GMT, David Holmes wrote:
>> Jonathan Joo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Clean up test and improve total counter name
>
> src/hotspot/share/runtime/perfData.hpp line 64:
>
>> 62: COM_THREAD
On Thu, 5 Oct 2023 03:00:36 GMT, Jonathan Joo wrote:
>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add comment and change if defined to ifdef
test/jdk/s
On Wed, 25 Oct 2023 20:37:46 GMT, Jonathan Joo wrote:
>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Use 64-bit atomic add for incrementing counters
The
On Thu, 26 Oct 2023 14:31:23 GMT, Volker Simonis wrote:
>> src/hotspot/share/gc/g1/g1ConcurrentMarkThread.cpp line 138:
>>
>>> 136: _vtime_accum = (os::elapsedVTime() - _vtime_start);
>>> 137:
>>> 138: cm()->update_concurrent_mark_threads_cpu_time();
>>
>> Is there some overlapping btw
On Thu, 26 Oct 2023 21:01:53 GMT, Jonathan Joo wrote:
>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove StringDedup from GC thread list
Marked as rev
On Thu, 26 Oct 2023 20:33:31 GMT, Man Cao wrote:
>> @albertnetymk, the hsperf counters are a non-public API and the new counters
>> have been added to the non-standard `sun.threads.cpu_time` name space which
>> is "[unstable and
>> unsupported](https:
On Thu, 26 Oct 2023 21:01:53 GMT, Jonathan Joo wrote:
>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove StringDedup from GC thread list
> Okay, these
On Tue, 31 Oct 2023 04:23:13 GMT, Jonathan Joo wrote:
>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Replace NULL with nullptr
LGTM still, thanks!
-
On Mon, 6 Nov 2023 12:11:47 GMT, Stefan Johansson wrote:
> I played around a bit instead of trying to explain what I mean and this is
> not very polished, but I was thinking something like this:
> https://github.com/openjdk/jdk/compare/pr/15082...kstefanj:jdk:pull/15082-idea
>
> What do you thi
On Mon, 13 Nov 2023 21:52:22 GMT, Jiangli Zhou wrote:
> Please review JvmtiThreadState::state_for_while_locked change to handle the
> state->get_thread_oop() null case. Please see
> https://bugs.openjdk.org/browse/JDK-8319935 for details.
Changes requested by manc (Committer).
src/hotspot/sha
On Wed, 15 Nov 2023 23:50:02 GMT, Jonathan Joo wrote:
>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix whitespace
Overall looks good, a few details cou
On Tue, 14 Nov 2023 21:33:37 GMT, Jonathan Joo wrote:
>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update parallel workers time after Remark
src/hotspo
On Tue, 14 Nov 2023 20:57:09 GMT, Jiangli Zhou wrote:
>> Please review JvmtiThreadState::state_for_while_locked change to handle the
>> state->get_thread_oop() null case. Please see
>> https://bugs.openjdk.org/browse/JDK-8319935 for details.
>
> Jiangli Zhou has updated the pull request increme
On Tue, 21 Nov 2023 21:42:39 GMT, Jonathan Joo wrote:
>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Update memory tracking type for CPUTimeCounters
>
On Wed, 22 Nov 2023 22:40:20 GMT, Jiangli Zhou wrote:
>> Please review JvmtiThreadState::state_for_while_locked change to handle the
>> state->get_thread_oop() null case. Please see
>> https://bugs.openjdk.org/browse/JDK-8319935 for details.
>
> Jiangli Zhou has updated the pull request increme
On Tue, 28 Nov 2023 20:38:55 GMT, Serguei Spitsyn wrote:
>> @sspitsyn For the above suggestions, it seems cleaner/safer to handle the
>> clean-ups in a separate RFE with full testing including the vthread cases.
>> There are additional comments in
>> https://github.com/openjdk/jdk/pull/16642#i
On Thu, 30 Nov 2023 21:17:14 GMT, Jonathan Joo wrote:
>> Me and Albert just spoke and we do see the problem that two concurrent
>> threads could be executing the closure at the same time. So if having a
>> total counter we need to sync the updates. But when talking we started to
>> question ho
On Thu, 30 Nov 2023 09:41:55 GMT, Stefan Johansson wrote:
>> Jonathan Joo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add missing include
>
> src/hotspot/share/runtime/cpuTimeCounters.hpp line 59:
>
>> 57: NONCOPYABLE(CPUTimeCount
On Fri, 1 Dec 2023 10:21:31 GMT, Stefan Johansson wrote:
>> Right, see @simonis 's comments at
>> https://github.com/openjdk/jdk/pull/15082#pullrequestreview-1613868256,
>> https://github.com/openjdk/jdk/pull/15082#discussion_r1321703912.
>>
>> I initially had similar thought that `gc_total` i
On Mon, 4 Dec 2023 13:07:15 GMT, Stefan Johansson wrote:
>> In the interest of the RDP1 deadline, should we leave improving the sync
>> issues with gc_total to a separate RFE? (Especially given that a "correct"
>> design may take some time to come up with, and that gc_total being slightly
>> o
On Sat, 2 Dec 2023 07:37:26 GMT, Jonathan Joo wrote:
>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Only create CPUTimeCounters if supported
> - Ensure
On Fri, 8 Mar 2024 03:35:16 GMT, Alex Menkov wrote:
>> Man Cao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix failure under -XX:+UseSerialGC
>
> Heap dumper was switched to always use segm
isk space and need to dump to a network socket.
>
> Tested:
> Stress tested with a fastdebug build with tests in
> `hotspot/jtreg/serviceability/dcmd/gc/HeapDump*`.
>
> -Man
Man Cao has updated the pull request with a new target base due to a merge or a
rebase. The pull reque
25 matches
Mail list logo
