On Wed, 20 Sep 2023 00:39:44 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Jonathan Joo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix build issues
>
> src/hotspot/share/gc/shared/collectedHeap.cpp line 161:
>
>> 159: }
>> 160:
>> 161: void CollectedHeap::inc_total_cpu_time(long diff) {
>
> We don't use `long` in shared code as it has different size on different
> platforms.
Using `long` is to avoid build failure on 32-bit ARM and x86. `jlong` is `long
long` on 32-bit, and Atomic template does not support `long long` on 32-bit.
Example failure:
https://github.com/jjoo172/jdk/actions/runs/6229455243/job/16907994694.
Is there a better way to avoid these failures on 32-bit?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15082#discussion_r1333718984
