> Greetings,
>
> This is a rewrite of the Compiler Memory Statistic. The primary new feature
> is the capability to track allocations by C2 phases. This will allow for a
> much faster, more thorough analysis of footprint issues.
>
> Tracking Arena memory movement is not trivial since one needs
On Sun, 2 Mar 2025 07:20:58 GMT, Thomas Stuefe wrote:
>> Greetings,
>>
>> This is a rewrite of the Compiler Memory Statistic. The primary new feature
>> is the capability to track allocations by C2 phases. This will allow for a
>> much faster, more thorough analysis of footprint issues.
>>
>
On Mon, 3 Mar 2025 09:17:03 GMT, Roberto Castañeda Lozano
wrote:
> Thanks for addressing my comments! The latest changeset looks good (modulo
> unnecessary changes in `ostream.hpp`) and passes all tier1-5 tests in
> Oracle's test pipeline.
Many thanks, @robcasloz ! I also merged master and wi
On Mon, 24 Feb 2025 09:59:15 GMT, Kevin Walls wrote:
>> DescriptorSupport has a constructor and a method providing creation from,
>> and export to, XML.
>>
>> These are unused in the JDK and have no practical known examples of usage.
>> XML parsing is best done by an independent implementatio
On Fri, 28 Feb 2025 01:40:34 GMT, Jiangli Zhou wrote:
> Please review the test fix that removes `libVThreadEventTest` explicit
> dependency to `libjvm`, by removing the call to `JNI_GetCreatedJavaVMs` in
> `Agent_OnAttach`. There is a `vm` argument passed via `Agent_OnAttach`. With
> the chang
On Mon, 3 Mar 2025 12:27:28 GMT, Kevin Walls wrote:
>> DescriptorSupport has a constructor and a method providing creation from,
>> and export to, XML.
>>
>> These are unused in the JDK and have no practical known examples of usage.
>> XML parsing is best done by an independent implementation
> DescriptorSupport has a constructor and a method providing creation from, and
> export to, XML.
>
> These are unused in the JDK and have no practical known examples of usage.
> XML parsing is best done by an independent implementation, not this class.
Kevin Walls has updated the pull request
On Fri, 28 Feb 2025 18:10:26 GMT, Coleen Phillimore wrote:
>> This change removes the ci, c1 and c2 compiler code from the serviceability
>> agent. The ciReplay functionality is supported inside the jvm and this
>> duplicated functionality in SA had bit rotted so is removed.
>> Tested with tie
On Mon, 3 Mar 2025 09:56:36 GMT, Daniel Fuchs wrote:
>> Kevin Walls has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 10 additional
>> commits sin
On Tue, 25 Feb 2025 16:52:09 GMT, Coleen Phillimore wrote:
> This change removes the ci, c1 and c2 compiler code from the serviceability
> agent. The ciReplay functionality is supported inside the jvm and this
> duplicated functionality in SA had bit rotted so is removed.
> Tested with tier1-4
On Fri, 28 Feb 2025 18:10:26 GMT, Coleen Phillimore wrote:
>> This change removes the ci, c1 and c2 compiler code from the serviceability
>> agent. The ciReplay functionality is supported inside the jvm and this
>> duplicated functionality in SA had bit rotted so is removed.
>> Tested with tie
On Mon, 3 Mar 2025 12:27:28 GMT, Kevin Walls wrote:
>> DescriptorSupport has a constructor and a method providing creation from,
>> and export to, XML.
>>
>> These are unused in the JDK and have no practical known examples of usage.
>> XML parsing is best done by an independent implementation
On Mon, 3 Mar 2025 10:41:16 GMT, Thomas Stuefe wrote:
>> Greetings,
>>
>> This is a rewrite of the Compiler Memory Statistic. The primary new feature
>> is the capability to track allocations by C2 phases. This will allow for a
>> much faster, more thorough analysis of footprint issues.
>>
>
On Sat, 8 Feb 2025 06:56:40 GMT, Thomas Stuefe wrote:
> Greetings,
>
> This is a rewrite of the Compiler Memory Statistic. The primary new feature
> is the capability to track allocations by C2 phases. This will allow for a
> much faster, more thorough analysis of footprint issues.
>
> Track
On Fri, 28 Feb 2025 01:40:34 GMT, Jiangli Zhou wrote:
> Please review the test fix that removes `libVThreadEventTest` explicit
> dependency to `libjvm`, by removing the call to `JNI_GetCreatedJavaVMs` in
> `Agent_OnAttach`. There is a `vm` argument passed via `Agent_OnAttach`. With
> the chang
On Mon, 3 Mar 2025 12:27:28 GMT, Kevin Walls wrote:
>> DescriptorSupport has a constructor and a method providing creation from,
>> and export to, XML.
>>
>> These are unused in the JDK and have no practical known examples of usage.
>> XML parsing is best done by an independent implementation
On Mon, 3 Mar 2025 17:08:21 GMT, Kevin Walls wrote:
> (the last sentence quoted there seems to contradict the first)
I think it is a typo and meant to say `_snprintf` not `snprintf`. I added
feedback to the MS page.
-
PR Comment: https://git.openjdk.org/jdk/pull/23861#issuecomment
On Mon, 3 Mar 2025 12:22:01 GMT, Kevin Walls wrote:
> Following on from JDK-8350820, which backed out the _snprintf to snprintf
> change (JDK-8336289) in OperatingSystemImpl.c on Windows, because the counter
> names were being truncated (so CPU monitoring was not possible).
>
> This change mov
On Wed, 26 Feb 2025 12:23:16 GMT, Kim Barrett wrote:
> Please review this trivial change to remove a use of literal zero as a null
> pointer constant in an nsk test utility.
>
> Testing: mach5 tier1
> Locally tested (linux-x64) with -Wzero-as-null-pointer-constant enabled to
> verify the warning
On Wed, 26 Feb 2025 12:23:16 GMT, Kim Barrett wrote:
> Please review this trivial change to remove a use of literal zero as a null
> pointer constant in an nsk test utility.
>
> Testing: mach5 tier1
> Locally tested (linux-x64) with -Wzero-as-null-pointer-constant enabled to
> verify the warning
On Tue, 4 Mar 2025 04:20:20 GMT, David Holmes wrote:
>> Please review this trivial change to remove a use of literal zero as a null
>> pointer constant in an nsk test utility.
>>
>> Testing: mach5 tier1
>> Locally tested (linux-x64) with -Wzero-as-null-pointer-constant enabled to
>> verify the w
Following on from JDK-8350820, which backed out the _snprintf to snprintf
change (JDK-8336289) in OperatingSystemImpl.c on Windows, because the counter
names were being truncated (so CPU monitoring was not possible).
This change moves to snprintf again, but the counter names are not truncated.
On Mon, 3 Mar 2025 12:22:01 GMT, Kevin Walls wrote:
> Following on from JDK-8350820, which backed out the _snprintf to snprintf
> change (JDK-8336289) in OperatingSystemImpl.c on Windows, because the counter
> names were being truncated (so CPU monitoring was not possible).
>
> This change mov
On Fri, 28 Feb 2025 01:40:34 GMT, Jiangli Zhou wrote:
> Please review the test fix that removes `libVThreadEventTest` explicit
> dependency to `libjvm`, by removing the call to `JNI_GetCreatedJavaVMs` in
> `Agent_OnAttach`. There is a `vm` argument passed via `Agent_OnAttach`. With
> the chang
24 matches
Mail list logo
