On Fri, 28 Feb 2025 01:40:34 GMT, Jiangli Zhou <jian...@openjdk.org> wrote:
> Please review the test fix that removes `libVThreadEventTest` explicit > dependency to `libjvm`, by removing the call to `JNI_GetCreatedJavaVMs` in > `Agent_OnAttach`. There is a `vm` argument passed via `Agent_OnAttach`. With > the change, `libVThreadEventTest` no longer needs to be linked with > `libjvm.so` (or `jvm.dll`). `VThreadEventTest.java` now runs on both dynamic > and static JDK. > > Tested on static JDK locally > GHA: > https://github.com/jianglizhou/jdk/actions/runs/13577993687/job/37960245161 It was needed when the test was originally created but it has changed significantly, and the addition of Agent_OnAttach in one of the updates meant the JavaVM* is provided, no need to call JNI_GetCreatedJavaVMs anymore. ------------- Marked as reviewed by alanb (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/23835#pullrequestreview-2653333029
