On Mon, 3 Mar 2025 09:56:36 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Kevin Walls has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 10 additional >> commits since the last revision: >> >> - constructor->method in deprecated tag >> - Merge remote-tracking branch 'upstream/master' into >> 8347433_DescriptorSupport_deprecate_XML >> - comments >> - Merge remote-tracking branch 'upstream/master' into >> 8347433_DescriptorSupport_deprecate_XML >> - (c) >> - typo >> - Merge remote-tracking branch 'upstream/master' into >> 8347433_DescriptorSupport_deprecate_XML >> - Also XMLParseException >> - RMMB comment update >> - Deprecate XML interchange in DescriptorSupport > > src/java.management/share/classes/javax/management/modelmbean/DescriptorSupport.java > line 978: > >> 976: * thrown. >> 977: * @deprecated This method exists for historical reasons. If >> 978: * reading from XML is required, it should be implemented >> externally. > > Technically here it should be `writing to XML` - I don't think changing that > would require re-submitting the CSR - but maybe @jddarcy could confirm? Thanks, done. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23038#discussion_r1977450609