On Thu, 12 Sep 2024 15:44:21 GMT, Volker Simonis wrote:
>> Hi there, we are seeing this issue when we run JFR on our services under
>> load, we see a large spike of CPU after JFR is triggered, which cause 500
>> errors in our service. We are currently using corretto-17 in our service.
>>
>> Wo
On Fri, 13 Sep 2024 13:11:45 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
Can I please get a review of this test-only change which replaces the usage of
`-noclassgc` with `-Xnoclassgc` option when launching the test?
As noted in https://bugs.openjdk.org/browse/JDK-8340176, the `-noclassgc` is an
undocumented option of the `java` launcher, which it converts to `-Xnocla
On Mon, 16 Sep 2024 09:21:22 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only change which replaces the usage
> of `-noclassgc` with `-Xnoclassgc` option when launching the test?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8340176, the `-noclassgc` is
> an undocum
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> It is also a follow-up to #20640, which now also includes (and supersedes)
> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
> previously missing.
>
> Main changes:
> - Introduction of the (
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> It is also a follow-up to #20640, which now also includes (and supersedes)
> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
> previously missing.
>
> Main changes:
> - Introduction of the (
On Thu, 12 Sep 2024 13:13:01 GMT, Roman Kennke wrote:
>>> @rkennke Can you please explain the changes in these tests:
>>>
>>> ```
>>> test/hotspot/jtreg/compiler/c2/irTests/TestVectorizationMismatchedAccess.java
>>> test/hotspot/jtreg/compiler/c2/irTests/TestVectorizationNotRun.java
>>> test/hot
On Thu, 12 Sep 2024 13:56:42 GMT, Simon Tooke wrote:
>> This PR changes the status of realpath() from a Posix-specific API to a
>> globally available API, i.e. adding it to the "Hotspot Porting API". Code
>> would refer to os::realpath() instead of os::Posix::realpath().
>>
>> This requires t
On Fri, 13 Sep 2024 09:47:07 GMT, Kevin Walls wrote:
> JDP tests only make 3 attempts to find a free port, using getFreePort().
> We know getFreePort() is racy and you need to make sure the port really is
> fee when trying to use it.
>
> Make 10 attempts. Leave the logic unchanged. Also fix a
On Mon, 16 Sep 2024 09:21:22 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only change which replaces the usage
> of `-noclassgc` with `-Xnoclassgc` option when launching the test?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8340176, the `-noclassgc` is
> an undocum
On Fri, 13 Sep 2024 09:47:07 GMT, Kevin Walls wrote:
> JDP tests only make 3 attempts to find a free port, using getFreePort().
> We know getFreePort() is racy and you need to make sure the port really is
> fee when trying to use it.
>
> Make 10 attempts. Leave the logic unchanged. Also fix a
On Mon, 16 Sep 2024 13:28:00 GMT, Roman Kennke wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> It is also a follow-up to #20640, which now also includes (and supersedes)
>> #20603 and #20605, plus the Tiny Class-Pointers parts that have been
>> prev
On Fri, 13 Sep 2024 09:47:07 GMT, Kevin Walls wrote:
> JDP tests only make 3 attempts to find a free port, using getFreePort().
> We know getFreePort() is racy and you need to make sure the port really is
> fee when trying to use it.
>
> Make 10 attempts. Leave the logic unchanged. Also fix a
On Mon, 16 Sep 2024 15:39:58 GMT, Kevin Walls wrote:
> The few uses of the operation parameter type "JULONG" in Diagnostic Commands
> should be changed to INT.
Use of the operation parameter type description "JULONG" in Diagnostic Commands
should be changed to INT.
DiagnosticCommandMBean prov
The few uses of the operation parameter type "JULONG" in Diagnostic Commands
should be changed to INT.
-
Commit messages:
- Merge remote-tracking branch 'upstream/master' into 8340113_JULONG
- 8340113: Remove JULONG as a Diagnostic Command argument type (jcmd JFR.view)
Changes: ht
On Sat, 14 Sep 2024 08:09:04 GMT, David Holmes wrote:
> A refactoring should not change behaviour. Maybe this only looked like an
> opportunity for refactoring but in reality is not?
The change of behavior here is there will no longer be any potential crashes
resulting from `get_new_method()` r
On Fri, 13 Sep 2024 09:47:07 GMT, Kevin Walls wrote:
> JDP tests only make 3 attempts to find a free port, using getFreePort().
> We know getFreePort() is racy and you need to make sure the port really is
> fee when trying to use it.
>
> Make 10 attempts. Leave the logic unchanged. Also fix a
The inner 'int max;' declaration hide previous max.
-
Commit messages:
- fixed typo
- 8340213: jcmd VM.events ignores max argument
Changes: https://git.openjdk.org/jdk/pull/21024/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21024&range=00
Issue: https://bugs.openjdk.
On Mon, 16 Sep 2024 19:14:01 GMT, Leonid Mesnik wrote:
> The inner 'int max;' declaration hide previous max.
I am not a Reviewer but this looks good to me.
test/hotspot/jtreg/serviceability/dcmd/vm/EventsTest.java line 81:
> 79: long lines = output.asLines().stream().filter(x ->
> x.
> The inner 'int max;' declaration hide previous max.
Leonid Mesnik has updated the pull request incrementally with two additional
commits since the last revision:
- typo fixed.
- check added.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/21024/files
- new: https://git.
On Mon, 16 Sep 2024 19:51:20 GMT, Leonid Mesnik wrote:
>> The inner 'int max;' declaration hide previous max.
>
> Leonid Mesnik has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - typo fixed.
> - check added.
Thanks!
test/hotspot/jtreg/se
On Mon, 16 Sep 2024 19:34:40 GMT, Sonia Zaldana Calles
wrote:
>> Leonid Mesnik has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - typo fixed.
>> - check added.
>
> test/hotspot/jtreg/serviceability/dcmd/vm/EventsTest.java line 81:
>
>>
On Mon, 16 Sep 2024 15:39:58 GMT, Kevin Walls wrote:
> The few uses of the operation parameter type "JULONG" in Diagnostic Commands
> should be changed to INT.
Hi Kevin,
I had some questions about this change.
Regarding the `INTEGER` -> `INT` change, I was wondering if the plan was to
also
On Thu, 12 Sep 2024 20:10:45 GMT, Simon Tooke wrote:
>> This is a port of [JDK-8318636](https://github.com/openjdk/jdk/pull/16301)
>> to Windows.
>>
>> System.map and System.dump_map are implemented using the Windows API and
>> provide roughly the same information in the same format. Most of
On Mon, 16 Sep 2024 19:54:38 GMT, Leonid Mesnik wrote:
>> The inner 'int max;' declaration hide previous max.
>
> Leonid Mesnik has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - typo fixed.
> - check added.
Looks good. Thanks for adding
On Mon, 16 Sep 2024 19:54:38 GMT, Leonid Mesnik wrote:
>> The inner 'int max;' declaration hide previous max.
>
> Leonid Mesnik has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - typo fixed.
> - check added.
Marked as reviewed by amenkov
> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading &
> Linking](https://bugs.openjdk.org/browse/JDK-8315737).
>
> **Overview**
>
> - A new `-XX:+AOTClassLinking` flag is added. See [JEP
> 498](https://bugs.openjdk.org/browse/JDK-8315737) and the
> [CSR](https://bugs.openjdk.org/bro
On Fri, 13 Sep 2024 16:09:25 GMT, Ashutosh Mehra wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @ashu-mehra comments
>
> src/hotspot/share/cds/aotClassLinker.cpp line 227:
>
>> 225: }
>> 226:
>> 227: int AOTClassLink
On Sat, 7 Sep 2024 00:30:34 GMT, Ioi Lam wrote:
>> I've taken an initial look through but there is an awful lot to try and
>> digest here. I've flagged numerous typos and minor nits.
>>
>> One general query: does this stuff work if the user defines their own
>> initial application classloader?
On Mon, 16 Sep 2024 21:54:49 GMT, Ioi Lam wrote:
>> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading &
>> Linking](https://bugs.openjdk.org/browse/JDK-8315737).
>>
>> **Overview**
>>
>> - A new `-XX:+AOTClassLinking` flag is added. See [JEP
>> 498](https://bugs.openjdk.org/browse/
On Mon, 16 Sep 2024 09:21:22 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only change which replaces the usage
> of `-noclassgc` with `-Xnoclassgc` option when launching the test?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8340176, the `-noclassgc` is
> an undocum
On Mon, 16 Sep 2024 09:21:22 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only change which replaces the usage
> of `-noclassgc` with `-Xnoclassgc` option when launching the test?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8340176, the `-noclassgc` is
> an undocum
32 matches
Mail list logo
