Re: RFR: 8330302: strace004 can still fail [v2]

2024-09-13 Thread Alan Bateman
On Fri, 13 Sep 2024 06:54:40 GMT, David Holmes wrote: >> This is a trivial point fix for the `strace` tests to add in the missing >> event (super)constructors. These tests have started failing more regularly >> after the `Thread.sleep` code was recently changed. >> >> The fragility of these te

Re: RFR: 8330302: strace004 can still fail [v2]

2024-09-13 Thread David Holmes
> This is a trivial point fix for the `strace` tests to add in the missing > event (super)constructors. These tests have started failing more regularly > after the `Thread.sleep` code was recently changed. > > The fragility of these tests is well known but I simply want to deal with > current f

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v13]

2024-09-13 Thread Roberto Castañeda Lozano
On Thu, 12 Sep 2024 15:38:18 GMT, Thomas Stuefe wrote: >> src/hotspot/share/opto/lcm.cpp line 272: >> >>> 270: const TypePtr* tptr; >>> 271: if ((UseCompressedOops || UseCompressedClassPointers) && >>> 272: (CompressedOops::shift() == 0 || >>> CompressedKlassPointers

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v13]

2024-09-13 Thread Roberto Castañeda Lozano
On Thu, 12 Sep 2024 11:46:35 GMT, Roberto Castañeda Lozano wrote: >> Roman Kennke has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert accidental change of UCOH default > > src/hotspot/share/cds/filemap.cpp line 2457: > >> 2455:

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v14]

2024-09-13 Thread Roman Kennke
> This is the main body of the JEP 450: Compact Object Headers (Experimental). > > It is also a follow-up to #20640, which now also includes (and supersedes) > #20603 and #20605, plus the Tiny Class-Pointers parts that have been > previously missing. > > Main changes: > - Introduction of the (

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v14]

2024-09-13 Thread Roman Kennke
On Fri, 13 Sep 2024 07:54:30 GMT, Roberto Castañeda Lozano wrote: >> src/hotspot/share/cds/filemap.cpp line 2457: >> >>> 2455: compressed_oops(), >>> compressed_class_pointers()); >>> 2456: if (compressed_oops() != UseCompressedOops || >>> compressed_class_pointers

Re: RFR: 8337563: NMT: rename MEMFLAGS to MemTag [v11]

2024-09-13 Thread Afshin Zafari
On Thu, 12 Sep 2024 15:52:41 GMT, Gerard Ziemski wrote: >> Please review this cleanup, where we rename `MEMFLAGS` to `MemTag`. >> >> `MEMFLAGS` implies that we can use more than one at the same time, but those >> are exclusive values, so `MemTag` is a more suitable name. >> >> This fix also in

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v8]

2024-09-13 Thread Thomas Stuefe
On Tue, 10 Sep 2024 12:19:32 GMT, Coleen Phillimore wrote: >> This is tricky. We are already deep in initialization and have done a couple >> of decisions based on +UseCompressedClassPointers (e.g. CDS setup). I >> *think* we could still go with -UseCCP, but I wonder whether this is wise. >>

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v8]

2024-09-13 Thread Thomas Stuefe
On Tue, 10 Sep 2024 12:13:58 GMT, Thomas Stuefe wrote: >> src/hotspot/share/oops/compressedKlass.cpp line 243: >> >>> 241: } else { >>> 242: >>> 243: // In legacy mode, we try, in order of preference: >> >> Can you not use the word 'legacy' here? Maybe in "non-compact object header >>

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v14]

2024-09-13 Thread Stefan Karlsson
On Fri, 13 Sep 2024 08:21:54 GMT, Roman Kennke wrote: >> This is the main body of the JEP 450: Compact Object Headers (Experimental). >> >> It is also a follow-up to #20640, which now also includes (and supersedes) >> #20603 and #20605, plus the Tiny Class-Pointers parts that have been >> prev

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v8]

2024-09-13 Thread Stefan Karlsson
On Mon, 9 Sep 2024 12:17:17 GMT, Thomas Schatzl wrote: >> Roman Kennke has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Try to avoid lea in loadNklass (aarch64) >> - Fix release build error > > src/hotspot/share/oops/oop.cpp line 230:

RFR: 8310525: DynamicLauncher for JDP test needs to try harder to find a free port

2024-09-13 Thread Kevin Walls
JDP tests only make 3 attempts to find a free port, using getFreePort(). We know getFreePort() is racy and you need to make sure the port really is fee when trying to use it. Make 10 attempts. Leave the logic unchanged. Also fix a typo in another test. - Commit messages: - 831052

Re: RFR: 8330302: strace004 can still fail [v2]

2024-09-13 Thread Aleksey Shipilev
On Fri, 13 Sep 2024 06:54:40 GMT, David Holmes wrote: >> This is a trivial point fix for the `strace` tests to add in the missing >> event (super)constructors. These tests have started failing more regularly >> after the `Thread.sleep` code was recently changed. >> >> The fragility of these te

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v8]

2024-09-13 Thread Thomas Schatzl
On Fri, 13 Sep 2024 09:00:32 GMT, Stefan Karlsson wrote: >> src/hotspot/share/oops/oop.cpp line 230: >> >>> 228: // disjunct below to fail if the two comparands are computed across >>> such >>> 229: // a concurrent change. >>> 230: return Universe::heap()->is_stw_gc_active() && >>> klass

Integrated: 8330302: strace004 can still fail

2024-09-13 Thread David Holmes
On Thu, 12 Sep 2024 23:18:48 GMT, David Holmes wrote: > This is a trivial point fix for the `strace` tests to add in the missing > event (super)constructors. These tests have started failing more regularly > after the `Thread.sleep` code was recently changed. > > The fragility of these tests i

Re: RFR: 8330302: strace004 can still fail

2024-09-13 Thread David Holmes
On Fri, 13 Sep 2024 06:12:04 GMT, Alan Bateman wrote: >> This is a trivial point fix for the `strace` tests to add in the missing >> event (super)constructors. These tests have started failing more regularly >> after the `Thread.sleep` code was recently changed. >> >> The fragility of these te

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v14]

2024-09-13 Thread Thomas Stuefe
On Tue, 10 Sep 2024 12:35:42 GMT, Thomas Stuefe wrote: >> src/hotspot/share/oops/compressedKlass.cpp line 116: >> >>> 114: _range = end - _base; >>> 115: >>> 116: DEBUG_ONLY(assert_is_valid_encoding(addr, len, _base, _shift);) >> >> Can you refactor so the aarch64 path runs this same code

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v8]

2024-09-13 Thread Stefan Karlsson
On Fri, 13 Sep 2024 11:10:58 GMT, Thomas Schatzl wrote: >> That bug doesn't fix all cases where the the length field is modified. > > Which ones are remaining? JDK-8337709 implemented the same change for G1 GC > before JDK-8311163. > > The full collectors/g1 marking do not modify the length fie

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v8]

2024-09-13 Thread Stefan Karlsson
On Fri, 13 Sep 2024 12:47:09 GMT, Stefan Karlsson wrote: >> Which ones are remaining? JDK-8337709 implemented the same change for G1 GC >> before JDK-8311163. >> >> The full collectors/g1 marking do not modify the length fields but have >> multiple separate queues which is a different issue. I

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v14]

2024-09-13 Thread Roman Kennke
On Fri, 13 Sep 2024 09:39:23 GMT, Stefan Karlsson wrote: >> Roman Kennke has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Hide log timestamps in test to prevent false failures > > src/hotspot/share/oops/oop.inline.hpp line 295: > >> 293:

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v14]

2024-09-13 Thread Roman Kennke
On Fri, 13 Sep 2024 09:31:39 GMT, Stefan Karlsson wrote: >> Roman Kennke has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Hide log timestamps in test to prevent false failures > > src/hotspot/share/oops/oop.hpp line 363: > >> 361:

Re: RFR: 8339927: Man page update for deprecating jhsdb debugd for removal

2024-09-13 Thread Kevin Walls
On Wed, 11 Sep 2024 11:53:19 GMT, Kevin Walls wrote: > Man page update to warn of deprecation of the jshdb debug subcommand and > --connect option. Thanks. I will go ahead with this change (the man page update for a change that has happened). I can't state a removal schedule. However with n

Integrated: 8339927: Man page update for deprecating jhsdb debugd for removal

2024-09-13 Thread Kevin Walls
On Wed, 11 Sep 2024 11:53:19 GMT, Kevin Walls wrote: > Man page update to warn of deprecation of the jshdb debug subcommand and > --connect option. This pull request has now been integrated. Changeset: 4d011785 Author:Kevin Walls URL: https://git.openjdk.org/jdk/commit/4d011785717c

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v15]

2024-09-13 Thread Roman Kennke
> This is the main body of the JEP 450: Compact Object Headers (Experimental). > > It is also a follow-up to #20640, which now also includes (and supersedes) > #20603 and #20605, plus the Tiny Class-Pointers parts that have been > previously missing. > > Main changes: > - Introduction of the (

Re: RFR: 8338471: Refactor Method::get_new_method() for better NoSuchMethodError handling [v4]

2024-09-13 Thread Coleen Phillimore
On Wed, 11 Sep 2024 21:02:41 GMT, Matias Saavedra Silva wrote: >> This patch cleans up the use of `get_new_method()` so callers don't have to >> worry about throwing `NoSuchMethodError`. The method is refactored to throw >> the error and avoid ever returning nullptr. Verified with tier1-5 test

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v14]

2024-09-13 Thread Stefan Karlsson
On Fri, 13 Sep 2024 12:53:29 GMT, Roman Kennke wrote: >> src/hotspot/share/oops/oop.inline.hpp line 295: >> >>> 293: // Used by scavengers >>> 294: void oopDesc::forward_to(oop p) { >>> 295: assert(cast_from_oop(p) != this, >> >> Do we really need the cast here? > > Yes, otherwise compiler co

Re: RFR: 8305895: Implement JEP 450: Compact Object Headers (Experimental) [v8]

2024-09-13 Thread Thomas Schatzl
On Fri, 13 Sep 2024 12:48:53 GMT, Stefan Karlsson wrote: >> If you've already fixed this for GC then I agree that we could remove this. > > This seems like something that should be done as a separate patch that gets > pushed before this PR. Will remove in JDK-8340119. - PR Review

Re: RFR: 8304824: NMT should not use ThreadCritical [v3]

2024-09-13 Thread Robert Toyonaga
On Thu, 12 Sep 2024 14:37:22 GMT, Robert Toyonaga wrote: >> ### Summary >> This PR just replaces `ThreadCritical` with a lock specific to NMT. >> `ThreadCritical` is a big lock and is unnecessary for the purposes of NMT. >> I've implemented the new lock with a semaphore so that it can be used

Re: RFR: 8319873: Add windows implementation for jcmd System.map and System.dump_map [v10]

2024-09-13 Thread Simon Tooke
On Thu, 12 Sep 2024 19:43:53 GMT, Kevin Walls wrote: >> Hello @kevinjwalls , and thank you for your review! I have attempted to >> address your concerns with my use of 'fatal()' by replacing with a message >> in the returned output and an assert(). >> >> I have also adjusted the spacing of th

Re: RFR: 8319873: Add windows implementation for jcmd System.map and System.dump_map [v11]

2024-09-13 Thread Simon Tooke
On Thu, 12 Sep 2024 16:01:52 GMT, Sonia Zaldana Calles wrote: >> Simon Tooke has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - remove calls to fatal(), remove segment lengt output >> - use nullptr insted of NULL > > src/hotspot/os/wind

Re: RFR: 8319873: Add windows implementation for jcmd System.map and System.dump_map [v10]

2024-09-13 Thread Simon Tooke
On Wed, 11 Sep 2024 23:57:11 GMT, David Holmes wrote: >> Simon Tooke has updated the pull request incrementally with one additional >> commit since the last revision: >> >> changes per review > > src/hotspot/share/services/diagnosticCommand.cpp line 1196: > >> 1194: void SystemDumpMapDCmd::e

Re: RFR: 8329706: Implement -XX:+AOTClassLinking [v5]

2024-09-13 Thread Ashutosh Mehra
On Thu, 12 Sep 2024 21:43:24 GMT, Ioi Lam wrote: >> This is the 3rd PR for [JEP 483: Ahead-of-Time Class Loading & >> Linking](https://bugs.openjdk.org/browse/JDK-8315737). >> >> **Overview** >> >> - A new `-XX:+AOTClassLinking` flag is added. See [JEP >> 498](https://bugs.openjdk.org/browse/

Re: RFR: 8304824: NMT should not use ThreadCritical [v3]

2024-09-13 Thread Thomas Stuefe
On Fri, 13 Sep 2024 14:02:38 GMT, Robert Toyonaga wrote: > After switching to a Hotspot Mutex, it looks like the `windows-x64 / test > (hs/tier1 common) GHA` is failing because the test `release_bad_ranges` in > test_os.cpp is expecting an assertion and an error message to be printed. > Howeve

Re: RFR: 8304824: NMT should not use ThreadCritical [v3]

2024-09-13 Thread Thomas Stuefe
On Fri, 13 Sep 2024 16:12:59 GMT, Thomas Stuefe wrote: > > After switching to a Hotspot Mutex, it looks like the `windows-x64 / test > > (hs/tier1 common) GHA` is failing because the test `release_bad_ranges` in > > test_os.cpp is expecting an assertion and an error message to be printed. > >

Re: RFR: 8338851: Hoist os::Posix::realpath() to os::realpath() and implement on Windows [v5]

2024-09-13 Thread Simon Tooke
On Fri, 13 Sep 2024 05:57:13 GMT, Thomas Stuefe wrote: >> Simon Tooke has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - remove empty line >> - fix indentation >> - fix missing return statement > > src/hotspot/os/windows/os_windows.cp

Re: RFR: 8304824: NMT should not use ThreadCritical [v3]

2024-09-13 Thread Robert Toyonaga
On Fri, 13 Sep 2024 16:17:56 GMT, Thomas Stuefe wrote: >>> After switching to a Hotspot Mutex, it looks like the `windows-x64 / test >>> (hs/tier1 common) GHA` is failing because the test `release_bad_ranges` in >>> test_os.cpp is expecting an assertion and an error message to be printed. >>>