On Fri, 13 Sep 2024 09:39:23 GMT, Stefan Karlsson <stef...@openjdk.org> wrote:
>> Roman Kennke has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Hide log timestamps in test to prevent false failures
>
> src/hotspot/share/oops/oop.inline.hpp line 295:
>
>> 293: // Used by scavengers
>> 294: void oopDesc::forward_to(oop p) {
>> 295: assert(cast_from_oop<oopDesc*>(p) != this,
>
> Do we really need the cast here?
Yes, otherwise compiler complains about ambiguous != operator.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20677#discussion_r1758815451
