On Tue, 21 May 2024 21:49:51 GMT, Leonid Mesnik wrote:
> The nsk.share.jdb.Jdb has finalize() nethods that close jdb connection and
> output streams.
>
> The fix renames the method to close() and calls it explicitly after the test
> finishes. I verified that close() called for each nsk share j
On Tue, 21 May 2024 06:08:54 GMT, Chris Plummer wrote:
>> Lei Zaakjyu has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains one
>> new comm
> follow up 8267941
Lei Zaakjyu has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 10 commits:
- review
- Merge branch 'master' of https://git.openjdk.org/jdk into JDK-8330694
- restore
- Merge branch 'master' of https://git.openjdk.
On Fri, 24 May 2024 13:04:14 GMT, Lei Zaakjyu wrote:
>> follow up 8267941
>
> Lei Zaakjyu has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 10 commits:
>
> - review
> - Merge branch 'master' of https://git.openjdk.org/jdk into JDK-
On Fri, 24 May 2024 13:04:14 GMT, Lei Zaakjyu wrote:
>> follow up 8267941
>
> Lei Zaakjyu has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 10 commits:
>
> - review
> - Merge branch 'master' of https://git.openjdk.org/jdk into JDK-
On Fri, 17 May 2024 10:35:39 GMT, Alan Bateman wrote:
>> Kevin Walls has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - add an 'also'
>> - typo
>
> src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnection.java
> l
On Fri, 24 May 2024 13:04:14 GMT, Lei Zaakjyu wrote:
>> follow up 8267941
>
> Lei Zaakjyu has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 10 commits:
>
> - review
> - Merge branch 'master' of https://git.openjdk.org/jdk into JDK-
On Fri, 24 May 2024 15:50:00 GMT, Chris Plummer wrote:
>> src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnection.java
>> line 961:
>>
>>> 959: * @param delegationSubjects should be {@code null}, but a non-null
>>> 960: * array is also accepted for compatibilit
On Fri, 24 May 2024 16:43:41 GMT, Kevin Walls wrote:
>> How about "must be null or an array of all null entries". You could still
>> have an `@apiNote` explaining why.
>
> Thanks, appreciate the effort trying to make it perfect.
> Can't quite say "must be null or an array of all null entries"
On Fri, 24 May 2024 16:49:25 GMT, Chris Plummer wrote:
>> Thanks, appreciate the effort trying to make it perfect.
>> Can't quite say "must be null or an array of all null entries" ..because I
>> suppose it could be an empty array.
>>
>> In reality, the only caller is our code that wraps a nu
> Running JConsole from a previous JDK, and attaching to jdk-23 (after
> [JDK-832](https://bugs.openjdk.org/browse/JDK-832): Remove the Java
> Management Extension (JMX) Subject Delegation feature), the MBean tab is
> blank.
>
> In javax/management/remote/rmi/RMIConnectionImpl.java:
> a
On Wed, 22 May 2024 16:54:13 GMT, Chris Plummer wrote:
>> The nsk.share.jdb.Jdb has finalize() nethods that close jdb connection and
>> output streams.
>>
>> The fix renames the method to close() and calls it explicitly after the test
>> finishes. I verified that close() called for each nsk sh
On Tue, 21 May 2024 21:49:51 GMT, Leonid Mesnik wrote:
> The nsk.share.jdb.Jdb has finalize() nethods that close jdb connection and
> output streams.
>
> The fix renames the method to close() and calls it explicitly after the test
> finishes. I verified that close() called for each nsk share j
On Tue, 21 May 2024 19:55:01 GMT, Leonid Mesnik wrote:
> The BindServer starts several threads and opens streams.
>
> It registered them for cleanup using "Finalizer" from nsk.share.framework.
> Currently, it cleanup resources during shutdown hook.
>
> This fix changes BindServer to explicitly
> The BindServer starts several threads and opens streams.
>
> It registered them for cleanup using "Finalizer" from nsk.share.framework.
> Currently, it cleanup resources during shutdown hook.
>
> This fix changes BindServer to explicitly close streams and finish threads
> after test is comple
On Wed, 22 May 2024 16:39:34 GMT, Chris Plummer wrote:
>> Leonid Mesnik has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Merge branch '8332631' of https://github.com/lmesnik/jdk into 8332631
>> - Update test/hotspot/jtreg/vmTestbase/
On Fri, 24 May 2024 17:15:31 GMT, Kevin Walls wrote:
>> Running JConsole from a previous JDK, and attaching to jdk-23 (after
>> [JDK-832](https://bugs.openjdk.org/browse/JDK-832): Remove the Java
>> Management Extension (JMX) Subject Delegation feature), the MBean tab is
>> blank.
>>
> Running JConsole from a previous JDK, and attaching to jdk-23 (after
> [JDK-832](https://bugs.openjdk.org/browse/JDK-832): Remove the Java
> Management Extension (JMX) Subject Delegation feature), the MBean tab is
> blank.
>
> In javax/management/remote/rmi/RMIConnectionImpl.java:
> a
On Fri, 24 May 2024 18:04:20 GMT, Chris Plummer wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove should... from delegationSubjects param
>
> src/java.management.rmi/share/classes/javax/management/remote/rmi/RM
On Fri, 24 May 2024 18:22:18 GMT, Kevin Walls wrote:
>> Running JConsole from a previous JDK, and attaching to jdk-23 (after
>> [JDK-832](https://bugs.openjdk.org/browse/JDK-832): Remove the Java
>> Management Extension (JMX) Subject Delegation feature), the MBean tab is
>> blank.
>>
On Fri, 24 May 2024 18:22:18 GMT, Kevin Walls wrote:
>> Running JConsole from a previous JDK, and attaching to jdk-23 (after
>> [JDK-832](https://bugs.openjdk.org/browse/JDK-832): Remove the Java
>> Management Extension (JMX) Subject Delegation feature), the MBean tab is
>> blank.
>>
On Wed, 15 May 2024 16:59:59 GMT, Kevin Walls wrote:
> Running JConsole from a previous JDK, and attaching to jdk-23 (after
> [JDK-832](https://bugs.openjdk.org/browse/JDK-832): Remove the Java
> Management Extension (JMX) Subject Delegation feature), the MBean tab is
> blank.
>
> In
This is a simple noreg cleanup. The motivation was that I noticed javac doesn't
recognise package.html files well.
Some of the contents of the `package.html` files (and code in the package) may
be outdated, but I think it is out of scope for this PR.
I have also changed three `{@link }` usages
If PointerLocation discovers that an address is for a JNI local ref, it will
print information about the thread that owns the JNI local ref. For JavaThreads
it calls the printThreadIDOn(tty) method. There's a comment on the call that
says that it 'includes "\n"'. This is actually not true, and a
On Fri, 24 May 2024 13:04:14 GMT, Lei Zaakjyu wrote:
>> follow up 8267941
>
> Lei Zaakjyu has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 10 commits:
>
> - review
> - Merge branch 'master' of https://git.openjdk.org/jdk into JDK-
On Sat, 20 Apr 2024 02:04:20 GMT, Lei Zaakjyu wrote:
> follow up 8267941
This pull request has now been integrated.
Changeset: 985b9ce7
Author:Lei Zaakjyu
Committer: Kim Barrett
URL:
https://git.openjdk.org/jdk/commit/985b9ce79a2d620a8b8675d1ae6c9730d72a757f
Stats: 1003 lines i
On Fri, 24 May 2024 18:11:18 GMT, Nizar Benalla wrote:
> This is a simple noreg cleanup. The motivation was that I noticed javac
> doesn't recognise package.html files well.
>
> Some of the contents of the `package.html` files (and code in the package)
> may be outdated, but I think it is out
27 matches
Mail list logo
