On Fri, 24 May 2024 18:04:20 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove should... from delegationSubjects param > > src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnection.java > line 978: > >> 976: * @throws IOException if a general communication exception >> occurred. >> 977: * @throws UnsupportedOperationException if {@code >> delegationSubjects} >> 978: * is non-null and contains any non-null values. > > Minor consistency issue. For the `delegationSubjects` comment above, you > refer to "non-null entries". Here you refer to "non-null values". I don't > have a preference on which you use, but they should be the same in both cases. OK I'll change the "values" in the throws clause to be "entries", to be consistent, to keep this moving... (But I don't think there was any possible confusion here. 8-) ) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19253#discussion_r1613856276