On Tue, 21 May 2024 21:49:51 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
> The nsk.share.jdb.Jdb has finalize() nethods that close jdb connection and > output streams. > > The fix renames the method to close() and calls it explicitly after the test > finishes. I verified that close() called for each nsk share jdb test. > > The jdb is also LocalProcess with it's own cleanup(). This part still remains > the same so far. Looks good to me. Nice that you can correct the typo where one of the JdbTest.java log lines was saying finalize instead of killDebuggee. 8-) ------------- Marked as reviewed by kevinw (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19336#pullrequestreview-2076278959
